101546 2012-11-07 22:27:58 -0800 Remove unnecessary save/restore in SVGTextRunRenderingContext 2012-11-08 07:20:29 -0800 1 1 1 Unclassified WebKit SVG 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr d-r eric fmalita reed schenney webkit.review.bot zimmermann oldest_to_newest 761348 0 pdr 2012-11-07 22:27:58 -0800 The Skia team noticed SVG overzealously saves and restores contexts. SVGTextRunRenderingContext has a particularly egregious case where we save/restore on every text run just for stroke thickness: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp?rev=133290#L145 Saves and restores are not free and we can pick up performance by avoiding them. 761351 1 172934 pdr 2012-11-07 22:33:52 -0800 Created attachment 172934 Patch 761667 2 reed 2012-11-08 05:02:41 -0800 works for me 761763 3 172934 webkit.review.bot 2012-11-08 07:20:26 -0800 Comment on attachment 172934 Patch Clearing flags on attachment: 172934 Committed r133897: <http://trac.webkit.org/changeset/133897> 761764 4 webkit.review.bot 2012-11-08 07:20:29 -0800 All reviewed patches have been landed. Closing bug. 172934 2012-11-07 22:33:52 -0800 2012-11-08 07:20:25 -0800 Patch 101546.1.patch text/plain 2532 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzg0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA3ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IHNh dmUvcmVzdG9yZSBpbiBTVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTQ2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIGFuIHVu bmVjZXNzYXJ5IGNvbnRleHQgc2F2ZS9yZXN0b3JlIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0 IGJ5CisgICAgICAgIHJlZmFjdG9yaW5nIHRoZSBjb2RlIHRvIHNhdmUgb2ZmIHRoZSBzdHJva2Ug dGhpY2tuZXNzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIGhlYXZpbHkgY292 ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHVGV4 dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVGV4dFJ1blJl bmRlcmluZ0NvbnRleHQ6OmRyYXdTVkdHbHlwaHMpOgorCiAyMDEyLTExLTA3ICBTaGVyaWZmIEJv dCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMTMzODQxLgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9T VkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5jcHAJKHJldmlzaW9u IDEzMzY1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRl cmluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIsOCArMTQyLDYgQEAgdm9pZCBT VkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dDo6ZHJhd1NWRwogICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgICB9CiAKLSAgICAgICAgY29udGV4dC0+c2F2ZSgpOwotCiAgICAgICAgIGlmIChp c1ZlcnRpY2FsVGV4dCkgewogICAgICAgICAgICAgZ2x5cGhPcmlnaW4uc2V0WChzdmdHbHlwaC52 ZXJ0aWNhbE9yaWdpblggKiBzY2FsZSk7CiAgICAgICAgICAgICBnbHlwaE9yaWdpbi5zZXRZKHN2 Z0dseXBoLnZlcnRpY2FsT3JpZ2luWSAqIHNjYWxlKTsKQEAgLTE1NywxNCArMTU1LDEyIEBAIHZv aWQgU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQ6OmRyYXdTVkcKICAgICAgICAgZ2x5cGhQYXRo LnRyYW5zZm9ybShnbHlwaFBhdGhUcmFuc2Zvcm0pOwogCiAgICAgICAgIGlmIChhY3RpdmVQYWlu dGluZ1Jlc291cmNlLT5hcHBseVJlc291cmNlKHBhcmVudFJlbmRlck9iamVjdCwgcGFyZW50UmVu ZGVyT2JqZWN0U3R5bGUsIGNvbnRleHQsIHJlc291cmNlTW9kZSkpIHsKLSAgICAgICAgICAgIGlm IChyZW5kZXJPYmplY3QgJiYgcmVuZGVyT2JqZWN0LT5pc1NWR0lubGluZVRleHQoKSkgewotICAg ICAgICAgICAgICAgIGNvbnN0IFJlbmRlclNWR0lubGluZVRleHQqIHRleHRSZW5kZXJlciA9IHRv UmVuZGVyU1ZHSW5saW5lVGV4dChyZW5kZXJPYmplY3QpOwotICAgICAgICAgICAgICAgIGNvbnRl eHQtPnNldFN0cm9rZVRoaWNrbmVzcyhjb250ZXh0LT5zdHJva2VUaGlja25lc3MoKSAqIHRleHRS ZW5kZXJlci0+c2NhbGluZ0ZhY3RvcigpKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGZs b2F0IHN0cm9rZVRoaWNrbmVzcyA9IGNvbnRleHQtPnN0cm9rZVRoaWNrbmVzcygpOworICAgICAg ICAgICAgaWYgKHJlbmRlck9iamVjdCAmJiByZW5kZXJPYmplY3QtPmlzU1ZHSW5saW5lVGV4dCgp KQorICAgICAgICAgICAgICAgIGNvbnRleHQtPnNldFN0cm9rZVRoaWNrbmVzcyhzdHJva2VUaGlj a25lc3MgKiB0b1JlbmRlclNWR0lubGluZVRleHQocmVuZGVyT2JqZWN0KS0+c2NhbGluZ0ZhY3Rv cigpKTsKICAgICAgICAgICAgIGFjdGl2ZVBhaW50aW5nUmVzb3VyY2UtPnBvc3RBcHBseVJlc291 cmNlKHBhcmVudFJlbmRlck9iamVjdCwgY29udGV4dCwgcmVzb3VyY2VNb2RlLCAmZ2x5cGhQYXRo LCAwKTsKLSAgICAgICAgIH0KLSAKLSAgICAgICAgY29udGV4dC0+cmVzdG9yZSgpOworICAgICAg ICAgICAgY29udGV4dC0+c2V0U3Ryb2tlVGhpY2tuZXNzKHN0cm9rZVRoaWNrbmVzcyk7CisgICAg ICAgIH0KIAogICAgICAgICBpZiAoaXNWZXJ0aWNhbFRleHQpCiAgICAgICAgICAgICBjdXJyZW50 UG9pbnQubW92ZSgwLCBhZHZhbmNlKTsK