101532 2012-11-07 17:52:11 -0800 [Qt][CSS Shaders] Make custom filter render in Wk1 mode 2013-01-15 02:03:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achicu allan.jensen allan.jensen noam webkit.review.bot oldest_to_newest 761234 0 achicu 2012-11-07 17:52:11 -0800 Currently, there's no way to enable custom filters in Wk1 mode. Also, it looks like WebGL fails to instantiate when running in that mode. 806172 1 allan.jensen 2013-01-14 01:55:37 -0800 They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer. 806403 2 allan.jensen 2013-01-14 09:09:29 -0800 (In reply to comment #1) > They are enabled by default when WebGL is enabled. They do however fail or cause crashes because BitmapTextureImageBuffer::applyFilter tries to build the FilterEffectRenderer without a Document pointer. That is bug #106796, but only applies when non-GL TextureMapper is used. There is also a problem even with the GL TextureMapper. 806446 3 182598 allan.jensen 2013-01-14 10:24:04 -0800 Created attachment 182598 Patch 807127 4 182598 webkit.review.bot 2013-01-15 02:03:24 -0800 Comment on attachment 182598 Patch Clearing flags on attachment: 182598 Committed r139731: <http://trac.webkit.org/changeset/139731> 807128 5 webkit.review.bot 2013-01-15 02:03:28 -0800 All reviewed patches have been landed. Closing bug. 182598 2013-01-14 10:24:04 -0800 2013-01-15 02:03:23 -0800 Patch bug-101532-20130114192028.patch text/plain 6585 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY2MDk1N2RhNjEyNWU5 NDlmZjhkYTdiNzdkOTQ0NDJhNjJlMDM1Yi4uNThjODU1MzBjMjkyYjU5YzdlYzU3NTU1YjJjZGIy YThkOWYzNmQ1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAxLTE0ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF1bQ1NTIFNoYWRlcnNdIE1ha2UgY3VzdG9tIGZpbHRlciByZW5kZXIgaW4gV2sxIG1vZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTUzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSBWYWxp ZGF0ZWRDdXN0b21GaWx0ZXJPcGVyYXRpb25zIHdoaWNoIGFyZSB1c2VkIGJ5IFdlYktpdDEuIFRv IGtlZXAgdGhlIGNhY2hlIG9mIGNvbXBpbGVkIHByb2dyYW1zIHdvcmtpbmcsIAorICAgICAgICB0 aGUgY2FjaGUgaGFzIGJlZW4gdXBkYXRlZCB0byB1c2UgQ3VzdG9tRmlsdGVyUHJvZ3JhbUluZm8g YXMgYSBoYXNoIGtleS4gQ3VzdG9tRmlsdGVyUHJvZ3JhbUluZm8gaXMgYW4gZXhpc3RpbmcKKyAg ICAgICAgY2xhc3Mgc3BlY2lmaWNhbGx5IGRlc2lnbmVkIGZvciB0aGlzIHB1cnBvc2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmdldFBhc3Nlc1JlcXVpcmVkRm9yRmlsdGVyKToKKyAgICAgICAgKFdl YkNvcmU6OlRleHR1cmVNYXBwZXJHTDo6cmVtb3ZlQ2FjaGVkQ3VzdG9tRmlsdGVyUHJvZ3JhbSk6 CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyR0w6OmRyYXdVc2luZ0N1c3RvbUZpbHRl cik6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBUZXh0dXJlR0w6OmFwcGx5RmlsdGVycyk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oOgorICAg ICAgICAoVGV4dHVyZU1hcHBlckdMKToKKwogMjAxMy0wMS0xNCAgUWlhbmt1biBNaWFvICA8cWlh bmt1bi5taWFvQGludGVsLmNvbT4KIAogICAgICAgICBGaXggYSB0eXBvIGVycm9yIGluIHRoZSBj b21tZW50cyBpbiBQbGF0Zm9ybUNvbnRleHRTa2lhLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5k ZXggOWYzZTgyMGE0NWQ1Nzg4MzRlNWNmMjhmNzZkYTZkYjk5ZGZmMWQ2YS4uMGY2ZDY3YjQzN2Zh OGQ5MTBmM2EyYzkxYWJiYjdlYWMxYTEwYTViNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKQEAg LTczNiw2ICs3MzYsNyBAQCBzdGF0aWMgdW5zaWduZWQgZ2V0UGFzc2VzUmVxdWlyZWRGb3JGaWx0 ZXIoRmlsdGVyT3BlcmF0aW9uOjpPcGVyYXRpb25UeXBlIHR5cGUpCiAgICAgY2FzZSBGaWx0ZXJP cGVyYXRpb246Ok9QQUNJVFk6CiAjaWYgRU5BQkxFKENTU19TSEFERVJTKQogICAgIGNhc2UgRmls dGVyT3BlcmF0aW9uOjpDVVNUT006CisgICAgY2FzZSBGaWx0ZXJPcGVyYXRpb246OlZBTElEQVRF RF9DVVNUT006CiAjZW5kaWYKICAgICAgICAgcmV0dXJuIDE7CiAgICAgY2FzZSBGaWx0ZXJPcGVy YXRpb246OkJMVVI6CkBAIC04NDMsNyArODQ0LDcgQEAgc3RhdGljIHZvaWQgcHJlcGFyZUZpbHRl clByb2dyYW0oVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0qIHByb2dyYW0sIGNvbnN0IEZpbHQK ICNpZiBFTkFCTEUoQ1NTX1NIQURFUlMpCiB2b2lkIFRleHR1cmVNYXBwZXJHTDo6cmVtb3ZlQ2Fj aGVkQ3VzdG9tRmlsdGVyUHJvZ3JhbShDdXN0b21GaWx0ZXJQcm9ncmFtKiBwcm9ncmFtKQogewot ICAgIG1fY3VzdG9tRmlsdGVyUHJvZ3JhbXMucmVtb3ZlKHByb2dyYW0pOworICAgIG1fY3VzdG9t RmlsdGVyUHJvZ3JhbXMucmVtb3ZlKHByb2dyYW0tPnByb2dyYW1JbmZvKCkpOwogfQogCiBib29s IFRleHR1cmVNYXBwZXJHTDo6ZHJhd1VzaW5nQ3VzdG9tRmlsdGVyKEJpdG1hcFRleHR1cmUmIHRh cmdldCwgY29uc3QgQml0bWFwVGV4dHVyZSYgc291cmNlLCBjb25zdCBGaWx0ZXJPcGVyYXRpb24m IGZpbHRlcikKQEAgLTg1OCwxMCArODU5LDEwIEBAIGJvb2wgVGV4dHVyZU1hcHBlckdMOjpkcmF3 VXNpbmdDdXN0b21GaWx0ZXIoQml0bWFwVGV4dHVyZSYgdGFyZ2V0LCBjb25zdCBCaXRtYXBUCiAg ICAgICAgIHJlbmRlcmVyID0gQ3VzdG9tRmlsdGVyUmVuZGVyZXI6OmNyZWF0ZShtX2NvbnRleHQz RCwgcHJvZ3JhbS0+cHJvZ3JhbVR5cGUoKSwgY3VzdG9tRmlsdGVyLT5wYXJhbWV0ZXJzKCksIAog ICAgICAgICAgICAgY3VzdG9tRmlsdGVyLT5tZXNoUm93cygpLCBjdXN0b21GaWx0ZXItPm1lc2hD b2x1bW5zKCksIGN1c3RvbUZpbHRlci0+bWVzaFR5cGUoKSk7CiAgICAgICAgIFJlZlB0cjxDdXN0 b21GaWx0ZXJDb21waWxlZFByb2dyYW0+IGNvbXBpbGVkUHJvZ3JhbTsKLSAgICAgICAgQ3VzdG9t RmlsdGVyUHJvZ3JhbU1hcDo6aXRlcmF0b3IgaXRlciA9IG1fY3VzdG9tRmlsdGVyUHJvZ3JhbXMu ZmluZChwcm9ncmFtLmdldCgpKTsKKyAgICAgICAgQ3VzdG9tRmlsdGVyUHJvZ3JhbU1hcDo6aXRl cmF0b3IgaXRlciA9IG1fY3VzdG9tRmlsdGVyUHJvZ3JhbXMuZmluZChwcm9ncmFtLT5wcm9ncmFt SW5mbygpKTsKICAgICAgICAgaWYgKGl0ZXIgPT0gbV9jdXN0b21GaWx0ZXJQcm9ncmFtcy5lbmQo KSkgewogICAgICAgICAgICAgY29tcGlsZWRQcm9ncmFtID0gQ3VzdG9tRmlsdGVyQ29tcGlsZWRQ cm9ncmFtOjpjcmVhdGUobV9jb250ZXh0M0QsIHByb2dyYW0tPnZlcnRleFNoYWRlclN0cmluZygp LCBwcm9ncmFtLT5mcmFnbWVudFNoYWRlclN0cmluZygpLCBwcm9ncmFtLT5wcm9ncmFtVHlwZSgp KTsKLSAgICAgICAgICAgIG1fY3VzdG9tRmlsdGVyUHJvZ3JhbXMuc2V0KHByb2dyYW0uZ2V0KCks IGNvbXBpbGVkUHJvZ3JhbSk7CisgICAgICAgICAgICBtX2N1c3RvbUZpbHRlclByb2dyYW1zLnNl dChwcm9ncmFtLT5wcm9ncmFtSW5mbygpLCBjb21waWxlZFByb2dyYW0pOwogICAgICAgICB9IGVs c2UKICAgICAgICAgICAgIGNvbXBpbGVkUHJvZ3JhbSA9IGl0ZXItPnZhbHVlOwogICAgICAgICBy ZW5kZXJlci0+c2V0Q29tcGlsZWRQcm9ncmFtKGNvbXBpbGVkUHJvZ3JhbS5yZWxlYXNlKCkpOwpA QCAtODY5LDkgKzg3MCwxOSBAQCBib29sIFRleHR1cmVNYXBwZXJHTDo6ZHJhd1VzaW5nQ3VzdG9t RmlsdGVyKEJpdG1hcFRleHR1cmUmIHRhcmdldCwgY29uc3QgQml0bWFwVAogICAgIH0KICAgICBj YXNlIEZpbHRlck9wZXJhdGlvbjo6VkFMSURBVEVEX0NVU1RPTTogewogICAgICAgICAvLyBXZWJL aXQxIHVzZXMgdGhlIFZhbGlkYXRlZEN1c3RvbUZpbHRlck9wZXJhdGlvbi4KLSAgICAgICAgLy8g RklYTUU6IFRoaXMgcGF0aCBpcyBub3Qgd29ya2luZyB5ZXQgYXMgR3JhcGhpY3NDb250ZXh0M0Qg ZmFpbHMgdG8gaW5pdGlhbGl6ZS4KLSAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTUzMgotICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGNv bnN0IFZhbGlkYXRlZEN1c3RvbUZpbHRlck9wZXJhdGlvbiogY3VzdG9tRmlsdGVyID0gc3RhdGlj X2Nhc3Q8Y29uc3QgVmFsaWRhdGVkQ3VzdG9tRmlsdGVyT3BlcmF0aW9uKj4oJmZpbHRlcik7Cisg ICAgICAgIFJlZlB0cjxDdXN0b21GaWx0ZXJWYWxpZGF0ZWRQcm9ncmFtPiBwcm9ncmFtID0gY3Vz dG9tRmlsdGVyLT52YWxpZGF0ZWRQcm9ncmFtKCk7CisgICAgICAgIHJlbmRlcmVyID0gQ3VzdG9t RmlsdGVyUmVuZGVyZXI6OmNyZWF0ZShtX2NvbnRleHQzRCwgcHJvZ3JhbS0+cHJvZ3JhbUluZm8o KS5wcm9ncmFtVHlwZSgpLCBjdXN0b21GaWx0ZXItPnBhcmFtZXRlcnMoKSwKKyAgICAgICAgICAg IGN1c3RvbUZpbHRlci0+bWVzaFJvd3MoKSwgY3VzdG9tRmlsdGVyLT5tZXNoQ29sdW1ucygpLCBj dXN0b21GaWx0ZXItPm1lc2hUeXBlKCkpOworICAgICAgICBSZWZQdHI8Q3VzdG9tRmlsdGVyQ29t cGlsZWRQcm9ncmFtPiBjb21waWxlZFByb2dyYW07CisgICAgICAgIEN1c3RvbUZpbHRlclByb2dy YW1NYXA6Oml0ZXJhdG9yIGl0ZXIgPSBtX2N1c3RvbUZpbHRlclByb2dyYW1zLmZpbmQocHJvZ3Jh bS0+cHJvZ3JhbUluZm8oKSk7CisgICAgICAgIGlmIChpdGVyID09IG1fY3VzdG9tRmlsdGVyUHJv Z3JhbXMuZW5kKCkpIHsKKyAgICAgICAgICAgIGNvbXBpbGVkUHJvZ3JhbSA9IEN1c3RvbUZpbHRl ckNvbXBpbGVkUHJvZ3JhbTo6Y3JlYXRlKG1fY29udGV4dDNELCBwcm9ncmFtLT52YWxpZGF0ZWRW ZXJ0ZXhTaGFkZXIoKSwgcHJvZ3JhbS0+dmFsaWRhdGVkRnJhZ21lbnRTaGFkZXIoKSwgcHJvZ3Jh bS0+cHJvZ3JhbUluZm8oKS5wcm9ncmFtVHlwZSgpKTsKKyAgICAgICAgICAgIG1fY3VzdG9tRmls dGVyUHJvZ3JhbXMuc2V0KHByb2dyYW0tPnByb2dyYW1JbmZvKCksIGNvbXBpbGVkUHJvZ3JhbSk7 CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgY29tcGlsZWRQcm9ncmFtID0gaXRlci0+dmFs dWU7CisgICAgICAgIHJlbmRlcmVyLT5zZXRDb21waWxlZFByb2dyYW0oY29tcGlsZWRQcm9ncmFt LnJlbGVhc2UoKSk7CisgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBkZWZhdWx0OgogICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTkyNiw3ICs5MzcsNyBAQCBQYXNzUmVmUHRyPEJp dG1hcFRleHR1cmU+IEJpdG1hcFRleHR1cmVHTDo6YXBwbHlGaWx0ZXJzKFRleHR1cmVNYXBwZXIq IHRleHR1cmVNYQogICAgICAgICAgICAgdGV4dHVyZU1hcHBlckdMLT5iaW5kU3VyZmFjZSh0YXJn ZXQuZ2V0KCkpOwogICAgICAgICAgICAgY29uc3QgQml0bWFwVGV4dHVyZSYgc291cmNlVGV4dHVy ZSA9IHVzZUNvbnRlbnRUZXh0dXJlID8gY29udGVudFRleHR1cmUgOiAqc291cmNlOwogI2lmIEVO QUJMRShDU1NfU0hBREVSUykKLSAgICAgICAgICAgIGlmIChmaWx0ZXItPmdldE9wZXJhdGlvblR5 cGUoKSA9PSBGaWx0ZXJPcGVyYXRpb246OkNVU1RPTSkgeworICAgICAgICAgICAgaWYgKGZpbHRl ci0+Z2V0T3BlcmF0aW9uVHlwZSgpID09IEZpbHRlck9wZXJhdGlvbjo6Q1VTVE9NIHx8IGZpbHRl ci0+Z2V0T3BlcmF0aW9uVHlwZSgpID09IEZpbHRlck9wZXJhdGlvbjo6VkFMSURBVEVEX0NVU1RP TSkgewogICAgICAgICAgICAgICAgIGlmICh0ZXh0dXJlTWFwcGVyR0wtPmRyYXdVc2luZ0N1c3Rv bUZpbHRlcigqdGFyZ2V0LCBzb3VyY2VUZXh0dXJlLCAqZmlsdGVyKSkgewogICAgICAgICAgICAg ICAgICAgICAvLyBPbmx5IHN3YXAgaWYgdGhlIGRyYXcgd2FzIHN1Y2Nlc3NmdWwuCiAgICAgICAg ICAgICAgICAgICAgIHN0ZDo6c3dhcChzb3VyY2UsIHRhcmdldCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmgK aW5kZXggYWExMzMxMmZhYWZjYTMxZmRmMWQxYzQxNGQzNWMyN2NhYzgwMmNhMi4uMTYwNTA3YzYw NjhmZWZjMzU0ODQzMGZiZWRhYWYzNTA2M2Q5NzQxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuaApAQCAt MjIsNiArMjIsNyBAQAogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCisjaW5j bHVkZSAiQ3VzdG9tRmlsdGVyUHJvZ3JhbUluZm8uaCIKICNpbmNsdWRlICJGbG9hdFF1YWQuaCIK ICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQzRC5oIgogI2luY2x1ZGUgIkludFNpemUuaCIKQEAg LTExNyw3ICsxMTgsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9lbmFibGVFZGdlRGlzdGFuY2VB bnRpYWxpYXNpbmc7CiAKICNpZiBFTkFCTEUoQ1NTX1NIQURFUlMpCi0gICAgdHlwZWRlZiBIYXNo TWFwPEN1c3RvbUZpbHRlclByb2dyYW0qLCBSZWZQdHI8Q3VzdG9tRmlsdGVyQ29tcGlsZWRQcm9n cmFtPiA+IEN1c3RvbUZpbHRlclByb2dyYW1NYXA7CisgICAgdHlwZWRlZiBIYXNoTWFwPEN1c3Rv bUZpbHRlclByb2dyYW1JbmZvLCBSZWZQdHI8Q3VzdG9tRmlsdGVyQ29tcGlsZWRQcm9ncmFtPiA+ IEN1c3RvbUZpbHRlclByb2dyYW1NYXA7CiAgICAgQ3VzdG9tRmlsdGVyUHJvZ3JhbU1hcCBtX2N1 c3RvbUZpbHRlclByb2dyYW1zOwogI2VuZGlmCiAK