101525 2012-11-07 17:21:11 -0800 [V8] Don't leak <img> elements in content scripts 2012-11-07 23:39:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101110 1 abarth abarth eric haraken japhet ojan webkit.review.bot oldest_to_newest 761199 0 abarth 2012-11-07 17:21:11 -0800 [V8] Don't leak <img> elements in content scripts 761201 1 172897 abarth 2012-11-07 17:23:17 -0800 Created attachment 172897 Patch 761205 2 172897 ojan 2012-11-07 17:26:01 -0800 Comment on attachment 172897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172897&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:81 > + ASSERT(object = static_cast<Node*>(toNative(wrapper))); Nit: move this above line 79 since it doesn't actually use info? 761208 3 172897 abarth 2012-11-07 17:27:44 -0800 Comment on attachment 172897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172897&action=review >> Source/WebCore/bindings/v8/DOMDataStore.cpp:81 >> + ASSERT(object = static_cast<Node*>(toNative(wrapper))); > > Nit: move this above line 79 since it doesn't actually use info? Will do. 761211 4 abarth 2012-11-07 17:30:05 -0800 Committed r133829: <http://trac.webkit.org/changeset/133829> 761390 5 172897 haraken 2012-11-07 23:39:54 -0800 Comment on attachment 172897 Patch LGTM too. 172897 2012-11-07 17:23:17 -0800 2012-11-07 23:39:54 -0800 Patch bug-101525-20121107172128.patch text/plain 5851 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FhMDYxNWQ4ZjY3MTMw YWE2MDI2ZjA1ODhmNjRlOTkyNGU5Y2RiMC4uODJlNGYwZTU4MDJlZmZmZmU5MjFmMWFlODFhYWE0 MGU5YzcwYmMxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTExLTA3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBEb24ndCBsZWFrIDxp bWc+IGVsZW1lbnRzIGluIGNvbnRlbnQgc2NyaXB0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSSBmb3VuZCB0aGUgbGVhayB0aGF0IHdhcyBjYXVzaW5n IGEgcHJvYmxlbSBmb3IgYnVnIDEwMTExMC4gV2Ugd2VyZW4ndAorICAgICAgICBmaWxsaW5nIGlu IHRoZSBkZXJlZk9iamVjdEZ1bmN0aW9uIGZvciBIVE1MSW1hZ2VFbGVtZW50cyAoYW5kCisgICAg ICAgIHBvdGVudGlhbGx5IHNvbWUgb3RoZXIgdHlwZXMgb2YgZWxlbWVudHMpLiBUaGF0IG1hbmlm ZXN0cyB0b2RheSBhcyBhCisgICAgICAgIG1lbW9yeSBsZWFrIGluIGNvbnRlbnQgc2NyaXB0cyAo d2hpY2ggdXNlIHRoZSBkZXJlZk9iamVjdEZ1bmN0aW9uIGZvcgorICAgICAgICBub2RlcykgYW5k IGNhdXNlZCBhIG1lbW9yeSBsZWFrIGFmdGVyIGJ1ZyAxMDExMTAgYmVjYXVzZSB3ZSBzdGFydGVk CisgICAgICAgIHVzaW5nIHRoZSBkZXJlZk9iamVjdEZ1bmN0aW9uIGluIHRoZSBtYWluIHdvcmxk IGFzIHdlbGwuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIEFTU0VSVHMgc28gdGhhdCB3ZSB3 b24ndCBtYWtlIHRoaXMgbWlzdGFrZSBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZW5lcmF0ZU5hbWVkQ29u c3RydWN0b3JDYWxsYmFjayk6CisgICAgICAgICogYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6d2Vha0NhbGxiYWNrKToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9ET01XcmFwcGVyTWFwLmg6CisgICAgICAgIChXZWJDb3JlOjpET01X cmFwcGVyTWFwOjpkZWZhdWx0V2Vha0NhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9j dXN0b20vVjhIVE1MSW1hZ2VFbGVtZW50Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29y ZSk6CisKKzIwMTItMTEtMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAg ICAgICBbVjhdIFByZXBhcmUgRE9NRGF0YVN0b3JlIHRvIGJlIGFibGUgdG8gc3RvcmUgU2NyaXB0 V3JhcHBhYmxlIHdyYXBwZXJzIGlubGluZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTIzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggMmQ5ZjkxMmUyYjc4MzA5YTNkMTg0 OTk4ZTgwYTVmMmZhNGMwNjcyYi4uM2M2NDZmOWZkZWE3NDc0MTViZjY5ZjgyZjk2NTFiMmFjYTkx YjBjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0KQEAgLTIwNjAsMjAgKzIwNjAsMTUgQEAgc3ViIEdlbmVyYXRlTmFtZWRDb25z dHJ1Y3RvckNhbGxiYWNrCiAgICAgbXkgQGJlZm9yZUFyZ3VtZW50TGlzdDsKICAgICBteSBAYWZ0 ZXJBcmd1bWVudExpc3Q7CiAKKyAgICBteSAkdG9BY3RpdmVET01PYmplY3QgPSAiMCI7CiAgICAg aWYgKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkFjdGl2ZURPTU9iamVjdCJ9KSB7 Ci0gICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7Ci1XcmFwcGVyVHlwZUluZm8gVjgk e2ltcGxDbGFzc05hbWV9Q29uc3RydWN0b3I6OmluZm8gPSB7IFY4JHtpbXBsQ2xhc3NOYW1lfUNv bnN0cnVjdG9yOjpHZXRUZW1wbGF0ZSwgVjgke2ltcGxDbGFzc05hbWV9OjpkZXJlZk9iamVjdCwg Vjgke2ltcGxDbGFzc05hbWV9Ojp0b0FjdGl2ZURPTU9iamVjdCwgMCwgVjgke2ltcGxDbGFzc05h bWV9OjppbnN0YWxsUGVyQ29udGV4dFByb3RvdHlwZVByb3BlcnRpZXMsIDAsIFdyYXBwZXJUeXBl T2JqZWN0UHJvdG90eXBlIH07Ci0KLUVORAotICAgIH0gZWxzZSB7Ci0gICAgICAgIHB1c2goQGlt cGxDb250ZW50LCA8PEVORCk7Ci1XcmFwcGVyVHlwZUluZm8gVjgke2ltcGxDbGFzc05hbWV9Q29u c3RydWN0b3I6OmluZm8gPSB7IFY4JHtpbXBsQ2xhc3NOYW1lfUNvbnN0cnVjdG9yOjpHZXRUZW1w bGF0ZSwgMCwgMCwgMCwgVjgke2ltcGxDbGFzc05hbWV9OjppbnN0YWxsUGVyQ29udGV4dFByb3Rv dHlwZVByb3BlcnRpZXMsIDAsIFdyYXBwZXJUeXBlT2JqZWN0UHJvdG90eXBlIH07Ci0KLUVORAor ICAgICAgICAkdG9BY3RpdmVET01PYmplY3QgPSAiVjgke2ltcGxDbGFzc05hbWV9Ojp0b0FjdGl2 ZURPTU9iamVjdCI7CiAgICAgfQotCiAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIkZyYW1lLmgiKTsK KwogICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CitXcmFwcGVyVHlwZUluZm8gVjgke2lt cGxDbGFzc05hbWV9Q29uc3RydWN0b3I6OmluZm8gPSB7IFY4JHtpbXBsQ2xhc3NOYW1lfUNvbnN0 cnVjdG9yOjpHZXRUZW1wbGF0ZSwgVjgke2ltcGxDbGFzc05hbWV9OjpkZXJlZk9iamVjdCwgJHt0 b0FjdGl2ZURPTU9iamVjdH0sIDAsIFY4JHtpbXBsQ2xhc3NOYW1lfTo6aW5zdGFsbFBlckNvbnRl eHRQcm90b3R5cGVQcm9wZXJ0aWVzLCAwLCBXcmFwcGVyVHlwZU9iamVjdFByb3RvdHlwZSB9Owor CiBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4JHtpbXBsQ2xhc3NOYW1lfUNvbnN0cnVj dG9yQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIHsKICAgICBJTkNfU1RBVFMo IkRPTS4ke2ltcGxDbGFzc05hbWV9LkNvbnN0cnVjdG9yIik7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNwcAppbmRleCAwOTc1YWEzZWRkZjE3OTQyODNjMzI3Yjk2 OTkyZTk3MjlmZjVkZDliLi5hODBmYTZlZmExMWFlNDYyNDczMTc3Y2FmZjM0OWU0ZTk5NDE2NmMw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHAKQEAgLTc0 LDEyICs3NCwxNiBAQCB2b2lkIERPTURhdGFTdG9yZTo6d2Vha0NhbGxiYWNrKHY4OjpQZXJzaXN0 ZW50PHY4OjpWYWx1ZT4gdmFsdWUsIHZvaWQqIGNvbnRleHQpCiB7CiAgICAgTm9kZSogb2JqZWN0 ID0gc3RhdGljX2Nhc3Q8Tm9kZSo+KGNvbnRleHQpOwogICAgIEFTU0VSVCh2YWx1ZS0+SXNPYmpl Y3QoKSk7Ci0gICAgQVNTRVJUKG9iamVjdC0+d3JhcHBlcigpID09IHY4OjpQZXJzaXN0ZW50PHY4 OjpPYmplY3Q+OjpDYXN0KHZhbHVlKSk7CisgICAgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4g d3JhcHBlciA9IHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+OjpDYXN0KHZhbHVlKTsKKyAgICBB U1NFUlQob2JqZWN0LT53cmFwcGVyKCkgPT0gd3JhcHBlcik7CisgICAgV3JhcHBlclR5cGVJbmZv KiBpbmZvID0gdG9XcmFwcGVyVHlwZUluZm8od3JhcHBlcik7CisgICAgQVNTRVJUKGluZm8tPmRl cmVmT2JqZWN0RnVuY3Rpb24pOworICAgIEFTU0VSVChvYmplY3QgPSBzdGF0aWNfY2FzdDxOb2Rl Kj4odG9OYXRpdmUod3JhcHBlcikpKTsKIAogICAgIG9iamVjdC0+Y2xlYXJXcmFwcGVyKCk7CiAg ICAgdmFsdWUuRGlzcG9zZSgpOwogICAgIHZhbHVlLkNsZWFyKCk7Ci0gICAgb2JqZWN0LT5kZXJl ZigpOworICAgIGluZm8tPmRlcmVmT2JqZWN0KG9iamVjdCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBw ZXJNYXAuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJNYXAuaAppbmRl eCA1N2QzMmNlN2RhZTNhYjk2ODk3YjA1MWJhMWEzMDMwN2E1M2VmY2VlLi44NmVmZjBlMjZkODU1 NGZjOTk5MzAyZjBiMmVmN2FkZDJjNWFlMzA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9ET01XcmFwcGVyTWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvRE9NV3JhcHBlck1hcC5oCkBAIC05NCw2ICs5NCw3IEBAIHByaXZhdGU6CiAgICAgICAgIEFT U0VSVCh2YWx1ZS0+SXNPYmplY3QoKSk7CiAgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmpl Y3Q+IHdyYXBwZXIgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7CiAg ICAgICAgIFdyYXBwZXJUeXBlSW5mbyogdHlwZSA9IHRvV3JhcHBlclR5cGVJbmZvKHdyYXBwZXIp OworICAgICAgICBBU1NFUlQodHlwZS0+ZGVyZWZPYmplY3RGdW5jdGlvbik7CiAgICAgICAgIEtl eVR5cGUqIGtleSA9IHN0YXRpY19jYXN0PEtleVR5cGUqPih0b05hdGl2ZSh3cmFwcGVyKSk7CiAK ICAgICAgICAgbWFwLT5yZW1vdmUoa2V5LCB3cmFwcGVyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3Rvci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MSW1hZ2VFbGVtZW50 Q29uc3RydWN0b3IuY3BwCmluZGV4IDU4YTdhZjQ5MmUyOTA1ZmFlYTcwY2Y0ZWI0MzdhMjZmMWVk ZGQyNTMuLmVkZGQxZGU5OTgwOGE0NmRjYTBhNTZkNDVhMTNjYzExYTE3MzFhZGYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxJbWFnZUVsZW1lbnRD b25zdHJ1Y3Rvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 SFRNTEltYWdlRWxlbWVudENvbnN0cnVjdG9yLmNwcApAQCAtNDMsNyArNDMsNyBAQAogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKLVdyYXBwZXJUeXBlSW5mbyBWOEhUTUxJbWFnZUVsZW1lbnRDb25z dHJ1Y3Rvcjo6aW5mbyA9IHsgVjhIVE1MSW1hZ2VFbGVtZW50Q29uc3RydWN0b3I6OkdldFRlbXBs YXRlLCAwLCAwLCAwLCBWOEhUTUxJbWFnZUVsZW1lbnQ6Omluc3RhbGxQZXJDb250ZXh0UHJvdG90 eXBlUHJvcGVydGllcywgMCwgV3JhcHBlclR5cGVPYmplY3RQcm90b3R5cGUgfTsKK1dyYXBwZXJU eXBlSW5mbyBWOEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3Rvcjo6aW5mbyA9IHsgVjhIVE1MSW1h Z2VFbGVtZW50Q29uc3RydWN0b3I6OkdldFRlbXBsYXRlLCBWOEhUTUxJbWFnZUVsZW1lbnQ6OmRl cmVmT2JqZWN0LCAwLCAwLCBWOEhUTUxJbWFnZUVsZW1lbnQ6Omluc3RhbGxQZXJDb250ZXh0UHJv dG90eXBlUHJvcGVydGllcywgMCwgV3JhcHBlclR5cGVPYmplY3RQcm90b3R5cGUgfTsKIAogc3Rh dGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3RvckNh bGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiB7Cg==