101520 2012-11-07 16:15:55 -0800 REGRESSION(r133810): This patch made ws_single_peak_r regress by 15% (Requested by abarth on #webkit). 2012-11-07 16:20:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101110 1 webkit.review.bot webkit.review.bot abarth haraken oldest_to_newest 761148 0 webkit.review.bot 2012-11-07 16:15:55 -0800 http://trac.webkit.org/changeset/133810 broke the build: This patch made ws_single_peak_r regress by 15% (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 761150 1 172888 webkit.review.bot 2012-11-07 16:16:44 -0800 Created attachment 172888 ROLLOUT of r133810 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 761153 2 172888 abarth 2012-11-07 16:20:32 -0800 Comment on attachment 172888 ROLLOUT of r133810 Clearing flags on attachment: 172888 Committed r133818: <http://trac.webkit.org/changeset/133818> 761154 3 abarth 2012-11-07 16:20:35 -0800 All reviewed patches have been landed. Closing bug. 172888 2012-11-07 16:16:44 -0800 2012-11-07 16:20:32 -0800 ROLLOUT of r133810 bug-101520-20121108002305.patch text/plain 4701 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWUyYjhhZWNlMTZlZmUy NTU3YmIyNzQyOTdlODQ5NzNlNjA0YWM4NC4uMjQyNzU4NDcwZWUyY2EzZjRlMDViMTVkYmU3NmJj OGQ1NzU1ZTZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA3ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTMzODEwLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzM4MTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTUyMAorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFkZSB3c19zaW5nbGVfcGVh a19yIHJlZ3Jlc3MgYnkgMTUlIChSZXF1ZXN0ZWQgYnkKKyAgICAgICAgYWJhcnRoIG9uICN3ZWJr aXQpLgorCisgICAgICAgICogYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6d2Vha0NhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5n cy92OC9ET01EYXRhU3RvcmUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6Z2V0 KToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6c2V0KToKKyAgICAgICAgKERPTURh dGFTdG9yZSk6CisKIDIwMTItMTEtMDcgIEVsbGlvdHQgU3ByZWhuICA8ZXNwcmVobkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgQ2xlYW4gdXAgY29uZnVzZWQgdXNlIG9mIERvY3VtZW50OjpyZW5k ZXJlciBhbmQgcmVuZGVyVmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvRE9NRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFT dG9yZS5jcHAKaW5kZXggOWIwZWY1OTJmNjdlMzVkNDM3NmY3OWFhODEyOTM5M2VkNjc0YTUzNS4u MDk3NWFhM2VkZGYxNzk0MjgzYzMyN2I5Njk5MmU5NzI5ZmY1ZGQ5YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3BwCkBAIC03MiwxOCArNzIsMTQgQEAgdm9p ZCBET01EYXRhU3RvcmU6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9y eU9iamVjdEluZm8pIGNvbnN0CiAKIHZvaWQgRE9NRGF0YVN0b3JlOjp3ZWFrQ2FsbGJhY2sodjg6 OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiB2YWx1ZSwgdm9pZCogY29udGV4dCkKIHsKLSAgICBTY3Jp cHRXcmFwcGFibGUqIGtleSA9IHN0YXRpY19jYXN0PFNjcmlwdFdyYXBwYWJsZSo+KGNvbnRleHQp OworICAgIE5vZGUqIG9iamVjdCA9IHN0YXRpY19jYXN0PE5vZGUqPihjb250ZXh0KTsKICAgICBB U1NFUlQodmFsdWUtPklzT2JqZWN0KCkpOwotICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+ IHdyYXBwZXIgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7Ci0gICAg QVNTRVJUKGtleS0+d3JhcHBlcigpID09IHdyYXBwZXIpOwotICAgIC8vIE5vdGU6IHxvYmplY3R8 IG1pZ2h0IG5vdCBiZSBlcXVhbCB0byB8a2V5fCwgZS5nLiwgaWYgU2NyaXB0V3JhcHBhYmxlIGlz bid0IGEgbGVmdC1tb3N0IGJhc2UgY2xhc3MuCi0gICAgdm9pZCogb2JqZWN0ID0gdG9OYXRpdmUo d3JhcHBlcik7Ci0gICAgV3JhcHBlclR5cGVJbmZvKiBpbmZvID0gdG9XcmFwcGVyVHlwZUluZm8o d3JhcHBlcik7CisgICAgQVNTRVJUKG9iamVjdC0+d3JhcHBlcigpID09IHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+OjpDYXN0KHZhbHVlKSk7CiAKLSAgICBrZXktPmNsZWFyV3JhcHBlcigpOwor ICAgIG9iamVjdC0+Y2xlYXJXcmFwcGVyKCk7CiAgICAgdmFsdWUuRGlzcG9zZSgpOwogICAgIHZh bHVlLkNsZWFyKCk7Ci0gICAgaW5mby0+ZGVyZWZPYmplY3Qob2JqZWN0KTsKKyAgICBvYmplY3Qt PmRlcmVmKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKaW5kZXggOWE3ZWNhZTJkODE3NzFmM2VkODU0NzFiNGI5 MWE5NmM3YmNhNDRiYS4uYjkwZWI5M2M0MzM3ZGMxNDc5YmE3MmY1MTUzYzI4YjlhNGJlMTEzMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKQEAgLTU5LDUyICs1 OSwyOSBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgRE9NRGF0YVN0b3JlKiBjdXJyZW50KHY4OjpJ c29sYXRlKik7CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgotICAgIGlubGluZSB2ODo6SGFu ZGxlPHY4OjpPYmplY3Q+IGdldChUKiBvYmplY3QpIGNvbnN0CisgICAgaW5saW5lIHY4OjpIYW5k bGU8djg6Ok9iamVjdD4gZ2V0KHZvaWQqIG9iamVjdCkgY29uc3QgeyByZXR1cm4gbV9kb21PYmpl Y3RNYXAtPmdldChvYmplY3QpOyB9CisgICAgaW5saW5lIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4g Z2V0KE5vZGUqIG9iamVjdCkgY29uc3QKICAgICB7Ci0gICAgICAgIGlmICh3cmFwcGVySXNTdG9y ZWRJbk9iamVjdChvYmplY3QpKQotICAgICAgICAgICAgcmV0dXJuIGdldFdyYXBwZXJGcm9tT2Jq ZWN0KG9iamVjdCk7CisgICAgICAgIGlmIChtX3R5cGUgPT0gTWFpbldvcmxkKQorICAgICAgICAg ICAgcmV0dXJuIG9iamVjdC0+d3JhcHBlcigpOwogICAgICAgICByZXR1cm4gbV9kb21PYmplY3RN YXAtPmdldChvYmplY3QpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+Ci0gICAg aW5saW5lIHZvaWQgc2V0KFQqIG9iamVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3Jh cHBlcikKKyAgICBpbmxpbmUgdm9pZCBzZXQodm9pZCogb2JqZWN0LCB2ODo6UGVyc2lzdGVudDx2 ODo6T2JqZWN0PiB3cmFwcGVyKSB7IG1fZG9tT2JqZWN0TWFwLT5zZXQob2JqZWN0LCB3cmFwcGVy KTsgfQorICAgIGlubGluZSB2b2lkIHNldChOb2RlKiBvYmplY3QsIHY4OjpQZXJzaXN0ZW50PHY4 OjpPYmplY3Q+IHdyYXBwZXIpCiAgICAgewotICAgICAgICBpZiAoc2V0V3JhcHBlckluT2JqZWN0 KG9iamVjdCwgd3JhcHBlcikpCisgICAgICAgIGlmIChtX3R5cGUgPT0gTWFpbldvcmxkKSB7Cisg ICAgICAgICAgICBBU1NFUlQob2JqZWN0LT53cmFwcGVyKCkuSXNFbXB0eSgpKTsKKyAgICAgICAg ICAgIG9iamVjdC0+c2V0V3JhcHBlcih3cmFwcGVyKTsKKyAgICAgICAgICAgIHdyYXBwZXIuTWFr ZVdlYWsob2JqZWN0LCB3ZWFrQ2FsbGJhY2spOwogICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICB9CiAgICAgICAgIG1fZG9tT2JqZWN0TWFwLT5zZXQob2JqZWN0LCB3cmFwcGVyKTsKICAgICB9 CiAKICAgICB2b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdDsK IAogcHJpdmF0ZToKLSAgICBib29sIHdyYXBwZXJJc1N0b3JlZEluT2JqZWN0KHZvaWQqKSBjb25z dCB7IHJldHVybiBmYWxzZTsgfQotICAgIGJvb2wgd3JhcHBlcklzU3RvcmVkSW5PYmplY3QoU2Ny aXB0V3JhcHBhYmxlKikgY29uc3QgeyByZXR1cm4gbV90eXBlID09IE1haW5Xb3JsZDsgfQotCi0g ICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnZXRXcmFwcGVyRnJvbU9iamVjdCh2b2lkKikgY29u c3QKLSAgICB7Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICByZXR1cm4g djg6OkhhbmRsZTx2ODo6T2JqZWN0PigpOwotICAgIH0KLQotICAgIHY4OjpIYW5kbGU8djg6Ok9i amVjdD4gZ2V0V3JhcHBlckZyb21PYmplY3QoU2NyaXB0V3JhcHBhYmxlKiBvYmplY3QpIGNvbnN0 Ci0gICAgewotICAgICAgICBBU1NFUlQobV90eXBlID09IE1haW5Xb3JsZCk7Ci0gICAgICAgIHJl dHVybiBvYmplY3QtPndyYXBwZXIoKTsKLSAgICB9Ci0KLSAgICBib29sIHNldFdyYXBwZXJJbk9i amVjdCh2b2lkKiwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4pIHsgcmV0dXJuIGZhbHNlOyB9 Ci0gICAgYm9vbCBzZXRXcmFwcGVySW5PYmplY3QoU2NyaXB0V3JhcHBhYmxlKiBvYmplY3QsIHY4 OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIpCi0gICAgewotICAgICAgICBpZiAobV90 eXBlICE9IE1haW5Xb3JsZCkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgQVNT RVJUKG9iamVjdC0+d3JhcHBlcigpLklzRW1wdHkoKSk7Ci0gICAgICAgIEFTU0VSVChtX2RvbU9i amVjdE1hcC0+Z2V0KHRvTmF0aXZlKHdyYXBwZXIpKS5Jc0VtcHR5KCkpOwotICAgICAgICBvYmpl Y3QtPnNldFdyYXBwZXIod3JhcHBlcik7Ci0gICAgICAgIHdyYXBwZXIuTWFrZVdlYWsob2JqZWN0 LCB3ZWFrQ2FsbGJhY2spOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0KICAgICBzdGF0 aWMgdm9pZCB3ZWFrQ2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiwgdm9pZCogY29u dGV4dCk7CiAKICAgICBUeXBlIG1fdHlwZTsK