101515 2012-11-07 15:12:18 -0800 HashAndUTF8CharactersTranslator should create an 8 bit string if possible 2012-11-08 10:48:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin webkit.review.bot oldest_to_newest 761091 0 msaboff 2012-11-07 15:12:18 -0800 HashAndUTF8CharactersTranslator::translate() calls convertUTF8ToUTF16() to turn the UTF8 source into character data. It should use the optional "is all ASCII" flag parameter to convertUTF8ToUTF16() and create an 8 bit string if the source is all ASCII. 761097 1 172880 msaboff 2012-11-07 15:22:18 -0800 Created attachment 172880 Patch 761917 2 172880 darin 2012-11-08 10:21:57 -0800 Comment on attachment 172880 Patch Changes like this are better if the change log or comments state why we are doing this. I know why, but I don’t think it’s obvious why this is the right thing to do. You can imagine a different approach where we actually allocated a UTF-16 buffer and scanned it and determined the whole thing was Latin-1 even for non-ASCII cases. Presumably that’s not important, but this optimization is important. Some brief remark about how you decided to do this is needed. The change log you have here is entirely mechanical, and it says what the code does, but what people are interested in more often is why. 761963 3 172880 webkit.review.bot 2012-11-08 10:48:02 -0800 Comment on attachment 172880 Patch Clearing flags on attachment: 172880 Committed r133918: <http://trac.webkit.org/changeset/133918> 761964 4 webkit.review.bot 2012-11-08 10:48:05 -0800 All reviewed patches have been landed. Closing bug. 172880 2012-11-07 15:22:18 -0800 2012-11-08 10:48:02 -0800 Patch 101515.patch text/plain 2026 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzM4MDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEhhc2hBbmRVVEY4Q2hhcmFjdGVyc1RyYW5zbGF0 b3Igc2hvdWxkIGNyZWF0ZSBhbiA4IGJpdCBzdHJpbmcgaWYgcG9zc2libGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTUxNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGlzQWxsQVNDSUkgZmxh ZyB0aGF0J3MgcGFzc2VkIHRvIGNvbnZlcnRVVEY4VG9VVEYxNigpLiAgSWYgb24gcmV0dXJuIGl0 IGlzIHRydWUsIGNyZWF0ZSBhbgorICAgICAgICA4IGJpdCBzdHJpbmcsIG90aGVyd2lzZSB1c2Ug dGhlIDE2IGJpdCBzdHJpbmcuCisKKyAgICAgICAgKiB3dGYvdGV4dC9BdG9taWNTdHJpbmcuY3Bw OgorICAgICAgICAoV1RGOjpIYXNoQW5kVVRGOENoYXJhY3RlcnNUcmFuc2xhdG9yOjp0cmFuc2xh dGUpOgorCiAyMDEyLTExLTA3ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgRml4IGFzbSBvcGVyYW5kIHR5cGUgZm9yIHdlYWtDb21wYXJlQW5kU3dhcCBvbiBB Uk1fVEhVTUIyCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCShyZXZpc2lv biAxMzM3NjApCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIyMCwxMiArMjIwLDE3IEBAIHN0cnVjdCBIYXNoQW5kVVRGOENoYXJhY3Rl cnNUcmFuc2xhdG9yIHsKICAgICBzdGF0aWMgdm9pZCB0cmFuc2xhdGUoU3RyaW5nSW1wbComIGxv Y2F0aW9uLCBjb25zdCBIYXNoQW5kVVRGOENoYXJhY3RlcnMmIGJ1ZmZlciwgdW5zaWduZWQgaGFz aCkKICAgICB7CiAgICAgICAgIFVDaGFyKiB0YXJnZXQ7Ci0gICAgICAgIGxvY2F0aW9uID0gU3Ry aW5nSW1wbDo6Y3JlYXRlVW5pbml0aWFsaXplZChidWZmZXIudXRmMTZMZW5ndGgsIHRhcmdldCku bGVha1JlZigpOworICAgICAgICBSZWZQdHI8U3RyaW5nSW1wbD4gbmV3U3RyaW5nID0gU3RyaW5n SW1wbDo6Y3JlYXRlVW5pbml0aWFsaXplZChidWZmZXIudXRmMTZMZW5ndGgsIHRhcmdldCk7CiAK KyAgICAgICAgYm9vbCBpc0FsbEFTQ0lJOwogICAgICAgICBjb25zdCBjaGFyKiBzb3VyY2UgPSBi dWZmZXIuY2hhcmFjdGVyczsKLSAgICAgICAgaWYgKGNvbnZlcnRVVEY4VG9VVEYxNigmc291cmNl LCBzb3VyY2UgKyBidWZmZXIubGVuZ3RoLCAmdGFyZ2V0LCB0YXJnZXQgKyBidWZmZXIudXRmMTZM ZW5ndGgpICE9IGNvbnZlcnNpb25PSykKKyAgICAgICAgaWYgKGNvbnZlcnRVVEY4VG9VVEYxNigm c291cmNlLCBzb3VyY2UgKyBidWZmZXIubGVuZ3RoLCAmdGFyZ2V0LCB0YXJnZXQgKyBidWZmZXIu dXRmMTZMZW5ndGgsICZpc0FsbEFTQ0lJKSAhPSBjb252ZXJzaW9uT0spCiAgICAgICAgICAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKIAorICAgICAgICBpZiAoaXNBbGxBU0NJSSkKKyAgICAgICAg ICAgIG5ld1N0cmluZyA9IFN0cmluZ0ltcGw6OmNyZWF0ZShidWZmZXIuY2hhcmFjdGVycywgYnVm ZmVyLmxlbmd0aCk7CisKKyAgICAgICAgbG9jYXRpb24gPSBuZXdTdHJpbmcucmVsZWFzZSgpLmxl YWtSZWYoKTsKICAgICAgICAgbG9jYXRpb24tPnNldEhhc2goaGFzaCk7CiAgICAgICAgIGxvY2F0 aW9uLT5zZXRJc0F0b21pYyh0cnVlKTsKICAgICB9Cg==