101513 2012-11-07 14:45:07 -0800 [chromium] correct coding oversight for clang 2012-11-08 07:44:16 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rjkroege rjkroege abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 761070 0 rjkroege 2012-11-07 14:45:07 -0800 https://bugs.webkit.org/show_bug.cgi?id=100675 introduced interfaces for implementing gesture animation curves in the Chromium embedder. Sadly (nigh stupidly), it featured an incorrect declaration that prevents compilation of embedder provided functionality with clang. The attached patch fixes it. 761079 1 172877 rjkroege 2012-11-07 14:56:01 -0800 Created attachment 172877 Patch 761082 2 172877 rjkroege 2012-11-07 14:57:11 -0800 Comment on attachment 172877 Patch Could you review please? 761085 3 webkit.review.bot 2012-11-07 14:59:25 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 761516 4 172877 tkent 2012-11-08 02:37:03 -0800 Comment on attachment 172877 Patch ok 761597 5 172877 webkit.review.bot 2012-11-08 03:40:11 -0800 Comment on attachment 172877 Patch Rejecting attachment 172877 from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14755815 761771 6 172877 rjkroege 2012-11-08 07:29:29 -0800 Comment on attachment 172877 Patch I am reasonably convinced that the layout test fail is flake. 761791 7 172877 webkit.review.bot 2012-11-08 07:44:12 -0800 Comment on attachment 172877 Patch Clearing flags on attachment: 172877 Committed r133901: <http://trac.webkit.org/changeset/133901> 761792 8 webkit.review.bot 2012-11-08 07:44:16 -0800 All reviewed patches have been landed. Closing bug. 172877 2012-11-07 14:56:01 -0800 2012-11-08 07:44:12 -0800 Patch bug-101513-20121107175412.patch text/plain 1353 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAwMzNkZjFkMDg3Y2U5 YjhhZWU1OWI0YWRmYWE4OTc1OWJhMjE5ZjA3Li4zM2EzNGNjOTVkZWI0ZjJiOTBkMGIwMzIxNmI2 NjNiNWM0MGUzOTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0wNyAg Um9iZXJ0IEtyb2VnZXIgIDxyamtyb2VnZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9t aXVtXSBjb3JyZWN0IGNvZGluZyBvdmVyc2lnaHQgZm9yIGNsYW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE1MTMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAwNjc1IGNvbnRhaW5zIGFuCisgICAgICAgIGluY29ycmVjdCBkZWNs YXJhdGlvbiB0aGF0IHByZWNsdWRlcyBjb21waWxpbmcgZW1iZWRkZXIgY29kZQorICAgICAgICB3 aXRoIGNsYW5nOiBwYXRjaCBjaGFuZ2VzIGNsYXNzIHRvIHN0cnVjdCBhcHByb3ByaWF0ZWx5Lgor CisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkdlc3R1cmVDdXJ2ZVRhcmdldC5oOgorICAg ICAgICAoV2ViS2l0KToKKwogMjAxMi0xMC0yMyAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNv QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbc2tpYV0gSW1wbGVtZW50IHJlZmVyZW5jZSAodXJs KSBmaWx0ZXJzIG9uIGNvbXBvc2l0ZWQgbGF5ZXJzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9XZWJHZXN0dXJlQ3VydmVUYXJnZXQuaCBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViR2VzdHVyZUN1cnZlVGFyZ2V0LmgKaW5kZXggZmFlYWMx YjZlMjk2MDAzZjJhY2FlODJhM2EyMTJmYmZiOTBkZjhlZC4uYTQ0YmZiZmI5NjlmMjk4NjI5ZDQ3 Y2E5MDdkYTMyNWRmZDcwZjJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJHZXN0dXJlQ3VydmVUYXJnZXQuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hy b21pdW0vcHVibGljL1dlYkdlc3R1cmVDdXJ2ZVRhcmdldC5oCkBAIC0yNyw3ICsyNyw3IEBACiAK IG5hbWVzcGFjZSBXZWJLaXQgewogCi1jbGFzcyBXZWJQb2ludDsKK3N0cnVjdCBXZWJQb2ludDsK IAogY2xhc3MgV2ViR2VzdHVyZUN1cnZlVGFyZ2V0IHsKIHB1YmxpYzoK