101509 2012-11-07 14:06:03 -0800 [Chromium] DumpRenderTree fix for canvas in software compositing 2012-11-08 13:40:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 skaslev webkit-unassigned enne jamesr webkit.review.bot oldest_to_newest 761038 0 skaslev 2012-11-07 14:06:03 -0800 [Chromium] DumpRenderTree fix for canvas in software compositing 761039 1 172868 skaslev 2012-11-07 14:07:49 -0800 Created attachment 172868 Patch 761040 2 172868 kbr 2012-11-07 14:09:12 -0800 Comment on attachment 172868 Patch Looks fine, though I wonder whether we'll run into similar problems with other features like hardware accelerated video. r=me 761095 3 skaslev 2012-11-07 15:21:28 -0800 Video layout tests pass now (minus filtering diff between Mesa and Skia which will be "fixed" when I do a layout test results rebase) so I didn't do anything about them. After the virtual/softwarecompositing layout tests rebase, I'll keep an eye if something like that breaks them. 761156 4 172868 webkit.review.bot 2012-11-07 16:24:17 -0800 Comment on attachment 172868 Patch Rejecting attachment 172868 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ion-size.html [ Failure Pass ] Unexpected flakiness: image-only failures (1) fast/text/international/hindi-spacing.html [ ImageOnlyFailure Pass ] Unexpected flakiness: timeouts (1) fast/loader/text-document-wrapping.html [ Timeout Pass ] Unexpected flakiness: text-only failures (1) fast/loader/javascript-url-in-object.html [ Failure Pass ] Regressions: Unexpected text-only failures (1) platform/chromium/virtual/softwarecompositing/layer-creation/spanOverlapsCanvas.html [ Failure ] Full output: http://queues.webkit.org/results/14759513 761183 5 172893 skaslev 2012-11-07 17:00:51 -0800 Created attachment 172893 Patch 762118 6 172893 webkit.review.bot 2012-11-08 13:30:51 -0800 Comment on attachment 172893 Patch Rejecting attachment 172893 from commit-queue. skaslev@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 762121 7 enne 2012-11-08 13:32:26 -0800 Should this be addressed at a much lower level, such as just turning this setting off when software compositing is enabled? 762125 8 172893 enne 2012-11-08 13:33:43 -0800 Comment on attachment 172893 Patch Actually, I guess there is no lower level. Sounds good. R=me. 762135 9 172893 webkit.review.bot 2012-11-08 13:40:25 -0800 Comment on attachment 172893 Patch Clearing flags on attachment: 172893 Committed r133941: <http://trac.webkit.org/changeset/133941> 762137 10 webkit.review.bot 2012-11-08 13:40:28 -0800 All reviewed patches have been landed. Closing bug. 172868 2012-11-07 14:07:49 -0800 2012-11-07 17:00:49 -0800 Patch bug-101509-20121107220559.patch text/plain 1658 skaslev U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDVlOTkyNWU5NDQ4MDA4YTc1NTQ0Mjc5MDhlMjI5ZTA3 NmM0MjVlZi4uOTQwMjk0OTZkM2MzZjI2NGU0MTllOGVhNGRhZTkyODRjMTlkMjMxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTA3ICBTbGF2b21pciBLYXNsZXYgIDxza2FzbGV2QGdvb2dsZS5jb20+CisK KyAgICAgICAgW0Nocm9taXVtXSBEdW1wUmVuZGVyVHJlZSBmaXggZm9yIGNhbnZhcyBpbiBzb2Z0 d2FyZSBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxNTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG9uJ3QgdXNlIGFjY2VsZXJhdGVkIGNhbnZhcyAyZCB3aGVuIGluIHNvZnR3YXJl IGNvbXBvc2l0aW5nIG1vZGUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpydW5GaWxlVGVzdCk6CisKIDIwMTIt MTEtMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92 ZSBidWlsZC13ZWJraXQgZGVwZW5kZW5jeSBvbiBKYXZhIFNESyBmb3IgQXBwbGUgTWFjIFdlYktp dC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmluZGV4IDRj NDJkYzBkZDc0OGRkNzg3NzkxMTMwNmY0NmY5NTkwNTk5NTVmMzAuLjJiY2NiNmEzMmFlNzM4MzAx OTAzOGZiZWIwYWJiYmNlMDA0YTUyMmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vVGVzdFNoZWxsLmNwcApAQCAtMjU1LDggKzI1NSw5IEBAIHZvaWQgVGVzdFNoZWxsOjpydW5G aWxlVGVzdChjb25zdCBUZXN0UGFyYW1zJiBwYXJhbXMsIGJvb2wgc2hvdWxkRHVtcFBpeGVscykK ICAgICAgICAgbV90ZXN0UnVubmVyLT5zZXRTaG91bGREdW1wRnJhbWVMb2FkQ2FsbGJhY2tzKHRy dWUpOwogCiAgICAgaWYgKHRlc3RVcmwuZmluZCgiY29tcG9zaXRpbmcvIikgIT0gc3RyaW5nOjpu cG9zIHx8IHRlc3RVcmwuZmluZCgiY29tcG9zaXRpbmdcXCIpICE9IHN0cmluZzo6bnBvcykgewor ICAgICAgICBpZiAoIW1fc29mdHdhcmVDb21wb3NpdGluZ0VuYWJsZWQpCisgICAgICAgICAgICBt X3ByZWZzLmFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkID0gdHJ1ZTsKICAgICAgICAgbV9wcmVm cy5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yVmlkZW9FbmFibGVkID0gdHJ1ZTsKLSAgICAgICAg bV9wcmVmcy5hY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxlZCA9IHRydWU7CiAgICAgICAgIG1fcHJl ZnMuZGVmZXJyZWQyZENhbnZhc0VuYWJsZWQgPSB0cnVlOwogICAgICAgICBtX3ByZWZzLm1vY2tT Y3JvbGxiYXJzRW5hYmxlZCA9IHRydWU7CiAgICAgICAgIG1fcHJlZnMuYXBwbHlUbyhtX3dlYlZp ZXcpOwo= 172893 2012-11-07 17:00:51 -0800 2012-11-08 13:40:25 -0800 Patch bug-101509-20121108005901.patch text/plain 2839 skaslev U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDVlOTkyNWU5NDQ4MDA4YTc1NTQ0Mjc5MDhlMjI5ZTA3 NmM0MjVlZi4uOTQwMjk0OTZkM2MzZjI2NGU0MTllOGVhNGRhZTkyODRjMTlkMjMxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTA3ICBTbGF2b21pciBLYXNsZXYgIDxza2FzbGV2QGdvb2dsZS5jb20+CisK KyAgICAgICAgW0Nocm9taXVtXSBEdW1wUmVuZGVyVHJlZSBmaXggZm9yIGNhbnZhcyBpbiBzb2Z0 d2FyZSBjb21wb3NpdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxNTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG9uJ3QgdXNlIGFjY2VsZXJhdGVkIGNhbnZhcyAyZCB3aGVuIGluIHNvZnR3YXJl IGNvbXBvc2l0aW5nIG1vZGUuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpydW5GaWxlVGVzdCk6CisKIDIwMTIt MTEtMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92 ZSBidWlsZC13ZWJraXQgZGVwZW5kZW5jeSBvbiBKYXZhIFNESyBmb3IgQXBwbGUgTWFjIFdlYktp dC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5j cHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmluZGV4IDRj NDJkYzBkZDc0OGRkNzg3NzkxMTMwNmY0NmY5NTkwNTk5NTVmMzAuLjJiY2NiNmEzMmFlNzM4MzAx OTAzOGZiZWIwYWJiYmNlMDA0YTUyMmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vVGVzdFNoZWxsLmNwcApAQCAtMjU1LDggKzI1NSw5IEBAIHZvaWQgVGVzdFNoZWxsOjpydW5G aWxlVGVzdChjb25zdCBUZXN0UGFyYW1zJiBwYXJhbXMsIGJvb2wgc2hvdWxkRHVtcFBpeGVscykK ICAgICAgICAgbV90ZXN0UnVubmVyLT5zZXRTaG91bGREdW1wRnJhbWVMb2FkQ2FsbGJhY2tzKHRy dWUpOwogCiAgICAgaWYgKHRlc3RVcmwuZmluZCgiY29tcG9zaXRpbmcvIikgIT0gc3RyaW5nOjpu cG9zIHx8IHRlc3RVcmwuZmluZCgiY29tcG9zaXRpbmdcXCIpICE9IHN0cmluZzo6bnBvcykgewor ICAgICAgICBpZiAoIW1fc29mdHdhcmVDb21wb3NpdGluZ0VuYWJsZWQpCisgICAgICAgICAgICBt X3ByZWZzLmFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkID0gdHJ1ZTsKICAgICAgICAgbV9wcmVm cy5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yVmlkZW9FbmFibGVkID0gdHJ1ZTsKLSAgICAgICAg bV9wcmVmcy5hY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxlZCA9IHRydWU7CiAgICAgICAgIG1fcHJl ZnMuZGVmZXJyZWQyZENhbnZhc0VuYWJsZWQgPSB0cnVlOwogICAgICAgICBtX3ByZWZzLm1vY2tT Y3JvbGxiYXJzRW5hYmxlZCA9IHRydWU7CiAgICAgICAgIG1fcHJlZnMuYXBwbHlUbyhtX3dlYlZp ZXcpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggNDNjZDk4OTE0ODZjNmUxM2E2NzJmOWYyODk2MzMzNTQ0NmIyYTY5MC4uMDYwMTI5OWFj NTVjZWFkYmIyMDZiYTYyZTYzMDAwMTY3NWQyNzE5MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC0zOTQ0LDcgKzM5NDQsNyBAQCBjcmJ1 Zy5jb20vMTUwMDEwIHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvc29mdHdhcmVjb21wb3NpdGlu Zy9yZWZsZWN0aW9ucy9yZW1vdgogY3JidWcuY29tLzE1MDAxMCBwbGF0Zm9ybS9jaHJvbWl1bS92 aXJ0dWFsL3NvZnR3YXJlY29tcG9zaXRpbmcvcmVmbGVjdGlvbnMvc2ltcGxlLWNvbXBvc2l0ZWQt cmVmbGVjdGlvbnMuaHRtbCBbIFBhc3MgXQogCiAjIENhbnZhczJkIG5vdCB5ZXQgc3VwcG9ydGVk IGJ5IHNvZnR3YXJlIGNvbXBvc2l0b3IuCi1jcmJ1Zy5jb20vMTUwMDE4IFsgRGVidWcgXSBwbGF0 Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL3NvZnR3YXJlY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24v c3Bhbk92ZXJsYXBzQ2FudmFzLmh0bWwgWyBTa2lwIF0KK2NyYnVnLmNvbS8xNTAwMTggcGxhdGZv cm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0d2FyZWNvbXBvc2l0aW5nL2xheWVyLWNyZWF0aW9uL3Nw YW5PdmVybGFwc0NhbnZhcy5odG1sIFsgU2tpcCBdCiBjcmJ1Zy5jb20vMTUwMDE4IHBsYXRmb3Jt L2Nocm9taXVtL3ZpcnR1YWwvc29mdHdhcmVjb21wb3NpdGluZy9vdmVyZmxvdy9vdmVyZmxvdy1o aWRkZW4tY2FudmFzLWxheWVyLmh0bWwgWyBTa2lwIF0KIGNyYnVnLmNvbS8xNTAwMTggcGxhdGZv cm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0d2FyZWNvbXBvc2l0aW5nL292ZXJmbG93L292ZXJmbG93 LWNvbXBvc2l0aW5nLWRlc2NlbmRhbnQuaHRtbCBbIFNraXAgXQogY3JidWcuY29tLzE1MDAxOCBw bGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL3NvZnR3YXJlY29tcG9zaXRpbmcvdmlzaWJpbGl0eS92 aXNpYmlsaXR5LXNpbXBsZS1jYW52YXMyZC1sYXllci5odG1sIFsgU2tpcCBdCg==