101507 2012-11-07 14:03:11 -0800 OpaqueJSClassContextData() should use StringImpl::isolatedCopy() to make string copies 2012-11-08 09:31:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff ggaren webkit.review.bot oldest_to_newest 761035 0 msaboff 2012-11-07 14:03:11 -0800 The OpaqueJSClassContextData construction creates its own copy of key StringImpls using StringImpl::create(UChar) and characters(). Instead it should use StringImpl::isolatedCopy(). 761037 1 172867 msaboff 2012-11-07 14:05:24 -0800 Created attachment 172867 Patch 761740 2 172867 webkit.review.bot 2012-11-08 06:55:09 -0800 Comment on attachment 172867 Patch Clearing flags on attachment: 172867 Committed r133894: <http://trac.webkit.org/changeset/133894> 761741 3 webkit.review.bot 2012-11-08 06:55:12 -0800 All reviewed patches have been landed. Closing bug. 761869 4 ggaren 2012-11-08 09:26:45 -0800 Why? 761878 5 msaboff 2012-11-08 09:31:24 -0800 (In reply to comment #4) > Why? isolatedCopy() will copy the string taking into account 8/16 bit. It is also better to have the object copy itself. 172867 2012-11-07 14:05:24 -0800 2012-11-08 06:55:09 -0800 Patch 101507.patch text/plain 2335 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzODA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTExLTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIE9wYXF1ZUpTQ2xhc3NDb250ZXh0RGF0YSgpIHNob3VsZCB1c2UgU3RyaW5nSW1wbDo6aXNv bGF0ZWRDb3B5KCkgdG8gbWFrZSBzdHJpbmcgY29waWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRvIHVzZSBpc29sYXRlZENvcHkoKSBm b3Iga2V5IFN0cmluZ3MuCisKKyAgICAgICAgKiBBUEkvSlNDbGFzc1JlZi5jcHA6CisgICAgICAg IChPcGFxdWVKU0NsYXNzQ29udGV4dERhdGE6Ok9wYXF1ZUpTQ2xhc3NDb250ZXh0RGF0YSk6CisK IDIwMTItMTEtMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBJ bmRlbnRhdGlvbiBvZiBBcmdMaXN0LmggaXMgd3JvbmcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNDbGFzc1JlZi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9KU0NsYXNzUmVmLmNwcAkocmV2aXNpb24gMTMzNzYwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM0LDcgKzEz NCw3IEBAIE9wYXF1ZUpTQ2xhc3NDb250ZXh0RGF0YTo6T3BhcXVlSlNDbGFzc0MKICAgICAgICAg T3BhcXVlSlNDbGFzc1N0YXRpY1ZhbHVlc1RhYmxlOjpjb25zdF9pdGVyYXRvciBlbmQgPSBqc0Ns YXNzLT5tX3N0YXRpY1ZhbHVlcy0+ZW5kKCk7CiAgICAgICAgIGZvciAoT3BhcXVlSlNDbGFzc1N0 YXRpY1ZhbHVlc1RhYmxlOjpjb25zdF9pdGVyYXRvciBpdCA9IGpzQ2xhc3MtPm1fc3RhdGljVmFs dWVzLT5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAgICAgIEFTU0VSVCghaXQt PmtleS0+aXNJZGVudGlmaWVyKCkpOwotICAgICAgICAgICAgc3RhdGljVmFsdWVzLT5hZGQoU3Ry aW5nSW1wbDo6Y3JlYXRlKGl0LT5rZXktPmNoYXJhY3RlcnMoKSwgaXQtPmtleS0+bGVuZ3RoKCkp LCBhZG9wdFB0cihuZXcgU3RhdGljVmFsdWVFbnRyeShpdC0+dmFsdWUtPmdldFByb3BlcnR5LCBp dC0+dmFsdWUtPnNldFByb3BlcnR5LCBpdC0+dmFsdWUtPmF0dHJpYnV0ZXMpKSk7CisgICAgICAg ICAgICBzdGF0aWNWYWx1ZXMtPmFkZChpdC0+a2V5LT5pc29sYXRlZENvcHkoKSwgYWRvcHRQdHIo bmV3IFN0YXRpY1ZhbHVlRW50cnkoaXQtPnZhbHVlLT5nZXRQcm9wZXJ0eSwgaXQtPnZhbHVlLT5z ZXRQcm9wZXJ0eSwgaXQtPnZhbHVlLT5hdHRyaWJ1dGVzKSkpOwogICAgICAgICB9CiAgICAgfQog CkBAIC0xNDMsNyArMTQzLDcgQEAgT3BhcXVlSlNDbGFzc0NvbnRleHREYXRhOjpPcGFxdWVKU0Ns YXNzQwogICAgICAgICBPcGFxdWVKU0NsYXNzU3RhdGljRnVuY3Rpb25zVGFibGU6OmNvbnN0X2l0 ZXJhdG9yIGVuZCA9IGpzQ2xhc3MtPm1fc3RhdGljRnVuY3Rpb25zLT5lbmQoKTsKICAgICAgICAg Zm9yIChPcGFxdWVKU0NsYXNzU3RhdGljRnVuY3Rpb25zVGFibGU6OmNvbnN0X2l0ZXJhdG9yIGl0 ID0ganNDbGFzcy0+bV9zdGF0aWNGdW5jdGlvbnMtPmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkg ewogICAgICAgICAgICAgQVNTRVJUKCFpdC0+a2V5LT5pc0lkZW50aWZpZXIoKSk7Ci0gICAgICAg ICAgICBzdGF0aWNGdW5jdGlvbnMtPmFkZChTdHJpbmdJbXBsOjpjcmVhdGUoaXQtPmtleS0+Y2hh cmFjdGVycygpLCBpdC0+a2V5LT5sZW5ndGgoKSksIGFkb3B0UHRyKG5ldyBTdGF0aWNGdW5jdGlv bkVudHJ5KGl0LT52YWx1ZS0+Y2FsbEFzRnVuY3Rpb24sIGl0LT52YWx1ZS0+YXR0cmlidXRlcykp KTsKKyAgICAgICAgICAgIHN0YXRpY0Z1bmN0aW9ucy0+YWRkKGl0LT5rZXktPmlzb2xhdGVkQ29w eSgpLCBhZG9wdFB0cihuZXcgU3RhdGljRnVuY3Rpb25FbnRyeShpdC0+dmFsdWUtPmNhbGxBc0Z1 bmN0aW9uLCBpdC0+dmFsdWUtPmF0dHJpYnV0ZXMpKSk7CiAgICAgICAgIH0KICAgICB9CiB9Cg==