101494 2012-11-07 11:26:41 -0800 [V8] DOMWrapperMap doesn't need to use virtual functions 2012-11-07 13:45:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101110 1 abarth abarth eric haraken oldest_to_newest 760914 0 abarth 2012-11-07 11:26:41 -0800 [V8] DOMWrapperMap doesn't need to use virtual functions 760917 1 172846 abarth 2012-11-07 11:27:30 -0800 Created attachment 172846 Patch 760921 2 172846 haraken 2012-11-07 11:30:54 -0800 Comment on attachment 172846 Patch ok 761027 3 172846 abarth 2012-11-07 13:45:48 -0800 Comment on attachment 172846 Patch Clearing flags on attachment: 172846 Committed r133805: <http://trac.webkit.org/changeset/133805> 761028 4 abarth 2012-11-07 13:45:50 -0800 All reviewed patches have been landed. Closing bug. 172846 2012-11-07 11:27:30 -0800 2012-11-07 13:45:48 -0800 Patch bug-101494-20121107112541.patch text/plain 5519 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM3MTU0YWI5Yjk5MTVk NGU1ZDE3ZDc5NGQzZDlkODE1NDQwYWQ1NS4uOGE5OGJiOWI0NjcyZjhlN2YxMjc3ODg5NWE3YTlh NTE3MmVlY2U1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEyLTExLTA3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBET01XcmFwcGVyTWFw IGRvZXNuJ3QgbmVlZCB0byB1c2UgdmlydHVhbCBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTQ5NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERPTVdyYXBwZXJNYXAgaGFzIG9ubHkgb25l IHN1YmNsYXNzLiBUaGVyZSdzIG5vIHJlYXNvbiB0byB1c2UgdmlydHVhbCBmdW5jdGlvbnMuCisK KyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RE9NRGF0YVN0b3JlOjpET01EYXRhU3RvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L0RP TVdyYXBwZXJNYXAuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdyYXBwZXJNYXA6OkRPTVdyYXBw ZXJNYXApOgorICAgICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlck1hcDo6Z2V0KToKKyAgICAgICAg KFdlYkNvcmU6OkRPTVdyYXBwZXJNYXA6OnNldCk6CisgICAgICAgIChXZWJDb3JlOjpET01XcmFw cGVyTWFwOjpjbGVhcik6CisgICAgICAgIChXZWJDb3JlOjpET01XcmFwcGVyTWFwOjpyZXBvcnRN ZW1vcnlVc2FnZSk6CisgICAgICAgIChXZWJDb3JlOjpET01XcmFwcGVyTWFwOjpyZW1vdmUpOgor ICAgICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlck1hcDo6ZGVmYXVsdFdlYWtDYWxsYmFjayk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhOUE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpz dGF0aWNOUE9iamVjdE1hcCk6CisKKzIwMTItMTEtMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBbVjhdIEludHJ1c2l2ZURPTVdyYXBwZXJNYXAgaXMgbm8gbG9u Z2VyIG5lZWRlZCBhbmQgY2FuIGJlIGRlbGV0ZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTQ5MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvRE9NRGF0YVN0b3JlLmNwcAppbmRleCAxNTNmNWQ0Yjg5MjNlMmMwMjBhZjg3ZGQ2NGI3Zjg3 ODUwZjIzNDY0Li4wOTc1YWEzZWRkZjE3OTQyODNjMzI3Yjk2OTkyZTk3MjlmZjVkZDliIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHAKQEAgLTQxLDcgKzQx LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogRE9NRGF0YVN0b3JlOjpET01EYXRhU3RvcmUoVHlw ZSB0eXBlKQogICAgIDogbV90eXBlKHR5cGUpCiB7Ci0gICAgbV9kb21PYmplY3RNYXAgPSBhZG9w dFB0cihuZXcgRE9NV3JhcHBlckhhc2hNYXA8dm9pZD4pOworICAgIG1fZG9tT2JqZWN0TWFwID0g YWRvcHRQdHIobmV3IERPTVdyYXBwZXJNYXA8dm9pZD4pOwogICAgIFY4UGVySXNvbGF0ZURhdGE6 OmN1cnJlbnQoKS0+cmVnaXN0ZXJET01EYXRhU3RvcmUodGhpcyk7CiB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJNYXAuaCBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L0RPTVdyYXBwZXJNYXAuaAppbmRleCBiNGMyNWQ5ZTRhNDlmYzIwNDY5 Y2Y3MWMyNmUzMWZmZGQ0Y2EwNmU5Li41N2QzMmNlN2RhZTNhYjk2ODk3YjA1MWJhMWEzMDMwN2E1 M2VmY2VlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01XcmFwcGVy TWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlck1hcC5oCkBA IC0zOSwzNiArMzksMjIgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBET01EYXRh U3RvcmU7Ci0KIHRlbXBsYXRlPGNsYXNzIEtleVR5cGU+CiBjbGFzcyBET01XcmFwcGVyTWFwIHsK IHB1YmxpYzoKLSAgICB2aXJ0dWFsIH5ET01XcmFwcGVyTWFwKCkgeyB9Ci0KLSAgICB2aXJ0dWFs IHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IGdldChLZXlUeXBlKikgPSAwOwotICAgIHZpcnR1 YWwgdm9pZCBzZXQoS2V5VHlwZSosIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+KSA9IDA7Ci0g ICAgdmlydHVhbCB2b2lkIGNsZWFyKCkgPSAwOwotCi0gICAgdmlydHVhbCB2b2lkIHJlcG9ydE1l bW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qKSBjb25zdCA9IDA7Ci19OwotCi10ZW1wbGF0ZTxj bGFzcyBLZXlUeXBlPgotY2xhc3MgRE9NV3JhcHBlckhhc2hNYXAgOiBwdWJsaWMgRE9NV3JhcHBl ck1hcDxLZXlUeXBlPiB7Ci1wdWJsaWM6CiAgICAgdHlwZWRlZiBIYXNoTWFwPEtleVR5cGUqLCB2 ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiA+IE1hcFR5cGU7CiAKLSAgICBleHBsaWNpdCBET01X cmFwcGVySGFzaE1hcCh2ODo6V2Vha1JlZmVyZW5jZUNhbGxiYWNrIGNhbGxiYWNrID0gJmRlZmF1 bHRXZWFrQ2FsbGJhY2spCisgICAgZXhwbGljaXQgRE9NV3JhcHBlck1hcCh2ODo6V2Vha1JlZmVy ZW5jZUNhbGxiYWNrIGNhbGxiYWNrID0gJmRlZmF1bHRXZWFrQ2FsbGJhY2spCiAgICAgICAgIDog bV9jYWxsYmFjayhjYWxsYmFjaykKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVhbCB2ODo6UGVy c2lzdGVudDx2ODo6T2JqZWN0PiBnZXQoS2V5VHlwZSoga2V5KSBPVkVSUklERQorICAgIHY4OjpQ ZXJzaXN0ZW50PHY4OjpPYmplY3Q+IGdldChLZXlUeXBlKiBrZXkpCiAgICAgewogICAgICAgICBy ZXR1cm4gbV9tYXAuZ2V0KGtleSk7CiAgICAgfQogCi0gICAgdmlydHVhbCB2b2lkIHNldChLZXlU eXBlKiBrZXksIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdyYXBwZXIpIE9WRVJSSURFCisg ICAgdm9pZCBzZXQoS2V5VHlwZSoga2V5LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFw cGVyKQogICAgIHsKICAgICAgICAgQVNTRVJUKCFtX21hcC5jb250YWlucyhrZXkpKTsKICAgICAg ICAgQVNTRVJUKHN0YXRpY19jYXN0PEtleVR5cGUqPih0b05hdGl2ZSh3cmFwcGVyKSkgPT0ga2V5 KTsKQEAgLTc2LDcgKzYyLDcgQEAgcHVibGljOgogICAgICAgICBtX21hcC5zZXQoa2V5LCB3cmFw cGVyKTsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgY2xlYXIoKSBPVkVSUklERQorICAgIHZv aWQgY2xlYXIoKQogICAgIHsKICAgICAgICAgZm9yICh0eXBlbmFtZSBNYXBUeXBlOjppdGVyYXRv ciBpdCA9IG1fbWFwLmJlZ2luKCk7IGl0ICE9IG1fbWFwLmVuZCgpOyArK2l0KSB7CiAgICAgICAg ICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyID0gaXQtPnZhbHVlOwpAQCAt ODcsMTMgKzczLDEzIEBAIHB1YmxpYzoKICAgICAgICAgbV9tYXAuY2xlYXIoKTsKICAgICB9CiAK LSAgICB2aXJ0dWFsIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVt b3J5T2JqZWN0SW5mbykgY29uc3QgT1ZFUlJJREUKKyAgICB2b2lkIHJlcG9ydE1lbW9yeVVzYWdl KE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CiAgICAgewogICAgICAg ICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBXZWJDb3JlTWVt b3J5VHlwZXM6OkJpbmRpbmcpOwogICAgICAgICBpbmZvLmFkZE1lbWJlcihtX21hcCk7CiAgICAg fQogCi0gICAgdmlydHVhbCB2b2lkIHJlbW92ZShLZXlUeXBlKiBrZXksIHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IHdyYXBwZXIpCisgICAgdm9pZCByZW1vdmUoS2V5VHlwZSoga2V5LCB2ODo6 UGVyc2lzdGVudDx2ODo6T2JqZWN0PiB3cmFwcGVyKQogICAgIHsKICAgICAgICAgdHlwZW5hbWUg TWFwVHlwZTo6aXRlcmF0b3IgaXQgPSBtX21hcC5maW5kKGtleSk7CiAgICAgICAgIEFTU0VSVChp dCAhPSBtX21hcC5lbmQoKSk7CkBAIC0xMDQsNyArOTAsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgog ICAgIHN0YXRpYyB2b2lkIGRlZmF1bHRXZWFrQ2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZh bHVlPiB2YWx1ZSwgdm9pZCogY29udGV4dCkKICAgICB7Ci0gICAgICAgIERPTVdyYXBwZXJIYXNo TWFwPEtleVR5cGU+KiBtYXAgPSBzdGF0aWNfY2FzdDxET01XcmFwcGVySGFzaE1hcDxLZXlUeXBl Pio+KGNvbnRleHQpOworICAgICAgICBET01XcmFwcGVyTWFwPEtleVR5cGU+KiBtYXAgPSBzdGF0 aWNfY2FzdDxET01XcmFwcGVyTWFwPEtleVR5cGU+Kj4oY29udGV4dCk7CiAgICAgICAgIEFTU0VS VCh2YWx1ZS0+SXNPYmplY3QoKSk7CiAgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+ IHdyYXBwZXIgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7CiAgICAg ICAgIFdyYXBwZXJUeXBlSW5mbyogdHlwZSA9IHRvV3JhcHBlclR5cGVJbmZvKHdyYXBwZXIpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOUE9iamVjdC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QT2JqZWN0LmNwcAppbmRleCBjNDg4NTE2YWE1 OTE5YTJjNTQxNTFmZTIxN2VhMjQ4YmNiYjA3YzBmLi4xOWFiZDllNzBmMWJiYjQ4OGQ3MTkzZDc1 ZGVhZTJiZmFlMWI1N2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OE5QT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5QT2JqZWN0 LmNwcApAQCAtMzc4LDkgKzM3OCw5IEBAIHY4OjpIYW5kbGU8djg6OkFycmF5PiBucE9iamVjdElu ZGV4ZWRQcm9wZXJ0eUVudW1lcmF0b3IoY29uc3Qgdjg6OkFjY2Vzc29ySW5mbyYKIAogc3RhdGlj IHZvaWQgd2Vha05QT2JqZWN0Q2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiwgdm9p ZCopOwogCi1zdGF0aWMgRE9NV3JhcHBlckhhc2hNYXA8TlBPYmplY3Q+JiBzdGF0aWNOUE9iamVj dE1hcCgpCitzdGF0aWMgRE9NV3JhcHBlck1hcDxOUE9iamVjdD4mIHN0YXRpY05QT2JqZWN0TWFw KCkKIHsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FMKERPTVdyYXBwZXJIYXNoTWFwPE5QT2JqZWN0 PiwgbnBPYmplY3RNYXAsICgmd2Vha05QT2JqZWN0Q2FsbGJhY2spKTsKKyAgICBERUZJTkVfU1RB VElDX0xPQ0FMKERPTVdyYXBwZXJNYXA8TlBPYmplY3Q+LCBucE9iamVjdE1hcCwgKCZ3ZWFrTlBP YmplY3RDYWxsYmFjaykpOwogICAgIHJldHVybiBucE9iamVjdE1hcDsKIH0KIAo=