<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101485</bug_id>
          
          <creation_ts>2012-11-07 10:24:46 -0800</creation_ts>
          <short_desc>[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText</short_desc>
          <delta_ts>2012-11-08 01:50:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Balazs Kelemen">kbalazs</reporter>
          <assigned_to name="Balazs Kelemen">kbalazs</assigned_to>
          <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>760833</commentid>
    <comment_count>0</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-11-07 10:24:46 -0800</bug_when>
    <thetext>All other platforms support it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760842</commentid>
    <comment_count>1</comment_count>
      <attachid>172831</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-11-07 10:31:19 -0800</bug_when>
    <thetext>Created attachment 172831
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760861</commentid>
    <comment_count>2</comment_count>
      <attachid>172831</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-07 10:45:10 -0800</bug_when>
    <thetext>Comment on attachment 172831
Patch

Good catch, r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760892</commentid>
    <comment_count>3</comment_count>
      <attachid>172831</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-11-07 11:03:16 -0800</bug_when>
    <thetext>Comment on attachment 172831
Patch

I&apos;m not sure how it will affect tests, so I&apos;m going to land it tomorrow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>761485</commentid>
    <comment_count>4</comment_count>
      <attachid>172831</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-11-08 01:50:27 -0800</bug_when>
    <thetext>Comment on attachment 172831
Patch

Clearing flags on attachment: 172831

Committed r133869: &lt;http://trac.webkit.org/changeset/133869&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>761486</commentid>
    <comment_count>5</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2012-11-08 01:50:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172831</attachid>
            <date>2012-11-07 10:31:19 -0800</date>
            <delta_ts>2012-11-08 01:50:27 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101485-20121107192929.patch</filename>
            <type>text/plain</type>
            <size>4359</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDMwZWQwZTNhNWQ5MjNmNjEwNjAxMGJhMGQ3NTdhMDQ2
NzYxYWNmMi4uOTA1MzIwODc4NzQxYWJkZjBiNzNiZGNhNzQzNzg3MzM3NWM3NzBjOSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2
IEBACiAyMDEyLTExLTA3ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAor
ICAgICAgICBbUXRdIER1bXBSZW5kZXJUcmVlIGRvZXMgbm90IGhvbm9yIHRoZSBzaG91bGREdW1w
UGl4ZWxzIGJvb2xlYW4gYXJndW1lbnQgb2YgZHVtcEFzVGV4dAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDg1CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEdW1wUmVuZGVyVHJlZSBkb2VzIG5v
dCBob25vciB0aGUgc2hvdWxkRHVtcFBpeGVscyBib29sZWFuIGFyZ3VtZW50IG9mIGR1bXBBc1Rl
eHQKKworICAgICAgICBTdXBwb3J0IGR1bXBBc1RleHQodHJ1ZSkgd2hpY2ggbWVhbnMgd2Ugc2hv
dWxkIG5vdCBkdW1wIGEgcmVuZGVyIHRyZWUKKyAgICAgICAgYnV0IHNob3VsZCBkdW1wIHBpeGVs
cy4gQWxsIG90aGVyIHBsYXRmb3JtcyBhbHJlYWR5IHN1cHBvcnQgaXQuCisKKyAgICAgICAgKiBE
dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkR1bXBSZW5kZXJUcmVlOjpkdW1wKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9UZXN0
UnVubmVyUXQuY3BwOgorICAgICAgICAoVGVzdFJ1bm5lcjo6cmVzZXQpOgorICAgICAgICAoVGVz
dFJ1bm5lcjo6ZHVtcEFzVGV4dCk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1
bm5lclF0Lmg6CisgICAgICAgIChUZXN0UnVubmVyOjpzaG91bGREdW1wUGl4ZWxzKToKKyAgICAg
ICAgKFRlc3RSdW5uZXIpOgorCisyMDEyLTExLTA3ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNA
d2Via2l0Lm9yZz4KKwogICAgICAgICBbTlJXVF0gVGhlIHJlcG9ydGVkIHJlc3VsdCBpcyBjb25m
dXNpbmcgd2hlbiBhbiBleHBlY3RlZCBwbmcgd2FzIGFjY2lkZWVudGFsbHkgYWRkZWQgZm9yIGEg
cmVmZXJlbmNlIHRlc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTEwMTQ3MQogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1w
UmVuZGVyVHJlZVF0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl
UXQuY3BwCmluZGV4IGVhMTE0ZTZlMGUzY2RhZjFjYjQzOWJmNGM2NTRhMGM1NDNhMDRiYWUuLjM0
ZWU1YWQ0YTFlNTIzZTU4YTM3ZjMwMTIwYjkwN2Y3OTliMmE4NjUgMTAwNzU1Ci0tLSBhL1Rvb2xz
L0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCisrKyBiL1Rvb2xzL0R1bXBS
ZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCkBAIC05MzgsNyArOTM4LDcgQEAgdm9p
ZCBEdW1wUmVuZGVyVHJlZTo6ZHVtcCgpCiAgICAgZnB1dHMoIiNFT0ZcbiIsIHN0ZG91dCk7CiAg
ICAgZnB1dHMoIiNFT0ZcbiIsIHN0ZGVycik7CiAKLSAgICBpZiAobV9kdW1wUGl4ZWxzRm9yQ3Vy
cmVudFRlc3QgJiYgIW1fY29udHJvbGxlci0+c2hvdWxkRHVtcEFzVGV4dCgpKSB7CisgICAgaWYg
KG1fZHVtcFBpeGVsc0ZvckN1cnJlbnRUZXN0ICYmIG1fY29udHJvbGxlci0+c2hvdWxkRHVtcFBp
eGVscygpKSB7CiAgICAgICAgIFFJbWFnZSBpbWFnZTsKICAgICAgICAgaWYgKCFtX2NvbnRyb2xs
ZXItPmlzUHJpbnRpbmcoKSkgewogICAgICAgICAgICAgaW1hZ2UgPSBRSW1hZ2UobV9wYWdlLT52
aWV3cG9ydFNpemUoKSwgUUltYWdlOjpGb3JtYXRfQVJHQjMyKTsKZGlmZiAtLWdpdCBhL1Rvb2xz
L0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl
ZS9xdC9UZXN0UnVubmVyUXQuY3BwCmluZGV4IDk4ZmE3MTAwYjNhYWFhOWFkNDkyMDc1MTYyY2Nl
MWU2Y2Q2YjhiNTMuLjYwNjc1MTRmMDU1MDk1ZWI3MjNhNGU4NDExYTIyZGFiNjJlYmQ4ZjEgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAKKysrIGIv
VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcApAQCAtNTMsNiArNTMsNyBA
QCB2b2lkIFRlc3RSdW5uZXI6OnJlc2V0KCkKICAgICBtX2hhc0R1bXBlZCA9IGZhbHNlOwogICAg
IG1fbG9hZEZpbmlzaGVkID0gZmFsc2U7CiAgICAgbV90ZXh0RHVtcCA9IGZhbHNlOworICAgIG1f
c2hvdWxkRHVtcFBpeGVscyA9IHRydWU7CiAgICAgbV9kdW1wQmFja0ZvcndhcmRMaXN0ID0gZmFs
c2U7CiAgICAgbV9kdW1wQ2hpbGRyZW5Bc1RleHQgPSBmYWxzZTsKICAgICBtX2R1bXBDaGlsZEZy
YW1lU2Nyb2xsUG9zaXRpb25zID0gZmFsc2U7CkBAIC0xNDIsNiArMTQzLDEyIEBAIHZvaWQgVGVz
dFJ1bm5lcjo6bWF5YmVEdW1wKGJvb2wgLypzdWNjZXNzKi8pCiAgICAgfQogfQogCit2b2lkIFRl
c3RSdW5uZXI6OmR1bXBBc1RleHQoYm9vbCBzaG91bGREdW1wUGl4ZWxzKQoreworICAgIG1fdGV4
dER1bXAgPSB0cnVlOworICAgIG1fc2hvdWxkRHVtcFBpeGVscyA9IHNob3VsZER1bXBQaXhlbHM7
Cit9CisKIHZvaWQgVGVzdFJ1bm5lcjo6d2FpdFVudGlsRG9uZSgpCiB7CiAgICAgLy9xRGVidWco
KSA8PCAiPj4+PndhaXRGb3JEb25lIjsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl
L3F0L1Rlc3RSdW5uZXJRdC5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0
LmgKaW5kZXggZTU0ZmRlMDllZDIwMzc2ZDQ3N2VlYjExMDM2YTEzOWVhMTU0YjFlMy4uYTFjMWE0
ODFmZTAwNjdhZjI2ZDU3OThhYzMyZTY5MGVmMmQzN2E5ZSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt
cFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv
cXQvVGVzdFJ1bm5lclF0LmgKQEAgLTYzLDYgKzYzLDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBz
aG91bGREaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhKCkgY29uc3QgeyBy
ZXR1cm4gbV9kaXNhbGxvd0luY3JlYXNlRm9yQXBwbGljYXRpb25DYWNoZVF1b3RhOyB9CiAgICAg
Ym9vbCBzaG91bGREdW1wQXNUZXh0KCkgY29uc3QgeyByZXR1cm4gbV90ZXh0RHVtcDsgfQorICAg
IGJvb2wgc2hvdWxkRHVtcFBpeGVscygpIGNvbnN0IHsgcmV0dXJuIG1fc2hvdWxkRHVtcFBpeGVs
czsgfQogICAgIGJvb2wgc2hvdWxkRHVtcEJhY2tGb3J3YXJkTGlzdCgpIGNvbnN0IHsgcmV0dXJu
IG1fZHVtcEJhY2tGb3J3YXJkTGlzdDsgfQogICAgIGJvb2wgc2hvdWxkRHVtcENoaWxkcmVuQXNU
ZXh0KCkgY29uc3QgeyByZXR1cm4gbV9kdW1wQ2hpbGRyZW5Bc1RleHQ7IH0KICAgICBib29sIHNo
b3VsZER1bXBDaGlsZEZyYW1lU2Nyb2xsUG9zaXRpb25zKCkgY29uc3QgeyByZXR1cm4gbV9kdW1w
Q2hpbGRGcmFtZVNjcm9sbFBvc2l0aW9uczsgfQpAQCAtOTgsNyArOTksNyBAQCBRX1NJR05BTFM6
CiBwdWJsaWMgUV9TTE9UUzoKICAgICB2b2lkIG1heWJlRHVtcChib29sIG9rKTsKICAgICB2b2lk
IGRpc2FsbG93SW5jcmVhc2VGb3JBcHBsaWNhdGlvbkNhY2hlUXVvdGEoKSB7IG1fZGlzYWxsb3dJ
bmNyZWFzZUZvckFwcGxpY2F0aW9uQ2FjaGVRdW90YSA9IHRydWU7IH0KLSAgICB2b2lkIGR1bXBB
c1RleHQoKSB7IG1fdGV4dER1bXAgPSB0cnVlOyB9CisgICAgdm9pZCBkdW1wQXNUZXh0KGJvb2wg
c2hvdWxkRHVtcFBpeGVscyA9IGZhbHNlKTsKICAgICB2b2lkIGR1bXBDaGlsZEZyYW1lc0FzVGV4
dCgpIHsgbV9kdW1wQ2hpbGRyZW5Bc1RleHQgPSB0cnVlOyB9CiAgICAgdm9pZCBkdW1wQ2hpbGRG
cmFtZVNjcm9sbFBvc2l0aW9ucygpIHsgbV9kdW1wQ2hpbGRGcmFtZVNjcm9sbFBvc2l0aW9ucyA9
IHRydWU7IH0KICAgICB2b2lkIGR1bXBEYXRhYmFzZUNhbGxiYWNrcygpIHsgbV9kdW1wRGF0YWJh
c2VDYWxsYmFja3MgPSB0cnVlOyB9CkBAIC0yODQsNiArMjg1LDcgQEAgcHJpdmF0ZToKIHByaXZh
dGU6CiAgICAgYm9vbCBtX2hhc0R1bXBlZDsKICAgICBib29sIG1fdGV4dER1bXA7CisgICAgYm9v
bCBtX3Nob3VsZER1bXBQaXhlbHM7CiAgICAgYm9vbCBtX2Rpc2FsbG93SW5jcmVhc2VGb3JBcHBs
aWNhdGlvbkNhY2hlUXVvdGE7CiAgICAgYm9vbCBtX2R1bXBCYWNrRm9yd2FyZExpc3Q7CiAgICAg
Ym9vbCBtX2R1bXBDaGlsZHJlbkFzVGV4dDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>