101482 2012-11-07 09:35:10 -0800 [EFL] Define WTF_PLATFORM_EFL in Platform.h 2012-11-23 07:37:24 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned benjamin gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 760775 0 laszlo.gombos 2012-11-07 09:35:10 -0800 to be consistent with other ports. 760783 1 172823 laszlo.gombos 2012-11-07 09:40:14 -0800 Created attachment 172823 1st try 760836 2 172823 rakuco 2012-11-07 10:28:01 -0800 Comment on attachment 172823 1st try Was anything broken with the current behavior? The FIXME before the sections you change in Platform.h suggests that this isn't really a nice place to add more definitions (and, for consistency, this should also be changed in OptionsWindows.cmake). 760906 3 laszlo.gombos 2012-11-07 11:21:36 -0800 (In reply to comment #2) > (From update of attachment 172823 [details]) > Was anything broken with the current behavior? Nothing is broken with the current solution. As the ChangeLog mentions this change is primary to align the EFL port with other ports. Improve readability/hackability for people not working on the EFL port on a daily basis if you wish. > The FIXME before the sections you change in Platform.h suggests that this isn't really a nice place to add more definitions My reading of the FIXME is different. To me it means that we should minimize the usage of PLATFORM(XX) and use instead USE(XX), OS(XX) and other macros. I think it is easier to act on the FIXME if these definitions are all in common C/C++ code and not in port/build system specific files. > (and, for consistency, this should also be changed in OptionsWindows.cmake). I agree, thanks for pointing this out. It is probably better to do it in another patch as it impacts another port and not EFL. 774554 4 172823 webkit.review.bot 2012-11-23 07:37:19 -0800 Comment on attachment 172823 1st try Clearing flags on attachment: 172823 Committed r135612: <http://trac.webkit.org/changeset/135612> 774555 5 webkit.review.bot 2012-11-23 07:37:24 -0800 All reviewed patches have been landed. Closing bug. 172823 2012-11-07 09:40:14 -0800 2012-11-23 07:37:19 -0800 1st try 101482.patch text/plain 2468 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzc2 OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEx LTA3ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gRGVmaW5lIFdURl9QTEFURk9STV9FRkwgaW4gUGxhdGZvcm0uaAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDgyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBkZWZpbml0aW9uIG9m IFdURl9QTEFURk9STV9FRkwgZnJvbSB0aGUgYnVpbGQgc3lzdGVtIHRvCisgICAgICAgIG1ha2Ug dGhlIEVGTCBwb3J0IGNvbnNpc3RlbnQgd2l0aCBvdGhlciBwb3J0cy4KKyAKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0xMS0wNyAgU2hpbnlhIEthd2Fu YWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1NoYWRvd10gVXNlIHNldFBz ZXVkbygpIGluc3RlYWQgb2Ygc2V0U2hhZG93UHNldWRvSWQoKS4KSW5kZXg6IFNvdXJjZS9XVEYv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAx MzM3NjgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE1IEBACisyMDEyLTExLTA3ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF0gRGVmaW5lIFdURl9QTEFURk9STV9FRkwgaW4gUGxhdGZvcm0uaAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDgyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVmaW5lIFdU Rl9QTEFURk9STV9FRkwgaW4gUGxhdGZvcm0uaCB0byBiZSBjb25zaXN0ZW50IHdpdGggCisgICAg ICAgIG90aGVyIHBvcnRzLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTItMTEt MDcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAg ICAgICBBZGQgcmVwbGFjZVdpdGhMaXRlcmFsKCkgbWV0aG9kIHRvIFdURjo6U3RyaW5nCkluZGV4 OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgJKHJldmlzaW9uIDEzMzc1OSkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgJKHdvcmtpbmcgY29weSkKQEAgLTQzMiw2ICs0MzIsNyBAQAogLyogUExBVEZPUk0oQ0hST01J VU0pICovCiAvKiBQTEFURk9STShRVCkgKi8KIC8qIFBMQVRGT1JNKFdYKSAqLworLyogUExBVEZP Uk0oRUZMKSAqLwogLyogUExBVEZPUk0oR1RLKSAqLwogLyogUExBVEZPUk0oQkxBQ0tCRVJSWSkg Ki8KIC8qIFBMQVRGT1JNKE1BQykgKi8KQEAgLTQ0Miw2ICs0NDMsOCBAQAogI2RlZmluZSBXVEZf UExBVEZPUk1fUVQgMQogI2VsaWYgZGVmaW5lZChCVUlMRElOR19XWF9fKQogI2RlZmluZSBXVEZf UExBVEZPUk1fV1ggMQorI2VsaWYgZGVmaW5lZChCVUlMRElOR19FRkxfXykKKyNkZWZpbmUgV1RG X1BMQVRGT1JNX0VGTCAxCiAjZWxpZiBkZWZpbmVkKEJVSUxESU5HX0dUS19fKQogI2RlZmluZSBX VEZfUExBVEZPUk1fR1RLIDEKICNlbGlmIGRlZmluZWQoQlVJTERJTkdfQkxBQ0tCRVJSWV9fKQpJ bmRleDogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L2NtYWtlL09wdGlvbnNFZmwuY21ha2UJKHJldmlzaW9uIDEzMzc1OSkKKysrIFNvdXJjZS9jbWFr ZS9PcHRpb25zRWZsLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC00LDggKzQsNiBAQCBTRVQoUFJP SkVDVF9WRVJTSU9OX1BBVENIIDApCiBTRVQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJT SU9OX01BSk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fUEFU Q0h9KQogCiBBRERfREVGSU5JVElPTlMoLURCVUlMRElOR19FRkxfXz0xKQotQUREX0RFRklOSVRJ T05TKC1EV1RGX1BMQVRGT1JNX0VGTD0xKQotU0VUKFdURl9QTEFURk9STV9FRkwgMSkKIAogRklO RF9QQUNLQUdFKENhaXJvIDEuMTAuMiBSRVFVSVJFRCkKIEZJTkRfUEFDS0FHRShGb250Y29uZmln IDIuOC4wIFJFUVVJUkVEKQo=