101480 2012-11-07 08:39:45 -0800 [EFL][WK2][AC] API tests crash 2012-11-07 12:45:11 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned lucas.de.marchi ostap73 webkit.review.bot oldest_to_newest 760739 0 yael 2012-11-07 08:39:45 -0800 When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests. A patch is coming. 760742 1 172817 yael 2012-11-07 08:42:32 -0800 Created attachment 172817 Patch 760877 2 172817 ostap73 2012-11-07 10:51:54 -0800 Comment on attachment 172817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > - ecoreEvas = ecore_evas_buffer_new(800, 600); It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here? 760931 3 yael 2012-11-07 11:38:22 -0800 (In reply to comment #2) > (From update of attachment 172817 [details]) Thank you for your comment :) > View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > > > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > > - ecoreEvas = ecore_evas_buffer_new(800, 600); > > It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here? ecore_evas_buffer_new is not used anywhere else, so I thought it will be ok to change it so that it is the same as everywhere else. I am building webkit with AC turned off, and will report the results of running the tests once I have that. 760974 4 172817 webkit.review.bot 2012-11-07 12:41:53 -0800 Comment on attachment 172817 Patch Clearing flags on attachment: 172817 Committed r133795: <http://trac.webkit.org/changeset/133795> 760975 5 webkit.review.bot 2012-11-07 12:41:57 -0800 All reviewed patches have been landed. Closing bug. 760979 6 yael 2012-11-07 12:45:11 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 172817 [details] [details]) > Thank you for your comment :) > > View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > > > > > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > > > - ecoreEvas = ecore_evas_buffer_new(800, 600); > > > > It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here? > > ecore_evas_buffer_new is not used anywhere else, so I thought it will be ok to change it so that it is the same as everywhere else. I am building webkit with AC turned off, and will report the results of running the tests once I have that. Sorry for the delay. It took 1 hour 36 minutes to compile :( All 50 tests are passing with my change and AC turned off, so I don't see an issue with the change. thanks. 172817 2012-11-07 08:42:32 -0800 2012-11-07 12:41:53 -0800 Patch 101480.patch text/plain 1436 yael SW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvZWZsL1BsYXRmb3JtV2ViVmlldy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3LmNwcAkocmV2 aXNpb24gMTMzNzUwKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsMTMgKzQxLDEyIEBACiB7CiAgICAgQVNTRVJUKGVj b3JlX2V2YXNfaW5pdCgpKTsKIAotICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhczsKKyAgICBjb25z dCBjaGFyKiBlbmdpbmUgPSAwOworI2lmIGRlZmluZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01Q T1NJVElORykgJiYgZGVmaW5lZChIQVZFX0VDT1JFX1gpCisgICAgZW5naW5lID0gIm9wZW5nbF94 MTEiOworI2VuZGlmCisgICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19uZXco ZW5naW5lLCAwLCAwLCA4MDAsIDYwMCwgMCk7CiAKLSAgICBpZiAodXNlWDExV2luZG93KQotICAg ICAgICBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldygwLCAwLCAwLCA4MDAsIDYwMCwgMCk7Ci0g ICAgZWxzZQotICAgICAgICBlY29yZUV2YXMgPSBlY29yZV9ldmFzX2J1ZmZlcl9uZXcoODAwLCA2 MDApOwotCiAgICAgQVNTRVJUKGVjb3JlRXZhcyk7CiAKICAgICBlY29yZV9ldmFzX3Nob3coZWNv cmVFdmFzKTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFu Z2VMb2cJKHJldmlzaW9uIDEzMzc2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTA3ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9u QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdW0FDXSBBUEkgdGVzdHMgY3Jhc2gKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTQ4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gQUMgaXMg ZW5hYmxlZCwgOCBBUEkgdGVzdHMgYXJlIGNyYXNoaW5nLiBXZSBuZWVkIHRvIHByb3Blcmx5IHNl dCB0aGUgZXZhcyBlbmdpbmUgZm9yIHRoZXNlIHRlc3RzLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9lZmwvUGxhdGZvcm1XZWJWaWV3LmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6Omlu aXRFY29yZUV2YXMpOgorCiAyMDEyLTExLTA3ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxh bi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0gT3BlbiBsaW5rIGluIHRoaXMgd2lu ZG93IGFjdGlvbgo=