101475 2012-11-07 07:54:46 -0800 [AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface 2012-11-07 12:33:31 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis kenneth webkit.review.bot oldest_to_newest 760700 0 naginenis 2012-11-07 07:54:46 -0800 Noticed the following two memory leaks in GraphicsSurface. 1) http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp#L175 > m_fbConfigs = glXChooseFBConfig(m_display, DefaultScreen(m_display), attributes, &numReturned); GLX frame buffer configurations returned by glXChooseFBConfig leaking. 2) http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp#L196 > XVisualInfo* visualInfo = glXGetVisualFromFBConfig(m_display, m_fbConfigs[0]); Data returned by glXGetVisualFromFBConfig also leaking here. We must free these values by using XFree() to avoid memory leaks. 760716 1 172806 naginenis 2012-11-07 08:12:09 -0800 Created attachment 172806 Patch 760969 2 172806 webkit.review.bot 2012-11-07 12:33:28 -0800 Comment on attachment 172806 Patch Clearing flags on attachment: 172806 Committed r133791: <http://trac.webkit.org/changeset/133791> 760970 3 webkit.review.bot 2012-11-07 12:33:31 -0800 All reviewed patches have been landed. Closing bug. 172806 2012-11-07 08:12:09 -0800 2012-11-07 12:33:28 -0800 Patch 101475.patch text/plain 1905 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMjYzN2RkLi5jZjY3ZGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTEtMDcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0FDXSBnbFhDaG9vc2VGQkNvbmZpZygpIGFuZCBnbFhHZXRW aXN1YWxGcm9tRkJDb25maWcoKSByZXR1cm4gdmFsdWVzIGFyZSBsZWFraW5nIGluIEdyYXBoaWNz U3VyZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAxNDc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RnJlZSB0aGUgbWVtb3J5IHJldHVybmVkIGJ5IGdsWENob29zZUZCQ29uZmlnIGFuZCBnbFhHZXRW aXN1YWxGcm9tRkJDb25maWcKKyAgICAgICAgdXNpbmcgWEZyZWUgdG8gYXZvaWQgbWVtb3J5IGxl YWtzLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NTdXJmYWNlUHJpdmF0ZTo6fkdyYXBoaWNzU3Vy ZmFjZVByaXZhdGUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NTdXJmYWNlUHJpdmF0ZTo6 Y3JlYXRlU3VyZmFjZSk6CisKIDIwMTItMTEtMDYgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdl YmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IG1vbnRoIHBpY2tpbmcgdG8gY2FsZW5kYXIg cGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJm YWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcAppbmRleCA2NDA3N2Jh Li4yOGFlOTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z dXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL3F0L0dyYXBoaWNzU3VyZmFjZUdMWC5jcHAKQEAgLTE4 Nyw2ICsxODcsOSBAQCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAgICAg ICBYRnJlZVBpeG1hcChtX2Rpc3BsYXksIG1feFBpeG1hcCk7CiAgICAgICAgIG1feFBpeG1hcCA9 IDA7CiAKKyAgICAgICAgaWYgKG1fZmJDb25maWdzKQorICAgICAgICAgICAgWEZyZWUobV9mYkNv bmZpZ3MpOworCiAgICAgICAgIGlmIChtX2dsQ29udGV4dCkKICAgICAgICAgICAgIGdsWERlc3Ry b3lDb250ZXh0KG1fZGlzcGxheSwgbV9nbENvbnRleHQpOwogICAgIH0KQEAgLTIwNyw2ICsyMTAs NyBAQCBzdHJ1Y3QgR3JhcGhpY3NTdXJmYWNlUHJpdmF0ZSB7CiAgICAgICAgICAgICBDV0JhY2tQ aXhlbCB8IENXQm9yZGVyUGl4ZWwgfCBDV0NvbG9ybWFwLCAmYSk7CiAgICAgICAgIFhTZXRXaW5k b3dCYWNrZ3JvdW5kUGl4bWFwKG1fZGlzcGxheSwgbV9zdXJmYWNlLCAwKTsKICAgICAgICAgWENv bXBvc2l0ZVJlZGlyZWN0V2luZG93KG1fZGlzcGxheSwgbV9zdXJmYWNlLCBDb21wb3NpdGVSZWRp cmVjdE1hbnVhbCk7CisgICAgICAgIFhGcmVlKHZpc3VhbEluZm8pOwogCiAgICAgICAgIC8vIE1h a2Ugc3VyZSB0aGUgWFJlbmRlciBFeHRlbnNpb24gaXMgYXZhaWxhYmxlLgogICAgICAgICBpbnQg ZXZlbnRCYXNlcCwgZXJyb3JCYXNlcDsK