101458 2012-11-07 05:46:46 -0800 Fix compile warning [-Wsign-compare] 2012-11-15 21:48:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101761 1 kangil.han ktf.kim andersca ap haraken ktf.kim laszlo.gombos webkit.review.bot oldest_to_newest 760592 0 kangil.han 2012-11-07 05:46:46 -0800 WebKit/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:55:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] 760597 1 172777 kangil.han 2012-11-07 05:50:00 -0800 Created attachment 172777 Patch 760787 2 172777 ap 2012-11-07 09:45:45 -0800 Comment on attachment 172777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172777&action=review This change at least needs a detailed explanation, but is likely incorrect. > Source/WebCore/ChangeLog:8 > + Fix compile warning by using early return when file size is less than or equal to zero. How can file size be less than zero? > Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:54 > - size_t bytesToRead = fileStat.st_size; > - if (bytesToRead != fileStat.st_size) { > + if (fileStat.st_size <= 0) { I'm not exactly sure what this check was meant for. It looks like it's meant to take care of platforms where st_size type is wider than size_t, so such conversion is lossy. Proposed code doesn't handle that. 761185 3 172894 kangil.han 2012-11-07 17:05:15 -0800 Created attachment 172894 Patch 761186 4 kangil.han 2012-11-07 17:05:38 -0800 (In reply to comment #2) > > I'm not exactly sure what this check was meant for. It looks like it's meant to take care of platforms where st_size type is wider than size_t, so such conversion is lossy. Proposed code doesn't handle that. Done. :) 761214 5 172894 ap 2012-11-07 17:35:24 -0800 Comment on attachment 172894 Patch As discussed on IRC, this doesn't seem right either, because casting numeric_limits<size_t>::max() to off_t does not necessarily work (and in fact, it does not work on your platform, where they have the same width, so the result becomes negative). 761251 6 172906 kangil.han 2012-11-07 18:19:45 -0800 Created attachment 172906 Patch 761305 7 172906 rafael.lobo 2012-11-07 20:29:54 -0800 Comment on attachment 172906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172906&action=review > Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:61 > + ptrdiff_t conversionedFileSize = fileStat.st_size; After you check it's not negative, then I think the only way their values could be different is if size_of(size_t) != size_of(off_t), right? Not sure if this would be a better check though, just shouting an idea. 765381 8 172906 ktf.kim 2012-11-13 01:14:25 -0800 Comment on attachment 172906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172906&action=review > Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:62 > + if (conversionedFileSize != fileStat.st_size) { How about include "fileStat.st_size < 0" check in here to avoid duplication? 765430 9 kangil.han 2012-11-13 02:53:28 -0800 Reset assignee and obsolete all my patches for next patch candidate. Good luck! :) 766199 10 174031 ktf.kim 2012-11-13 17:09:07 -0800 Created attachment 174031 Patch 766331 11 174031 ap 2012-11-13 19:40:14 -0800 Comment on attachment 174031 Patch I think that this is the right fix. You can consider adding an assertion that st_size is non-negative. Please fix coding style though - we prefer C++ style casts (static_cast). 766369 12 174063 ktf.kim 2012-11-13 20:54:35 -0800 Created attachment 174063 Patch 766397 13 174063 ap 2012-11-13 21:36:10 -0800 Comment on attachment 174063 Patch I guess a runtime check for <0 is fine as well. 766415 14 kangil.han 2012-11-13 21:56:51 -0800 Nice job, Kyungtae! :-) 766433 15 174063 webkit.review.bot 2012-11-13 22:15:44 -0800 Comment on attachment 174063 Patch Clearing flags on attachment: 174063 Committed r134544: <http://trac.webkit.org/changeset/134544> 766434 16 webkit.review.bot 2012-11-13 22:15:48 -0800 All reviewed patches have been landed. Closing bug. 768890 17 174063 darin 2012-11-15 20:55:47 -0800 Comment on attachment 174063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174063&action=review > Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:55 > + if (fileStat.st_size < 0 || bytesToRead != static_cast<unsigned long long>(fileStat.st_size)) { What’s the point of the size < 0 check, again? Converting a signed integer to unsigned long long will create a giant size that won’t possibly equal bytesToRead, so I see no reason to need that. 768898 18 ktf.kim 2012-11-15 21:13:04 -0800 Darin Adler : I agree with you on that. That's why my 1st patch was not included < 0 check. But the 2nd patch is more clear for human read, I think. If you think 1st patch is better, I'll fix it to that and add a comment that explains the < 0 case. 768922 19 174063 ap 2012-11-15 21:48:44 -0800 Comment on attachment 174063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174063&action=review >> Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:55 >> + if (fileStat.st_size < 0 || bytesToRead != static_cast<unsigned long long>(fileStat.st_size)) { > > What’s the point of the size < 0 check, again? Converting a signed integer to unsigned long long will create a giant size that won’t possibly equal bytesToRead, so I see no reason to need that. Can't they be equal if size_t is the same size as unsigned long long? I guess this combines a sanity check with a loss of precision check. 172777 2012-11-07 05:50:00 -0800 2012-11-07 17:05:08 -0800 Patch bug-101458-20121107224811.patch text/plain 1542 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QzYjYxMDcyMTdhNmMz MzFkNDY3MGJlOWQ2ZDc5OTJhMjBhZmE5Yy4uYzQ5Y2QxMmUzOTAyZWNiYzk0NDRkMDI1NmE4ZGFi ZGM2MmRmMzQwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTA3ICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZSB3 YXJuaW5nIFstV3NpZ24tY29tcGFyZV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBjb21waWxlIHdhcm5pbmcgYnkgdXNpbmcgZWFybHkgcmV0dXJu IHdoZW4gZmlsZSBzaXplIGlzIGxlc3MgdGhhbiBvciBlcXVhbCB0byB6ZXJvLgorCisgICAgICAg ICogcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUpOgorCiAyMDEyLTExLTA3 ICBEYW4gQ2FybmV5ICA8ZGNhcm5leUBnb29nbGUuY29tPgogCiAgICAgICAgIFtWOF0gQ2xlYW51 cCBWOERPTVdyYXBwZXI6OmdldENhY2hlZFdyYXBwZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcAppbmRleCBlYmQ3MWJmZDZiNzRk YTMyOGZkZWIxZWEzZDg3NTRlNzJiZGQxMDA4Li44Y2ZkMTU5ZTc3Njk4NjhlYWU1ZmVkNzVmMTAw MzVhMDY2NzE5YTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9T aGFyZWRCdWZmZXJQT1NJWC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgv U2hhcmVkQnVmZmVyUE9TSVguY3BwCkBAIC01MSwxMiArNTEsMTIgQEAgUGFzc1JlZlB0cjxTaGFy ZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0 cmluZyYgZmkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCi0gICAgc2l6ZV90IGJ5dGVzVG9S ZWFkID0gZmlsZVN0YXQuc3Rfc2l6ZTsKLSAgICBpZiAoYnl0ZXNUb1JlYWQgIT0gZmlsZVN0YXQu c3Rfc2l6ZSkgeworICAgIGlmIChmaWxlU3RhdC5zdF9zaXplIDw9IDApIHsKICAgICAgICAgY2xv c2UoZmQpOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKKyAgICBzaXplX3QgYnl0ZXNUb1Jl YWQgPSBzdGF0aWNfY2FzdDxzaXplX3Q+KGZpbGVTdGF0LnN0X3NpemUpOwogICAgIFZlY3Rvcjxj aGFyPiBidWZmZXIoYnl0ZXNUb1JlYWQpOwogCiAgICAgc2l6ZV90IHRvdGFsQnl0ZXNSZWFkID0g MDsK 172894 2012-11-07 17:05:15 -0800 2012-11-07 18:19:40 -0800 Patch bug-101458-20121108100325.patch text/plain 2113 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QzYjYxMDcyMTdhNmMz MzFkNDY3MGJlOWQ2ZDc5OTJhMjBhZmE5Yy4uZjMwY2Y1ZGU3MzNhY2JhNTYxODcwNTBhZWZmNmE3 OTI2NWZhOTQ5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA3ICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZSB3 YXJuaW5nIFstV3NpZ24tY29tcGFyZV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgbG9zc3kgY2hlY2sgaGFzIGJlZW4gZG9uZSBhcyBj b21wYXJpbmcgb3JpZ2luYWwgZmlsZSBzaXplIHdpdGggY29udmVyc2lvbmVkLCBvZmZfdCB0byBz aXplX3QsIHZhbHVlLgorICAgICAgICBIb3dldmVyLCBpdCBsZWFkcyAtV3NpZ24tY29tcGFyZSBj b21waWxlIGVycm9yLgorICAgICAgICBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggY2hhbmdlcyBjb252 ZXJzaW9uIGxvc3N5IGNoZWNrIGJ5IGNvbXBhcmluZyBtYXggbnVtYmVyIG9mIHNpemVfdCB3aXRo IGZpbGUgc2l6ZS4KKworICAgICAgICAqIHBsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lY LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRz T2ZGaWxlKToKKwogMjAxMi0xMS0wNyAgRGFuIENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4K IAogICAgICAgICBbVjhdIENsZWFudXAgVjhET01XcmFwcGVyOjpnZXRDYWNoZWRXcmFwcGVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJ WC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5j cHAKaW5kZXggZWJkNzFiZmQ2Yjc0ZGEzMjhmZGViMWVhM2Q4NzU0ZTcyYmRkMTAwOC4uYzZiYjlk OGUxYzAyNzE1NjdkODUxYTZhZDZlNDUwNDk1NmU1ZmYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcApAQCAtMjksMTIgKzI5 LDE1IEBACiAjaW5jbHVkZSAiRmlsZVN5c3RlbS5oIgogCiAjaW5jbHVkZSA8ZmNudGwuaD4KKyNp bmNsdWRlIDxsaW1pdHM+CiAjaW5jbHVkZSA8c3lzL3N0YXQuaD4KICNpbmNsdWRlIDx1bmlzdGQu aD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAordXNpbmcgbmFtZXNwYWNlIHN0ZDsKKwogUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IFNoYXJl ZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0cmluZyYgZmlsZVBhdGgp CiB7CiAgICAgaWYgKGZpbGVQYXRoLmlzRW1wdHkoKSkKQEAgLTUxLDEyICs1NCwxMiBAQCBQYXNz UmVmUHRyPFNoYXJlZEJ1ZmZlcj4gU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZp bGUoY29uc3QgU3RyaW5nJiBmaQogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICBzaXpl X3QgYnl0ZXNUb1JlYWQgPSBmaWxlU3RhdC5zdF9zaXplOwotICAgIGlmIChieXRlc1RvUmVhZCAh PSBmaWxlU3RhdC5zdF9zaXplKSB7CisgICAgaWYgKGZpbGVTdGF0LnN0X3NpemUgPiBzdGF0aWNf Y2FzdDxvZmZfdD4obnVtZXJpY19saW1pdHM8c2l6ZV90Pjo6bWF4KCkpKSB7CiAgICAgICAgIGNs b3NlKGZkKTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCisgICAgc2l6ZV90IGJ5dGVzVG9S ZWFkID0gc3RhdGljX2Nhc3Q8c2l6ZV90PihmaWxlU3RhdC5zdF9zaXplKTsKICAgICBWZWN0b3I8 Y2hhcj4gYnVmZmVyKGJ5dGVzVG9SZWFkKTsKIAogICAgIHNpemVfdCB0b3RhbEJ5dGVzUmVhZCA9 IDA7Cg== 172906 2012-11-07 18:19:45 -0800 2012-11-13 02:52:19 -0800 Patch bug-101458-20121108111755.patch text/plain 2080 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2QzYjYxMDcyMTdhNmMz MzFkNDY3MGJlOWQ2ZDc5OTJhMjBhZmE5Yy4uNzM4Y2QxOWU3Y2Y2ZWVjMGE3ZGI2ODBiMDZiOWNh NjNjZDBkZWFiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA3ICBLYW5n aWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggY29tcGlsZSB3 YXJuaW5nIFstV3NpZ24tY29tcGFyZV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgbG9zc3kgY2hlY2sgaGFzIGJlZW4gZG9uZSBieSBj b21wYXJpbmcgZmlsZSBzaXplKHBvc2l4IHNpZ25lZCBpbnRlZ3JhbCB2YWx1ZSkgd2l0aCBjb252 ZXJzaW9uZWQoc3RhbmRhcmQgYysrIHVuc2lnbmVkIGludGVncmFsIHZhbHVlKS4KKyAgICAgICAg SG93ZXZlciwgaXQgbGVhZHMgLVdzaWduLWNvbXBhcmUgY29tcGlsZSB3YXJuaW5nLgorICAgICAg ICBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggY2hhbmdlcyBjb252ZXJzaW9uIGxvc3N5IGNoZWNrIHVz ZXMgcHRyZGlmZl90IHRvIGF2b2lkIGNvbXBpbGUgd2FybmluZy4KKworICAgICAgICAqIHBsYXRm b3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJl ZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKToKKwogMjAxMi0xMS0wNyAgRGFuIENh cm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbVjhdIENsZWFudXAgVjhET01X cmFwcGVyOjpnZXRDYWNoZWRXcmFwcGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5jcHAKaW5kZXggZWJkNzFiZmQ2Yjc0ZGEzMjhmZGVi MWVhM2Q4NzU0ZTcyYmRkMTAwOC4uNWIxMDQ3OGNhYzkwN2UxOWRlNjllNjRjMzBjYzcxZDE0ODgy YTRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVm ZmVyUE9TSVguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1 ZmZlclBPU0lYLmNwcApAQCAtNTEsMTIgKzUxLDIwIEBAIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVy PiBTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZShjb25zdCBTdHJpbmcmIGZp CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIHNpemVfdCBieXRlc1RvUmVhZCA9IGZp bGVTdGF0LnN0X3NpemU7Ci0gICAgaWYgKGJ5dGVzVG9SZWFkICE9IGZpbGVTdGF0LnN0X3NpemUp IHsKKyAgICAvLyBGaWxlIHNpemUgaXMgdG9vIGJpZyB0byBiZSBoYW5kbGVkIGluIGN1cnJlbnQg b3BlcmF0aW5nIHN5c3RlbS4KKyAgICBpZiAoZmlsZVN0YXQuc3Rfc2l6ZSA8IDApIHsKICAgICAg ICAgY2xvc2UoZmQpOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKKyAgICAvLyBMb3NzeSBj aGVjayBpbmR1Y2VkIGJ5IGNvbnZlcnNpb24gZnJvbSBwb3NpeCBvZmZfdCB0byBzdGFuZGFyZCBj KysgcHRyZGlmZl90LgorICAgIHB0cmRpZmZfdCBjb252ZXJzaW9uZWRGaWxlU2l6ZSA9IGZpbGVT dGF0LnN0X3NpemU7CisgICAgaWYgKGNvbnZlcnNpb25lZEZpbGVTaXplICE9IGZpbGVTdGF0LnN0 X3NpemUpIHsKKyAgICAgICAgY2xvc2UoZmQpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisK KyAgICBzaXplX3QgYnl0ZXNUb1JlYWQgPSBzdGF0aWNfY2FzdDxzaXplX3Q+KGNvbnZlcnNpb25l ZEZpbGVTaXplKTsKICAgICBWZWN0b3I8Y2hhcj4gYnVmZmVyKGJ5dGVzVG9SZWFkKTsKIAogICAg IHNpemVfdCB0b3RhbEJ5dGVzUmVhZCA9IDA7Cg== 174031 2012-11-13 17:09:07 -0800 2012-11-13 20:54:29 -0800 Patch bug-101458-20121114100707.patch text/plain 1682 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRiNTYwMWQ0MzRlYTYz NWEzZjI4YTVjN2QyZjZjYmYyYjVjYTMyOS4uZmY3M2NmNTUyZjVlNTU3YWU0NGU1NzZlNmI0Njll ZGE0YjY0ZDdiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTEzICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBjb21waWxlIHdh cm5pbmcgWy1Xc2lnbi1jb21wYXJlXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAxNDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBsb3NzeSBjaGVjayBoYXMgYmVlbiBkb25lIGJ5IGNv bXBhcmluZyBmaWxlIHNpemUocG9zaXggc2lnbmVkIGludGVncmFsIHZhbHVlKSB3aXRoIGNvbnZl cnNpb25lZChzdGFuZGFyZCBjKysgdW5zaWduZWQgaW50ZWdyYWwgdmFsdWUpLgorICAgICAgICBI b3dldmVyLCBpdCBsZWFkcyAtV3NpZ24tY29tcGFyZSBjb21waWxlIHdhcm5pbmcuCisgICAgICAg IFRoZXJlZm9yZSwgdGhpcyBwYXRjaCBhc3NpZ25zIHRoZSBmaWxlIHNpemUgdG8gdGhlIGJpZ2dl c3QgcG9zc2libGUgdW5zaWduZWQgdmFyaWFibGUsIHRoZW4gZG9lcyB0aGUgbG9zc3kgY2hlY2su CisKKyAgICAgICAgKiBwbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZSk6CisK IDIwMTItMTEtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBb VjhdIGluc3RhbnRpYXRlVjhPYmplY3Qgc2hvdWxkIGVuY2FwdWxhdGUgdGhlIHRyaWNreSBjcmVh dGlvbkNvbnRleHQgbG9naWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bv c2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Bvc2l4 L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcAppbmRleCBlYmQ3MWJmZDZiNzRkYTMyOGZkZWIxZWEzZDg3 NTRlNzJiZGQxMDA4Li44ZmE5NDFkOGNlNmFjNTg0ZGYxNGIzNTM1ZjhiNGE5NGE1MjQyMzNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJ WC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9T SVguY3BwCkBAIC01Miw3ICs1Miw3IEBAIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBTaGFyZWRC dWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZShjb25zdCBTdHJpbmcmIGZpCiAgICAgfQog CiAgICAgc2l6ZV90IGJ5dGVzVG9SZWFkID0gZmlsZVN0YXQuc3Rfc2l6ZTsKLSAgICBpZiAoYnl0 ZXNUb1JlYWQgIT0gZmlsZVN0YXQuc3Rfc2l6ZSkgeworICAgIGlmIChieXRlc1RvUmVhZCAhPSAo dW5zaWduZWQgbG9uZyBsb25nKSBmaWxlU3RhdC5zdF9zaXplKSB7CiAgICAgICAgIGNsb3NlKGZk KTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQo= 174063 2012-11-13 20:54:35 -0800 2012-11-15 21:48:44 -0800 Patch bug-101458-20121114135235.patch text/plain 1693 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhhYzc2ODM2OWFiNDQ1 YTc4NjA2NDgyMGU4OTkwMDE1YTIxN2I2NC4uZGNlMjE2MTM0ZTQzZmIxZThjODEwY2Y0ZWJlZmQy MDAyMGJjNmVhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTEzICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBjb21waWxlIHdh cm5pbmcgWy1Xc2lnbi1jb21wYXJlXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAxNDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBsb3NzeSBjaGVjayBoYXMgYmVlbiBkb25lIGJ5IGNv bXBhcmluZyBmaWxlIHNpemUocG9zaXggc2lnbmVkIGludGVncmFsIHZhbHVlKSB3aXRoIGNvbnZl cnNpb25lZChzdGFuZGFyZCBjKysgdW5zaWduZWQgaW50ZWdyYWwgdmFsdWUpLgorICAgICAgICBI b3dldmVyLCBpdCBsZWFkcyAtV3NpZ24tY29tcGFyZSBjb21waWxlIHdhcm5pbmcuCisgICAgICAg IFRoZXJlZm9yZSwgdGhpcyBwYXRjaCBhc3NpZ25zIHRoZSBmaWxlIHNpemUgdG8gdGhlIGJpZ2dl c3QgcG9zc2libGUgdW5zaWduZWQgdmFyaWFibGUsIHRoZW4gZG9lcyB0aGUgbG9zc3kgY2hlY2su CisKKyAgICAgICAgKiBwbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZSk6CisK IDIwMTItMTEtMTMgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVcGRhdGUgRE9NRXhjZXB0aW9uIG5hbWU6IEludmFsaWRDaGFyYWN0ZXJFcnJvcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwCmlu ZGV4IGViZDcxYmZkNmI3NGRhMzI4ZmRlYjFlYTNkODc1NGU3MmJkZDEwMDguLjk1ZGJhNjFjZTAy NmQ4ZWU3MWQwYWYwMjc3NGRhMjIzNzEwMzNlMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3Bvc2l4L1NoYXJlZEJ1ZmZlclBPU0lYLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9wb3NpeC9TaGFyZWRCdWZmZXJQT1NJWC5jcHAKQEAgLTUyLDcgKzUyLDcgQEAg UGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRz T2ZGaWxlKGNvbnN0IFN0cmluZyYgZmkKICAgICB9CiAKICAgICBzaXplX3QgYnl0ZXNUb1JlYWQg PSBmaWxlU3RhdC5zdF9zaXplOwotICAgIGlmIChieXRlc1RvUmVhZCAhPSBmaWxlU3RhdC5zdF9z aXplKSB7CisgICAgaWYgKGZpbGVTdGF0LnN0X3NpemUgPCAwIHx8IGJ5dGVzVG9SZWFkICE9IHN0 YXRpY19jYXN0PHVuc2lnbmVkIGxvbmcgbG9uZz4oZmlsZVN0YXQuc3Rfc2l6ZSkpIHsKICAgICAg ICAgY2xvc2UoZmQpOwogICAgICAgICByZXR1cm4gMDsKICAgICB9Cg==