101446 2012-11-07 04:09:27 -0800 [WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin() 2013-01-30 13:04:57 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108371 1 cdumez cdumez cgarcia hausmann kbalazs kenneth mariusz.g mikhail.pozdnyakov webkit.review.bot oldest_to_newest 760516 0 cdumez 2012-11-07 04:09:27 -0800 I often get the following warning and crash in WebKit::PluginProcessProxy::scanPlugin() on my machine: (process:12859): GLib-WARNING **: In call to g_spawn_sync(), exit status of a child process was requested but SIGCHLD action was set to SIG_IGN and ECHILD was received by waitpid(), so exit status can't be returned. This is a bug in the program calling g_spawn_sync(); either don't request the exit status, or don't set the SIGCHLD action. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffa334b700 (LWP 12880)] 0x00007ffff7a178d3 in WebKit::PluginProcessProxy::scanPlugin (pluginPath=..., result=...) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:91 91 while (*current++ != UChar('\n')) { } (gdb) bt 25 #0 0x00007ffff7a178d3 in WebKit::PluginProcessProxy::scanPlugin (pluginPath=..., result=...) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:91 #1 0x00007ffff79d0f3c in WebKit::NetscapePluginModule::getPluginInfo (pluginPath=..., plugin=...) at /home/chris/Devel/WebKit/Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:131 #2 0x00007ffff7a1626f in WebKit::PluginInfoStore::getPluginInfo (pluginPath=..., plugin=...) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:101 #3 0x00007ffff78d158b in WebKit::PluginInfoStore::loadPlugin (plugins=..., pluginPath=...) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:118 #4 0x00007ffff78d14c0 in WebKit::PluginInfoStore::loadPluginsIfNecessary (this=0x4dc370) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:107 #5 0x00007ffff78d1601 in WebKit::PluginInfoStore::plugins (this=0x4dc370) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:130 #6 0x00007ffff78ab857 in WebKit::WebProcessProxy::handleGetPlugins (this=0x4f6fb0, requestID=1, refresh=false) at /home/chris/Devel/WebKit/Source/WebKit2/UIProcess/WebProcessProxy.cpp:347 #7 0x00007ffff78b7e29 in WTF::FunctionWrapper<void (WebKit::WebProcessProxy::*)(unsigned long, bool)>::operator() (this=0x7fff94000d80, c=0x4f6fb0, p1=1, p2=false) at /home/chris/Devel/WebKit/Source/WTF/wtf/Functional.h:214 #8 0x00007ffff78b7c62 in WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (WebKit::WebProcessProxy::*)(unsigned long, bool)>, void (WebKit::WebProcessProxy*, unsigned long, bool)>::operator()() ( this=0x7fff94000d70) at /home/chris/Devel/WebKit/Source/WTF/wtf/Functional.h:460 #9 0x00000000004662e4 in WTF::Function<void ()>::operator()() const (this=0x7fff940011f0) at /home/chris/Devel/WebKit/Source/WTF/wtf/Functional.h:614 #10 0x00007ffff79c75d1 in WorkQueue::performWork (this=0x7fff94000db0) at /home/chris/Devel/WebKit/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:83 #11 0x00007ffff79c7c4e in WorkQueue::workQueueThread (workQueue=0x7fff94000db0) at /home/chris/Devel/WebKit/Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:178 #12 0x00007ffff398f95d in WTF::threadEntryPoint (contextData=0x7fff94000c10) at /home/chris/Devel/WebKit/Source/WTF/wtf/Threading.cpp:69 #13 0x000000000043799e in WTF::wtfThreadEntryPoint (param=0x7fff94000f40) at /home/chris/Devel/WebKit/Source/WTF/wtf/ThreadingPthreads.cpp:196 #14 0x00007ffff6f59e9a in start_thread (arg=0x7fffa334b700) at pthread_create.c:308 #15 0x00007ffff5d55cbd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112 warning: (Internal error: pc 0x0 in read in psymtab, but not in symtab.) I'll investigate this and hopefully fix it. 760540 1 172761 cdumez 2012-11-07 05:01:03 -0800 Created attachment 172761 Patch 760552 2 172761 mikhail.pozdnyakov 2012-11-07 05:15:00 -0800 Comment on attachment 172761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172761&action=review > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:75 > + // If the dispositon of SIGCLD signal is set to SIG_IGN then would be interesting to know why it was ignored 760556 3 cdumez 2012-11-07 05:19:22 -0800 (In reply to comment #2) > (From update of attachment 172761 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172761&action=review > > > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:75 > > + // If the dispositon of SIGCLD signal is set to SIG_IGN then > > would be interesting to know why it was ignored The default disposition for SIGCLD signal *is* SIG_IGN. I think I should move the disposition setting to the initialization function though to call it only once. 760566 4 172768 cdumez 2012-11-07 05:29:45 -0800 Created attachment 172768 Patch Clarified the comment but kept the signal() instruction where it is since I cannot find a better place for it. 760575 5 172768 hausmann 2012-11-07 05:34:18 -0800 Comment on attachment 172768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172768&action=review > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:80 > + signal(SIGCLD, SIG_DFL); Shouldn't we be using sigaction() instead of signal()? AFAIK the latter is deprecated. 760577 6 cdumez 2012-11-07 05:36:36 -0800 (In reply to comment #5) > (From update of attachment 172768 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172768&action=review > > > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:80 > > + signal(SIGCLD, SIG_DFL); > > Shouldn't we be using sigaction() instead of signal()? AFAIK the latter is deprecated. The signal man page seems to confirm your comment so I'll fix it before landing. Thanks! 760594 7 172775 cdumez 2012-11-07 05:47:34 -0800 Created attachment 172775 Patch Use sigaction() instead of signal() since signal() is deprecated. 760654 8 172775 webkit.review.bot 2012-11-07 06:56:15 -0800 Comment on attachment 172775 Patch Clearing flags on attachment: 172775 Committed r133755: <http://trac.webkit.org/changeset/133755> 760655 9 webkit.review.bot 2012-11-07 06:56:19 -0800 All reviewed patches have been landed. Closing bug. 172761 2012-11-07 05:01:03 -0800 2012-11-07 05:29:45 -0800 Patch 101446_scanPlugins2.patch text/plain 3455 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MjUzY2FhLi4yOGIyZTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzEg QEAKIDIwMTItMTEtMDcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbV0syXVtVTklYXSBDcmFzaCBpbiBXZWJLaXQ6OlBsdWdpblByb2Nl c3NQcm94eTo6c2NhblBsdWdpbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDE0NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgZGlzcG9zaXRpb24gb2YgdGhlIFNJR0NI TEQgc2lnbmFsIGlzIHJlc2V0IHRvIHRoZSBkZWZhdWx0CisgICAgICAgIGJlZm9yZSBjYWxsaW5n IGdfc3Bhd25fc3luYygpLiBJZiB0aGUgZGlzcG9zaXRpb24gaXMgc2V0IHRvIFNJR19JR04sIHRo ZW4KKyAgICAgICAgZ19zcGF3bl9zeW5jKCkgd2lsbCBub3QgYmUgYWJsZSB0byByZXR1cm4gdGhl IGV4aXQgc3RhdHVzIG9mIHRoZSBjaGlsZAorICAgICAgICBwcm9jZXNzLCBvdXIgZXhpdCBmYWls dXJlIGNoZWNrIHdpbGwgYmUgdXNlbGVzcyBhbmQgdGhlIGZvbGxvd2luZyB3YXJuaW5nCisgICAg ICAgIHdpbGwgYmUgcHJpbnRlZDoKKworICAgICAgICBHTGliLVdBUk5JTkcgKio6IEluIGNhbGwg dG8gZ19zcGF3bl9zeW5jKCksIGV4aXQgc3RhdHVzIG9mIGEgY2hpbGQgcHJvY2VzcworICAgICAg ICB3YXMgcmVxdWVzdGVkIGJ1dCBTSUdDSExEIGFjdGlvbiB3YXMgc2V0IHRvIFNJR19JR04gYW5k IEVDSElMRCB3YXMgcmVjZWl2ZWQKKyAgICAgICAgYnkgd2FpdHBpZCgpLCBzbyBleGl0IHN0YXR1 cyBjYW4ndCBiZSByZXR1cm5lZC4gVGhpcyBpcyBhIGJ1ZyBpbiB0aGUKKyAgICAgICAgcHJvZ3Jh bSBjYWxsaW5nIGdfc3Bhd25fc3luYygpOyBlaXRoZXIgZG9uJ3QgcmVxdWVzdCB0aGUgZXhpdCBz dGF0dXMsIG9yCisgICAgICAgIGRvbid0IHNldCB0aGUgU0lHQ0hMRCBhY3Rpb24uCisKKyAgICAg ICAgVGhpcyBwYXRjaCBhbHNvIGFkZHMgYSBOVUxMLWNoZWNrIGZvciBzdGRPdXQgdG8gYXZvaWQg Y3Jhc2hpbmcgaW4gc3VjaAorICAgICAgICBjYXNlIGFuZCBtYWtlcyB1c2Ugb2YgU3RyaW5nOjpz cGxpdCgpIHRvIHBhcnNlIHN0ZE91dCBpbnN0ZWFkIG9mIGRvaW5nIGl0CisgICAgICAgIG1hbnVh bGx5LgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJv eHlVbml4LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1 Z2luKToKKworMjAxMi0xMS0wNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCiAgICAgICAgIEFkZCByZXBsYWNlV2l0aExpdGVyYWwoKSBtZXRob2QgdG8g V1RGOjpTdHJpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTI1NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRleCAxODllMjEz Li5kNDcyN2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91 bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKQEAgLTcyLDI4ICs3 MiwzMCBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcm IHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRhJgogICAgIGludCBzdGF0dXM7CiAgICAgY2hh ciogc3RkT3V0ID0gMDsKIAorICAgIC8vIElmIHRoZSBkaXNwb3NpdG9uIG9mIFNJR0NMRCBzaWdu YWwgaXMgc2V0IHRvIFNJR19JR04gdGhlbgorICAgIC8vIHRoZSBzaWduYWwgd2lsbCBiZSBpZ25v cmVkIGFuZCBnX3NwYXduX3N5bmMoKSB3aWxsIG5vdCBiZQorICAgIC8vIGFibGUgdG8gcmV0dXJu IHRoZSBzdGF0dXMuCisgICAgLy8gQXMgYSBjb25zZXF1ZW5jZSwgd2UgbWFrZSBzdXJlIHRoYXQg dGhlIGRpc3Bvc2l0aW9uIG9mIHRoZQorICAgIC8vIFNJR0NMRCBzaWduYWwgaXMgcmVzZXQgdG8g dGhlIGRlZmF1bHQgYmVmb3JlIGNhbGxpbmcKKyAgICAvLyBnX3NwYXduX3N5bmMoKS4KKyAgICBz aWduYWwoU0lHQ0xELCBTSUdfREZMKTsKKwogICAgIGlmICghZ19zcGF3bl9zeW5jKDAsIGFyZ3Ys IDAsIEdfU1BBV05fU1RERVJSX1RPX0RFVl9OVUxMLCAwLCAwLCAmc3RkT3V0LCAwLCAmc3RhdHVz LCAwKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFXSUZFWElURUQoc3RhdHVz KSB8fCBXRVhJVFNUQVRVUyhzdGF0dXMpICE9IEVYSVRfU1VDQ0VTUykgeworICAgIGlmICghV0lG RVhJVEVEKHN0YXR1cykgfHwgV0VYSVRTVEFUVVMoc3RhdHVzKSAhPSBFWElUX1NVQ0NFU1MgfHwg IXN0ZE91dCkgewogICAgICAgICBmcmVlKHN0ZE91dCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICB9CiAKLSAgICBjb25zdCB1bnNpZ25lZCBrTnVtTGluZXNFeHBlY3RlZCA9IDM7Ci0gICAg U3RyaW5nIGxpbmVzW2tOdW1MaW5lc0V4cGVjdGVkXTsKLSAgICB1bnNpZ25lZCBsaW5lSW5kZXgg PSAwOwotCi0gICAgY29uc3QgVUNoYXIqIGN1cnJlbnQgPSByZWludGVycHJldF9jYXN0PGNvbnN0 IFVDaGFyKj4oc3RkT3V0KTsKKyAgICBTdHJpbmcgc3RkT3V0U3RyaW5nKHJlaW50ZXJwcmV0X2Nh c3Q8Y29uc3QgVUNoYXIqPihzdGRPdXQpKTsKKyAgICBmcmVlKHN0ZE91dCk7CiAKLSAgICB3aGls ZSAobGluZUluZGV4IDwga051bUxpbmVzRXhwZWN0ZWQpIHsKLSAgICAgICAgY29uc3QgVUNoYXIq IHN0YXJ0ID0gY3VycmVudDsKLSAgICAgICAgd2hpbGUgKCpjdXJyZW50KysgIT0gVUNoYXIoJ1xu JykpIHsgfQotICAgICAgICBsaW5lc1tsaW5lSW5kZXgrK10gPSBTdHJpbmcoc3RhcnQsIGN1cnJl bnQgLSBzdGFydCAtIDEpOwotICAgIH0KKyAgICBWZWN0b3I8U3RyaW5nPiBsaW5lczsKKyAgICBz dGRPdXRTdHJpbmcuc3BsaXQoVUNoYXIoJ1xuJyksIGxpbmVzKTsKIAotICAgIGlmIChzdGRPdXQp Ci0gICAgICAgIGZyZWUoc3RkT3V0KTsKKyAgICBpZiAobGluZXMuc2l6ZSgpIDwgMykKKyAgICAg ICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmVzdWx0Lm5hbWUuc3dhcChsaW5lc1swXSk7CiAgICAg cmVzdWx0LmRlc2NyaXB0aW9uLnN3YXAobGluZXNbMV0pOwo= 172768 2012-11-07 05:29:45 -0800 2012-11-07 05:47:34 -0800 Patch 101446_scanPlugins2.patch text/plain 3431 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MjUzY2FhLi4yOGIyZTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzEg QEAKIDIwMTItMTEtMDcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbV0syXVtVTklYXSBDcmFzaCBpbiBXZWJLaXQ6OlBsdWdpblByb2Nl c3NQcm94eTo6c2NhblBsdWdpbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDE0NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgZGlzcG9zaXRpb24gb2YgdGhlIFNJR0NI TEQgc2lnbmFsIGlzIHJlc2V0IHRvIHRoZSBkZWZhdWx0CisgICAgICAgIGJlZm9yZSBjYWxsaW5n IGdfc3Bhd25fc3luYygpLiBJZiB0aGUgZGlzcG9zaXRpb24gaXMgc2V0IHRvIFNJR19JR04sIHRo ZW4KKyAgICAgICAgZ19zcGF3bl9zeW5jKCkgd2lsbCBub3QgYmUgYWJsZSB0byByZXR1cm4gdGhl IGV4aXQgc3RhdHVzIG9mIHRoZSBjaGlsZAorICAgICAgICBwcm9jZXNzLCBvdXIgZXhpdCBmYWls dXJlIGNoZWNrIHdpbGwgYmUgdXNlbGVzcyBhbmQgdGhlIGZvbGxvd2luZyB3YXJuaW5nCisgICAg ICAgIHdpbGwgYmUgcHJpbnRlZDoKKworICAgICAgICBHTGliLVdBUk5JTkcgKio6IEluIGNhbGwg dG8gZ19zcGF3bl9zeW5jKCksIGV4aXQgc3RhdHVzIG9mIGEgY2hpbGQgcHJvY2VzcworICAgICAg ICB3YXMgcmVxdWVzdGVkIGJ1dCBTSUdDSExEIGFjdGlvbiB3YXMgc2V0IHRvIFNJR19JR04gYW5k IEVDSElMRCB3YXMgcmVjZWl2ZWQKKyAgICAgICAgYnkgd2FpdHBpZCgpLCBzbyBleGl0IHN0YXR1 cyBjYW4ndCBiZSByZXR1cm5lZC4gVGhpcyBpcyBhIGJ1ZyBpbiB0aGUKKyAgICAgICAgcHJvZ3Jh bSBjYWxsaW5nIGdfc3Bhd25fc3luYygpOyBlaXRoZXIgZG9uJ3QgcmVxdWVzdCB0aGUgZXhpdCBz dGF0dXMsIG9yCisgICAgICAgIGRvbid0IHNldCB0aGUgU0lHQ0hMRCBhY3Rpb24uCisKKyAgICAg ICAgVGhpcyBwYXRjaCBhbHNvIGFkZHMgYSBOVUxMLWNoZWNrIGZvciBzdGRPdXQgdG8gYXZvaWQg Y3Jhc2hpbmcgaW4gc3VjaAorICAgICAgICBjYXNlIGFuZCBtYWtlcyB1c2Ugb2YgU3RyaW5nOjpz cGxpdCgpIHRvIHBhcnNlIHN0ZE91dCBpbnN0ZWFkIG9mIGRvaW5nIGl0CisgICAgICAgIG1hbnVh bGx5LgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJv eHlVbml4LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1 Z2luKToKKworMjAxMi0xMS0wNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCiAgICAgICAgIEFkZCByZXBsYWNlV2l0aExpdGVyYWwoKSBtZXRob2QgdG8g V1RGOjpTdHJpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTI1NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRleCAxODllMjEz Li5hOTIwNmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91 bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKQEAgLTcyLDI4ICs3 MiwyOSBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcm IHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRhJgogICAgIGludCBzdGF0dXM7CiAgICAgY2hh ciogc3RkT3V0ID0gMDsKIAorICAgIC8vIElmIHRoZSBkaXNwb3NpdGlvbiBvZiBTSUdDTEQgc2ln bmFsIGlzIHNldCB0byBTSUdfSUdOIChkZWZhdWx0KQorICAgIC8vIHRoZW4gdGhlIHNpZ25hbCB3 aWxsIGJlIGlnbm9yZWQgYW5kIGdfc3Bhd25fc3luYygpIHdpbGwgbm90IGJlCisgICAgLy8gYWJs ZSB0byByZXR1cm4gdGhlIHN0YXR1cy4KKyAgICAvLyBBcyBhIGNvbnNlcXVlbmNlLCB3ZSBtYWtl IHN1cmUgdGhhdCB0aGUgZGlzcG9zaXRpb24gaXMgc2V0IHRvCisgICAgLy8gU0lHX0RGTCBiZWZv cmUgY2FsbGluZyBnX3NwYXduX3N5bmMoKS4KKyAgICBzaWduYWwoU0lHQ0xELCBTSUdfREZMKTsK KwogICAgIGlmICghZ19zcGF3bl9zeW5jKDAsIGFyZ3YsIDAsIEdfU1BBV05fU1RERVJSX1RPX0RF Vl9OVUxMLCAwLCAwLCAmc3RkT3V0LCAwLCAmc3RhdHVzLCAwKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCi0gICAgaWYgKCFXSUZFWElURUQoc3RhdHVzKSB8fCBXRVhJVFNUQVRVUyhzdGF0dXMp ICE9IEVYSVRfU1VDQ0VTUykgeworICAgIGlmICghV0lGRVhJVEVEKHN0YXR1cykgfHwgV0VYSVRT VEFUVVMoc3RhdHVzKSAhPSBFWElUX1NVQ0NFU1MgfHwgIXN0ZE91dCkgewogICAgICAgICBmcmVl KHN0ZE91dCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBjb25zdCB1bnNp Z25lZCBrTnVtTGluZXNFeHBlY3RlZCA9IDM7Ci0gICAgU3RyaW5nIGxpbmVzW2tOdW1MaW5lc0V4 cGVjdGVkXTsKLSAgICB1bnNpZ25lZCBsaW5lSW5kZXggPSAwOwotCi0gICAgY29uc3QgVUNoYXIq IGN1cnJlbnQgPSByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4oc3RkT3V0KTsKKyAgICBT dHJpbmcgc3RkT3V0U3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUNoYXIqPihzdGRPdXQp KTsKKyAgICBmcmVlKHN0ZE91dCk7CiAKLSAgICB3aGlsZSAobGluZUluZGV4IDwga051bUxpbmVz RXhwZWN0ZWQpIHsKLSAgICAgICAgY29uc3QgVUNoYXIqIHN0YXJ0ID0gY3VycmVudDsKLSAgICAg ICAgd2hpbGUgKCpjdXJyZW50KysgIT0gVUNoYXIoJ1xuJykpIHsgfQotICAgICAgICBsaW5lc1ts aW5lSW5kZXgrK10gPSBTdHJpbmcoc3RhcnQsIGN1cnJlbnQgLSBzdGFydCAtIDEpOwotICAgIH0K KyAgICBWZWN0b3I8U3RyaW5nPiBsaW5lczsKKyAgICBzdGRPdXRTdHJpbmcuc3BsaXQoVUNoYXIo J1xuJyksIGxpbmVzKTsKIAotICAgIGlmIChzdGRPdXQpCi0gICAgICAgIGZyZWUoc3RkT3V0KTsK KyAgICBpZiAobGluZXMuc2l6ZSgpIDwgMykKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAg cmVzdWx0Lm5hbWUuc3dhcChsaW5lc1swXSk7CiAgICAgcmVzdWx0LmRlc2NyaXB0aW9uLnN3YXAo bGluZXNbMV0pOwo= 172775 2012-11-07 05:47:34 -0800 2012-11-07 06:56:15 -0800 Patch 101446_scanPlugins2.patch text/plain 3593 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MjUzY2FhLi4yOGIyZTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzEg QEAKIDIwMTItMTEtMDcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbV0syXVtVTklYXSBDcmFzaCBpbiBXZWJLaXQ6OlBsdWdpblByb2Nl c3NQcm94eTo6c2NhblBsdWdpbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDE0NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgZGlzcG9zaXRpb24gb2YgdGhlIFNJR0NI TEQgc2lnbmFsIGlzIHJlc2V0IHRvIHRoZSBkZWZhdWx0CisgICAgICAgIGJlZm9yZSBjYWxsaW5n IGdfc3Bhd25fc3luYygpLiBJZiB0aGUgZGlzcG9zaXRpb24gaXMgc2V0IHRvIFNJR19JR04sIHRo ZW4KKyAgICAgICAgZ19zcGF3bl9zeW5jKCkgd2lsbCBub3QgYmUgYWJsZSB0byByZXR1cm4gdGhl IGV4aXQgc3RhdHVzIG9mIHRoZSBjaGlsZAorICAgICAgICBwcm9jZXNzLCBvdXIgZXhpdCBmYWls dXJlIGNoZWNrIHdpbGwgYmUgdXNlbGVzcyBhbmQgdGhlIGZvbGxvd2luZyB3YXJuaW5nCisgICAg ICAgIHdpbGwgYmUgcHJpbnRlZDoKKworICAgICAgICBHTGliLVdBUk5JTkcgKio6IEluIGNhbGwg dG8gZ19zcGF3bl9zeW5jKCksIGV4aXQgc3RhdHVzIG9mIGEgY2hpbGQgcHJvY2VzcworICAgICAg ICB3YXMgcmVxdWVzdGVkIGJ1dCBTSUdDSExEIGFjdGlvbiB3YXMgc2V0IHRvIFNJR19JR04gYW5k IEVDSElMRCB3YXMgcmVjZWl2ZWQKKyAgICAgICAgYnkgd2FpdHBpZCgpLCBzbyBleGl0IHN0YXR1 cyBjYW4ndCBiZSByZXR1cm5lZC4gVGhpcyBpcyBhIGJ1ZyBpbiB0aGUKKyAgICAgICAgcHJvZ3Jh bSBjYWxsaW5nIGdfc3Bhd25fc3luYygpOyBlaXRoZXIgZG9uJ3QgcmVxdWVzdCB0aGUgZXhpdCBz dGF0dXMsIG9yCisgICAgICAgIGRvbid0IHNldCB0aGUgU0lHQ0hMRCBhY3Rpb24uCisKKyAgICAg ICAgVGhpcyBwYXRjaCBhbHNvIGFkZHMgYSBOVUxMLWNoZWNrIGZvciBzdGRPdXQgdG8gYXZvaWQg Y3Jhc2hpbmcgaW4gc3VjaAorICAgICAgICBjYXNlIGFuZCBtYWtlcyB1c2Ugb2YgU3RyaW5nOjpz cGxpdCgpIHRvIHBhcnNlIHN0ZE91dCBpbnN0ZWFkIG9mIGRvaW5nIGl0CisgICAgICAgIG1hbnVh bGx5LgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJv eHlVbml4LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1 Z2luKToKKworMjAxMi0xMS0wNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCiAgICAgICAgIEFkZCByZXBsYWNlV2l0aExpdGVyYWwoKSBtZXRob2QgdG8g V1RGOjpTdHJpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTI1NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRleCAxODllMjEz Li5kMjRjMzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91 bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKQEAgLTcyLDI4ICs3 MiwzNCBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcm IHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRhJgogICAgIGludCBzdGF0dXM7CiAgICAgY2hh ciogc3RkT3V0ID0gMDsKIAorICAgIC8vIElmIHRoZSBkaXNwb3NpdGlvbiBvZiBTSUdDTEQgc2ln bmFsIGlzIHNldCB0byBTSUdfSUdOIChkZWZhdWx0KQorICAgIC8vIHRoZW4gdGhlIHNpZ25hbCB3 aWxsIGJlIGlnbm9yZWQgYW5kIGdfc3Bhd25fc3luYygpIHdpbGwgbm90IGJlCisgICAgLy8gYWJs ZSB0byByZXR1cm4gdGhlIHN0YXR1cy4KKyAgICAvLyBBcyBhIGNvbnNlcXVlbmNlLCB3ZSBtYWtl IHN1cmUgdGhhdCB0aGUgZGlzcG9zaXRpb24gaXMgc2V0IHRvCisgICAgLy8gU0lHX0RGTCBiZWZv cmUgY2FsbGluZyBnX3NwYXduX3N5bmMoKS4KKyAgICBzdHJ1Y3Qgc2lnYWN0aW9uIGFjdGlvbjsK KyAgICBzaWdhY3Rpb24oU0lHQ0xELCAwLCAmYWN0aW9uKTsKKyAgICBpZiAoYWN0aW9uLnNhX2hh bmRsZXIgPT0gU0lHX0lHTikgeworICAgICAgICBhY3Rpb24uc2FfaGFuZGxlciA9IFNJR19ERkw7 CisgICAgICAgIHNpZ2FjdGlvbihTSUdDTEQsICZhY3Rpb24sIDApOworICAgIH0KKwogICAgIGlm ICghZ19zcGF3bl9zeW5jKDAsIGFyZ3YsIDAsIEdfU1BBV05fU1RERVJSX1RPX0RFVl9OVUxMLCAw LCAwLCAmc3RkT3V0LCAwLCAmc3RhdHVzLCAwKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgaWYgKCFXSUZFWElURUQoc3RhdHVzKSB8fCBXRVhJVFNUQVRVUyhzdGF0dXMpICE9IEVYSVRf U1VDQ0VTUykgeworICAgIGlmICghV0lGRVhJVEVEKHN0YXR1cykgfHwgV0VYSVRTVEFUVVMoc3Rh dHVzKSAhPSBFWElUX1NVQ0NFU1MgfHwgIXN0ZE91dCkgewogICAgICAgICBmcmVlKHN0ZE91dCk7 CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBjb25zdCB1bnNpZ25lZCBrTnVt TGluZXNFeHBlY3RlZCA9IDM7Ci0gICAgU3RyaW5nIGxpbmVzW2tOdW1MaW5lc0V4cGVjdGVkXTsK LSAgICB1bnNpZ25lZCBsaW5lSW5kZXggPSAwOwotCi0gICAgY29uc3QgVUNoYXIqIGN1cnJlbnQg PSByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4oc3RkT3V0KTsKKyAgICBTdHJpbmcgc3Rk T3V0U3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVUNoYXIqPihzdGRPdXQpKTsKKyAgICBm cmVlKHN0ZE91dCk7CiAKLSAgICB3aGlsZSAobGluZUluZGV4IDwga051bUxpbmVzRXhwZWN0ZWQp IHsKLSAgICAgICAgY29uc3QgVUNoYXIqIHN0YXJ0ID0gY3VycmVudDsKLSAgICAgICAgd2hpbGUg KCpjdXJyZW50KysgIT0gVUNoYXIoJ1xuJykpIHsgfQotICAgICAgICBsaW5lc1tsaW5lSW5kZXgr K10gPSBTdHJpbmcoc3RhcnQsIGN1cnJlbnQgLSBzdGFydCAtIDEpOwotICAgIH0KKyAgICBWZWN0 b3I8U3RyaW5nPiBsaW5lczsKKyAgICBzdGRPdXRTdHJpbmcuc3BsaXQoVUNoYXIoJ1xuJyksIGxp bmVzKTsKIAotICAgIGlmIChzdGRPdXQpCi0gICAgICAgIGZyZWUoc3RkT3V0KTsKKyAgICBpZiAo bGluZXMuc2l6ZSgpIDwgMykKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmVzdWx0Lm5h bWUuc3dhcChsaW5lc1swXSk7CiAgICAgcmVzdWx0LmRlc2NyaXB0aW9uLnN3YXAobGluZXNbMV0p Owo=