101441 2012-11-07 01:59:25 -0800 Indentation of ArgList.h is wrong 2012-11-07 13:16:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo ap barraclough ggaren mark.lam mhahnenberg msaboff oliver oldest_to_newest 760477 0 fpizlo 2012-11-07 01:59:25 -0800 Patch forthcoming. 760481 1 172742 fpizlo 2012-11-07 02:07:57 -0800 Created attachment 172742 the patch 760522 2 172742 kling 2012-11-07 04:30:03 -0800 Comment on attachment 172742 the patch Truly groundbreaking work! r=me 760737 3 ap 2012-11-07 08:37:50 -0800 There is really no need to post these patches for review, an IRC rubber-stamp would work better. 760985 4 fpizlo 2012-11-07 12:53:02 -0800 (In reply to comment #2) > (From update of attachment 172742 [details]) > Truly groundbreaking work! r=me Thanks brah! 761003 5 fpizlo 2012-11-07 13:16:31 -0800 Landed in http://trac.webkit.org/changeset/133800 172742 2012-11-07 02:07:57 -0800 2012-11-07 04:30:02 -0800 the patch fixindent.patch text/plain 7947 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNzMyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTExLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SW5kZW50YXRpb24gb2YgQXJnTGlzdC5oIGlzIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0NDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKdXN0IHVuaW5kZW50ZWQgYnkgNCBzcGFjZXMuCisK KyAgICAgICAgKiBydW50aW1lL0FyZ0xpc3QuaDoKKwogMjAxMi0xMS0wNiAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZHVjZSBwYXJzZXIgb3ZlcmhlYWQgaW4g SlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcmdMaXN0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJnTGlzdC5oCShyZXZpc2lv biAxMzM2ODUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcmdMaXN0LmgJKHdv cmtpbmcgY29weSkKQEAgLTI5LDE1MyArMjksMTUzIEBACiAKIG5hbWVzcGFjZSBKU0MgewogCi0g ICAgY2xhc3MgU2xvdFZpc2l0b3I7CitjbGFzcyBTbG90VmlzaXRvcjsKIAotICAgIGNsYXNzIE1h cmtlZEFyZ3VtZW50QnVmZmVyIHsKLSAgICAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoTWFya2Vk QXJndW1lbnRCdWZmZXIpOwotICAgICAgICBmcmllbmQgY2xhc3MgSlNHbG9iYWxEYXRhOwotICAg ICAgICBmcmllbmQgY2xhc3MgQXJnTGlzdDsKLQotICAgIHByaXZhdGU6Ci0gICAgICAgIHN0YXRp YyBjb25zdCBzaXplX3QgaW5saW5lQ2FwYWNpdHkgPSA4OwotICAgICAgICB0eXBlZGVmIFZlY3Rv cjxSZWdpc3RlciwgaW5saW5lQ2FwYWNpdHk+IFZlY3RvclR5cGU7Ci0gICAgICAgIHR5cGVkZWYg SGFzaFNldDxNYXJrZWRBcmd1bWVudEJ1ZmZlcio+IExpc3RTZXQ7Ci0KLSAgICBwdWJsaWM6Ci0g ICAgICAgIC8vIENvbnN0cnVjdG9yIGZvciBhIHJlYWQtd3JpdGUgbGlzdCwgdG8gd2hpY2ggeW91 IG1heSBhcHBlbmQgdmFsdWVzLgotICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIGFsbCBjbGllbnRz IG9mIHRoaXMgQVBJLCB0aGVuIHJlbW92ZSB0aGlzIEFQSS4KLSAgICAgICAgTWFya2VkQXJndW1l bnRCdWZmZXIoKQotICAgICAgICAgICAgOiBtX3NpemUoMCkKLSAgICAgICAgICAgICwgbV9jYXBh Y2l0eShpbmxpbmVDYXBhY2l0eSkKLSAgICAgICAgICAgICwgbV9idWZmZXIoJm1faW5saW5lQnVm ZmVyW21fY2FwYWNpdHkgLSAxXSkKLSAgICAgICAgICAgICwgbV9tYXJrU2V0KDApCi0gICAgICAg IHsKLSAgICAgICAgfQotCi0gICAgICAgIH5NYXJrZWRBcmd1bWVudEJ1ZmZlcigpCi0gICAgICAg IHsKLSAgICAgICAgICAgIGlmIChtX21hcmtTZXQpCi0gICAgICAgICAgICAgICAgbV9tYXJrU2V0 LT5yZW1vdmUodGhpcyk7Ci0KLSAgICAgICAgICAgIGlmIChFbmNvZGVkSlNWYWx1ZSogYmFzZSA9 IG1hbGxvY0Jhc2UoKSkKLSAgICAgICAgICAgICAgICBkZWxldGUgW10gYmFzZTsKLSAgICAgICAg fQotCi0gICAgICAgIHNpemVfdCBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9zaXplOyB9Ci0gICAg ICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuICFtX3NpemU7IH0KLQotICAgICAgICBK U1ZhbHVlIGF0KGludCBpKSBjb25zdAotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoaSA+PSBt X3NpemUpCi0gICAgICAgICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Ci0KLSAgICAgICAg ICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUoc2xvdEZvcihpKSk7Ci0gICAgICAgIH0KLQotICAg ICAgICB2b2lkIGNsZWFyKCkKLSAgICAgICAgewotICAgICAgICAgICAgbV9zaXplID0gMDsKLSAg ICAgICAgfQotCi0gICAgICAgIHZvaWQgYXBwZW5kKEpTVmFsdWUgdikKLSAgICAgICAgewotICAg ICAgICAgICAgaWYgKG1fc2l6ZSA+PSBtX2NhcGFjaXR5KQotICAgICAgICAgICAgICAgIHJldHVy biBzbG93QXBwZW5kKHYpOwotCi0gICAgICAgICAgICBzbG90Rm9yKG1fc2l6ZSkgPSBKU1ZhbHVl OjplbmNvZGUodik7Ci0gICAgICAgICAgICArK21fc2l6ZTsKLSAgICAgICAgfQotCi0gICAgICAg IHZvaWQgcmVtb3ZlTGFzdCgpCi0gICAgICAgIHsgCi0gICAgICAgICAgICBBU1NFUlQobV9zaXpl KTsKLSAgICAgICAgICAgIG1fc2l6ZS0tOwotICAgICAgICB9Ci0KLSAgICAgICAgSlNWYWx1ZSBs YXN0KCkgCi0gICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VSVChtX3NpemUpOwotICAgICAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmRlY29kZShzbG90Rm9yKG1fc2l6ZSAtIDEpKTsKLSAgICAgICAg fQorY2xhc3MgTWFya2VkQXJndW1lbnRCdWZmZXIgeworICAgIFdURl9NQUtFX05PTkNPUFlBQkxF KE1hcmtlZEFyZ3VtZW50QnVmZmVyKTsKKyAgICBmcmllbmQgY2xhc3MgSlNHbG9iYWxEYXRhOwor ICAgIGZyaWVuZCBjbGFzcyBBcmdMaXN0OworCitwcml2YXRlOgorICAgIHN0YXRpYyBjb25zdCBz aXplX3QgaW5saW5lQ2FwYWNpdHkgPSA4OworICAgIHR5cGVkZWYgVmVjdG9yPFJlZ2lzdGVyLCBp bmxpbmVDYXBhY2l0eT4gVmVjdG9yVHlwZTsKKyAgICB0eXBlZGVmIEhhc2hTZXQ8TWFya2VkQXJn dW1lbnRCdWZmZXIqPiBMaXN0U2V0OworCitwdWJsaWM6CisgICAgLy8gQ29uc3RydWN0b3IgZm9y IGEgcmVhZC13cml0ZSBsaXN0LCB0byB3aGljaCB5b3UgbWF5IGFwcGVuZCB2YWx1ZXMuCisgICAg Ly8gRklYTUU6IFJlbW92ZSBhbGwgY2xpZW50cyBvZiB0aGlzIEFQSSwgdGhlbiByZW1vdmUgdGhp cyBBUEkuCisgICAgTWFya2VkQXJndW1lbnRCdWZmZXIoKQorICAgICAgICA6IG1fc2l6ZSgwKQor ICAgICAgICAsIG1fY2FwYWNpdHkoaW5saW5lQ2FwYWNpdHkpCisgICAgICAgICwgbV9idWZmZXIo Jm1faW5saW5lQnVmZmVyW21fY2FwYWNpdHkgLSAxXSkKKyAgICAgICAgLCBtX21hcmtTZXQoMCkK KyAgICB7CisgICAgfQorCisgICAgfk1hcmtlZEFyZ3VtZW50QnVmZmVyKCkKKyAgICB7CisgICAg ICAgIGlmIChtX21hcmtTZXQpCisgICAgICAgICAgICBtX21hcmtTZXQtPnJlbW92ZSh0aGlzKTsK KworICAgICAgICBpZiAoRW5jb2RlZEpTVmFsdWUqIGJhc2UgPSBtYWxsb2NCYXNlKCkpCisgICAg ICAgICAgICBkZWxldGUgW10gYmFzZTsKKyAgICB9CisKKyAgICBzaXplX3Qgc2l6ZSgpIGNvbnN0 IHsgcmV0dXJuIG1fc2l6ZTsgfQorICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuICFt X3NpemU7IH0KKworICAgIEpTVmFsdWUgYXQoaW50IGkpIGNvbnN0CisgICAgeworICAgICAgICBp ZiAoaSA+PSBtX3NpemUpCisgICAgICAgICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKKworICAg ICAgICByZXR1cm4gSlNWYWx1ZTo6ZGVjb2RlKHNsb3RGb3IoaSkpOworICAgIH0KKworICAgIHZv aWQgY2xlYXIoKQorICAgIHsKKyAgICAgICAgbV9zaXplID0gMDsKKyAgICB9CisKKyAgICB2b2lk IGFwcGVuZChKU1ZhbHVlIHYpCisgICAgeworICAgICAgICBpZiAobV9zaXplID49IG1fY2FwYWNp dHkpCisgICAgICAgICAgICByZXR1cm4gc2xvd0FwcGVuZCh2KTsKKworICAgICAgICBzbG90Rm9y KG1fc2l6ZSkgPSBKU1ZhbHVlOjplbmNvZGUodik7CisgICAgICAgICsrbV9zaXplOworICAgIH0K KworICAgIHZvaWQgcmVtb3ZlTGFzdCgpCisgICAgeyAKKyAgICAgICAgQVNTRVJUKG1fc2l6ZSk7 CisgICAgICAgIG1fc2l6ZS0tOworICAgIH0KKworICAgIEpTVmFsdWUgbGFzdCgpIAorICAgIHsK KyAgICAgICAgQVNTRVJUKG1fc2l6ZSk7CisgICAgICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUo c2xvdEZvcihtX3NpemUgLSAxKSk7CisgICAgfQogICAgICAgICAKLSAgICAgICAgc3RhdGljIHZv aWQgbWFya0xpc3RzKEhlYXBSb290VmlzaXRvciYsIExpc3RTZXQmKTsKKyAgICBzdGF0aWMgdm9p ZCBtYXJrTGlzdHMoSGVhcFJvb3RWaXNpdG9yJiwgTGlzdFNldCYpOwogCi0gICAgcHJpdmF0ZToK LSAgICAgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBzbG93QXBwZW5kKEpTVmFsdWUpOworcHJp dmF0ZToKKyAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIHNsb3dBcHBlbmQoSlNWYWx1ZSk7CiAg ICAgICAgIAotICAgICAgICBFbmNvZGVkSlNWYWx1ZSYgc2xvdEZvcihpbnQgaXRlbSkgY29uc3QK LSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIG1fYnVmZmVyWy1pdGVtXTsKLSAgICAgICAg fQorICAgIEVuY29kZWRKU1ZhbHVlJiBzbG90Rm9yKGludCBpdGVtKSBjb25zdAorICAgIHsKKyAg ICAgICAgcmV0dXJuIG1fYnVmZmVyWy1pdGVtXTsKKyAgICB9CiAgICAgICAgIAotICAgICAgICBF bmNvZGVkSlNWYWx1ZSogbWFsbG9jQmFzZSgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGlmICht X2NhcGFjaXR5ID09IHN0YXRpY19jYXN0PGludD4oaW5saW5lQ2FwYWNpdHkpKQotICAgICAgICAg ICAgICAgIHJldHVybiAwOwotICAgICAgICAgICAgcmV0dXJuICZzbG90Rm9yKG1fY2FwYWNpdHkg LSAxKTsKLSAgICAgICAgfQorICAgIEVuY29kZWRKU1ZhbHVlKiBtYWxsb2NCYXNlKCkKKyAgICB7 CisgICAgICAgIGlmIChtX2NhcGFjaXR5ID09IHN0YXRpY19jYXN0PGludD4oaW5saW5lQ2FwYWNp dHkpKQorICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiAmc2xvdEZvcihtX2Nh cGFjaXR5IC0gMSk7CisgICAgfQogICAgICAgICAKLSAgICAgICAgaW50IG1fc2l6ZTsKLSAgICAg ICAgaW50IG1fY2FwYWNpdHk7Ci0gICAgICAgIEVuY29kZWRKU1ZhbHVlIG1faW5saW5lQnVmZmVy W2lubGluZUNhcGFjaXR5XTsKLSAgICAgICAgRW5jb2RlZEpTVmFsdWUqIG1fYnVmZmVyOwotICAg ICAgICBMaXN0U2V0KiBtX21hcmtTZXQ7Ci0KLSAgICBwcml2YXRlOgotICAgICAgICAvLyBQcm9o aWJpdHMgbmV3IC8gZGVsZXRlLCB3aGljaCB3b3VsZCBicmVhayBHQy4KLSAgICAgICAgdm9pZCog b3BlcmF0b3IgbmV3KHNpemVfdCBzaXplKQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4g ZmFzdE1hbGxvYyhzaXplKTsKLSAgICAgICAgfQotICAgICAgICB2b2lkIG9wZXJhdG9yIGRlbGV0 ZSh2b2lkKiBwKQotICAgICAgICB7Ci0gICAgICAgICAgICBmYXN0RnJlZShwKTsKLSAgICAgICAg fQotCi0gICAgICAgIHZvaWQqIG9wZXJhdG9yIG5ld1tdKHNpemVfdCk7Ci0gICAgICAgIHZvaWQg b3BlcmF0b3IgZGVsZXRlW10odm9pZCopOwotCi0gICAgICAgIHZvaWQqIG9wZXJhdG9yIG5ldyhz aXplX3QsIHZvaWQqKTsKLSAgICAgICAgdm9pZCBvcGVyYXRvciBkZWxldGUodm9pZCosIHNpemVf dCk7Ci0gICAgfTsKLQotICAgIGNsYXNzIEFyZ0xpc3QgewotICAgICAgICBmcmllbmQgY2xhc3Mg SklUOwotICAgIHB1YmxpYzoKLSAgICAgICAgQXJnTGlzdCgpCi0gICAgICAgICAgICA6IG1fYXJn cygwKQotICAgICAgICAgICAgLCBtX2FyZ0NvdW50KDApCi0gICAgICAgIHsKLSAgICAgICAgfQot Ci0gICAgICAgIEFyZ0xpc3QoRXhlY1N0YXRlKiBleGVjKQotICAgICAgICAgICAgOiBtX2FyZ3Mo cmVpbnRlcnByZXRfY2FzdDxKU1ZhbHVlKj4oJmV4ZWNbQ2FsbEZyYW1lOjphcmd1bWVudE9mZnNl dCgwKV0pKQotICAgICAgICAgICAgLCBtX2FyZ0NvdW50KGV4ZWMtPmFyZ3VtZW50Q291bnQoKSkK LSAgICAgICAgewotICAgICAgICB9Ci0KLSAgICAgICAgQXJnTGlzdChjb25zdCBNYXJrZWRBcmd1 bWVudEJ1ZmZlciYgYXJncykKLSAgICAgICAgICAgIDogbV9hcmdzKHJlaW50ZXJwcmV0X2Nhc3Q8 SlNWYWx1ZSo+KGFyZ3MubV9idWZmZXIpKQotICAgICAgICAgICAgLCBtX2FyZ0NvdW50KGFyZ3Mu c2l6ZSgpKQotICAgICAgICB7Ci0gICAgICAgIH0KLQotICAgICAgICBKU1ZhbHVlIGF0KGludCBp KSBjb25zdAotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoaSA+PSBtX2FyZ0NvdW50KQotICAg ICAgICAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwotICAgICAgICAgICAgcmV0dXJuIG1f YXJnc1staV07Ci0gICAgICAgIH0KKyAgICBpbnQgbV9zaXplOworICAgIGludCBtX2NhcGFjaXR5 OworICAgIEVuY29kZWRKU1ZhbHVlIG1faW5saW5lQnVmZmVyW2lubGluZUNhcGFjaXR5XTsKKyAg ICBFbmNvZGVkSlNWYWx1ZSogbV9idWZmZXI7CisgICAgTGlzdFNldCogbV9tYXJrU2V0OworCitw cml2YXRlOgorICAgIC8vIFByb2hpYml0cyBuZXcgLyBkZWxldGUsIHdoaWNoIHdvdWxkIGJyZWFr IEdDLgorICAgIHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3Qgc2l6ZSkKKyAgICB7CisgICAgICAg IHJldHVybiBmYXN0TWFsbG9jKHNpemUpOworICAgIH0KKyAgICB2b2lkIG9wZXJhdG9yIGRlbGV0 ZSh2b2lkKiBwKQorICAgIHsKKyAgICAgICAgZmFzdEZyZWUocCk7CisgICAgfQorCisgICAgdm9p ZCogb3BlcmF0b3IgbmV3W10oc2l6ZV90KTsKKyAgICB2b2lkIG9wZXJhdG9yIGRlbGV0ZVtdKHZv aWQqKTsKKworICAgIHZvaWQqIG9wZXJhdG9yIG5ldyhzaXplX3QsIHZvaWQqKTsKKyAgICB2b2lk IG9wZXJhdG9yIGRlbGV0ZSh2b2lkKiwgc2l6ZV90KTsKK307CisKK2NsYXNzIEFyZ0xpc3Qgewor ICAgIGZyaWVuZCBjbGFzcyBKSVQ7CitwdWJsaWM6CisgICAgQXJnTGlzdCgpCisgICAgICAgIDog bV9hcmdzKDApCisgICAgICAgICwgbV9hcmdDb3VudCgwKQorICAgIHsKKyAgICB9CisKKyAgICBB cmdMaXN0KEV4ZWNTdGF0ZSogZXhlYykKKyAgICAgICAgOiBtX2FyZ3MocmVpbnRlcnByZXRfY2Fz dDxKU1ZhbHVlKj4oJmV4ZWNbQ2FsbEZyYW1lOjphcmd1bWVudE9mZnNldCgwKV0pKQorICAgICAg ICAsIG1fYXJnQ291bnQoZXhlYy0+YXJndW1lbnRDb3VudCgpKQorICAgIHsKKyAgICB9CisKKyAg ICBBcmdMaXN0KGNvbnN0IE1hcmtlZEFyZ3VtZW50QnVmZmVyJiBhcmdzKQorICAgICAgICA6IG1f YXJncyhyZWludGVycHJldF9jYXN0PEpTVmFsdWUqPihhcmdzLm1fYnVmZmVyKSkKKyAgICAgICAg LCBtX2FyZ0NvdW50KGFyZ3Muc2l6ZSgpKQorICAgIHsKKyAgICB9CisKKyAgICBKU1ZhbHVlIGF0 KGludCBpKSBjb25zdAorICAgIHsKKyAgICAgICAgaWYgKGkgPj0gbV9hcmdDb3VudCkKKyAgICAg ICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOworICAgICAgICByZXR1cm4gbV9hcmdzWy1pXTsK KyAgICB9CiAKLSAgICAgICAgYm9vbCBpc0VtcHR5KCkgY29uc3QgeyByZXR1cm4gIW1fYXJnQ291 bnQ7IH0KLSAgICAgICAgc2l6ZV90IHNpemUoKSBjb25zdCB7IHJldHVybiBtX2FyZ0NvdW50OyB9 CisgICAgYm9vbCBpc0VtcHR5KCkgY29uc3QgeyByZXR1cm4gIW1fYXJnQ291bnQ7IH0KKyAgICBz aXplX3Qgc2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fYXJnQ291bnQ7IH0KICAgICAgICAgCi0gICAg ICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgZ2V0U2xpY2UoaW50IHN0YXJ0SW5kZXgsIEFyZ0xp c3QmIHJlc3VsdCkgY29uc3Q7CisgICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBnZXRTbGljZShp bnQgc3RhcnRJbmRleCwgQXJnTGlzdCYgcmVzdWx0KSBjb25zdDsKIAotICAgIHByaXZhdGU6Ci0g ICAgICAgIEpTVmFsdWUqIG1fYXJnczsKLSAgICAgICAgaW50IG1fYXJnQ291bnQ7Ci0gICAgfTsK K3ByaXZhdGU6CisgICAgSlNWYWx1ZSogbV9hcmdzOworICAgIGludCBtX2FyZ0NvdW50OworfTsK IAogfSAvLyBuYW1lc3BhY2UgSlNDCiAK