101435 2012-11-07 00:33:18 -0800 Seam occurred between pieces of ShadowBlur on floating point zoom 2012-11-07 19:03:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim bdakin leviw simon.fraser webkit.review.bot oldest_to_newest 760436 0 ktf.kim 2012-11-07 00:33:18 -0800 Issue> When paint Shadow that doesn't have blurred edge on floating point zoom, pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect. Solution> Enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing) even if the unaligned clip rect occurred 760464 1 172736 ktf.kim 2012-11-07 01:26:54 -0800 Created attachment 172736 Patch 761164 2 172736 simon.fraser 2012-11-07 16:27:41 -0800 Comment on attachment 172736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172736&action=review > Source/WebCore/ChangeLog:3 > + Seem occurred between pieces of ShadowBlur on floating point zoom Seam. We often refer to these as "pixel cracks". > Source/WebCore/ChangeLog:9 > + pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect. seam 761235 3 172903 ktf.kim 2012-11-07 17:52:42 -0800 Created attachment 172903 Patch 761237 4 172903 simon.fraser 2012-11-07 17:54:27 -0800 Comment on attachment 172903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172903&action=review > Source/WebCore/ChangeLog:9 > + pixel seam(pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect. space before ( 761240 5 172904 ktf.kim 2012-11-07 17:56:20 -0800 Created attachment 172904 Patch 761277 6 172904 webkit.review.bot 2012-11-07 19:03:35 -0800 Comment on attachment 172904 Patch Clearing flags on attachment: 172904 Committed r133836: <http://trac.webkit.org/changeset/133836> 761278 7 webkit.review.bot 2012-11-07 19:03:40 -0800 All reviewed patches have been landed. Closing bug. 172736 2012-11-07 01:26:54 -0800 2012-11-07 17:52:36 -0800 Patch bug-101435-20121107182507.patch text/plain 1918 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI2MzdkZDI0ZjcxOWMz MmFlYmQ0OWNjYjkyNmMzNmU4ZWY2ZWY4Ni4uYWM2MWRjZjlmNWNjMTRhMWY3YTcxZmI5MjYyYmI3 MTg2MTkxMjk2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA3ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFNlZW0gb2NjdXJyZWQg YmV0d2VlbiBwaWVjZXMgb2YgU2hhZG93Qmx1ciBvbiBmbG9hdGluZyBwb2ludCB6b29tCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0MzUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHBhaW50IFNo YWRvdyB0aGF0IGRvZXNuJ3QgaGF2ZSBibHVycmVkIGVkZ2Ugb24gZmxvYXRpbmcgcG9pbnQgem9v bSwKKyAgICAgICAgcGl4ZWwgc2VlbSBvY2N1cnJlZCBiZXR3ZWVuIHBpZWNlcyBvZiB0aGUgU2hh ZG93Qmx1ciBiZWNhdXNlIG9mIHVuYWxpZ25lZCBjbGlwIHJlY3QuCisgICAgICAgIFNvLCBlbmxh cmdlIHRoZSBjbGlwcGluZyBhcmVhIDEgcGl4ZWwgc28gdGhhdCB0aGUgZmlsbCBkb2VzIG5vdCBi bGVlZCAoZHVlIHRvIGFudGlhbGlhc2luZykKKyAgICAgICAgZXZlbiBpZiB0aGUgdW5hbGlnbmVk IGNsaXAgcmVjdCBvY2N1cnJlZC4KKworCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvU2hh ZG93Qmx1ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dCbHVyOjpjYWxjdWxhdGVMYXll ckJvdW5kaW5nUmVjdCk6CisKIDIwMTItMTEtMDYgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdl YmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IG1vbnRoIHBpY2tpbmcgdG8gY2FsZW5kYXIg cGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFk b3dCbHVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIu Y3BwCmluZGV4IGU2MGY1YzUzZGU2YTVhOGNjZTQ3ZjMxYzJmNDZjYzg1Mjc1NDgyMDYuLjMzNTky ODM2N2JmN2M0MjEwZGVmMjJlYmVkYTBlNWIxY2VjMjg2NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCkBAIC00MTEsNiArNDExLDExIEBA IEludFJlY3QgU2hhZG93Qmx1cjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZGluZ1JlY3QoR3JhcGhpY3ND b250ZXh0KiBjb250ZXh0LCBjb25zdCBGCiAgICAgICAgIGlmIChtX3R5cGUgPT0gQmx1clNoYWRv dykgewogICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVYKGVkZ2VTaXplLndpZHRoKCkp OwogICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVZKGVkZ2VTaXplLmhlaWdodCgpKTsK KyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIC8vIEVubGFyZ2UgdGhlIGNsaXBwaW5nIGFy ZWEgMSBwaXhlbCBzbyB0aGF0IHRoZSBmaWxsIGRvZXMgbm90CisgICAgICAgICAgICAvLyBibGVl ZCAoZHVlIHRvIGFudGlhbGlhc2luZykgZXZlbiBpZiB0aGUgdW5hbGlnbmVkIGNsaXAgcmVjdCBv Y2N1cnJlZAorICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVYKDEpOworICAgICAgICAg ICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVZKDEpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAg ICBsYXllclJlY3QuaW50ZXJzZWN0KGluZmxhdGVkQ2xpcCk7Cg== 172903 2012-11-07 17:52:42 -0800 2012-11-07 17:56:15 -0800 Patch bug-101435-20121108105054.patch text/plain 1972 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFhODU3NjU5ZWQxYmRj YmY5ZTI1OTcxYWVlYWE3NTBhOTdhODIwNi4uYmI1NWJmNThiNjFjZjA5YzRjMWQ5ZGNhZGM2MWVl YjdlZDQ2OGRmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA3ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFNlYW0gb2NjdXJyZWQg YmV0d2VlbiBwaWVjZXMgb2YgU2hhZG93Qmx1ciBvbiBmbG9hdGluZyBwb2ludCB6b29tCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0MzUKKworICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hlbiBwYWludCBTaGFk b3cgdGhhdCBkb2Vzbid0IGhhdmUgYmx1cnJlZCBlZGdlIG9uIGZsb2F0aW5nIHBvaW50IHpvb20s CisgICAgICAgIHBpeGVsIHNlYW0ocGl4ZWwgY3JhY2tzKSBvY2N1cnJlZCBiZXR3ZWVuIHBpZWNl cyBvZiB0aGUgU2hhZG93Qmx1ciBiZWNhdXNlIG9mIHVuYWxpZ25lZCBjbGlwIHJlY3QuCisgICAg ICAgIFNvLCBlbmxhcmdlIHRoZSBjbGlwcGluZyBhcmVhIDEgcGl4ZWwgc28gdGhhdCB0aGUgZmls bCBkb2VzIG5vdCBibGVlZCAoZHVlIHRvIGFudGlhbGlhc2luZykKKyAgICAgICAgZXZlbiBpZiB0 aGUgdW5hbGlnbmVkIGNsaXAgcmVjdCBvY2N1cnJlZC4KKworCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvU2hhZG93Qmx1ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dCbHVyOjpj YWxjdWxhdGVMYXllckJvdW5kaW5nUmVjdCk6CisKIDIwMTItMTEtMDcgIEFsZWMgRmxldHQgIDxh bGVjZmxldHRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogUHJlcGFyZSBmb3Ig SURCQmFja2luZ1N0b3JlIG1lcmdlIGJ5IHJlbmFtaW5nIElEQkxldmVsREJCYWNraW5nU3RvcmUu Y3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFkb3dC bHVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3Bw CmluZGV4IGU2MGY1YzUzZGU2YTVhOGNjZTQ3ZjMxYzJmNDZjYzg1Mjc1NDgyMDYuLjMzNTkyODM2 N2JmN2M0MjEwZGVmMjJlYmVkYTBlNWIxY2VjMjg2NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwCkBAIC00MTEsNiArNDExLDExIEBAIElu dFJlY3QgU2hhZG93Qmx1cjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZGluZ1JlY3QoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LCBjb25zdCBGCiAgICAgICAgIGlmIChtX3R5cGUgPT0gQmx1clNoYWRvdykg ewogICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVYKGVkZ2VTaXplLndpZHRoKCkpOwog ICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVZKGVkZ2VTaXplLmhlaWdodCgpKTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIC8vIEVubGFyZ2UgdGhlIGNsaXBwaW5nIGFyZWEg MSBwaXhlbCBzbyB0aGF0IHRoZSBmaWxsIGRvZXMgbm90CisgICAgICAgICAgICAvLyBibGVlZCAo ZHVlIHRvIGFudGlhbGlhc2luZykgZXZlbiBpZiB0aGUgdW5hbGlnbmVkIGNsaXAgcmVjdCBvY2N1 cnJlZAorICAgICAgICAgICAgaW5mbGF0ZWRDbGlwLmluZmxhdGVYKDEpOworICAgICAgICAgICAg aW5mbGF0ZWRDbGlwLmluZmxhdGVZKDEpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBs YXllclJlY3QuaW50ZXJzZWN0KGluZmxhdGVkQ2xpcCk7Cg== 172904 2012-11-07 17:56:20 -0800 2012-11-07 19:03:35 -0800 Patch bug-101435-20121108105433.patch text/plain 1973 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFhODU3NjU5ZWQxYmRj YmY5ZTI1OTcxYWVlYWE3NTBhOTdhODIwNi4uODUwMThjYWZmZDQ1MDMyNjA1MWY1NDgwNzc5OTc0 OGRhNDljZjM2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA3ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFNlYW0gb2NjdXJyZWQg YmV0d2VlbiBwaWVjZXMgb2YgU2hhZG93Qmx1ciBvbiBmbG9hdGluZyBwb2ludCB6b29tCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0MzUKKworICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hlbiBwYWludCBTaGFk b3cgdGhhdCBkb2Vzbid0IGhhdmUgYmx1cnJlZCBlZGdlIG9uIGZsb2F0aW5nIHBvaW50IHpvb20s CisgICAgICAgIHBpeGVsIHNlYW0gKHBpeGVsIGNyYWNrcykgb2NjdXJyZWQgYmV0d2VlbiBwaWVj ZXMgb2YgdGhlIFNoYWRvd0JsdXIgYmVjYXVzZSBvZiB1bmFsaWduZWQgY2xpcCByZWN0LgorICAg ICAgICBTbywgZW5sYXJnZSB0aGUgY2xpcHBpbmcgYXJlYSAxIHBpeGVsIHNvIHRoYXQgdGhlIGZp bGwgZG9lcyBub3QgYmxlZWQgKGR1ZSB0byBhbnRpYWxpYXNpbmcpCisgICAgICAgIGV2ZW4gaWYg dGhlIHVuYWxpZ25lZCBjbGlwIHJlY3Qgb2NjdXJyZWQuCisKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL1NoYWRvd0JsdXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93Qmx1cjo6 Y2FsY3VsYXRlTGF5ZXJCb3VuZGluZ1JlY3QpOgorCiAyMDEyLTExLTA3ICBBbGVjIEZsZXR0ICA8 YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFByZXBhcmUgZm9y IElEQkJhY2tpbmdTdG9yZSBtZXJnZSBieSByZW5hbWluZyBJREJMZXZlbERCQmFja2luZ1N0b3Jl LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2hhZG93 Qmx1ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFkb3dCbHVyLmNw cAppbmRleCBlNjBmNWM1M2RlNmE1YThjY2U0N2YzMWMyZjQ2Y2M4NTI3NTQ4MjA2Li4zMzU5Mjgz NjdiZjdjNDIxMGRlZjIyZWJlZGEwZTViMWNlYzI4NjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFkb3dCbHVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9TaGFkb3dCbHVyLmNwcApAQCAtNDExLDYgKzQxMSwxMSBAQCBJ bnRSZWN0IFNoYWRvd0JsdXI6OmNhbGN1bGF0ZUxheWVyQm91bmRpbmdSZWN0KEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgRgogICAgICAgICBpZiAobV90eXBlID09IEJsdXJTaGFkb3cp IHsKICAgICAgICAgICAgIGluZmxhdGVkQ2xpcC5pbmZsYXRlWChlZGdlU2l6ZS53aWR0aCgpKTsK ICAgICAgICAgICAgIGluZmxhdGVkQ2xpcC5pbmZsYXRlWShlZGdlU2l6ZS5oZWlnaHQoKSk7Cisg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAvLyBFbmxhcmdlIHRoZSBjbGlwcGluZyBhcmVh IDEgcGl4ZWwgc28gdGhhdCB0aGUgZmlsbCBkb2VzIG5vdAorICAgICAgICAgICAgLy8gYmxlZWQg KGR1ZSB0byBhbnRpYWxpYXNpbmcpIGV2ZW4gaWYgdGhlIHVuYWxpZ25lZCBjbGlwIHJlY3Qgb2Nj dXJyZWQKKyAgICAgICAgICAgIGluZmxhdGVkQ2xpcC5pbmZsYXRlWCgxKTsKKyAgICAgICAgICAg IGluZmxhdGVkQ2xpcC5pbmZsYXRlWSgxKTsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAg bGF5ZXJSZWN0LmludGVyc2VjdChpbmZsYXRlZENsaXApOwo=