101427 2012-11-06 21:28:58 -0800 Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING 2012-11-12 06:04:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage peavo webkit.review.bot oldest_to_newest 760374 0 vivekgalatage 2012-11-06 21:28:58 -0800 Move DrawingAreaImpl methods graphicsLayerFactory, setRootCompositingLayer & scheduleCompositingLayerSync under ACCELERATED_COMPOSITING This will fix the broken win cairo build. The error thrown by win cairo build is: 8>####### COMPILING 3 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 8>DrawingArea.cpp 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(71) : error C3668: 'WebKit::DrawingAreaImpl::graphicsLayerFactory' : method with override specifier 'override' did not override any base class methods 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(72) : error C3668: 'WebKit::DrawingAreaImpl::setRootCompositingLayer' : method with override specifier 'override' did not override any base class methods 8>c:\projects\buildslave\win-cairo-release\build\source\webkit2\webprocess\webpage\DrawingAreaImpl.h(73) : error C3668: 'WebKit::DrawingAreaImpl::scheduleCompositingLayerFlush' : method with override specifier 'override' did not override any base class methods 760378 1 172715 vivekgalatage 2012-11-06 21:34:53 -0800 Created attachment 172715 Patch 760410 2 172715 webkit.review.bot 2012-11-06 22:46:27 -0800 Comment on attachment 172715 Patch Clearing flags on attachment: 172715 Committed r133724: <http://trac.webkit.org/changeset/133724> 760411 3 webkit.review.bot 2012-11-06 22:46:30 -0800 All reviewed patches have been landed. Closing bug. 764326 4 peavo 2012-11-12 06:04:00 -0800 *** Bug 101059 has been marked as a duplicate of this bug. *** 172715 2012-11-06 21:34:53 -0800 2012-11-06 22:46:27 -0800 Patch bug-101427-20121107110341.patch text/plain 2672 vivekgalatage U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWMxMGE0ZTczNzgxMWNh NzIxOWQ0YzA5ZWQ4OTAzYWIyNGZmODc1MC4uNzA0NGE5ZTY4NDk3M2ZlODM4MjljY2RhNmNiZDcw MTIxMjFhNThjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA2ICBWaXZl ayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIE1vdmUgRHJh d2luZ0FyZWFJbXBsIG1ldGhvZHMgZ3JhcGhpY3NMYXllckZhY3RvcnksIHNldFJvb3RDb21wb3Np dGluZ0xheWVyICYgc2NoZWR1bGVDb21wb3NpdGluZ0xheWVyU3luYyB1bmRlciBBQ0NFTEVSQVRF RF9DT01QT1NJVElORworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAxNDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTW92aW5nIHRoZXNlIG1ldGhvZHMgdW5kZXIgdGhlIEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HIGZsYWcuCisgICAgICAgIFRoaXMgZml4ZXMgYnJva2VuIHdpbmNhaXJvIGR1ZSB0byB1c2Ug b2Ygb3ZlcnJpZGUgc3BlY2lmaWVyLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Ry YXdpbmdBcmVhSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuaDoKKyAgICAgICAgKERyYXdpbmdBcmVhSW1wbCk6 CisKIDIwMTItMTEtMDYgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAog ICAgICAgICBVcGRhdGUgSmF2YSByZWxhdGVkIFdLU0kgZnVuY3Rpb24gbmFtZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAK aW5kZXggNzE5MTY5MDlkMzkxMDFmZjBmZDAwZmZmOGM5YmU0MmFlMmVjYzllZC4uNWU3MGM5NDQ4 MTM0NTA0M2M0OTdjZjJhNGRmZTk4YzFlMzIyOWM3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKQEAgLTMwNyw2ICsz MDcsNyBAQCB2b2lkIERyYXdpbmdBcmVhSW1wbDo6bGF5ZXJIb3N0RGlkRmx1c2hMYXllcnMoKQog I2VuZGlmCiB9CiAKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiBHcmFwaGljc0xh eWVyRmFjdG9yeSogRHJhd2luZ0FyZWFJbXBsOjpncmFwaGljc0xheWVyRmFjdG9yeSgpCiB7CiAg ICAgaWYgKG1fbGF5ZXJUcmVlSG9zdCkKQEAgLTM2MSw2ICszNjIsNyBAQCB2b2lkIERyYXdpbmdB cmVhSW1wbDo6c2NoZWR1bGVDb21wb3NpdGluZ0xheWVyRmx1c2goKQogICAgICAgICByZXR1cm47 CiAgICAgbV9sYXllclRyZWVIb3N0LT5zY2hlZHVsZUxheWVyRmx1c2goKTsKIH0KKyNlbmRpZgog CiB2b2lkIERyYXdpbmdBcmVhSW1wbDo6dXBkYXRlQmFja2luZ1N0b3JlU3RhdGUodWludDY0X3Qg c3RhdGVJRCwgYm9vbCByZXNwb25kSW1tZWRpYXRlbHksIGZsb2F0IGRldmljZVNjYWxlRmFjdG9y LCBjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBzaXplLCBjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBz Y3JvbGxPZmZzZXQpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvRHJhd2luZ0FyZWFJbXBsLmgKaW5kZXggYmE5Mzk1NGY5YjdkOWIwZGFlNTMzZTYzMmQ1NzQ0 OTM5NDUyOTdjNi4uNmQ0OTcxOWY3YTk4Y2VmMjVkNDkzNWZmYTcwNmNhNGNkMmNmZDNiMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1w bC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUlt cGwuaApAQCAtNjgsOSArNjgsMTEgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgc2V0UGFp bnRpbmdFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVQcmVmZXJlbmNlcyhj b25zdCBXZWJQcmVmZXJlbmNlc1N0b3JlJikgT1ZFUlJJREU7CiAKKyNpZiBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCiAgICAgdmlydHVhbCBXZWJDb3JlOjpHcmFwaGljc0xheWVyRmFjdG9y eSogZ3JhcGhpY3NMYXllckZhY3RvcnkoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0 Um9vdENvbXBvc2l0aW5nTGF5ZXIoV2ViQ29yZTo6R3JhcGhpY3NMYXllciopIE9WRVJSSURFOwog ICAgIHZpcnR1YWwgdm9pZCBzY2hlZHVsZUNvbXBvc2l0aW5nTGF5ZXJGbHVzaCgpIE9WRVJSSURF OworI2VuZGlmCiAKICNpZiBQTEFURk9STShXSU4pCiAgICAgdmlydHVhbCB2b2lkIHNjaGVkdWxl Q2hpbGRXaW5kb3dHZW9tZXRyeVVwZGF0ZShjb25zdCBXaW5kb3dHZW9tZXRyeSYpOwo=