101420 2012-11-06 18:52:14 -0800 Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer 2012-11-07 12:35:59 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rdemarest webkit-unassigned andersca benjamin mrowe webkit.review.bot oldest_to_newest 760290 0 rdemarest 2012-11-06 18:52:14 -0800 Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer <rdar://problem/12644883> 760291 1 172697 rdemarest 2012-11-06 18:56:38 -0800 Created attachment 172697 Patch 760454 2 172697 benjamin 2012-11-07 01:07:29 -0800 Comment on attachment 172697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review Nice patch. I did not know about those annotations. > Source/WTF/ChangeLog:9 > + Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, uses in function declarations. Ok, not a native English speaker here. :) Should Define and use really take a S? Is the subject implicit or something? 760872 3 rdemarest 2012-11-07 10:50:09 -0800 (In reply to comment #2) > (From update of attachment 172697 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review > > Nice patch. I did not know about those annotations. > > > Source/WTF/ChangeLog:9 > > + Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, uses in function declarations. > > Ok, not a native English speaker here. :) > Should Define and use really take a S? Is the subject implicit or something? Same here, not a native speaker, but if you take the "patch" as the subject of the sentence, then the S makes sense. Though the second sentence might need a "uses them in function declarations". 760942 4 172697 benjamin 2012-11-07 11:48:55 -0800 Comment on attachment 172697 Patch > Same here, not a native speaker, but if you take the "patch" as the subject of the sentence, then the S makes sense. Though the second sentence might need a "uses them in function declarations". Okay :) Can you please just update the changelog? 760948 5 172854 rdemarest 2012-11-07 11:56:05 -0800 Created attachment 172854 Patch I modified the grammar of the change log to make it more consistent. 760949 6 172854 benjamin 2012-11-07 11:58:20 -0800 Comment on attachment 172854 Patch Thank you :) 760972 7 172854 webkit.review.bot 2012-11-07 12:35:56 -0800 Comment on attachment 172854 Patch Clearing flags on attachment: 172854 Committed r133793: <http://trac.webkit.org/changeset/133793> 760973 8 webkit.review.bot 2012-11-07 12:35:59 -0800 All reviewed patches have been landed. Closing bug. 172697 2012-11-06 18:56:38 -0800 2012-11-07 11:56:05 -0800 Patch 0001-Function-adoptNS-and-adoptCF-should-not-generate-mem.patch text/plain 3001 rdemarest RnJvbSAzZTRmYzNmZGEzMDViYmZlODYzMGQ3Mjg0MTA1Mjg1YjE4YTg4NGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW15IERlbWFyZXN0IDxyZGVtYXJlc3RAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDYgTm92IDIwMTIgMTg6NDM6MzAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGdW5j dGlvbiBhZG9wdE5TIGFuZCBhZG9wdENGIHNob3VsZCBub3QgZ2VuZXJhdGUgbWVtb3J5IGxlYWsK IGRpYWdub3N0aWMgd2l0aCBDbGFuZyBTdGF0aWMgQW5hbHl6ZXIuCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDIwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCkFkZCBhdHRyaWJ1dGVzIHRvIHRoZSBhZG9wdE5TIGFuZCBhZG9wdENGIGZ1bmN0aW9uIGFy Z3VtZW50cyB0byByZW1vdmUgQ2xhbmcgU3RhdGljIEFuYWx5emVyIGRpYWdub3RpY3MuCkRlZmlu ZXMgQ0ZfUkVMRUFTRVNfQVJHVU1FTlQgYW5kIE5TX1JFTEVBU0VTX0FSR1VNRU5UIGlmIG5vdCBh dmFpbGFibGUsIHVzZXMgaW4gZnVuY3Rpb24gZGVjbGFyYXRpb25zLgoKKiB3dGYvUmV0YWluUHRy Lmg6CihXVEY6OmFkb3B0Q0YpOiBBZGRzIENGX1JFTEVBU0VTX0FSR1VNRU5UIGF0dHJpYnV0ZSB0 byB0aGUgYXJndW1lbnQuCihXVEY6OmFkb3B0TlMpOiBBZGRzIE5TX1JFTEVBU0VTX0FSR1VNRU5U IGF0dHJpYnV0ZSB0byB0aGUgYXJndW1lbnQuCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAg ICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9SZXRhaW5QdHIuaCB8ICAg MTIgKysrKysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RG L0NoYW5nZUxvZwppbmRleCBlMjA0NjYzLi5hYTRkYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy MDEyLTExLTA2ICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4KKworICAgICAg ICBGdW5jdGlvbiBhZG9wdE5TIGFuZCBhZG9wdENGIHNob3VsZCBub3QgZ2VuZXJhdGUgbWVtb3J5 IGxlYWsgZGlhZ25vc3RpYyB3aXRoIENsYW5nIFN0YXRpYyBBbmFseXplci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTQyMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhdHRyaWJ1dGVzIHRvIHRo ZSBhZG9wdE5TIGFuZCBhZG9wdENGIGZ1bmN0aW9uIGFyZ3VtZW50cyB0byByZW1vdmUgQ2xhbmcg U3RhdGljIEFuYWx5emVyIGRpYWdub3RpY3MuCisgICAgICAgIERlZmluZXMgQ0ZfUkVMRUFTRVNf QVJHVU1FTlQgYW5kIE5TX1JFTEVBU0VTX0FSR1VNRU5UIGlmIG5vdCBhdmFpbGFibGUsIHVzZXMg aW4gZnVuY3Rpb24gZGVjbGFyYXRpb25zLgorCisgICAgICAgICogd3RmL1JldGFpblB0ci5oOgor ICAgICAgICAoV1RGOjphZG9wdENGKTogQWRkcyBDRl9SRUxFQVNFU19BUkdVTUVOVCBhdHRyaWJ1 dGUgdG8gdGhlIGFyZ3VtZW50LgorICAgICAgICAoV1RGOjphZG9wdE5TKTogQWRkcyBOU19SRUxF QVNFU19BUkdVTUVOVCBhdHRyaWJ1dGUgdG8gdGhlIGFyZ3VtZW50LgorCiAyMDEyLTExLTA2ICBC ZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBTcGVlZCB1 cCBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6bXVsdGlwbHkoKSBvbiBtb2Rlcm4gQVJNCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZXRhaW5QdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0 ci5oCmluZGV4IGIyZjJlOTQuLjcxMzkxZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Jl dGFpblB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCkBAIC0zNCw2ICszNCwx NCBAQAogI2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9uLmg+CiAjZW5kaWYKIAorI2lmbmRl ZiBDRl9SRUxFQVNFU19BUkdVTUVOVAorI2RlZmluZSBDRl9SRUxFQVNFU19BUkdVTUVOVAorI2Vu ZGlmCisKKyNpZm5kZWYgTlNfUkVMRUFTRVNfQVJHVU1FTlQKKyNkZWZpbmUgTlNfUkVMRUFTRVNf QVJHVU1FTlQKKyNlbmRpZgorCiBuYW1lc3BhY2UgV1RGIHsKIAogICAgIC8vIFVubGlrZSBtb3N0 IG1vc3Qgb2Ygb3VyIHNtYXJ0IHBvaW50ZXJzLCBSZXRhaW5QdHIgY2FuIHRha2UgZWl0aGVyIHRo ZSBwb2ludGVyIHR5cGUgb3IgdGhlIHBvaW50ZWQtdG8gdHlwZSwKQEAgLTI1NywxMyArMjY1LDEz IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICByZXR1cm4gYSAhPSBiLmdldCgpOyAKICAgICB9 CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IGFkb3B0Q0Yo VCkgV0FSTl9VTlVTRURfUkVUVVJOOworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBS ZXRhaW5QdHI8VD4gYWRvcHRDRihUIENGX1JFTEVBU0VTX0FSR1VNRU5UKSBXQVJOX1VOVVNFRF9S RVRVUk47CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0cjxUPiBhZG9w dENGKFQgbykKICAgICB7CiAgICAgICAgIHJldHVybiBSZXRhaW5QdHI8VD4oQWRvcHRDRiwgbyk7 CiAgICAgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0cjxUPiBh ZG9wdE5TKFQpIFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBp bmxpbmUgUmV0YWluUHRyPFQ+IGFkb3B0TlMoVCBOU19SRUxFQVNFU19BUkdVTUVOVCkgV0FSTl9V TlVTRURfUkVUVVJOOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBSZXRhaW5QdHI8 VD4gYWRvcHROUyhUIG8pCiAgICAgewogICAgICAgICByZXR1cm4gUmV0YWluUHRyPFQ+KEFkb3B0 TlMsIG8pOwotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykKCg== 172854 2012-11-07 11:56:05 -0800 2012-11-07 12:35:56 -0800 Patch 0001-Function-adoptNS-and-adoptCF-should-not-generate-mem.patch text/plain 3007 rdemarest RnJvbSAzZTRmYzNmZGEzMDViYmZlODYzMGQ3Mjg0MTA1Mjg1YjE4YTg4NGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW15IERlbWFyZXN0IDxyZGVtYXJlc3RAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDYgTm92IDIwMTIgMTg6NDM6MzAgLTA4MDAKU3ViamVjdDogW1BBVENIXSBGdW5j dGlvbiBhZG9wdE5TIGFuZCBhZG9wdENGIHNob3VsZCBub3QgZ2VuZXJhdGUgbWVtb3J5IGxlYWsK IGRpYWdub3N0aWMgd2l0aCBDbGFuZyBTdGF0aWMgQW5hbHl6ZXIuCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDIwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCkFkZCBhdHRyaWJ1dGVzIHRvIHRoZSBhZG9wdE5TIGFuZCBhZG9wdENGIGZ1bmN0aW9uIGFy Z3VtZW50cyB0byByZW1vdmUgQ2xhbmcgU3RhdGljIEFuYWx5emVyIGRpYWdub3RpY3MuCkRlZmlu ZSBDRl9SRUxFQVNFU19BUkdVTUVOVCBhbmQgTlNfUkVMRUFTRVNfQVJHVU1FTlQgaWYgbm90IGF2 YWlsYWJsZSwgdXNlIHRoZW0gaW4gZnVuY3Rpb24gZGVjbGFyYXRpb25zLgoKKiB3dGYvUmV0YWlu UHRyLmg6CihXVEY6OmFkb3B0Q0YpOiBBZGRzIENGX1JFTEVBU0VTX0FSR1VNRU5UIGF0dHJpYnV0 ZSB0byB0aGUgYXJndW1lbnQuCihXVEY6OmFkb3B0TlMpOiBBZGRzIE5TX1JFTEVBU0VTX0FSR1VN RU5UIGF0dHJpYnV0ZSB0byB0aGUgYXJndW1lbnQuCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cg ICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBTb3VyY2UvV1RGL3d0Zi9SZXRhaW5QdHIuaCB8 ICAgMTIgKysrKysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V1RGL0NoYW5nZUxvZwppbmRleCBlMjA0NjYzLi5hYTRkYzk0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTExLTA2ICBSZW15IERlbWFyZXN0ICA8cmRlbWFyZXN0QGFwcGxlLmNvbT4KKworICAg ICAgICBGdW5jdGlvbiBhZG9wdE5TIGFuZCBhZG9wdENGIHNob3VsZCBub3QgZ2VuZXJhdGUgbWVt b3J5IGxlYWsgZGlhZ25vc3RpYyB3aXRoIENsYW5nIFN0YXRpYyBBbmFseXplci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTQyMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhdHRyaWJ1dGVzIHRv IHRoZSBhZG9wdE5TIGFuZCBhZG9wdENGIGZ1bmN0aW9uIGFyZ3VtZW50cyB0byByZW1vdmUgQ2xh bmcgU3RhdGljIEFuYWx5emVyIGRpYWdub3RpY3MuCisgICAgICAgIERlZmluZSBDRl9SRUxFQVNF U19BUkdVTUVOVCBhbmQgTlNfUkVMRUFTRVNfQVJHVU1FTlQgaWYgbm90IGF2YWlsYWJsZSwgdXNl IHRoZW0gaW4gZnVuY3Rpb24gZGVjbGFyYXRpb25zLgorCisgICAgICAgICogd3RmL1JldGFpblB0 ci5oOgorICAgICAgICAoV1RGOjphZG9wdENGKTogQWRkcyBDRl9SRUxFQVNFU19BUkdVTUVOVCBh dHRyaWJ1dGUgdG8gdGhlIGFyZ3VtZW50LgorICAgICAgICAoV1RGOjphZG9wdE5TKTogQWRkcyBO U19SRUxFQVNFU19BUkdVTUVOVCBhdHRyaWJ1dGUgdG8gdGhlIGFyZ3VtZW50LgorCiAyMDEyLTEx LTA2ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBT cGVlZCB1cCBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6bXVsdGlwbHkoKSBvbiBtb2Rlcm4gQVJNCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZXRhaW5QdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1Jl dGFpblB0ci5oCmluZGV4IGIyZjJlOTQuLjcxMzkxZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL1JldGFpblB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oCkBAIC0zNCw2 ICszNCwxNCBAQAogI2ltcG9ydCA8Rm91bmRhdGlvbi9Gb3VuZGF0aW9uLmg+CiAjZW5kaWYKIAor I2lmbmRlZiBDRl9SRUxFQVNFU19BUkdVTUVOVAorI2RlZmluZSBDRl9SRUxFQVNFU19BUkdVTUVO VAorI2VuZGlmCisKKyNpZm5kZWYgTlNfUkVMRUFTRVNfQVJHVU1FTlQKKyNkZWZpbmUgTlNfUkVM RUFTRVNfQVJHVU1FTlQKKyNlbmRpZgorCiBuYW1lc3BhY2UgV1RGIHsKIAogICAgIC8vIFVubGlr ZSBtb3N0IG1vc3Qgb2Ygb3VyIHNtYXJ0IHBvaW50ZXJzLCBSZXRhaW5QdHIgY2FuIHRha2UgZWl0 aGVyIHRoZSBwb2ludGVyIHR5cGUgb3IgdGhlIHBvaW50ZWQtdG8gdHlwZSwKQEAgLTI1NywxMyAr MjY1LDEzIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICByZXR1cm4gYSAhPSBiLmdldCgpOyAK ICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IGFk b3B0Q0YoVCkgV0FSTl9VTlVTRURfUkVUVVJOOworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlu bGluZSBSZXRhaW5QdHI8VD4gYWRvcHRDRihUIENGX1JFTEVBU0VTX0FSR1VNRU5UKSBXQVJOX1VO VVNFRF9SRVRVUk47CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0cjxU PiBhZG9wdENGKFQgbykKICAgICB7CiAgICAgICAgIHJldHVybiBSZXRhaW5QdHI8VD4oQWRvcHRD Riwgbyk7CiAgICAgfQogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFJldGFpblB0 cjxUPiBhZG9wdE5TKFQpIFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBUPiBpbmxpbmUgUmV0YWluUHRyPFQ+IGFkb3B0TlMoVCBOU19SRUxFQVNFU19BUkdVTUVOVCkg V0FSTl9VTlVTRURfUkVUVVJOOwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBSZXRh aW5QdHI8VD4gYWRvcHROUyhUIG8pCiAgICAgewogICAgICAgICByZXR1cm4gUmV0YWluUHRyPFQ+ KEFkb3B0TlMsIG8pOwotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykKCg==