101411 2012-11-06 16:45:55 -0800 WeakBlocks should be HeapBlocks 2012-11-07 15:35:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 760205 0 mhahnenberg 2012-11-06 16:45:55 -0800 Currently WeakBlocks use fastMalloc memory. They are very similar to the other HeapBlocks, however, so we should change them to being allocated with the BlockAllocator. 760220 1 172679 mhahnenberg 2012-11-06 17:02:13 -0800 Created attachment 172679 Patch 761112 2 172679 webkit.review.bot 2012-11-07 15:34:59 -0800 Comment on attachment 172679 Patch Clearing flags on attachment: 172679 Committed r133812: <http://trac.webkit.org/changeset/133812> 761113 3 webkit.review.bot 2012-11-07 15:35:01 -0800 All reviewed patches have been landed. Closing bug. 172679 2012-11-06 17:02:13 -0800 2012-11-07 15:34:58 -0800 Patch bug-101411-20121106170025.patch text/plain 7178 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNjk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDEyLTExLTA2ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2Vha0Jsb2NrcyBzaG91bGQgYmUgSGVhcEJsb2NrcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNDExCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IFdlYWtCbG9ja3MgdXNl IGZhc3RNYWxsb2MgbWVtb3J5LiBUaGV5IGFyZSB2ZXJ5IHNpbWlsYXIgdG8gdGhlIG90aGVyIEhl YXBCbG9ja3MsIGhvd2V2ZXIsIAorICAgICAgICBzbyB3ZSBzaG91bGQgY2hhbmdlIHRoZW0gdG8g YmVpbmcgYWxsb2NhdGVkIHdpdGggdGhlIEJsb2NrQWxsb2NhdG9yLgorCisgICAgICAgICogaGVh cC9CbG9ja0FsbG9jYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJsb2NrQWxsb2NhdG9yOjpCbG9j a0FsbG9jYXRvcik6CisgICAgICAgICogaGVhcC9CbG9ja0FsbG9jYXRvci5oOiBBZGRlZCBhIG5l dyBSZWdpb25TZXQgZm9yIFdlYWtCbG9ja3MuCisgICAgICAgIChKU0MpOgorICAgICAgICAoQmxv Y2tBbGxvY2F0b3IpOgorICAgICAgICAoSlNDOjpXZWFrQmxvY2spOgorICAgICAgICAqIGhlYXAv SGVhcC5oOiBGcmllbmRlZCBXZWFrU2V0IHRvIGFsbG93IGFjY2VzcyB0byB0aGUgQmxvY2tBbGxv Y2F0b3IuCisgICAgICAgIChIZWFwKToKKyAgICAgICAgKiBoZWFwL1dlYWtCbG9jay5jcHA6Cisg ICAgICAgIChKU0M6OldlYWtCbG9jazo6Y3JlYXRlKTogUmVmYWN0b3JlZCB0byB1c2UgSGVhcEJs b2NrcyByYXRoZXIgdGhhbiBmYXN0TWFsbG9jLgorICAgICAgICAoSlNDOjpXZWFrQmxvY2s6Oldl YWtCbG9jayk6CisgICAgICAgICogaGVhcC9XZWFrQmxvY2suaDogQ2hhbmdlZCB0aGUgV2Vha0Js b2NrIHNpemUgdG8gNCBLQiBzbyB0aGF0IGl0IGRpdmlkZXMgZXZlbmx5IGludG8gdGhlIFJlZ2lv biBzaXplLgorICAgICAgICAoSlNDKToKKyAgICAgICAgKFdlYWtCbG9jayk6CisgICAgICAgICog aGVhcC9XZWFrU2V0LmNwcDoKKyAgICAgICAgKEpTQzo6V2Vha1NldDo6fldlYWtTZXQpOgorICAg ICAgICAoSlNDOjpXZWFrU2V0OjphZGRBbGxvY2F0b3IpOgorCiAyMDEyLTExLTA2ICBPbGl2ZXIg SHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIHBhcnNlciBvdmVyaGVh ZCBpbiBKU0MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Jsb2NrQWxsb2NhdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0FsbG9j YXRvci5jcHAJKHJldmlzaW9uIDEzMzY4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0Jsb2NrQWxsb2NhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogCiAj aW5jbHVkZSAiQ29waWVkQmxvY2suaCIKICNpbmNsdWRlICJNYXJrZWRCbG9jay5oIgorI2luY2x1 ZGUgIldlYWtCbG9jay5oIgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogCiBuYW1lc3Bh Y2UgSlNDIHsKQEAgLTM1LDYgKzM2LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiBCbG9ja0FsbG9jYXRv cjo6QmxvY2tBbGxvY2F0b3IoKQogICAgIDogbV9jb3BpZWRSZWdpb25TZXQoQ29waWVkQmxvY2s6 OmJsb2NrU2l6ZSkKICAgICAsIG1fbWFya2VkUmVnaW9uU2V0KE1hcmtlZEJsb2NrOjpibG9ja1Np emUpCisgICAgLCBtX3dlYWtSZWdpb25TZXQoV2Vha0Jsb2NrOjpibG9ja1NpemUpCiAgICAgLCBt X251bWJlck9mRW1wdHlSZWdpb25zKDApCiAgICAgLCBtX2lzQ3VycmVudGx5QWxsb2NhdGluZyhm YWxzZSkKICAgICAsIG1fYmxvY2tGcmVlaW5nVGhyZWFkU2hvdWxkUXVpdChmYWxzZSkKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Jsb2NrQWxsb2NhdG9yLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAkocmV2aXNpb24g MTMzNjg1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQmxvY2tBbGxvY2F0b3IuaAko d29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksNyBAQCBjbGFzcyBCbG9ja0FsbG9jYXRvcjsKIGNs YXNzIENvcGllZEJsb2NrOwogY2xhc3MgTWFya2VkQmxvY2s7CiBjbGFzcyBSZWdpb247CitjbGFz cyBXZWFrQmxvY2s7CiAKIC8vIFNpbXBsZSBhbGxvY2F0b3IgdG8gcmVkdWNlIFZNIGNvc3QgYnkg aG9sZGluZyBvbnRvIGJsb2NrcyBvZiBtZW1vcnkgZm9yCiAvLyBzaG9ydCBwZXJpb2RzIG9mIHRp bWUgYW5kIHRoZW4gZnJlZWluZyB0aGVtIG9uIGEgc2Vjb25kYXJ5IHRocmVhZC4KQEAgLTE4NCw2 ICsxODUsNyBAQCBwcml2YXRlOgogCiAgICAgUmVnaW9uU2V0IG1fY29waWVkUmVnaW9uU2V0Owog ICAgIFJlZ2lvblNldCBtX21hcmtlZFJlZ2lvblNldDsKKyAgICBSZWdpb25TZXQgbV93ZWFrUmVn aW9uU2V0OwogCiAgICAgRG91Ymx5TGlua2VkTGlzdDxSZWdpb24+IG1fZW1wdHlSZWdpb25zOwog ICAgIHNpemVfdCBtX251bWJlck9mRW1wdHlSZWdpb25zOwpAQCAtMzExLDYgKzMxMywxMiBAQCBp bmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBCiB9CiAKIHRlbXBsYXRlIDw+ CitpbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYgQmxvY2tBbGxvY2F0b3I6OnJlZ2lv blNldEZvcjxXZWFrQmxvY2s+KCkKK3sKKyAgICByZXR1cm4gbV93ZWFrUmVnaW9uU2V0OworfQor Cit0ZW1wbGF0ZSA8PgogaW5saW5lIEJsb2NrQWxsb2NhdG9yOjpSZWdpb25TZXQmIEJsb2NrQWxs b2NhdG9yOjpyZWdpb25TZXRGb3I8SGVhcEJsb2NrPENvcGllZEJsb2NrPiA+KCkKIHsKICAgICBy ZXR1cm4gbV9jb3BpZWRSZWdpb25TZXQ7CkBAIC0zMjIsNiArMzMwLDEyIEBAIGlubGluZSBCbG9j a0FsbG9jYXRvcjo6UmVnaW9uU2V0JiBCbG9ja0EKICAgICByZXR1cm4gbV9tYXJrZWRSZWdpb25T ZXQ7CiB9CiAKK3RlbXBsYXRlIDw+CitpbmxpbmUgQmxvY2tBbGxvY2F0b3I6OlJlZ2lvblNldCYg QmxvY2tBbGxvY2F0b3I6OnJlZ2lvblNldEZvcjxIZWFwQmxvY2s8V2Vha0Jsb2NrPiA+KCkKK3sK KyAgICByZXR1cm4gbV93ZWFrUmVnaW9uU2V0OworfQorCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4K IGlubGluZSBCbG9ja0FsbG9jYXRvcjo6UmVnaW9uU2V0JiBCbG9ja0FsbG9jYXRvcjo6cmVnaW9u U2V0Rm9yKCkKIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgJKHJldmlzaW9uIDEz MzY4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkod29ya2luZyBjb3B5 KQpAQCAtMTg4LDYgKzE4OCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBmcmllbmQgY2xh c3MgU2xvdFZpc2l0b3I7CiAgICAgICAgIGZyaWVuZCBjbGFzcyBJbmNyZW1lbnRhbFN3ZWVwZXI7 CiAgICAgICAgIGZyaWVuZCBjbGFzcyBIZWFwU3RhdGlzdGljczsKKyAgICAgICAgZnJpZW5kIGNs YXNzIFdlYWtTZXQ7CiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGZyaWVuZCB2b2lkKiBh bGxvY2F0ZUNlbGwoSGVhcCYpOwogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBmcmllbmQg dm9pZCogYWxsb2NhdGVDZWxsKEhlYXAmLCBzaXplX3QpOwogCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9XZWFrQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL1dlYWtCbG9jay5jcHAJKHJldmlzaW9uIDEzMzY4NSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL1dlYWtCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0LDE4 ICszNCwxNCBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAotV2Vha0Jsb2NrKiBXZWFrQmxvY2s6OmNy ZWF0ZSgpCitXZWFrQmxvY2sqIFdlYWtCbG9jazo6Y3JlYXRlKERlYWRCbG9jayogYmxvY2spCiB7 Ci0gICAgdm9pZCogYWxsb2NhdGlvbiA9IGZhc3RNYWxsb2MoYmxvY2tTaXplKTsKLSAgICByZXR1 cm4gbmV3IChOb3ROdWxsLCBhbGxvY2F0aW9uKSBXZWFrQmxvY2s7CisgICAgUmVnaW9uKiByZWdp b24gPSBibG9jay0+cmVnaW9uKCk7CisgICAgcmV0dXJuIG5ldyAoTm90TnVsbCwgYmxvY2spIFdl YWtCbG9jayhyZWdpb24pOwogfQogCi12b2lkIFdlYWtCbG9jazo6ZGVzdHJveShXZWFrQmxvY2sq IGJsb2NrKQotewotICAgIGZhc3RGcmVlKGJsb2NrKTsKLX0KLQotV2Vha0Jsb2NrOjpXZWFrQmxv Y2soKQorV2Vha0Jsb2NrOjpXZWFrQmxvY2soUmVnaW9uKiByZWdpb24pCisgICAgOiBIZWFwQmxv Y2s8V2Vha0Jsb2NrPihyZWdpb24pCiB7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB3ZWFr SW1wbENvdW50KCk7ICsraSkgewogICAgICAgICBXZWFrSW1wbCogd2Vha0ltcGwgPSAmd2Vha0lt cGxzKClbaV07CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrQmxvY2suaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrQmxvY2suaAkocmV2 aXNpb24gMTMzNjg1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha0Jsb2NrLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM0LDE0ICszNCwxNSBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAor Y2xhc3MgRGVhZEJsb2NrOwogY2xhc3MgSGVhcFJvb3RWaXNpdG9yOwogY2xhc3MgSlNWYWx1ZTsK IGNsYXNzIFdlYWtIYW5kbGVPd25lcjsKIAotY2xhc3MgV2Vha0Jsb2NrIDogcHVibGljIERvdWJs eUxpbmtlZExpc3ROb2RlPFdlYWtCbG9jaz4geworY2xhc3MgV2Vha0Jsb2NrIDogcHVibGljIEhl YXBCbG9jazxXZWFrQmxvY2s+IHsKIHB1YmxpYzoKICAgICBmcmllbmQgY2xhc3MgV1RGOjpEb3Vi bHlMaW5rZWRMaXN0Tm9kZTxXZWFrQmxvY2s+OwotICAgIHN0YXRpYyBjb25zdCBzaXplX3QgYmxv Y2tTaXplID0gMyAqIEtCOyAvLyA1JSBvZiBNYXJrZWRCbG9jayBzaXplCisgICAgc3RhdGljIGNv bnN0IHNpemVfdCBibG9ja1NpemUgPSA0ICogS0I7IC8vIDUlIG9mIE1hcmtlZEJsb2NrIHNpemUK IAogICAgIHN0cnVjdCBGcmVlQ2VsbCB7CiAgICAgICAgIEZyZWVDZWxsKiBuZXh0OwpAQCAtNTUs OCArNTYsNyBAQCBwdWJsaWM6CiAgICAgICAgIEZyZWVDZWxsKiBmcmVlTGlzdDsKICAgICB9Owog Ci0gICAgc3RhdGljIFdlYWtCbG9jayogY3JlYXRlKCk7Ci0gICAgc3RhdGljIHZvaWQgZGVzdHJv eShXZWFrQmxvY2sqKTsKKyAgICBzdGF0aWMgV2Vha0Jsb2NrKiBjcmVhdGUoRGVhZEJsb2NrKik7 CiAKICAgICBzdGF0aWMgV2Vha0ltcGwqIGFzV2Vha0ltcGwoRnJlZUNlbGwqKTsKIApAQCAtNzMs MTUgKzczLDEzIEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgc3RhdGljIEZyZWVDZWxsKiBhc0Zy ZWVDZWxsKFdlYWtJbXBsKik7CiAKLSAgICBXZWFrQmxvY2soKTsKKyAgICBXZWFrQmxvY2soUmVn aW9uKik7CiAgICAgV2Vha0ltcGwqIGZpcnN0V2Vha0ltcGwoKTsKICAgICB2b2lkIGZpbmFsaXpl KFdlYWtJbXBsKik7CiAgICAgV2Vha0ltcGwqIHdlYWtJbXBscygpOwogICAgIHNpemVfdCB3ZWFr SW1wbENvdW50KCk7CiAgICAgdm9pZCBhZGRUb0ZyZWVMaXN0KEZyZWVDZWxsKiosIFdlYWtJbXBs Kik7CiAKLSAgICBXZWFrQmxvY2sqIG1fcHJldjsKLSAgICBXZWFrQmxvY2sqIG1fbmV4dDsKICAg ICBTd2VlcFJlc3VsdCBtX3N3ZWVwUmVzdWx0OwogfTsKIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvV2Vha1NldC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvV2Vha1NldC5jcHAJKHJldmlzaW9uIDEzMzY4NSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL1dlYWtTZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBA IFdlYWtTZXQ6On5XZWFrU2V0KCkKICAgICBXZWFrQmxvY2sqIG5leHQgPSAwOwogICAgIGZvciAo V2Vha0Jsb2NrKiBibG9jayA9IG1fYmxvY2tzLmhlYWQoKTsgYmxvY2s7IGJsb2NrID0gbmV4dCkg ewogICAgICAgICBuZXh0ID0gYmxvY2stPm5leHQoKTsKLSAgICAgICAgV2Vha0Jsb2NrOjpkZXN0 cm95KGJsb2NrKTsKKyAgICAgICAgaGVhcCgpLT5ibG9ja0FsbG9jYXRvcigpLmRlYWxsb2NhdGUo V2Vha0Jsb2NrOjpkZXN0cm95KGJsb2NrKSk7CiAgICAgfQogICAgIG1fYmxvY2tzLmNsZWFyKCk7 CiB9CkBAIC03Myw3ICs3Myw3IEBAIFdlYWtCbG9jazo6RnJlZUNlbGwqIFdlYWtTZXQ6OnRyeUZp bmRBbGwKIAogV2Vha0Jsb2NrOjpGcmVlQ2VsbCogV2Vha1NldDo6YWRkQWxsb2NhdG9yKCkKIHsK LSAgICBXZWFrQmxvY2sqIGJsb2NrID0gV2Vha0Jsb2NrOjpjcmVhdGUoKTsKKyAgICBXZWFrQmxv Y2sqIGJsb2NrID0gV2Vha0Jsb2NrOjpjcmVhdGUoaGVhcCgpLT5ibG9ja0FsbG9jYXRvcigpLmFs bG9jYXRlPFdlYWtCbG9jaz4oKSk7CiAgICAgaGVhcCgpLT5kaWRBbGxvY2F0ZShXZWFrQmxvY2s6 OmJsb2NrU2l6ZSk7CiAgICAgbV9ibG9ja3MuYXBwZW5kKGJsb2NrKTsKICAgICBXZWFrQmxvY2s6 OlN3ZWVwUmVzdWx0IHN3ZWVwUmVzdWx0ID0gYmxvY2stPnRha2VTd2VlcFJlc3VsdCgpOwo=