101406 2012-11-06 16:01:18 -0800 Add API for touchEventHandlerRegion to WebLayer 2012-11-07 11:31:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yusufo yusufo abarth dglazkov fishd jamesr peter+ews tkent+wkapi webkit.review.bot yusufo oldest_to_newest 760148 0 yusufo 2012-11-06 16:01:18 -0800 Add API for touchEventHandlerRegion to WebLayer 760152 1 172669 yusufo 2012-11-06 16:04:11 -0800 Created attachment 172669 Patch 760155 2 webkit.review.bot 2012-11-06 16:07:16 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 760158 3 yusufo 2012-11-06 16:11:45 -0800 jamesr@ can you take a look at this when you get a chance? Thanks! 760163 4 172669 webkit.review.bot 2012-11-06 16:13:50 -0800 Comment on attachment 172669 Patch Attachment 172669 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14745487 760233 5 172669 peter+ews 2012-11-06 17:22:35 -0800 Comment on attachment 172669 Patch Attachment 172669 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14745506 760366 6 172669 jamesr 2012-11-06 21:17:09 -0800 Comment on attachment 172669 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172669&action=review > Source/Platform/chromium/public/WebLayer.h:194 > + virtual void setTouchEventHandlerRegion(const WebVector<WebRect>&) = 0; > + virtual WebVector<WebRect> touchEventHandlerRegion() const = 0; I would recommend that you not make these pure virtual, even though it's not consistent with the rest of the file. Having them be pure virtual is a pain when trying to land a two-side patch of this nature. Can you put this a few lines up next to setNonFastScrollable..()? there's a section there that has to do with input (setHaveWheel..., setShouldScroll..., setNonFast...) and I think this goes well with those 760367 7 172669 jamesr 2012-11-06 21:17:28 -0800 Comment on attachment 172669 Patch R=me with those minor issues fixed 760837 8 172830 yusufo 2012-11-07 10:28:27 -0800 Created attachment 172830 Patch 760875 9 yusufo 2012-11-07 10:50:45 -0800 jamesr@ can you put this on the CQ if it looks good? Thanks a lot! 760922 10 172830 webkit.review.bot 2012-11-07 11:31:44 -0800 Comment on attachment 172830 Patch Clearing flags on attachment: 172830 Committed r133787: <http://trac.webkit.org/changeset/133787> 760923 11 webkit.review.bot 2012-11-07 11:31:48 -0800 All reviewed patches have been landed. Closing bug. 172669 2012-11-06 16:04:11 -0800 2012-11-07 10:28:24 -0800 Patch bug-101406-20121106160223.patch text/plain 1611 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA5OGE3ZDhkMjMzMDJj NTFiNGQyMTY4MDM1ZDA4ZmZjZjBhNWMwZGQ0Li45NTMyNjI1ZWMyZDRkM2M0ZjU3N2M4YTViYWE2 ZTE5NDFlYWU1ZjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0wNiAg WXVzdWYgT3p1eXNhbCAgPHl1c3Vmb0Bnb29nbGUuY29tPgorCisgICAgICAgIEFkZCBBUEkgZm9y IHRvdWNoRXZlbnRIYW5kbGVyUmVnaW9uIHRvIFdlYkxheWVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSB3aWxsIGJlIHVzZWQgdG8ga2VlcCB0 cmFjayBvZiBKYXZhU2NyaXB0IHRvdWNoIGV2ZW50IGhhbmRsZXJzIGZyb20gdGhlIGNvbXBvc2l0 b3IgdGhyZWFkLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmg6CisgICAg ICAgIChXZWJMYXllcik6CisKIDIwMTItMTEtMDEgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xl YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gTWFrZSBXZWJMYXllclRyZWVW aWV3OjphZGp1c3RFdmVudFBvaW50Rm9yUGluY2hab29tIHB1cmUgdmlydHVhbC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaCBiL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaAppbmRleCA3ZWM1MTY1NTVlZDM5ZDgx ZWQwOTgyOWUzYmYyMTQzMDRkNDRmMGZmLi5lNTc4ZjVlNzQ5NzA2ODhkMTliZmZlNGY5ZTZhNGZl YzI3MGIyNmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dl YkxheWVyLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllci5o CkBAIC0xOTAsNiArMTkwLDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRGaXhlZFRv Q29udGFpbmVyTGF5ZXIoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgYm9vbCBmaXhlZFRvQ29udGFp bmVyTGF5ZXIoKSBjb25zdCA9IDA7CiAKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VG91Y2hFdmVudEhh bmRsZXJSZWdpb24oY29uc3QgV2ViVmVjdG9yPFdlYlJlY3Q+JikgPSAwOworICAgIHZpcnR1YWwg V2ViVmVjdG9yPFdlYlJlY3Q+IHRvdWNoRXZlbnRIYW5kbGVyUmVnaW9uKCkgY29uc3QgPSAwOwor CiAgICAgLy8gVGhlIHNjcm9sbCBjbGllbnQgaXMgbm90aWZpZWQgd2hlbiB0aGUgc2Nyb2xsIHBv c2l0aW9uIG9mIHRoZSBXZWJMYXllcgogICAgIC8vIGNoYW5nZXMuIE9ubHkgYSBzaW5nbGUgc2Ny b2xsIGNsaWVudCBjYW4gYmUgc2V0IGZvciBhIFdlYkxheWVyIGF0IGEgdGltZS4KICAgICAvLyBU aGUgV2ViTGF5ZXIgZG9lcyBub3QgdGFrZSBvd25lcnNoaXAgb2YgdGhlIHNjcm9sbCBjbGllbnQs IGFuZCBpdCBpcyB0aGUK 172830 2012-11-07 10:28:27 -0800 2012-11-07 11:31:44 -0800 Patch bug-101406-20121107102638.patch text/plain 1667 yusufo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBiZTYzM2Y4NmRlNmMx ZDg4ZWNjZmUxM2YyOTMzY2M1MDBjYjY0YzhhLi4xNDc1ZGRmYmZlMzI3YmZmYWQ3ZTMxNmEzOGFk NjY0YzBiMDhjYmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0wNyAg WXVzdWYgT3p1eXNhbCAgPHl1c3Vmb0Bnb29nbGUuY29tPgorCisgICAgICAgIEFkZCBBUEkgZm9y IHRvdWNoRXZlbnRIYW5kbGVyUmVnaW9uIHRvIFdlYkxheWVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE0MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSB3aWxsIGJlIHVzZWQgdG8ga2VlcCB0 cmFjayBvZiBKYXZhU2NyaXB0IHRvdWNoIGV2ZW50IGhhbmRsZXJzIGZyb20gdGhlIGNvbXBvc2l0 b3IgdGhyZWFkLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmg6CisgICAg ICAgIChXZWJLaXQ6OldlYkxheWVyOjpzZXRUb3VjaEV2ZW50SGFuZGxlclJlZ2lvbik6CisgICAg ICAgIChXZWJLaXQ6OldlYkxheWVyOjp0b3VjaEV2ZW50SGFuZGxlclJlZ2lvbik6CisgICAgICAg IChXZWJMYXllcik6CisKIDIwMTItMTEtMDEgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9lZ2VAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUHJvdmlkZSBXZWJLaXQgQVBJIGludGVy ZmFjZSBmb3IgcGxhdGZvcm0gZ2VzdHVyZSBjdXJ2ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXIuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViTGF5ZXIuaAppbmRleCA3ZWM1MTY1NTVlZDM5ZDgxZWQwOTgyOWUzYmYyMTQz MDRkNDRmMGZmLi4xZjg3ODExNDlmMjIyZGUxNzZkOWVkY2E1NWE3MDA5YjQxYTM1MjlmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyLmgKKysrIGIv U291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllci5oCkBAIC0xODQsNiArMTg0 LDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXROb25GYXN0U2Nyb2xsYWJsZVJlZ2lv bihjb25zdCBXZWJWZWN0b3I8V2ViUmVjdD4mKSA9IDA7CiAgICAgdmlydHVhbCBXZWJWZWN0b3I8 V2ViUmVjdD4gbm9uRmFzdFNjcm9sbGFibGVSZWdpb24oKSBjb25zdCA9IDA7CiAKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0VG91Y2hFdmVudEhhbmRsZXJSZWdpb24oY29uc3QgV2ViVmVjdG9yPFdlYlJl Y3Q+JikgeyB9OworICAgIHZpcnR1YWwgV2ViVmVjdG9yPFdlYlJlY3Q+IHRvdWNoRXZlbnRIYW5k bGVyUmVnaW9uKCkgY29uc3QgeyByZXR1cm4gV2ViVmVjdG9yPFdlYlJlY3Q+KCk7fQorCiAgICAg dmlydHVhbCB2b2lkIHNldElzQ29udGFpbmVyRm9yRml4ZWRQb3NpdGlvbkxheWVycyhib29sKSA9 IDA7CiAgICAgdmlydHVhbCBib29sIGlzQ29udGFpbmVyRm9yRml4ZWRQb3NpdGlvbkxheWVycygp IGNvbnN0ID0gMDsKIAo=