101405 2012-11-06 15:51:36 -0800 [CSS Exclusions] Changeset r133384 defeated the rectilinear polygon tests 2012-11-06 17:02:46 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 giles_joplin giles_joplin webkit.review.bot oldest_to_newest 760139 0 giles_joplin 2012-11-06 15:51:36 -0800 The patch from https://bugs.webkit.org/show_bug.cgi?id=100704, changeset r133384, failed to refactor the two rectilinear polygon tests: shape-inside-rectilinear-polygon-001.html and shape-inside-rectilinear-polygon-002.html. Both tests must now include the subpixel-utils.js. Currently both the tests and their expected HTML throw the same JS exception, so the reftests appear to "pass". 760149 1 172668 giles_joplin 2012-11-06 16:01:29 -0800 Created attachment 172668 Patch Corrected the tests. 760157 2 172668 krit 2012-11-06 16:10:20 -0800 Comment on attachment 172668 Patch LGTM. 760221 3 172668 webkit.review.bot 2012-11-06 17:02:42 -0800 Comment on attachment 172668 Patch Clearing flags on attachment: 172668 Committed r133697: <http://trac.webkit.org/changeset/133697> 760222 4 webkit.review.bot 2012-11-06 17:02:46 -0800 All reviewed patches have been landed. Closing bug. 172668 2012-11-06 16:01:29 -0800 2012-11-06 17:02:42 -0800 Patch tmp.patch text/plain 3551 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmYTRhY2VhLi4yMDE5NTZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTEt MDYgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBFeGNs dXNpb25zXSBDaGFuZ2VzZXQgcjEzMzM4NCBkZWZlYXRlZCB0aGUgcmVjdGlsaW5lYXIgcG9seWdv biB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAxNDA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiB0aGUgZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUgc3VicGl4ZWwgbGF5b3V0IEpTIGNvZGUg d2FzIHJlZmFjdG9yZWQsCisgICAgICAgIChzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMDcwNCkgdGhlc2UgdHdvIHRlc3RzIHdlcmUgbm90CisgICAgICAgIHBy b3Blcmx5IHVwZGF0ZWQuIFRoZXkgbm93IGluY2x1ZGUgc3VicGl4ZWwtdXRpbHMuanMsIHdoaWNo IHNpbXBsZS1wb2x5Z29uLmpzIGRlcGVuZHMgb24uCisKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lv bnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29uLTAwMS1leHBl Y3RlZC5odG1sOgorICAgICAgICAqIGZhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUt aW5zaWRlLXJlY3RpbGluZWFyLXBvbHlnb24tMDAxLmh0bWw6CisgICAgICAgICogZmFzdC9leGNs dXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcmVjdGlsaW5lYXItcG9seWdvbi0wMDIt ZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3No YXBlLWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29uLTAwMi5odG1sOgorCiAyMDEyLTExLTA2ICBK b3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgaHR0cC90ZXN0cy9p bnNwZWN0b3ItZW5hYmxlZC9keW5hbWljLXNjcmlwdHMuaHRtbCBpcyBmbGFrZXkKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRl LXJlY3RpbGluZWFyLXBvbHlnb24tMDAxLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29u LTAwMS1leHBlY3RlZC5odG1sCmluZGV4IDM3OTJkODcuLjk2YmU4MmEgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXJlY3Rp bGluZWFyLXBvbHlnb24tMDAxLWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9l eGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcmVjdGlsaW5lYXItcG9seWdvbi0w MDEtZXhwZWN0ZWQuaHRtbApAQCAtMSw2ICsxLDcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+ CiA8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvc3VicGl4ZWwtdXRpbHMuanMiPjwv c2NyaXB0PgogPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9zaW1wbGUtcG9seWdvbi5qcyI+PC9z Y3JpcHQ+CiA8c2NyaXB0PgogICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcmVj dGlsaW5lYXItcG9seWdvbi0wMDEuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9z aGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXJlY3RpbGluZWFyLXBvbHlnb24tMDAxLmh0bWwKaW5k ZXggOWM5NDc0Zi4uODhiNjUxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNp b25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcmVjdGlsaW5lYXItcG9seWdvbi0wMDEuaHRt bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWlu c2lkZS1yZWN0aWxpbmVhci1wb2x5Z29uLTAwMS5odG1sCkBAIC0xLDYgKzEsNyBAQAogPCFET0NU WVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9zdWJw aXhlbC11dGlscy5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3NpbXBs ZS1wb2x5Z29uLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CiAgICAgaWYgKHdpbmRvdy5pbnRlcm5h bHMpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRl L3NoYXBlLWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29uLTAwMi1leHBlY3RlZC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtcmVjdGls aW5lYXItcG9seWdvbi0wMDItZXhwZWN0ZWQuaHRtbAppbmRleCA3M2EzMDIzLi4zMzQwN2YwIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBl LWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29uLTAwMi1leHBlY3RlZC5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXJlY3RpbGlu ZWFyLXBvbHlnb24tMDAyLWV4cGVjdGVkLmh0bWwKQEAgLTEsNiArMSw3IEBACiA8IURPQ1RZUEUg aHRtbD4KIDxodG1sPgogPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3N1YnBpeGVs LXV0aWxzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvc2ltcGxlLXBv bHlnb24uanMiPjwvc2NyaXB0PgogPHNjcmlwdD4KICAgICBpZiAod2luZG93LmludGVybmFscykK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hh cGUtaW5zaWRlLXJlY3RpbGluZWFyLXBvbHlnb24tMDAyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2V4Y2x1c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1yZWN0aWxpbmVhci1wb2x5Z29u LTAwMi5odG1sCmluZGV4IDVjYjMxZTIuLjFhNjE0MjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLXJlY3RpbGluZWFyLXBv bHlnb24tMDAyLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWlu c2lkZS9zaGFwZS1pbnNpZGUtcmVjdGlsaW5lYXItcG9seWdvbi0wMDIuaHRtbApAQCAtMSw2ICsx LDcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9y ZXNvdXJjZXMvc3VicGl4ZWwtdXRpbHMuanMiPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9Ii4uL3Jl c291cmNlcy9zaW1wbGUtcG9seWdvbi5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgogICAgIGlmICh3 aW5kb3cuaW50ZXJuYWxzKQo=