101399 2012-11-06 14:33:51 -0800 [BlackBerry] Crash in InRegionScrollerPrivate 2012-11-12 10:44:43 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gmak rwlbuis mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 760057 0 gmak 2012-11-06 14:33:51 -0800 As the tin says 760068 1 172656 gmak 2012-11-06 14:45:41 -0800 Created attachment 172656 Patch 760074 2 172656 rwlbuis 2012-11-06 14:49:13 -0800 Comment on attachment 172656 Patch LGTM. 760114 3 172656 webkit.review.bot 2012-11-06 15:30:31 -0800 Comment on attachment 172656 Patch Clearing flags on attachment: 172656 Committed r133679: <http://trac.webkit.org/changeset/133679> 760115 4 webkit.review.bot 2012-11-06 15:30:34 -0800 All reviewed patches have been landed. Closing bug. 760628 5 172656 tonikitoo 2012-11-07 06:19:13 -0800 Comment on attachment 172656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172656&action=review Hi Gen! > Source/WebKit/blackberry/WebKitSupport/InRegionScrollableArea.cpp:65 > + // Add a pointer to the enclosing document as the pointer to layer or node along the way may become invalid. > + if (m_layer->enclosingElement()) > + m_document = m_layer->enclosingElement()->document(); > + do you know when that happens? where is it used? 760687 6 gmak 2012-11-07 07:36:59 -0800 Antonio - we had an unreproducable crash from our automatic bug logging system with a partial stack trace which ended here: BlackBerry::WebKit::WebPagePrivate::clearDocumentData (this=0x78b9d750, documentGoingAway=0x7a35aa38) 760719 7 172656 tonikitoo 2012-11-07 08:13:45 -0800 Comment on attachment 172656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172656&action=review > Source/WebKit/blackberry/Api/InRegionScroller.cpp:105 > ASSERT(scrollableArea); > - Node* node = scrollableArea->layer()->enclosingElement(); > - if (node && node->document() == documentGoingAway) > + if (scrollableArea->document() == documentGoingAway) maybe the fix could be test Node::isInDocument (what ever the name is) first instead. But ok, will leave it as is :) 764477 8 rwlbuis 2012-11-12 09:18:51 -0800 Reopening to attach new patch. 764478 9 173656 rwlbuis 2012-11-12 09:18:54 -0800 Created attachment 173656 Patch 764560 10 rwlbuis 2012-11-12 10:44:43 -0800 Committed r134256: <http://trac.webkit.org/changeset/134256> 172656 2012-11-06 14:45:41 -0800 2012-11-12 09:18:44 -0800 Patch 0001-2012-11-06-Genevieve-Mak-gmak-rim.com.patch text/plain 5431 gmak RnJvbSBhZmJkMmU2OGQ3YmM1OTNlN2MxMGUxYzJmMTgwOTUxNjE1M2I0MWI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFR1 ZSwgNiBOb3YgMjAxMiAxNzoyMzowNiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMTEtMDYg IEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CgogICAgICAgIFtCbGFja0JlcnJ5XSBDcmFz aCBpbiBJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZS4KICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzk5CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKICAgICAgICBBZGQgYSBwb2ludGVyIHRvIHRoZSBlbmNsb3NpbmcgZG9jdW1lbnQg YXMgdGhlIHBvaW50ZXIgdG8gbGF5ZXIKICAgICAgICBvciBub2RlIGFsb25nIHRoZSB3YXkgbWF5 IGJlY29tZSBpbnZhbGlkLgogICAgICAgIFVzZSBkb2N1bWVudCBwb2ludGVyIGluIGNsZWFyRG9j dW1lbnREYXRhLgogICAgICAgIFBSICMyMzg0NjkKCiAgICAgICAgKiBBcGkvSW5SZWdpb25TY3Jv bGxlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5SZWdpb25TY3JvbGxlclBy aXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKToKICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5SZWdp b25TY3JvbGxhYmxlQXJlYS5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5SZWdp b25TY3JvbGxhYmxlQXJlYTo6SW5SZWdpb25TY3JvbGxhYmxlQXJlYSk6CiAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6SW5SZWdpb25TY3JvbGxhYmxlQXJlYTo6ZG9jdW1lbnQpOgogICAgICAg IChXZWJLaXQpOgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFibGVBcmVh Lmg6CiAgICAgICAgKFdlYkNvcmUpOgogICAgICAgIChJblJlZ2lvblNjcm9sbGFibGVBcmVhKToK LS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwICB8 ICAgIDMgKy0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysKIC4uLi9XZWJLaXRTdXBwb3J0L0luUmVn aW9uU2Nyb2xsYWJsZUFyZWEuY3BwICAgICAgIHwgICAxMiArKysrKysrKysrKwogLi4uL1dlYktp dFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5oICAgICAgICAgfCAgICAzICsrKwogNCBm aWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCmluZGV4IGMw YzAzNjUuLmRiNjU2YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv SW5SZWdpb25TY3JvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9J blJlZ2lvblNjcm9sbGVyLmNwcApAQCAtMTAyLDggKzEwMiw3IEBAIHZvaWQgSW5SZWdpb25TY3Jv bGxlclByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKGNvbnN0IERvY3VtZW50KiBkb2N1bWVudEdv aW5nQXdhCiAKICAgICBJblJlZ2lvblNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSA9IHN0 YXRpY19jYXN0PEluUmVnaW9uU2Nyb2xsYWJsZUFyZWEqPihtX2FjdGl2ZUluUmVnaW9uU2Nyb2xs YWJsZUFyZWFzWzBdKTsKICAgICBBU1NFUlQoc2Nyb2xsYWJsZUFyZWEpOwotICAgIE5vZGUqIG5v ZGUgPSBzY3JvbGxhYmxlQXJlYS0+bGF5ZXIoKS0+ZW5jbG9zaW5nRWxlbWVudCgpOwotICAgIGlm IChub2RlICYmIG5vZGUtPmRvY3VtZW50KCkgPT0gZG9jdW1lbnRHb2luZ0F3YXkpCisgICAgaWYg KHNjcm9sbGFibGVBcmVhLT5kb2N1bWVudCgpID09IGRvY3VtZW50R29pbmdBd2F5KQogICAgICAg ICByZXNldCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCAzYmM0YTVl Li5kMjA4MWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBA QAorMjAxMi0xMS0wNiAgR2VuZXZpZXZlIE1hayAgPGdtYWtAcmltLmNvbT4KKworICAgICAgICBb QmxhY2tCZXJyeV0gQ3Jhc2ggaW4gSW5SZWdpb25TY3JvbGxlclByaXZhdGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEzOTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBwb2ludGVyIHRvIHRo ZSBlbmNsb3NpbmcgZG9jdW1lbnQgYXMgdGhlIHBvaW50ZXIgdG8gbGF5ZXIKKyAgICAgICAgb3Ig bm9kZSBhbG9uZyB0aGUgd2F5IG1heSBiZWNvbWUgaW52YWxpZC4KKyAgICAgICAgVXNlIGRvY3Vt ZW50IHBvaW50ZXIgaW4gY2xlYXJEb2N1bWVudERhdGEuCisgICAgICAgIFBSICMyMzg0NjkKKwor ICAgICAgICAqIEFwaS9JblJlZ2lvblNjcm9sbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6SW5SZWdpb25TY3JvbGxlclByaXZhdGU6OmNsZWFyRG9jdW1lbnREYXRhKToKKyAg ICAgICAgKiBXZWJLaXRTdXBwb3J0L0luUmVnaW9uU2Nyb2xsYWJsZUFyZWEuY3BwOgorICAgICAg ICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGFibGVBcmVhOjpJblJlZ2lvblNj cm9sbGFibGVBcmVhKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5SZWdpb25TY3Jv bGxhYmxlQXJlYTo6ZG9jdW1lbnQpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBXZWJL aXRTdXBwb3J0L0luUmVnaW9uU2Nyb2xsYWJsZUFyZWEuaDoKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAoSW5SZWdpb25TY3JvbGxhYmxlQXJlYSk6CisKIDIwMTItMTEtMDUgIEdlbmV2aWV2 ZSBNYWsgIDxnbWFrQHJpbS5jb20+CiAKICAgICAgICAgW0JMQUNLQkVSUlldIFVwZGF0ZSB0b3Vj aCBjb2RlIHRvIHJlZmxlY3QgdG91Y2ggcmVmYWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0luUmVnaW9uU2Nyb2xsYWJsZUFyZWEuY3BwIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxl QXJlYS5jcHAKaW5kZXggNWI0NjM2ZC4uNDQzZGI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxh YmxlQXJlYS5jcHAKQEAgLTE5LDYgKzE5LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJJblJlZ2lvblNjcm9sbGFibGVBcmVhLmgiCiAKKyNpbmNsdWRlICJEb2N1bWVudC5oIgog I2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiTGF5ZXJXZWJLaXRUaHJlYWQuaCIKICNpbmNs dWRlICJJblJlZ2lvblNjcm9sbGVyX3AuaCIKQEAgLTUyLDExICs1MywxNiBAQCBJblJlZ2lvblNj cm9sbGFibGVBcmVhOjpJblJlZ2lvblNjcm9sbGFibGVBcmVhKFdlYlBhZ2VQcml2YXRlKiB3ZWJQ YWdlLCBSZW5kZXJMYQogICAgIDogbV93ZWJQYWdlKHdlYlBhZ2UpCiAgICAgLCBtX2xheWVyKGxh eWVyKQogICAgICwgbV9oYXNXaW5kb3dWaXNpYmxlUmVjdENhbGN1bGF0ZWQoZmFsc2UpCisgICAg LCBtX2RvY3VtZW50KDApCiB7CiAgICAgQVNTRVJUKHdlYlBhZ2UpOwogICAgIEFTU0VSVChsYXll cik7CiAgICAgbV9pc051bGwgPSBmYWxzZTsKIAorICAgIC8vIEFkZCBhIHBvaW50ZXIgdG8gdGhl IGVuY2xvc2luZyBkb2N1bWVudCBhcyB0aGUgcG9pbnRlciB0byBsYXllciBvciBub2RlIGFsb25n IHRoZSB3YXkgbWF5IGJlY29tZSBpbnZhbGlkLgorICAgIGlmIChtX2xheWVyLT5lbmNsb3NpbmdF bGVtZW50KCkpCisgICAgICAgIG1fZG9jdW1lbnQgPSBtX2xheWVyLT5lbmNsb3NpbmdFbGVtZW50 KCktPmRvY3VtZW50KCk7CisKICAgICAvLyBGSVhNRTogQWRkIGFuIEFTU0VSVCBoZXJlIGFzIHRo ZSAnbGF5ZXInIG11c3QgYmUgc2Nyb2xsYWJsZS4KIAogICAgIFJlbmRlck9iamVjdCogbGF5ZXJS ZW5kZXJlciA9IGxheWVyLT5yZW5kZXJlcigpOwpAQCAtMTM5LDUgKzE0NSwxMSBAQCBSZW5kZXJM YXllciogSW5SZWdpb25TY3JvbGxhYmxlQXJlYTo6bGF5ZXIoKSBjb25zdAogICAgIHJldHVybiBt X2xheWVyOwogfQogCitEb2N1bWVudCogSW5SZWdpb25TY3JvbGxhYmxlQXJlYTo6ZG9jdW1lbnQo KSBjb25zdAoreworICAgIEFTU0VSVCghbV9pc051bGwpOworICAgIHJldHVybiBtX2RvY3VtZW50 OworfQorCiB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFibGVBcmVhLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFibGVBcmVhLmgKaW5kZXggNDQzYjk0Zi4u MzFmY2I5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0luUmVnaW9uU2Nyb2xsYWJsZUFyZWEuaApAQCAtMjQsNiArMjQsNyBA QAogI2luY2x1ZGUgPGludGVyYWN0aW9uL1Njcm9sbFZpZXdCYXNlLmg+CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKK2NsYXNzIERvY3VtZW50OwogY2xhc3MgTGF5ZXJXZWJLaXRUaHJlYWQ7CiBjbGFz cyBOb2RlOwogY2xhc3MgUmVuZGVyTGF5ZXI7CkBAIC00NSwxMCArNDYsMTIgQEAgcHVibGljOgog ICAgIFBsYXRmb3JtOjpJbnRSZWN0IHZpc2libGVXaW5kb3dSZWN0KCkgY29uc3Q7CiAKICAgICBX ZWJDb3JlOjpSZW5kZXJMYXllciogbGF5ZXIoKSBjb25zdDsKKyAgICBXZWJDb3JlOjpEb2N1bWVu dCogZG9jdW1lbnQoKSBjb25zdDsKIAogcHJpdmF0ZToKICAgICBXZWJQYWdlUHJpdmF0ZSogbV93 ZWJQYWdlOwogICAgIFdlYkNvcmU6OlJlbmRlckxheWVyKiBtX2xheWVyOworICAgIFdlYkNvcmU6 OkRvY3VtZW50KiBtX2RvY3VtZW50OwogCiAgICAgLy8gV2UgZWl0aGVyIGNhY2hlIG9uZSBoZXJl OiBpbiBjYXNlIG9mIGEgY29tcG9zaXRlZCBzY3JvbGxhYmxlIGxheWVyCiAgICAgLy8gY2FjaGUg dGhlIExheWVyV2ViS2l0VGhyZWFkLiBPdGhlcndpc2UsIHRoZSBOb2RlLgotLSAKMS43LjEwLjIg KEFwcGxlIEdpdC0zMykKCg== 173656 2012-11-12 09:18:54 -0800 2012-11-12 09:26:40 -0800 Patch bug-101399-20121112131647.patch text/plain 1583 rwlbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5ZmRlOGFmOGZmYThhYmZiMWE1MjI3ZWIwODBkYjk3ZmJlN2JhMDFhLi4zYjBmNTZiOWRj YjlkNDk3NTNkNjYwMTNhYWM1NjE0OTI2M2I3Y2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0xMiAgUm9iIEJ1aXMgIDxyYnVpc0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDcmFzaCBpbiBJblJlZ2lvblNjcm9sbGVyUHJp dmF0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MTM5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCB3YXJuaW5nIGNhdXNlZCBieSB0aGUgcHJldmlvdXMgcGF0Y2ggZm9yIHRoaXMgYnVnIChyMTMz Njc5KS4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Nyb2xsYWJsZUFyZWE6 OkluUmVnaW9uU2Nyb2xsYWJsZUFyZWEpOgorCiAyMDEyLTExLTA3ICBSb2IgQnVpcyAgPHJidWlz QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSBzZXRVc2VyU3R5bGVTaGVl dFN0cmluZy91c2VyU3R5bGVTaGVldFN0cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5SZWdpb25TY3JvbGxhYmxlQXJlYS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFibGVBcmVh LmNwcAppbmRleCA0NDNkYjhiOGNlYjA0N2FiYTQ3M2VhOTgyNTFlMmViYTVhZDRiNjgzLi40M2Ri ZGU4ODc1MTg3NjhjZTQ0MmUyOTNlNGJhM2VlOTMxZDg1Yzc0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNjcm9sbGFibGVBcmVhLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JblJlZ2lvblNj cm9sbGFibGVBcmVhLmNwcApAQCAtNTIsOCArNTIsOCBAQCBJblJlZ2lvblNjcm9sbGFibGVBcmVh Ojp+SW5SZWdpb25TY3JvbGxhYmxlQXJlYSgpCiBJblJlZ2lvblNjcm9sbGFibGVBcmVhOjpJblJl Z2lvblNjcm9sbGFibGVBcmVhKFdlYlBhZ2VQcml2YXRlKiB3ZWJQYWdlLCBSZW5kZXJMYXllciog bGF5ZXIpCiAgICAgOiBtX3dlYlBhZ2Uod2ViUGFnZSkKICAgICAsIG1fbGF5ZXIobGF5ZXIpCi0g ICAgLCBtX2hhc1dpbmRvd1Zpc2libGVSZWN0Q2FsY3VsYXRlZChmYWxzZSkKICAgICAsIG1fZG9j dW1lbnQoMCkKKyAgICAsIG1faGFzV2luZG93VmlzaWJsZVJlY3RDYWxjdWxhdGVkKGZhbHNlKQog ewogICAgIEFTU0VSVCh3ZWJQYWdlKTsKICAgICBBU1NFUlQobGF5ZXIpOwo=