101392 2012-11-06 14:07:57 -0800 [EFL] Simplify the build system 2012-11-06 16:59:27 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim heejin.r.chung kenneth lucas.de.marchi ostap73 rakuco webkit.review.bot yael oldest_to_newest 760030 0 laszlo.gombos 2012-11-06 14:07:57 -0800 Remove unused cmake variables, refactor build flags. 760047 1 172648 laszlo.gombos 2012-11-06 14:23:47 -0800 Created attachment 172648 1st try 760065 2 172648 rakuco 2012-11-06 14:41:51 -0800 Comment on attachment 172648 1st try Looks good, I guess. These things are not enabled by default so they are not really tested by the EWS, but if you guys who are working on it say it's OK it's probably fine :-) 760104 3 172648 yael 2012-11-06 15:19:58 -0800 Comment on attachment 172648 1st try View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review > Source/cmake/OptionsEfl.cmake:178 > - SET(WTF_USE_ACCELERATED_COMPOSITING 1) > ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1) Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ? > Source/cmake/OptionsEfl.cmake:180 > - SET(WTF_USE_COORDINATED_GRAPHICS 1) > ADD_DEFINITIONS(-DWTF_USE_COORDINATED_GRAPHICS=1) ditto 760110 4 172648 webkit.review.bot 2012-11-06 15:25:46 -0800 Comment on attachment 172648 1st try Clearing flags on attachment: 172648 Committed r133678: <http://trac.webkit.org/changeset/133678> 760111 5 webkit.review.bot 2012-11-06 15:25:50 -0800 All reviewed patches have been landed. Closing bug. 760189 6 laszlo.gombos 2012-11-06 16:29:53 -0800 (In reply to comment #3) > (From update of attachment 172648 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review > > > Source/cmake/OptionsEfl.cmake:178 > > - SET(WTF_USE_ACCELERATED_COMPOSITING 1) > > ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1) > > Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ? At the moment WTF_USE_ACCELERATED_COMPOSITING is only enabled in OptionsEfl.cmake for EFL. I agree in that once we enable WTF_USE_ACCELERATED_COMPOSITING by default for EFL, it is best to do it in Platform.h and not in OptionsEfl.cmake. /* Accelerated compositing */ -#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) Until this change is not made, we still need the above line in OptionsEfl.cmake. 760215 7 yael 2012-11-06 16:59:27 -0800 (In reply to comment #6) > (In reply to comment #3) > > (From update of attachment 172648 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=172648&action=review > > > > > Source/cmake/OptionsEfl.cmake:178 > > > - SET(WTF_USE_ACCELERATED_COMPOSITING 1) > > > ADD_DEFINITIONS(-DWTF_USE_ACCELERATED_COMPOSITING=1) > > > > Is this still needed after WTF_USE_ACCELERATED_COMPOSITING was moved to platform.h ? > > At the moment WTF_USE_ACCELERATED_COMPOSITING is only enabled in OptionsEfl.cmake for EFL. > > I agree in that once we enable WTF_USE_ACCELERATED_COMPOSITING by default for EFL, it is best to do it in Platform.h and not in OptionsEfl.cmake. > > /* Accelerated compositing */ > -#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) > +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(QT) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) > > Until this change is not made, we still need the above line in OptionsEfl.cmake. My bad. I thought your other patch changed that . 172648 2012-11-06 14:23:47 -0800 2012-11-06 15:25:45 -0800 1st try 101392.patch text/plain 2938 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzY3 MCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEx LTA2ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU2ltcGxpZnkgdGhlIGJ1aWxkIHN5c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBjbWFrZSB2YXJpYWJsZXMuIEluIGFk ZGl0aW9uIHRoZXJlIGlzIG5vIGxvbmdlciBhIG5lZWQgdG8gZGVmaW5lIAorICAgICAgICBXVEZf VVNFX1RFWFRVUkVfTUFQUEVSX0dMIGluIHRoZSBidWlsZCBzeXN0ZW0gYXMgdGhhdCBpcyBub3cg aGFuZGxlZCBpbiBQbGF0Zm9ybS5oCisgICAgICAgIChzZWUgcjEzMzYyMykuCisKKyAgICAgICAg KiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0xMS0wNSAgU2ltb24gSGF1 c21hbm4gIDxzaW1vbi5oYXVzbWFubkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBUcml2aWFs IHVucmV2aWV3ZWQ6IEFkZCBtaXNzaW5nIG1vZHVsZSBkZXBlbmRlbmNpZXMgZm9yIGJ1aWxkcyBp biBRdCBDSSBzeXN0ZW0uCkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNjcwKQorKysgU291cmNl L1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0x MS0wNiAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtF RkxdIFNpbXBsaWZ5IHRoZSBidWlsZCBzeXN0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTM5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBXVEZfVVNFXzNEX0dSQVBISUNTIHRvIGd1YXJkIHRo ZSBpbmNsdXNpb24gb2Ygc3VyZmFjZXMgYW5kIHRleHRtYXAgCisgICAgICAgIGRpcmVjdG9yaWVz IHVuZGVyIFdlYkNvcmUvZ3JhcGhpY3MgdG8gYmUgY29uc2lzdGVudCB3aXRoIAorICAgICAgICBX ZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlLgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6 CisKIDIwMTItMTEtMDQgIEhhbHRvbiBIdW8gIDxoYWx0b24uaHVvQGludGVsLmNvbT4KIAogICAg ICAgICBbRUZMXSBVc2UgX0xJQlJBUklFUyBpbnN0ZWFkIG9mIF9MSUJSQVJZCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtRWZsLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv UGxhdGZvcm1FZmwuY21ha2UJKHJldmlzaW9uIDEzMzY0MikKKysrIFNvdXJjZS9XZWJLaXQvUGxh dGZvcm1FZmwuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTc5LDcgKzc5LDcgQEAgSUYgKEVOQUJM RV9OQVZJR0FUT1JfQ09OVEVOVF9VVElMUykKICAgKQogRU5ESUYgKCkKIAotSUYgKFdURl9VU0Vf VEVYVFVSRV9NQVBQRVJfR0wpCitJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgTElTVChBUFBF TkQgV2ViS2l0X0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZv cm0vZ3JhcGhpY3Mvc3VyZmFjZXMiCiAgICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcCIKSW5kZXg6IFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCShyZXZpc2lvbiAxMzM2NDIpCisr KyBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTc1LDE4 ICsxNzUsMTMgQEAgRU5ESUYgKCkKIFNFVChDUEFDS19TT1VSQ0VfR0VORVJBVE9SIFRCWjIpCiAK IElGIChXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUpCi0gIFNFVChXVEZfVVNFX0FDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HIDEpCiAgIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfQUNDRUxFUkFU RURfQ09NUE9TSVRJTkc9MSkKIAotICBTRVQoV1RGX1VTRV9DT09SRElOQVRFRF9HUkFQSElDUyAx KQogICBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX0NPT1JESU5BVEVEX0dSQVBISUNTPTEpCiAK ICAgU0VUKFdURl9VU0VfVEVYVFVSRV9NQVBQRVIgMSkKICAgQUREX0RFRklOSVRJT05TKC1EV1RG X1VTRV9URVhUVVJFX01BUFBFUj0xKQogCi0gIFNFVChXVEZfVVNFX1RFWFRVUkVfTUFQUEVSX0dM IDEpCi0gIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfVEVYVFVSRV9NQVBQRVJfR0w9MSkKLQog ICBTRVQoV1RGX1VTRV8zRF9HUkFQSElDUyAxKQogICBBRERfREVGSU5JVElPTlMoLURXVEZfVVNF XzNEX0dSQVBISUNTPTEpCiAKQEAgLTE5NCw3ICsxODksNiBAQCBJRiAoV1RGX1VTRV9USUxFRF9C QUNLSU5HX1NUT1JFKQogICBBRERfREVGSU5JVElPTlMoLURFTkFCTEVfM0RfUkVOREVSSU5HPTEp CiAKICAgU0VUIChFTkFCTEVfV0VCR0wgMSkKLSAgU0VUIChXVEZfVVNFX0dSQVBISUNTX1NVUkZB Q0UgMSkKICAgQUREX0RFRklOSVRJT05TKC1EV1RGX1VTRV9HUkFQSElDU19TVVJGQUNFPTEpCiAg IEFERF9ERUZJTklUSU9OUygtREhBVkVfR0xYKQogCg==