101391 2012-11-06 13:57:20 -0800 Reduce direct m_symbolTable usage in CodeBlock 2012-11-06 14:06:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 760017 0 oliver 2012-11-06 13:57:20 -0800 Reduce direct m_symbolTable usage in CodeBlock 760018 1 172644 oliver 2012-11-06 13:57:43 -0800 Created attachment 172644 Patch 760020 2 172645 oliver 2012-11-06 13:59:25 -0800 Created attachment 172645 Patch 760029 3 oliver 2012-11-06 14:06:08 -0800 Committed r133669: <http://trac.webkit.org/changeset/133669> 172644 2012-11-06 13:57:43 -0800 2012-11-06 13:59:24 -0800 Patch bug-101391-20121106135555.patch text/plain 3597 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NTNjZDFlNDVjYTI5ZGI2NjExYWNiMDIxMGUyNThiZDAyNjE5OWJjLi5lNTFkNDU2NDdmNDU4NDg2 MGZjOWM0OGY2MjY0ZDAzODBjZDI5NmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0xMS0wNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJlZHVjZSBkaXJlY3QgbV9zeW1ib2xUYWJsZSB1c2FnZSBpbiBDb2RlQmxvY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTM5MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsZSBy ZWZhY3RvcmluZy4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAg IChKU0M6OkNvZGVCbG9jazo6ZHVtcCk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZHVtcFN0 YXRpc3RpY3MpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6Om5hbWVGb3JSZWdpc3Rlcik6Cisg ICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6 aXNDYXB0dXJlZCk6CisKIDIwMTItMTEtMDUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNv bT4KIAogICAgICAgICBJbmRlbnRhdGlvbiBvZiBKU09iamVjdC5oIGlzIHdyb25nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCmluZGV4IDU4ZDM4MDc3MjA3 ODc4YjI3ZDYxZWM0MjM1Nzk4OGM2YWQxOThhZGEuLjI0Zjc0N2E5YzcyOWNmMGNhZjU4M2E2YTdj MmNmYzdkNDNjM2ViZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Db2RlQmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCkBAIC00OTIsOCArNDkyLDggQEAgdm9pZCBDb2RlQmxvY2s6OmR1bXAoRXhlY1N0 YXRlKiBleGVjKQogICAgICAgICBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nPihpbnN0cnVjdGlv bnMoKS5zaXplKCkgKiBzaXplb2YoSW5zdHJ1Y3Rpb24pKSwKICAgICAgICAgdGhpcywgY29kZVR5 cGVUb1N0cmluZyhjb2RlVHlwZSgpKSwgbV9udW1QYXJhbWV0ZXJzLCBtX251bUNhbGxlZVJlZ2lz dGVycywKICAgICAgICAgbV9udW1WYXJzKTsKLSAgICBpZiAobV9zeW1ib2xUYWJsZS0+Y2FwdHVy ZUNvdW50KCkpCi0gICAgICAgIGRhdGFMb2coIjsgJWQgY2FwdHVyZWQgdmFyKHMpIiwgbV9zeW1i b2xUYWJsZS0+Y2FwdHVyZUNvdW50KCkpOworICAgIGlmIChzeW1ib2xUYWJsZSgpLT5jYXB0dXJl Q291bnQoKSkKKyAgICAgICAgZGF0YUxvZygiOyAlZCBjYXB0dXJlZCB2YXIocykiLCBzeW1ib2xU YWJsZSgpLT5jYXB0dXJlQ291bnQoKSk7CiAgICAgaWYgKHVzZXNBcmd1bWVudHMoKSkgewogICAg ICAgICBkYXRhTG9nKAogICAgICAgICAgICAgIjsgdXNlcyBhcmd1bWVudHMsIGluIHIlZCwgciVk IiwKQEAgLTE0OTEsOSArMTQ5MSw5IEBAIHZvaWQgQ29kZUJsb2NrOjpkdW1wU3RhdGlzdGljcygp CiAgICAgICAgICAgICBGT1JfRUFDSF9NRU1CRVJfVkVDVE9SKEdFVF9TVEFUUykKICAgICAgICAg I3VuZGVmIEdFVF9TVEFUUwogCi0gICAgICAgIGlmICghY29kZUJsb2NrLT5tX3N5bWJvbFRhYmxl LmlzRW1wdHkoKSkgeworICAgICAgICBpZiAoIWNvZGVCbG9jay0+c3ltYm9sVGFibGUoKS5pc0Vt cHR5KCkpIHsKICAgICAgICAgICAgIHN5bWJvbFRhYmxlSXNOb3RFbXB0eSsrOwotICAgICAgICAg ICAgc3ltYm9sVGFibGVUb3RhbFNpemUgKz0gKGNvZGVCbG9jay0+bV9zeW1ib2xUYWJsZS5jYXBh Y2l0eSgpICogKHNpemVvZihTeW1ib2xUYWJsZTo6S2V5VHlwZSkgKyBzaXplb2YoU3ltYm9sVGFi bGU6Ok1hcHBlZFR5cGUpKSk7CisgICAgICAgICAgICBzeW1ib2xUYWJsZVRvdGFsU2l6ZSArPSAo Y29kZUJsb2NrLT5zeW1ib2xUYWJsZSgpLmNhcGFjaXR5KCkgKiAoc2l6ZW9mKFN5bWJvbFRhYmxl OjpLZXlUeXBlKSArIHNpemVvZihTeW1ib2xUYWJsZTo6TWFwcGVkVHlwZSkpKTsKICAgICAgICAg fQogCiAgICAgICAgIGlmIChjb2RlQmxvY2stPm1fcmFyZURhdGEpIHsKQEAgLTI4MDcsOCArMjgw Nyw4IEBAIGJvb2wgQ29kZUJsb2NrOjp1c2VzT3Bjb2RlKE9wY29kZUlEIG9wY29kZUlEKQogCiBT dHJpbmcgQ29kZUJsb2NrOjpuYW1lRm9yUmVnaXN0ZXIoaW50IHJlZ2lzdGVyTnVtYmVyKQogewot ICAgIFN5bWJvbFRhYmxlOjppdGVyYXRvciBlbmQgPSBtX3N5bWJvbFRhYmxlLT5lbmQoKTsKLSAg ICBmb3IgKFN5bWJvbFRhYmxlOjppdGVyYXRvciBwdHIgPSBtX3N5bWJvbFRhYmxlLT5iZWdpbigp OyBwdHIgIT0gZW5kOyArK3B0cikgeworICAgIFN5bWJvbFRhYmxlOjppdGVyYXRvciBlbmQgPSBz eW1ib2xUYWJsZSgpLT5lbmQoKTsKKyAgICBmb3IgKFN5bWJvbFRhYmxlOjppdGVyYXRvciBwdHIg PSBzeW1ib2xUYWJsZSgpLT5iZWdpbigpOyBwdHIgIT0gZW5kOyArK3B0cikgewogICAgICAgICBp ZiAocHRyLT52YWx1ZS5nZXRJbmRleCgpID09IHJlZ2lzdGVyTnVtYmVyKQogICAgICAgICAgICAg cmV0dXJuIFN0cmluZyhwdHItPmtleSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0NvZGVCbG9jay5oCmluZGV4IGQ0MTkzMjNhMGNkNDEwMDU4YmE2MDg0ZmM4MzE3NTg3 ODRmMzI5MzYuLjdmYjNjYjA1OGU3MmU0NzcxMWJmMzYyMDQ4MTNmYzVjZWIzYTE3ZTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAgLTU4OSw4ICs1ODks OCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIGlmICh1c2VzQXJndW1lbnRzKCkgJiYg b3BlcmFuZCA9PSB1bm1vZGlmaWVkQXJndW1lbnRzUmVnaXN0ZXIoYXJndW1lbnRzUmVnaXN0ZXIo KSkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICAgICAgICAgIHJldHVybiBv cGVyYW5kID49IG1fc3ltYm9sVGFibGUtPmNhcHR1cmVTdGFydCgpIAotICAgICAgICAgICAgICAg ICYmIG9wZXJhbmQgPCBtX3N5bWJvbFRhYmxlLT5jYXB0dXJlRW5kKCk7CisgICAgICAgICAgICBy ZXR1cm4gb3BlcmFuZCA+PSBzeW1ib2xUYWJsZSgpLT5jYXB0dXJlU3RhcnQoKQorICAgICAgICAg ICAgICAgICYmIG9wZXJhbmQgPCBzeW1ib2xUYWJsZSgpLT5jYXB0dXJlRW5kKCk7CiAgICAgICAg IH0KIAogICAgICAgICBDb2RlVHlwZSBjb2RlVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29kZVR5 cGU7IH0K 172645 2012-11-06 13:59:25 -0800 2012-11-06 14:00:16 -0800 Patch bug-101391-20121106135738.patch text/plain 4049 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NTNjZDFlNDVjYTI5ZGI2NjExYWNiMDIxMGUyNThiZDAyNjE5OWJjLi5lNTFkNDU2NDdmNDU4NDg2 MGZjOWM0OGY2MjY0ZDAzODBjZDI5NmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0xMS0wNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJlZHVjZSBkaXJlY3QgbV9zeW1ib2xUYWJsZSB1c2FnZSBpbiBDb2RlQmxvY2sK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTM5MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsZSBy ZWZhY3RvcmluZy4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAg IChKU0M6OkNvZGVCbG9jazo6ZHVtcCk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZHVtcFN0 YXRpc3RpY3MpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6Om5hbWVGb3JSZWdpc3Rlcik6Cisg ICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6 aXNDYXB0dXJlZCk6CisKIDIwMTItMTEtMDUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNv bT4KIAogICAgICAgICBJbmRlbnRhdGlvbiBvZiBKU09iamVjdC5oIGlzIHdyb25nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCmluZGV4IDU4ZDM4MDc3MjA3 ODc4YjI3ZDYxZWM0MjM1Nzk4OGM2YWQxOThhZGEuLjI0Zjc0N2E5YzcyOWNmMGNhZjU4M2E2YTdj MmNmYzdkNDNjM2ViZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Db2RlQmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCkBAIC00OTIsOCArNDkyLDggQEAgdm9pZCBDb2RlQmxvY2s6OmR1bXAoRXhlY1N0 YXRlKiBleGVjKQogICAgICAgICBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nPihpbnN0cnVjdGlv bnMoKS5zaXplKCkgKiBzaXplb2YoSW5zdHJ1Y3Rpb24pKSwKICAgICAgICAgdGhpcywgY29kZVR5 cGVUb1N0cmluZyhjb2RlVHlwZSgpKSwgbV9udW1QYXJhbWV0ZXJzLCBtX251bUNhbGxlZVJlZ2lz dGVycywKICAgICAgICAgbV9udW1WYXJzKTsKLSAgICBpZiAobV9zeW1ib2xUYWJsZS0+Y2FwdHVy ZUNvdW50KCkpCi0gICAgICAgIGRhdGFMb2coIjsgJWQgY2FwdHVyZWQgdmFyKHMpIiwgbV9zeW1i b2xUYWJsZS0+Y2FwdHVyZUNvdW50KCkpOworICAgIGlmIChzeW1ib2xUYWJsZSgpLT5jYXB0dXJl Q291bnQoKSkKKyAgICAgICAgZGF0YUxvZygiOyAlZCBjYXB0dXJlZCB2YXIocykiLCBzeW1ib2xU YWJsZSgpLT5jYXB0dXJlQ291bnQoKSk7CiAgICAgaWYgKHVzZXNBcmd1bWVudHMoKSkgewogICAg ICAgICBkYXRhTG9nKAogICAgICAgICAgICAgIjsgdXNlcyBhcmd1bWVudHMsIGluIHIlZCwgciVk IiwKQEAgLTE0OTEsOSArMTQ5MSw5IEBAIHZvaWQgQ29kZUJsb2NrOjpkdW1wU3RhdGlzdGljcygp CiAgICAgICAgICAgICBGT1JfRUFDSF9NRU1CRVJfVkVDVE9SKEdFVF9TVEFUUykKICAgICAgICAg I3VuZGVmIEdFVF9TVEFUUwogCi0gICAgICAgIGlmICghY29kZUJsb2NrLT5tX3N5bWJvbFRhYmxl LmlzRW1wdHkoKSkgeworICAgICAgICBpZiAoIWNvZGVCbG9jay0+c3ltYm9sVGFibGUoKS5pc0Vt cHR5KCkpIHsKICAgICAgICAgICAgIHN5bWJvbFRhYmxlSXNOb3RFbXB0eSsrOwotICAgICAgICAg ICAgc3ltYm9sVGFibGVUb3RhbFNpemUgKz0gKGNvZGVCbG9jay0+bV9zeW1ib2xUYWJsZS5jYXBh Y2l0eSgpICogKHNpemVvZihTeW1ib2xUYWJsZTo6S2V5VHlwZSkgKyBzaXplb2YoU3ltYm9sVGFi bGU6Ok1hcHBlZFR5cGUpKSk7CisgICAgICAgICAgICBzeW1ib2xUYWJsZVRvdGFsU2l6ZSArPSAo Y29kZUJsb2NrLT5zeW1ib2xUYWJsZSgpLmNhcGFjaXR5KCkgKiAoc2l6ZW9mKFN5bWJvbFRhYmxl OjpLZXlUeXBlKSArIHNpemVvZihTeW1ib2xUYWJsZTo6TWFwcGVkVHlwZSkpKTsKICAgICAgICAg fQogCiAgICAgICAgIGlmIChjb2RlQmxvY2stPm1fcmFyZURhdGEpIHsKQEAgLTI4MDcsOCArMjgw Nyw4IEBAIGJvb2wgQ29kZUJsb2NrOjp1c2VzT3Bjb2RlKE9wY29kZUlEIG9wY29kZUlEKQogCiBT dHJpbmcgQ29kZUJsb2NrOjpuYW1lRm9yUmVnaXN0ZXIoaW50IHJlZ2lzdGVyTnVtYmVyKQogewot ICAgIFN5bWJvbFRhYmxlOjppdGVyYXRvciBlbmQgPSBtX3N5bWJvbFRhYmxlLT5lbmQoKTsKLSAg ICBmb3IgKFN5bWJvbFRhYmxlOjppdGVyYXRvciBwdHIgPSBtX3N5bWJvbFRhYmxlLT5iZWdpbigp OyBwdHIgIT0gZW5kOyArK3B0cikgeworICAgIFN5bWJvbFRhYmxlOjppdGVyYXRvciBlbmQgPSBz eW1ib2xUYWJsZSgpLT5lbmQoKTsKKyAgICBmb3IgKFN5bWJvbFRhYmxlOjppdGVyYXRvciBwdHIg PSBzeW1ib2xUYWJsZSgpLT5iZWdpbigpOyBwdHIgIT0gZW5kOyArK3B0cikgewogICAgICAgICBp ZiAocHRyLT52YWx1ZS5nZXRJbmRleCgpID09IHJlZ2lzdGVyTnVtYmVyKQogICAgICAgICAgICAg cmV0dXJuIFN0cmluZyhwdHItPmtleSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0NvZGVCbG9jay5oCmluZGV4IGQ0MTkzMjNhMGNkNDEwMDU4YmE2MDg0ZmM4MzE3NTg3 ODRmMzI5MzYuLmZhNzRhN2RjZmIxY2VmZmZiYWIwZjRkOTUyM2JlZTc4YmNkYThkZWMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAgLTU4OSw4ICs1ODks OCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIGlmICh1c2VzQXJndW1lbnRzKCkgJiYg b3BlcmFuZCA9PSB1bm1vZGlmaWVkQXJndW1lbnRzUmVnaXN0ZXIoYXJndW1lbnRzUmVnaXN0ZXIo KSkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICAgICAgICAgIHJldHVybiBv cGVyYW5kID49IG1fc3ltYm9sVGFibGUtPmNhcHR1cmVTdGFydCgpIAotICAgICAgICAgICAgICAg ICYmIG9wZXJhbmQgPCBtX3N5bWJvbFRhYmxlLT5jYXB0dXJlRW5kKCk7CisgICAgICAgICAgICBy ZXR1cm4gb3BlcmFuZCA+PSBzeW1ib2xUYWJsZSgpLT5jYXB0dXJlU3RhcnQoKQorICAgICAgICAg ICAgICAgICYmIG9wZXJhbmQgPCBzeW1ib2xUYWJsZSgpLT5jYXB0dXJlRW5kKCk7CiAgICAgICAg IH0KIAogICAgICAgICBDb2RlVHlwZSBjb2RlVHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fY29kZVR5 cGU7IH0KQEAgLTk2NCw3ICs5NjQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgU3RyaW5n SnVtcFRhYmxlJiBzdHJpbmdTd2l0Y2hKdW1wVGFibGUoaW50IHRhYmxlSW5kZXgpIHsgQVNTRVJU KG1fcmFyZURhdGEpOyByZXR1cm4gbV9yYXJlRGF0YS0+bV9zdHJpbmdTd2l0Y2hKdW1wVGFibGVz W3RhYmxlSW5kZXhdOyB9CiAKIAotICAgICAgICBTaGFyZWRTeW1ib2xUYWJsZSogc3ltYm9sVGFi bGUoKSB7IHJldHVybiBtX3N5bWJvbFRhYmxlLmdldCgpOyB9CisgICAgICAgIFNoYXJlZFN5bWJv bFRhYmxlKiBzeW1ib2xUYWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3ltYm9sVGFibGUuZ2V0KCk7 IH0KIAogICAgICAgICBFdmFsQ29kZUNhY2hlJiBldmFsQ29kZUNhY2hlKCkgeyBjcmVhdGVSYXJl RGF0YUlmTmVjZXNzYXJ5KCk7IHJldHVybiBtX3JhcmVEYXRhLT5tX2V2YWxDb2RlQ2FjaGU7IH0K IAo=