101386 2012-11-06 13:14:18 -0800 [BlackBerry] Pushing window.external.* events to webplatform 2012-11-06 14:00:54 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 759986 0 otcheung 2012-11-06 13:14:18 -0800 The stubs for window.external are in place. Add event calls so we can handle the event on the browser chrome. 759988 1 172636 otcheung 2012-11-06 13:19:49 -0800 Created attachment 172636 Patch 759993 2 172636 rwlbuis 2012-11-06 13:25:47 -0800 Comment on attachment 172636 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172636&action=review Small fixies to do. > Source/WebKit/blackberry/ChangeLog:8 > + Adding calls to trigger window.external events so we could handle them on the we could -> we can. Yes we can! > Source/WebKit/blackberry/Api/WebPageClient.h:266 > + virtual int isSearchProviderInstalled(const Platform::String& newURL) = 0; newURL can be left off here. 759994 3 172638 otcheung 2012-11-06 13:27:24 -0800 Created attachment 172638 Patch 759995 4 172638 rwlbuis 2012-11-06 13:28:21 -0800 Comment on attachment 172638 Patch LGTM. 760023 5 172638 webkit.review.bot 2012-11-06 14:00:50 -0800 Comment on attachment 172638 Patch Clearing flags on attachment: 172638 Committed r133667: <http://trac.webkit.org/changeset/133667> 760024 6 webkit.review.bot 2012-11-06 14:00:54 -0800 All reviewed patches have been landed. Closing bug. 172636 2012-11-06 13:19:49 -0800 2012-11-06 13:27:20 -0800 Patch bug-101386-20121106161801.patch text/plain 3483 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzZhNzg1NTNlMDM3MTI3OTg4OTc4NTk2ZjA3ZTg2OWViMWZiYTNjLi41M2VhN2IxODhl Mjg3NjU3NmJmODJhMDc1NDQ5ZDZmOWRhNzk5MGRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMi0xMS0wNiAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBQdXNoaW5nIHdpbmRvdy5l eHRlcm5hbC4qIGV2ZW50cyB0byB3ZWJwbGF0Zm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGNhbGxzIHRvIHRyaWdnZXIgd2luZG93LmV4 dGVybmFsIGV2ZW50cyBzbyB3ZSBjb3VsZCBoYW5kbGUgdGhlbSBvbiB0aGUKKyAgICAgICAgYnJv d3NlciBzaWRlLgorCisgICAgICAgIFBSIDE3MDA1OQorCisgICAgICAgICogQXBpL1dlYlBhZ2VD bGllbnQuaDoKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEJsYWNrQmVycnk6OmFkZFNlYXJj aFByb3ZpZGVyKToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEJsYWNrQmVycnk6Omlz U2VhcmNoUHJvdmlkZXJJbnN0YWxsZWQpOgorCisyMDEyLTExLTA2ICBPdHRvIERlcmVrIENoZXVu ZyAgPG90Y2hldW5nQHJpbS5jb20+CisKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyB3aW5k b3cuZXh0ZXJuYWwgdG8gb3VyIHBvcnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMDg2OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZUNsaWVudC5oCmluZGV4IGFmMTFlZTVhYzgxZmVlNzMxYWY2ZTdiYzc4NDU1NTFlYmY4 ZWI5MmEuLjEyOGM0NjUyY2ZhMGYwYjg1MDVlODBhMDgwZjgyZDg4MDQzMzE0NDUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCkBAIC0yNjIsNiArMjYy LDkgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBjcmVhdGVQb3B1cFdlYlZpZXcoY29uc3Qg UGxhdGZvcm06OkludFJlY3QmKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGNsb3NlUG9wdXBXZWJW aWV3KCkgPSAwOwogCisgICAgdmlydHVhbCB2b2lkIGFkZFNlYXJjaFByb3ZpZGVyKGNvbnN0IFBs YXRmb3JtOjpTdHJpbmcmIG5ld1VSTCkgPSAwOworICAgIHZpcnR1YWwgaW50ICBpc1NlYXJjaFBy b3ZpZGVySW5zdGFsbGVkKGNvbnN0IFBsYXRmb3JtOjpTdHJpbmcmIG5ld1VSTCkgPSAwOworCiAg ICAgLy8gTWF0Y2ggd2l0aCBDaHJvbWVDbGllbnQ6OkN1c3RvbUhhbmRsZXJzU3RhdGUuCiAgICAg ZW51bSBQcm90b2NvbEhhbmRsZXJzU3RhdGUgewogICAgICAgICBQcm90b2NvbEhhbmRsZXJzTmV3 LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDA1OGU1MDI3Yzk1MTU4 MTkxYjIzYTFhYTE0NzNjZGY5MWNiY2I2YjcuLjc4YzEyYjJjOTZmYjg1NmNkOWMxYzE5YzlmMzU2 MGYxNzE0ZjY5YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTgz OCw3ICs4MzgsMTEgQEAgdm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5Ojp1bnJlZ2lzdGVyUHJv dG9jb2xIYW5kbGVyKGNvbnN0IFN0cmluZyYgc2NoZW1lLCBjb24KIAogdm9pZCBDaHJvbWVDbGll bnRCbGFja0JlcnJ5OjphZGRTZWFyY2hQcm92aWRlcihjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6U3RyaW5nJiBvcmlnaW5VUkwsIGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcm IG5ld1VSTCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIC8vIFNlZSBpZiB0aGUgaW5w dXQgVVJMIGhvc3QgbWF0Y2hlcyBvZiB0aGUgb3JpZ2luIGhvc3QuCisgICAgS1VSTCBvcmlnaW5I b3N0ID0gS1VSTChLVVJMKCksIG9yaWdpblVSTCk7CisgICAgS1VSTCB1cmwgPSBLVVJMKEtVUkwo KSwgbmV3VVJMKTsKKyAgICBpZiAodXJsLmlzVmFsaWQoKSAmJiBvcmlnaW5Ib3N0Lmhvc3QoKSA9 PSB1cmwuaG9zdCgpKQorICAgICAgICBtX3dlYlBhZ2VQcml2YXRlLT5jbGllbnQoKS0+YWRkU2Vh cmNoUHJvdmlkZXIobmV3VVJMKTsKIH0KIAogaW50IENocm9tZUNsaWVudEJsYWNrQmVycnk6Omlz U2VhcmNoUHJvdmlkZXJJbnN0YWxsZWQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmlu ZyYgb3JpZ2luVVJMLCBjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBuZXdVUkwp CkBAIC04NDcsNiArODUxLDEyIEBAIGludCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5Ojppc1NlYXJj aFByb3ZpZGVySW5zdGFsbGVkKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtCiAvLyAgICAwIC0g Tm9uZSBvZiB0aGUgaW5zdGFsbGVkIHNlYXJjaCBlbmdpbmVzIG1hdGNoIHVybC4KIC8vICAgIDEg LSBPbmUgb3IgbW9yZSBpbnN0YWxsZWQgc2VhcmNoIGVuZ2luZXMgbWF0Y2ggdXJsLCBidXQgbm9u ZSBhcmUgdGhlIHVzZXIncyBkZWZhdWx0IHNlYXJjaCBlbmdpbmUuCiAvLyAgICAyIC0gVGhlIHVz ZXIncyBkZWZhdWx0IHNlYXJjaCBlbmdpbmUgbWF0Y2hlcyB1cmwuCisKKyAgICAvLyBTZWUgaWYg dGhlIGlucHV0IFVSTCBob3N0IG1hdGNoZXMgb2YgdGhlIG9yaWdpbiBob3N0LgorICAgIEtVUkwg b3JpZ2luSG9zdCA9IEtVUkwoS1VSTCgpLCBvcmlnaW5VUkwpOworICAgIEtVUkwgdXJsID0gS1VS TChLVVJMKCksIG5ld1VSTCk7CisgICAgaWYgKHVybC5pc1ZhbGlkKCkgJiYgb3JpZ2luSG9zdC5o b3N0KCkgPT0gdXJsLmhvc3QoKSkKKyAgICAgICAgcmV0dXJuIG1fd2ViUGFnZVByaXZhdGUtPmNs aWVudCgpLT5pc1NlYXJjaFByb3ZpZGVySW5zdGFsbGVkKG5ld1VSTCk7CiAgICAgcmV0dXJuIDA7 CiB9CiAK 172638 2012-11-06 13:27:24 -0800 2012-11-06 14:00:49 -0800 Patch bug-101386-20121106162536.patch text/plain 3467 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzZhNzg1NTNlMDM3MTI3OTg4OTc4NTk2ZjA3ZTg2OWViMWZiYTNjLi4xOTg5ODc5MzFh Mjc1ODIwNDc3ZDQ1NTIzNmNhNTIxNjZjMGUwYTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMi0xMS0wNiAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBQdXNoaW5nIHdpbmRvdy5l eHRlcm5hbC4qIGV2ZW50cyB0byB3ZWJwbGF0Zm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGNhbGxzIHRvIHRyaWdnZXIgd2luZG93LmV4 dGVybmFsIGV2ZW50cyBzbyB3ZSBjYW4gaGFuZGxlIHRoZW0gb24gdGhlCisgICAgICAgIGJyb3dz ZXIgc2lkZS4KKworICAgICAgICBQUiAxNzAwNTkKKworICAgICAgICAqIEFwaS9XZWJQYWdlQ2xp ZW50Lmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjphZGRTZWFyY2hQ cm92aWRlcik6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5Ojppc1Nl YXJjaFByb3ZpZGVySW5zdGFsbGVkKToKKworMjAxMi0xMS0wNiAgT3R0byBEZXJlayBDaGV1bmcg IDxvdGNoZXVuZ0ByaW0uY29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBZGRpbmcgd2luZG93 LmV4dGVybmFsIHRvIG91ciBwb3J0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDA4NjgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlQ2xpZW50LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2VDbGllbnQuaAppbmRleCBhZjExZWU1YWM4MWZlZTczMWFmNmU3YmM3ODQ1NTUxZWJmOGVi OTJhLi44ZGE0YTRmOTNjNTM3NTQ2YWEwNjRiYzE1MzVlMTQyZjAxOTg0ZjQwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaApAQCAtMjYyLDYgKzI2Miw5 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgY3JlYXRlUG9wdXBXZWJWaWV3KGNvbnN0IFBs YXRmb3JtOjpJbnRSZWN0JikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBjbG9zZVBvcHVwV2ViVmll dygpID0gMDsKIAorICAgIHZpcnR1YWwgdm9pZCBhZGRTZWFyY2hQcm92aWRlcihjb25zdCBQbGF0 Zm9ybTo6U3RyaW5nJikgPSAwOworICAgIHZpcnR1YWwgaW50ICBpc1NlYXJjaFByb3ZpZGVySW5z dGFsbGVkKGNvbnN0IFBsYXRmb3JtOjpTdHJpbmcmKSA9IDA7CisKICAgICAvLyBNYXRjaCB3aXRo IENocm9tZUNsaWVudDo6Q3VzdG9tSGFuZGxlcnNTdGF0ZS4KICAgICBlbnVtIFByb3RvY29sSGFu ZGxlcnNTdGF0ZSB7CiAgICAgICAgIFByb3RvY29sSGFuZGxlcnNOZXcsCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMDU4ZTUwMjdjOTUxNTgxOTFiMjNhMWFhMTQ3M2Nk ZjkxY2JjYjZiNy4uNzhjMTJiMmM5NmZiODU2Y2Q5YzFjMTljOWYzNTYwZjE3MTRmNjliNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtODM4LDcgKzgzOCwxMSBAQCB2 b2lkIENocm9tZUNsaWVudEJsYWNrQmVycnk6OnVucmVnaXN0ZXJQcm90b2NvbEhhbmRsZXIoY29u c3QgU3RyaW5nJiBzY2hlbWUsIGNvbgogCiB2b2lkIENocm9tZUNsaWVudEJsYWNrQmVycnk6OmFk ZFNlYXJjaFByb3ZpZGVyKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIG9yaWdp blVSTCwgY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgbmV3VVJMKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7CisgICAgLy8gU2VlIGlmIHRoZSBpbnB1dCBVUkwgaG9zdCBtYXRj aGVzIG9mIHRoZSBvcmlnaW4gaG9zdC4KKyAgICBLVVJMIG9yaWdpbkhvc3QgPSBLVVJMKEtVUkwo KSwgb3JpZ2luVVJMKTsKKyAgICBLVVJMIHVybCA9IEtVUkwoS1VSTCgpLCBuZXdVUkwpOworICAg IGlmICh1cmwuaXNWYWxpZCgpICYmIG9yaWdpbkhvc3QuaG9zdCgpID09IHVybC5ob3N0KCkpCisg ICAgICAgIG1fd2ViUGFnZVByaXZhdGUtPmNsaWVudCgpLT5hZGRTZWFyY2hQcm92aWRlcihuZXdV UkwpOwogfQogCiBpbnQgQ2hyb21lQ2xpZW50QmxhY2tCZXJyeTo6aXNTZWFyY2hQcm92aWRlcklu c3RhbGxlZChjb25zdCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBvcmlnaW5VUkwsIGNv bnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIG5ld1VSTCkKQEAgLTg0Nyw2ICs4NTEs MTIgQEAgaW50IENocm9tZUNsaWVudEJsYWNrQmVycnk6OmlzU2VhcmNoUHJvdmlkZXJJbnN0YWxs ZWQoY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZvcm0KIC8vICAgIDAgLSBOb25lIG9mIHRoZSBpbnN0 YWxsZWQgc2VhcmNoIGVuZ2luZXMgbWF0Y2ggdXJsLgogLy8gICAgMSAtIE9uZSBvciBtb3JlIGlu c3RhbGxlZCBzZWFyY2ggZW5naW5lcyBtYXRjaCB1cmwsIGJ1dCBub25lIGFyZSB0aGUgdXNlcidz IGRlZmF1bHQgc2VhcmNoIGVuZ2luZS4KIC8vICAgIDIgLSBUaGUgdXNlcidzIGRlZmF1bHQgc2Vh cmNoIGVuZ2luZSBtYXRjaGVzIHVybC4KKworICAgIC8vIFNlZSBpZiB0aGUgaW5wdXQgVVJMIGhv c3QgbWF0Y2hlcyBvZiB0aGUgb3JpZ2luIGhvc3QuCisgICAgS1VSTCBvcmlnaW5Ib3N0ID0gS1VS TChLVVJMKCksIG9yaWdpblVSTCk7CisgICAgS1VSTCB1cmwgPSBLVVJMKEtVUkwoKSwgbmV3VVJM KTsKKyAgICBpZiAodXJsLmlzVmFsaWQoKSAmJiBvcmlnaW5Ib3N0Lmhvc3QoKSA9PSB1cmwuaG9z dCgpKQorICAgICAgICByZXR1cm4gbV93ZWJQYWdlUHJpdmF0ZS0+Y2xpZW50KCktPmlzU2VhcmNo UHJvdmlkZXJJbnN0YWxsZWQobmV3VVJMKTsKICAgICByZXR1cm4gMDsKIH0KIAo=