101367 2012-11-06 10:09:49 -0800 check-webkit-style false report about asm() code in DFGOperations.cpp. 2017-07-18 08:29:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All UNCONFIRMED P2 Normal --- 0 kilvadyb webkit-unassigned abarth commit-queue dpranke eric fu gergely levin palfia webkit.review.bot oldest_to_newest 759809 0 kilvadyb 2012-11-06 10:09:49 -0800 As I didn't find coding style rules to asm(…) blocks just followed the style/indention of existing asm(… ) blocks but received: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.cpp:1569: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5] for: asm( ".text" "\n" ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n" HIDE_SYMBOL(getHostCallReturnValue) "\n" SYMBOL_STRING(getHostCallReturnValue) ":" "\n" LOAD_FUNCTION_TO_T9(getHostCallReturnValueWithExecState) "lw $s0, -40($s0)" "\n" "move $a0, $s0" "\n" "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n" ); Where line 1569 is the closing ); 761906 1 173060 kilvadyb 2012-11-08 10:09:52 -0800 Created attachment 173060 patch With this patch "asm(" "asm (" "__asm(" and "__asm (" blocks accepted at style checking. 822365 2 173060 hausmann 2013-01-31 23:09:18 -0800 Comment on attachment 173060 patch Would it make sense perhaps to also add a unit test for this in cpp_unittest.py? 976921 3 173060 andersca 2014-02-05 11:07:47 -0800 Comment on attachment 173060 patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 173060 2012-11-08 10:09:52 -0800 2014-02-05 11:07:47 -0800 patch check.diff text/plain 2693 kilvadyb ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTI5 NGNjLi45YmUwNzRlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTEtMDggIEJhbGF6cyBLaWx2YWR5ICA8a2ls dmFkeWJAaG9tZWppbm5pLmNvbT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgZmFsc2Ug cmVwb3J0IGFib3V0IGFzbSgpIGNvZGUgaW4gREZHT3BlcmF0aW9ucy5jcHAuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEzNjcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggImFzbSAoIiBoYW5kbGlu ZyBpbiBjcHAgZmlsZXMgYXQgc3R5bGUgY2hlY2tpbmcuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3NwYWNpbmdfZm9y X2Z1bmN0aW9uX2NhbGwpOgorICAgICAgICAoZGV0ZWN0X2Z1bmN0aW9ucyk6CisgICAgICAgIChw cm9jZXNzX2xpbmUpOgorCiAyMDEyLTExLTA4ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQGlu dGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBUdXJuIG9uIFdURl9VU0VfVElMRURfQkFDS0lOR19T VE9SRSBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CmluZGV4IGExNDQ3ZTIuLjIyMmJjOTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xNDAyLDcgKzE0MDIsOSBAQCBkZWYgY2hlY2tf c3BhY2luZ19mb3JfZnVuY3Rpb25fY2FsbChsaW5lLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAg ICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVuY2VzIHRvIGZ1bmN0aW9ucy4KICAgICAgICAg YW5kIG5vdCBzZWFyY2gocicgXChbXildK1wpXChbXildKihcKXwsJCknLCBmdW5jdGlvbl9jYWxs KQogICAgICAgICAjIElnbm9yZSBwb2ludGVycy9yZWZlcmVuY2VzIHRvIGFycmF5cy4KLSAgICAg ICAgYW5kIG5vdCBzZWFyY2gocicgXChbXildK1wpXFtbXlxdXStcXScsIGZ1bmN0aW9uX2NhbGwp KToKKyAgICAgICAgYW5kIG5vdCBzZWFyY2gocicgXChbXildK1wpXFtbXlxdXStcXScsIGZ1bmN0 aW9uX2NhbGwpCisgICAgICAgICMgSWdub3JlIGFzbSBibG9jayBiZWdpbm5pbmdzLgorICAgICAg ICBhbmQgbm90IG1hdGNoKHInXHMqXGIoX18pP2FzbVwgP1woJywgZnVuY3Rpb25fY2FsbCkpOgog ICAgICAgICBpZiBzZWFyY2gocidcd1xzKlwoWyBcdF0oPyFccypcXCQpJywgZnVuY3Rpb25fY2Fs bCk6ICAgICAgIyBhICggdXNlZCBmb3IgYSBmbiBjYWxsCiAgICAgICAgICAgICBlcnJvcihsaW5l X251bWJlciwgJ3doaXRlc3BhY2UvcGFyZW5zJywgNCwKICAgICAgICAgICAgICAgICAgICdFeHRy YSBzcGFjZSBhZnRlciAoIGluIGZ1bmN0aW9uIGNhbGwnKQpAQCAtMTQ3Nyw2ICsxNDc5LDEwIEBA IGRlZiBkZXRlY3RfZnVuY3Rpb25zKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZnVuY3Rpb25f c3RhdGUsIGVycm9yKToKICAgICBpZiBmdW5jdGlvbl9uYW1lICE9ICdURVNUJyBhbmQgZnVuY3Rp b25fbmFtZSAhPSAnVEVTVF9GJyBhbmQgbWF0Y2gocidbQS1aX10rJCcsIGZ1bmN0aW9uX25hbWUp OgogICAgICAgICByZXR1cm4KIAorICAgICMgSWdub3JlIGFzbSBsaW5lcyBhcyB0aGV5IGZvcm1h dCBkaWZmZXJlbnRseS4KKyAgICBpZiBtYXRjaChyJyhfXyk/YXNtJywgZnVuY3Rpb25fbmFtZSk6 CisgICAgICAgIHJldHVybgorCiAgICAgam9pbmVkX2xpbmUgPSAnJwogICAgIGZvciBzdGFydF9s aW5lX251bWJlciBpbiB4cmFuZ2UobGluZV9udW1iZXIsIGNsZWFuX2xpbmVzLm51bV9saW5lcygp KToKICAgICAgICAgc3RhcnRfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtzdGFydF9saW5lX251 bWJlcl0KQEAgLTM1MDIsOCArMzUwOCw2IEBAIGRlZiBwcm9jZXNzX2xpbmUoZmlsZW5hbWUsIGZp bGVfZXh0ZW5zaW9uLAogICAgIGNoZWNrX2Zvcl9mdW5jdGlvbl9sZW5ndGhzKGNsZWFuX2xpbmVz LCBsaW5lLCBmdW5jdGlvbl9zdGF0ZSwgZXJyb3IpCiAgICAgaWYgc2VhcmNoKHInXGJOT0xJTlRc YicsIHJhd19saW5lc1tsaW5lXSk6ICAjIGlnbm9yZSBub2xpbnQgbGluZXMKICAgICAgICAgcmV0 dXJuCi0gICAgaWYgbWF0Y2gocidccypcYl9fYXNtXGInLCByYXdfbGluZXNbbGluZV0pOiAgIyBJ Z25vcmUgYXNtIGxpbmVzIGFzIHRoZXkgZm9ybWF0IGRpZmZlcmVudGx5LgotICAgICAgICByZXR1 cm4KICAgICBjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lv biwgY2xlYW5fbGluZXMsIGxpbmUsIGZ1bmN0aW9uX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19w YXNzX3B0cl91c2FnZShjbGVhbl9saW5lcywgbGluZSwgZnVuY3Rpb25fc3RhdGUsIGVycm9yKQog ICAgIGNoZWNrX2Zvcl9sZWFreV9wYXR0ZXJucyhjbGVhbl9saW5lcywgbGluZSwgZnVuY3Rpb25f c3RhdGUsIGVycm9yKQo=