101364 2012-11-06 09:39:19 -0800 [CSS Regions] Fix failing tests on Mac after sub-pixel layout was enabled 2012-11-06 11:19:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101220 57312 1 abucur abucur leviw simon.fraser webkit.review.bot oldest_to_newest 759783 0 abucur 2012-11-06 09:39:19 -0800 Three tests started failing after sub-pixel layout started failing after sub-pixel layout was enabled on Mac: LayoutTests/fast/regions/float-pushed-width-change.html LayoutTests/fast/regions/floats-basic-in-variable-width-regions.html LayoutTests/fast/regions/render-region-renderer.html Fix the tests or the issues in code that caused the failings. 759835 1 simon.fraser 2012-11-06 10:28:23 -0800 These are reference tests, which suggests that the references are not really doing layout the same way as the actual test. I'm curious about how other platforms that enable SUBPIXEL_LAYOUT handle this. 759837 2 172612 abucur 2012-11-06 10:30:32 -0800 Created attachment 172612 Patch 759901 3 172612 webkit.review.bot 2012-11-06 11:19:02 -0800 Comment on attachment 172612 Patch Clearing flags on attachment: 172612 Committed r133648: <http://trac.webkit.org/changeset/133648> 759902 4 webkit.review.bot 2012-11-06 11:19:05 -0800 All reviewed patches have been landed. Closing bug. 172612 2012-11-06 10:30:32 -0800 2012-11-06 11:19:02 -0800 Patch bug-101364-20121106202844.patch text/plain 3413 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTgxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzM2YmQxNGI3MjRkNTc4ZWVjYjgw NGM5M2QyZmI0ZDU5ZTY4NzAwOS4uMzlmMTg4N2U2NTFlNGM1ZTA3NWE3NmFiMTc4ZDQzNGU0YWY3 MzAxNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA2ICBBbmRyZWkgQnVjdXIgIDxh YnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gRml4IGZhaWxpbmcgdGVz dHMgb24gTWFjIGFmdGVyIHN1Yi1waXhlbCBsYXlvdXQgd2FzIGVuYWJsZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTM2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBubyBjaGFuZ2Vz IGluIHRoZSBjb2RlLiBPbmx5IHRoZSB0ZXN0cyBoYWQgdG8gYmUgZml4ZWQuCisKKyAgICAgICAg KiBmYXN0L3JlZ2lvbnMvZmxvYXQtcHVzaGVkLXdpZHRoLWNoYW5nZS1leHBlY3RlZC5odG1sOiBS ZW1vdmUgdGhlIHVubmVjZXNzYXJ5IDAuNXB4IG1hcmdpbi4KKyAgICAgICAgKiBmYXN0L3JlZ2lv bnMvZmxvYXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRoLXJlZ2lvbnMtZXhwZWN0ZWQuaHRtbDog QmVjYXVzZSBvZiBob3cgcmVnaW9ucyBhcmUgaW1wbGVtZW50ZWQsIHRoZSBsZWZ0IG9mZnNldCBm b3IgbGluZXMgaXMgNTBweCAodGhlIGZsb2F0IHdpZHRoKSAtIFguNXB4IChtYXJnaW46IGF1dG8g Z2l2ZXMgYSBkaWZmZXJlbnQgdmFsdWUgaW4gdGhlIHR3byByZWdpb25zKS4gVGhpcyB0cmFuc2xh dGVkIGludG8gMzcuNXB4IHdoaWNoIHRyaWdnZXJlZCBhIHN1Yi1waXhlbCBsYXlvdXQgaXNzdWUu IFRoZSBuZXcgd2lkdGggdmFsdWVzIGNoYW5nZXMgdGhlIFguNXB4IGludG8gYSByb3VuZGVkIHZh bHVlLgorICAgICAgICAqIGZhc3QvcmVnaW9ucy9mbG9hdHMtYmFzaWMtaW4tdmFyaWFibGUtd2lk dGgtcmVnaW9ucy5odG1sOiBTZWUgYWJvdmUKKyAgICAgICAgKiBmYXN0L3JlZ2lvbnMvcmVuZGVy LXJlZ2lvbi1yZW5kZXJlci1leHBlY3RlZC5odG1sOiBSZW1vdmUgdW5uZWNlc3NhcnkgMC41cHgg aGVpZ2h0LgorCiAyMDEyLTExLTA2ICBUYWthc2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNv bT4KIAogICAgICAgICByZW1vdmVBdHRyaWJ1dGUoJ3N0eWxlJykgbm90IHdvcmtpbmcgaW4gY2Vy dGFpbiBjaXJjdW1zdGFuY2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMv ZmxvYXQtcHVzaGVkLXdpZHRoLWNoYW5nZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9yZWdpb25zL2Zsb2F0LXB1c2hlZC13aWR0aC1jaGFuZ2UtZXhwZWN0ZWQuaHRtbAppbmRleCBi NzJhZTFkM2YwZTdlOGM4NTk0YTI4MTQ3YzgyZDBlNjVmOTU2MDZiLi4xYzAwOWE2ZTEzYTQwM2Zj YzExNzQxZmIzMzY1ZWIxZjhjNjYzOGY3IDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3Jl Z2lvbnMvZmxvYXQtcHVzaGVkLXdpZHRoLWNoYW5nZS1leHBlY3RlZC5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvcmVnaW9ucy9mbG9hdC1wdXNoZWQtd2lkdGgtY2hhbmdlLWV4cGVjdGVkLmh0 bWwKQEAgLTU2LDcgKzU2LDcgQEAKIAl9CiAKIAlwLmZsb3cyIHsKLQkJbWFyZ2luLXRvcDogMC41 cHg7CisJCW1hcmdpbi10b3A6IDBweDsKIAl9CiAJCiA8L3N0eWxlPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9yZWdpb25zL2Zsb2F0cy1iYXNpYy1pbi12YXJpYWJsZS13aWR0aC1yZWdp b25zLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvZmxvYXRzLWJhc2lj LWluLXZhcmlhYmxlLXdpZHRoLXJlZ2lvbnMtZXhwZWN0ZWQuaHRtbAppbmRleCBiNTA2Y2ZiNDVj YzNjM2Q4MWU2YTg1ZmFjMmIyOTZhNWRjMDZjZjI2Li4yOTNlMWY4NWMyNDJhYjVhMGFlMmU5ODFi ZjkzNjM2ZDg0OTdlOTY4IDEwMDc1NQotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvZmxv YXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRoLXJlZ2lvbnMtZXhwZWN0ZWQuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvZmxvYXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRoLXJl Z2lvbnMtZXhwZWN0ZWQuaHRtbApAQCAtMzIsNyArMzIsNyBAQAogICAgIH0KIAogICAgICNyZWdp b24xIHsKLSAgICAgICAgd2lkdGg6IDI5MHB4OworICAgICAgICB3aWR0aDogMjcwcHg7CiAgICAg ICAgIGhlaWdodDogOTVweDsKICAgICAgICAgcGFkZGluZy10b3A6NXB4OwogICAgICAgICBwYWRk aW5nLWxlZnQ6NXB4OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2Zsb2F0 cy1iYXNpYy1pbi12YXJpYWJsZS13aWR0aC1yZWdpb25zLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L3JlZ2lvbnMvZmxvYXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRoLXJlZ2lvbnMuaHRtbAppbmRl eCAzYjRmN2I4ZWUzM2U2YzAzZGNjODkzNDM1ZDZlM2NkYjNhNmQ2MGY3Li42MWIxYzAzYTdjZTg0 MjI2MTMyOTIzZjIyNjZkZGE5NjVhMGVhOTAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L3JlZ2lvbnMvZmxvYXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRoLXJlZ2lvbnMuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvZmxvYXRzLWJhc2ljLWluLXZhcmlhYmxlLXdpZHRo LXJlZ2lvbnMuaHRtbApAQCAtMjIsNyArMjIsNyBAQAogICAgIH0KIAogICAgICNyZWdpb24xIHsK LSAgICAgICAgd2lkdGg6IDMwMHB4OworICAgICAgICB3aWR0aDogMjgwcHg7CiAgICAgICAgIGhl aWdodDogMTAwcHg7CiAgICAgfQogICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9y ZWdpb25zL3JlbmRlci1yZWdpb24tcmVuZGVyZXItZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvcmVnaW9ucy9yZW5kZXItcmVnaW9uLXJlbmRlcmVyLWV4cGVjdGVkLmh0bWwKaW5kZXgg ODkzYWNjMDZhMmFlMjJjZjU5YTdiYjA3ZjA1ZmNmZDc1NzdkYWQ0ZS4uOTA3MjAwMjA1MjVhMWU1 MjRlMjA5N2NlMzFmNmQ2YTAwZGMzOThmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9y ZWdpb25zL3JlbmRlci1yZWdpb24tcmVuZGVyZXItZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L3JlZ2lvbnMvcmVuZGVyLXJlZ2lvbi1yZW5kZXJlci1leHBlY3RlZC5odG1sCkBA IC0xNCw3ICsxNCw3IEBACiAgICAgfQogICAgIC5zaXplMQogICAgIHsKLSAgICAgICAgaGVpZ2h0 OjAuNXB4OworICAgICAgICBoZWlnaHQ6MHB4OwogICAgIH0KIAogICAgIC5zaXplMgo=