101360 2012-11-06 09:05:38 -0800 [EFL][WK2] Declare all smart callbacks in EwkViewCallbacks.h 2012-11-06 11:09:05 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco tonikitoo webkit.review.bot oldest_to_newest 759751 0 cdumez 2012-11-06 09:05:38 -0800 Some of the EwkView callbacks are not defined in EwkViewCallbacks.h, instead the callers still use evas_object_smart_callback_call(). We should move all of them to EwkViewCallbacks.h for consistency and for better argument type checking. 759796 1 172607 cdumez 2012-11-06 09:59:20 -0800 Created attachment 172607 Patch 759887 2 172607 webkit.review.bot 2012-11-06 11:09:01 -0800 Comment on attachment 172607 Patch Clearing flags on attachment: 172607 Committed r133643: <http://trac.webkit.org/changeset/133643> 759888 3 webkit.review.bot 2012-11-06 11:09:05 -0800 All reviewed patches have been landed. Closing bug. 172607 2012-11-06 09:59:20 -0800 2012-11-06 11:09:01 -0800 Patch 101360_remaining_view_callbacks.patch text/plain 6010 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZDA2MmI3Li5kMDA0NDJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMTEtMDYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIERlY2xhcmUgYWxsIHNtYXJ0IGNhbGxiYWNrcyBp biBFd2tWaWV3Q2FsbGJhY2tzLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMTM2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERlY2xhcmUgYWxsIEV3a1ZpZXcgc21hcnQgY2FsbGJhY2tzIGluIEV3a1Zp ZXdDYWxsYmFja3MuaAorICAgICAgICBhbmQgcmVtb3ZlIHJlbWFpbmluZyBjYWxscyB0byBldmFz X29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKCkuCisgICAgICAgIEl0IGlzIGEgZ29vZCBpZGVh IHRvIGhhdmUgYWxsIHRoZSBjYWxsYmFja3MgZGVjbGFyZWQgaW4gb25lCisgICAgICAgIHBsYWNl IGZvciBjb252ZW5pZW5jZSBhbmQgY29uc2lzdGVuY3kuIFdlIGFsc28gaGF2ZSBiZXR0ZXIKKyAg ICAgICAgYXJndW1lbnQgdHlwZSBjaGVja2luZyBpZiB3ZSB1c2UgdGhlIG5ldyBjYWxsYmFjayBt ZWNoYW5pc20uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3Q2FsbGJhY2tz Lmg6CisgICAgICAgIChFd2tWaWV3Q2FsbGJhY2tzOjpDYWxsQmFjazo6Y2FsbCk6CisgICAgICAg IChDYWxsQmFjayk6CisgICAgICAgIChFd2tWaWV3Q2FsbGJhY2tzKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tWaWV3SW1wbDo6aW5m b3JtSWNvbkNoYW5nZSk6CisgICAgICAgIChFd2tWaWV3SW1wbDo6aW5mb3JtVVJMQ2hhbmdlKToK KyAgICAgICAgKEV3a1ZpZXdJbXBsOjpjcmVhdGVOZXdQYWdlKToKKyAgICAgICAgKEV3a1ZpZXdJ bXBsOjpjbG9zZVBhZ2UpOgorCiAyMDEyLTExLTA2ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxh QGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIENvb3JkaW5hdGVkIEdyYXBoaWNzOiBSZW1vdmUg YSBwYXJlbnQgbWVtYmVyIGluIFdlYkxheWVySW5mby4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdDYWxsYmFja3MuaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdDYWxsYmFja3MuaAppbmRleCA3MGIyN2M3Li43ZjVh MmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 Q2FsbGJhY2tzLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmll d0NhbGxiYWNrcy5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIEV3a1ZpZXdDYWxsYmFja3Nf aAogI2RlZmluZSBFd2tWaWV3Q2FsbGJhY2tzX2gKIAorI2luY2x1ZGUgIldLRWluYVNoYXJlZFN0 cmluZy5oIgogI2luY2x1ZGUgImV3a19wcml2YXRlLmgiCiAjaW5jbHVkZSA8RXZhcy5oPgogI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KQEAgLTU0LDEyICs1NSwxNSBAQCBuYW1lc3BhY2Ug RXdrVmlld0NhbGxiYWNrcyB7CiBlbnVtIENhbGxiYWNrVHlwZSB7CiAgICAgQXV0aGVudGljYXRp b25SZXF1ZXN0LAogICAgIEJhY2tGb3J3YXJkTGlzdENoYW5nZSwKKyAgICBDbG9zZVdpbmRvdywK KyAgICBDcmVhdGVXaW5kb3csCiAgICAgRG93bmxvYWRKb2JDYW5jZWxsZWQsCiAgICAgRG93bmxv YWRKb2JGYWlsZWQsCiAgICAgRG93bmxvYWRKb2JGaW5pc2hlZCwKICAgICBEb3dubG9hZEpvYlJl cXVlc3RlZCwKICAgICBGaWxlQ2hvb3NlclJlcXVlc3QsCiAgICAgTmV3Rm9ybVN1Ym1pc3Npb25S ZXF1ZXN0LAorICAgIEljb25DaGFuZ2VkLAogICAgIExvYWRFcnJvciwKICAgICBMb2FkRmluaXNo ZWQsCiAgICAgTG9hZFByb2dyZXNzLApAQCAtNzcsNiArODEsNyBAQCBlbnVtIENhbGxiYWNrVHlw ZSB7CiAgICAgVGl0bGVDaGFuZ2UsCiAgICAgVG9vbHRpcFRleHRVbnNldCwKICAgICBUb29sdGlw VGV4dFNldCwKKyAgICBVUkxDaGFuZ2VkLAogICAgIFdlYlByb2Nlc3NDcmFzaGVkLAogI2lmIEVO QUJMRShXRUJfSU5URU5UUykKICAgICBJbnRlbnRSZXF1ZXN0LApAQCAtMTM2LDYgKzE0MSwxMSBA QCBwdWJsaWM6CiAgICAgICAgIGNhbGwoY29uc3RfY2FzdDxjaGFyKj4oYXJnLnV0ZjgoKS5kYXRh KCkpKTsKICAgICB9CiAKKyAgICB2b2lkIGNhbGwoY29uc3QgV0tFaW5hU2hhcmVkU3RyaW5nJiBh cmcpCisgICAgeworICAgICAgICBjYWxsKGNvbnN0X2Nhc3Q8Y2hhcio+KHN0YXRpY19jYXN0PGNv bnN0IGNoYXIqPihhcmcpKSk7CisgICAgfQorCiBwcml2YXRlOgogICAgIEV2YXNfT2JqZWN0KiBt X3ZpZXc7CiB9OwpAQCAtMTUwLDEyICsxNjAsMTUgQEAgc3RydWN0IENhbGxCYWNrSW5mbzxjYWxs YmFja1R5cGU+IHsgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAvLyBOb3RlOiB0eXBlICd2 b2lkJyBtZWFucyB0aGF0IG5vIGFyZ3VtZW50cyBhcmUgZXhwZWN0ZWQuCiBERUNMQVJFX0VXS19W SUVXX0NBTExCQUNLKEF1dGhlbnRpY2F0aW9uUmVxdWVzdCwgImF1dGhlbnRpY2F0aW9uLHJlcXVl c3QiLCBFd2tfQXV0aF9SZXF1ZXN0KTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soQmFja0Zv cndhcmRMaXN0Q2hhbmdlLCAiYmFjayxmb3J3YXJkLGxpc3QsY2hhbmdlZCIsIHZvaWQpOworREVD TEFSRV9FV0tfVklFV19DQUxMQkFDSyhDbG9zZVdpbmRvdywgImNsb3NlLHdpbmRvdyIsIHZvaWQp OworREVDTEFSRV9FV0tfVklFV19DQUxMQkFDSyhDcmVhdGVXaW5kb3csICJjcmVhdGUsd2luZG93 IiwgRXZhc19PYmplY3QqKTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soRG93bmxvYWRKb2JD YW5jZWxsZWQsICJkb3dubG9hZCxjYW5jZWxsZWQiLCBFd2tfRG93bmxvYWRfSm9iKTsKIERFQ0xB UkVfRVdLX1ZJRVdfQ0FMTEJBQ0soRG93bmxvYWRKb2JGYWlsZWQsICJkb3dubG9hZCxmYWlsZWQi LCBFd2tfRG93bmxvYWRfSm9iX0Vycm9yKTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soRG93 bmxvYWRKb2JGaW5pc2hlZCwgImRvd25sb2FkLGZpbmlzaGVkIiwgRXdrX0Rvd25sb2FkX0pvYik7 CiBERUNMQVJFX0VXS19WSUVXX0NBTExCQUNLKERvd25sb2FkSm9iUmVxdWVzdGVkLCAiZG93bmxv YWQscmVxdWVzdCIsIEV3a19Eb3dubG9hZF9Kb2IpOwogREVDTEFSRV9FV0tfVklFV19DQUxMQkFD SyhGaWxlQ2hvb3NlclJlcXVlc3QsICJmaWxlLGNob29zZXIscmVxdWVzdCIsIEV3a19GaWxlX0No b29zZXJfUmVxdWVzdCk7CiBERUNMQVJFX0VXS19WSUVXX0NBTExCQUNLKE5ld0Zvcm1TdWJtaXNz aW9uUmVxdWVzdCwgImZvcm0sc3VibWlzc2lvbixyZXF1ZXN0IiwgRXdrX0Zvcm1fU3VibWlzc2lv bl9SZXF1ZXN0KTsKK0RFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soSWNvbkNoYW5nZWQsICJpY29u LGNoYW5nZWQiLCB2b2lkKTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soTG9hZEVycm9yLCAi bG9hZCxlcnJvciIsIEV3a19FcnJvcik7CiBERUNMQVJFX0VXS19WSUVXX0NBTExCQUNLKExvYWRG aW5pc2hlZCwgImxvYWQsZmluaXNoZWQiLCB2b2lkKTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJB Q0soTG9hZFByb2dyZXNzLCAibG9hZCxwcm9ncmVzcyIsIGRvdWJsZSk7CkBAIC0xNzMsNiArMTg2 LDcgQEAgREVDTEFSRV9FV0tfVklFV19DQUxMQkFDSyhUZXh0Rm91bmQsICJ0ZXh0LGZvdW5kIiwg dW5zaWduZWQpOwogREVDTEFSRV9FV0tfVklFV19DQUxMQkFDSyhUaXRsZUNoYW5nZSwgInRpdGxl LGNoYW5nZWQiLCBjaGFyKTsKIERFQ0xBUkVfRVdLX1ZJRVdfQ0FMTEJBQ0soVG9vbHRpcFRleHRV bnNldCwgInRvb2x0aXAsdGV4dCx1bnNldCIsIHZvaWQpOwogREVDTEFSRV9FV0tfVklFV19DQUxM QkFDSyhUb29sdGlwVGV4dFNldCwgInRvb2x0aXAsdGV4dCxzZXQiLCBjaGFyKTsKK0RFQ0xBUkVf RVdLX1ZJRVdfQ0FMTEJBQ0soVVJMQ2hhbmdlZCwgInVybCxjaGFuZ2VkIiwgY2hhcik7CiBERUNM QVJFX0VXS19WSUVXX0NBTExCQUNLKFdlYlByb2Nlc3NDcmFzaGVkLCAid2VicHJvY2VzcyxjcmFz aGVkIiwgYm9vbCk7CiAjaWYgRU5BQkxFKFdFQl9JTlRFTlRTKQogREVDTEFSRV9FV0tfVklFV19D QUxMQkFDSyhJbnRlbnRSZXF1ZXN0LCAiaW50ZW50LHJlcXVlc3QsbmV3IiwgRXdrX0ludGVudCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1w bC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAK aW5kZXggMjAyYTk4Yi4uNDIxNjZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcApAQCAtNjQsNiArNjQsNyBAQAogI2luY2x1ZGUgPEV2 YXNfR0wuaD4KICNlbmRpZgogCit1c2luZyBuYW1lc3BhY2UgRXdrVmlld0NhbGxiYWNrczsKIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIApAQCAtNDk1 LDcgKzQ5Niw3IEBAIHZvaWQgRXdrVmlld0ltcGw6OmluZm9ybUljb25DaGFuZ2UoKQogICAgIEFT U0VSVChpY29uRGF0YWJhc2UpOwogCiAgICAgbV9mYXZpY29uVVJMID0gZXdrX2Zhdmljb25fZGF0 YWJhc2VfaWNvbl91cmxfZ2V0KGljb25EYXRhYmFzZSwgbV91cmwpOwotICAgIGV2YXNfb2JqZWN0 X3NtYXJ0X2NhbGxiYWNrX2NhbGwobV92aWV3LCAiaWNvbixjaGFuZ2VkIiwgMCk7CisgICAgc21h cnRDYWxsYmFjazxJY29uQ2hhbmdlZD4oKS5jYWxsKCk7CiB9CiAKICNpZiBVU0UoQUNDRUxFUkFU RURfQ09NUE9TSVRJTkcpCkBAIC03MjYsOCArNzI3LDcgQEAgdm9pZCBFd2tWaWV3SW1wbDo6aW5m b3JtVVJMQ2hhbmdlKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV91cmwgPSByYXdBY3RpdmVV UkwuZGF0YSgpOwotICAgIGNvbnN0IGNoYXIqIGNhbGxiYWNrQXJndW1lbnQgPSBzdGF0aWNfY2Fz dDxjb25zdCBjaGFyKj4obV91cmwpOwotICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2Nh bGwobV92aWV3LCAidXJsLGNoYW5nZWQiLCBjb25zdF9jYXN0PGNoYXIqPihjYWxsYmFja0FyZ3Vt ZW50KSk7CisgICAgc21hcnRDYWxsYmFjazxVUkxDaGFuZ2VkPigpLmNhbGwobV91cmwpOwogCiAg ICAgLy8gVXBkYXRlIHRoZSB2aWV3J3MgZmF2aWNvbi4KICAgICBpbmZvcm1JY29uQ2hhbmdlKCk7 CkBAIC03MzYsNyArNzM2LDcgQEAgdm9pZCBFd2tWaWV3SW1wbDo6aW5mb3JtVVJMQ2hhbmdlKCkK IFdLUGFnZVJlZiBFd2tWaWV3SW1wbDo6Y3JlYXRlTmV3UGFnZSgpCiB7CiAgICAgRXZhc19PYmpl Y3QqIG5ld0V3a1ZpZXcgPSAwOwotICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwo bV92aWV3LCAiY3JlYXRlLHdpbmRvdyIsICZuZXdFd2tWaWV3KTsKKyAgICBzbWFydENhbGxiYWNr PENyZWF0ZVdpbmRvdz4oKS5jYWxsKCZuZXdFd2tWaWV3KTsKIAogICAgIGlmICghbmV3RXdrVmll dykKICAgICAgICAgcmV0dXJuIDA7CkBAIC03NDksNyArNzQ5LDcgQEAgV0tQYWdlUmVmIEV3a1Zp ZXdJbXBsOjpjcmVhdGVOZXdQYWdlKCkKIAogdm9pZCBFd2tWaWV3SW1wbDo6Y2xvc2VQYWdlKCkK IHsKLSAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKG1fdmlldywgImNsb3NlLHdp bmRvdyIsIDApOworICAgIHNtYXJ0Q2FsbGJhY2s8Q2xvc2VXaW5kb3c+KCkuY2FsbCgpOwogfQog CiB2b2lkIEV3a1ZpZXdJbXBsOjpvbk1vdXNlRG93bih2b2lkKiBkYXRhLCBFdmFzKiwgRXZhc19P YmplY3QqLCB2b2lkKiBldmVudEluZm8pCg==