101358 2012-11-06 08:34:52 -0800 [WK2] Wrong scroll position when going back in history 2012-11-06 12:45:11 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abecsi laszlo.gombos lucas.de.marchi webkit.review.bot oldest_to_newest 759733 0 yael 2012-11-06 08:34:52 -0800 When loading page A, scrolling down, then loading page B, scrolling down, and then going back in history, the scroll position is not preserved. When we go back in history, we send the new visibleContentsRect to the web process, and that turns on the flag wasScrolledByUser. The history controller does not send the saved history scrollPosition, because this flag is set. Looking at it further, I found out that when the load is committed, we are still using the contentsSize of the previous page. Resetting the contentsSize of the page prevents prevents this bug. A patch is coming. 759738 1 172598 yael 2012-11-06 08:38:23 -0800 Created attachment 172598 Patch 759746 2 laszlo.gombos 2012-11-06 08:45:36 -0800 [EFL] prefix should be probably removed from the bug (title + ChangeLog). It looks good to me. 759748 3 yael 2012-11-06 08:55:48 -0800 (In reply to comment #2) > [EFL] prefix should be probably removed from the bug (title + ChangeLog). > > It looks good to me. Perhaps add [Qt] instead? This is not an issue for gtk or mac ports . 759757 4 laszlo.gombos 2012-11-06 09:19:02 -0800 > Perhaps add [Qt] instead? This is not an issue for gtk or mac ports . Yes, that is better. 759827 5 172598 kenneth 2012-11-06 10:23:50 -0800 Comment on attachment 172598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172598&action=review > Source/WebKit2/ChangeLog:3 > + [EFL][WK2] Wrong scroll position when going back in history Remove [EFL], as this code can be used be all. 759832 6 yael 2012-11-06 10:27:30 -0800 (In reply to comment #5) > (From update of attachment 172598 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172598&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL][WK2] Wrong scroll position when going back in history > > Remove [EFL], as this code can be used be all. ok 759844 7 172615 yael 2012-11-06 10:36:23 -0800 Created attachment 172615 Patch for landing. 759962 8 172615 webkit.review.bot 2012-11-06 12:45:07 -0800 Comment on attachment 172615 Patch for landing. Clearing flags on attachment: 172615 Committed r133659: <http://trac.webkit.org/changeset/133659> 759963 9 webkit.review.bot 2012-11-06 12:45:11 -0800 All reviewed patches have been landed. Closing bug. 172598 2012-11-06 08:38:23 -0800 2012-11-06 10:36:23 -0800 Patch 101356.patch text/plain 1512 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29u dHJvbGxlci5jcHAJKHJldmlzaW9uIDEzMzYxNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTUsNiArOTUs OSBAQAogICAgIC8vIERvIG5vdCBjb3VudCB0aGUgcHJldmlvdXMgY29tbWl0dGVkIHBhZ2UgY29u dGVudHMgYXMgY292ZXJlZC4KICAgICBtX2xhc3RGcmFtZUNvdmVyZWRSZWN0ID0gRmxvYXRSZWN0 KCk7CiAKKyAgICAvLyBEbyBub3QgY29udGludWUgdG8gdXNlIHRoZSBjb250ZW50IHNpemUgb2Yg dGhlIHByZXZpb3VzIHBhZ2UuCisgICAgbV9jb250ZW50c1NpemUgPSBJbnRTaXplKCk7CisKICAg ICAvLyBSZXNldCB0aGUgcG9zaXRpb24gdG8gdGhlIHRvcCwgcGFnZS9oaXN0b3J5IHNjcm9sbCBy ZXF1ZXN0cyBtYXkgb3ZlcnJpZGUgdGhpcyBiZWZvcmUgd2UgcmUtZW5hYmxlIHJlbmRlcmluZy4K ICAgICBhcHBseVBvc2l0aW9uQWZ0ZXJSZW5kZXJpbmdDb250ZW50cyhGbG9hdFBvaW50KCkpOwog fQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNjE3KQorKysgU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMDYgIFlhZWwg QWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gV3Jv bmcgc2Nyb2xsIHBvc2l0aW9uIHdoZW4gZ29pbmcgYmFjayBpbiBoaXN0b3J5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEzNTgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldCB0aGUgY29udGVudHNT aXplIGFmdGVyIGEgbmV3IGxvYWQgd2FzIGNvbW1pdHRlZC4gV2Ugc2hvdWxkIG5vdCBjb250aW51 ZQorICAgICAgICB0byB1c2UgdGhlIGNvbnRlbnRzU2l6ZSBvZiB0aGUgcHJldmlvdXMgcGFnZSBp biBhbnkgY2FsY3VsYXRpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29u dHJvbGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXI6OmRp ZENvbW1pdExvYWQpOgorCiAyMDEyLTExLTA2ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNv bXBhbnkxMDAubmV0PgogCiAgICAgICAgIENvb3JkaW5hdGVkIEdyYXBoaWNzOiBSZW1vdmUgYSBw YXJlbnQgbWVtYmVyIGluIFdlYkxheWVySW5mby4K 172615 2012-11-06 10:36:23 -0800 2012-11-06 12:45:07 -0800 Patch for landing. 101356.patch text/plain 1519 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29u dHJvbGxlci5jcHAJKHJldmlzaW9uIDEzMzYxNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QYWdlVmlld3BvcnRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTUsNiArOTUs OSBAQAogICAgIC8vIERvIG5vdCBjb3VudCB0aGUgcHJldmlvdXMgY29tbWl0dGVkIHBhZ2UgY29u dGVudHMgYXMgY292ZXJlZC4KICAgICBtX2xhc3RGcmFtZUNvdmVyZWRSZWN0ID0gRmxvYXRSZWN0 KCk7CiAKKyAgICAvLyBEbyBub3QgY29udGludWUgdG8gdXNlIHRoZSBjb250ZW50IHNpemUgb2Yg dGhlIHByZXZpb3VzIHBhZ2UuCisgICAgbV9jb250ZW50c1NpemUgPSBJbnRTaXplKCk7CisKICAg ICAvLyBSZXNldCB0aGUgcG9zaXRpb24gdG8gdGhlIHRvcCwgcGFnZS9oaXN0b3J5IHNjcm9sbCBy ZXF1ZXN0cyBtYXkgb3ZlcnJpZGUgdGhpcyBiZWZvcmUgd2UgcmUtZW5hYmxlIHJlbmRlcmluZy4K ICAgICBhcHBseVBvc2l0aW9uQWZ0ZXJSZW5kZXJpbmdDb250ZW50cyhGbG9hdFBvaW50KCkpOwog fQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNjE3KQorKysgU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMDYgIFlhZWwg QWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgorCisgICAgICAgIFtXSzJdIFdyb25nIHNj cm9sbCBwb3NpdGlvbiB3aGVuIGdvaW5nIGJhY2sgaW4gaGlzdG9yeQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgUmVzZXQgdGhlIGNv bnRlbnRzU2l6ZSBhZnRlciBhIG5ldyBsb2FkIHdhcyBjb21taXR0ZWQuIFdlIHNob3VsZCBub3Qg Y29udGludWUKKyAgICAgICAgdG8gdXNlIHRoZSBjb250ZW50c1NpemUgb2YgdGhlIHByZXZpb3Vz IHBhZ2UgaW4gYW55IGNhbGN1bGF0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VWaWV3 cG9ydENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9s bGVyOjpkaWRDb21taXRMb2FkKToKKwogMjAxMi0xMS0wNiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0 ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBHcmFwaGljczogUmVt b3ZlIGEgcGFyZW50IG1lbWJlciBpbiBXZWJMYXllckluZm8uCg==