101354 2012-11-06 08:00:43 -0800 Web Inspector: [Regression] Snippets evaluations should not appear in Sources tab of navigator. 2012-11-07 05:51:33 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 759705 0 vsevik 2012-11-06 08:00:43 -0800 Patch to follow 759712 1 172592 vsevik 2012-11-06 08:08:03 -0800 Created attachment 172592 Patch 760598 2 172592 webkit.review.bot 2012-11-07 05:51:30 -0800 Comment on attachment 172592 Patch Clearing flags on attachment: 172592 Committed r133746: <http://trac.webkit.org/changeset/133746> 760599 3 webkit.review.bot 2012-11-07 05:51:33 -0800 All reviewed patches have been landed. Closing bug. 172592 2012-11-06 08:08:03 -0800 2012-11-07 05:51:30 -0800 Patch bug-101354-20121106200615.patch text/plain 5936 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjIwNzAwMDk5MDVkNDkz NmM1NWJjYTg3NzM2MGFhNmI3MWE1ZDYwMi4uNjMxZmVlNjVjMjExMjAxYmNhMWM0ZTJlMjRkZjkz ZmMxNDQ1MzQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA2ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtSZWdyZXNzaW9uXSBTbmlwcGV0cyBldmFsdWF0aW9ucyBzaG91bGQgbm90IGFwcGVhciBp biBTb3VyY2VzIHRhYiBvZiBuYXZpZ2F0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEzNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRGVidWdnZXJTY3JpcHRN YXBwaW5nLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1VJU291cmNl Q29kZVByb3ZpZGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtVSVNvdXJjZUNv ZGVQcm92aWRlci5wcm90b3R5cGUuX3BhcnNlZFNjcmlwdFNvdXJjZSk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9TY3JpcHQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0 LnByb3RvdHlwZS5pc1NuaXBwZXQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2Ny aXB0U25pcHBldE1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdFNuaXBwZXRN b2RlbC5wcm90b3R5cGUuX3NuaXBwZXRJZEZvclNvdXJjZVVSTCk6CisKIDIwMTItMTEtMDYgIEFs ZXhlaSBGaWxpcHBvdiAgPGFscGhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlcG9ydCBwaHlzaWNhbCBtZW1vcnkgcmVhbGx5IGNvbW1pdHRlZCBmb3IgSlMgaGVhcCBp biBOTUkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVi dWdnZXJTY3JpcHRNYXBwaW5nLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EZWJ1Z2dlclNjcmlwdE1hcHBpbmcuanMKaW5kZXggZDMyYjJlNDU0YTI2NDNhZjU3MzBjNTFm YzUzNTc1ZTk5OWIyOTg4NS4uZmExYTZlOGExODhhMTdkZTA5ODUzOGVhMDAxNWViN2ZkMTgyMDEx NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWJ1Z2dl clNjcmlwdE1hcHBpbmcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EZWJ1Z2dlclNjcmlwdE1hcHBpbmcuanMKQEAgLTY1LDEwICs2NSw4IEBAIFdlYkluc3BlY3Rv ci5EZWJ1Z2dlclNjcmlwdE1hcHBpbmcucHJvdG90eXBlID0gewogICAgICAqLwogICAgIF9tYXBw aW5nRm9yU2NyaXB0OiBmdW5jdGlvbihzY3JpcHQpCiAgICAgewotICAgICAgICBpZiAoV2ViSW5z cGVjdG9yLmV4cGVyaW1lbnRzU2V0dGluZ3Muc25pcHBldHNTdXBwb3J0LmlzRW5hYmxlZCgpKSB7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fc25pcHBldE1hcHBpbmcgJiYgdGhpcy5fc25pcHBldE1h cHBpbmcuc25pcHBldElkRm9yU291cmNlVVJMKHNjcmlwdC5zb3VyY2VVUkwpKQotICAgICAgICAg ICAgICAgIHJldHVybiB0aGlzLl9zbmlwcGV0TWFwcGluZzsKLSAgICAgICAgfQorICAgICAgICBp ZiAoV2ViSW5zcGVjdG9yLmV4cGVyaW1lbnRzU2V0dGluZ3Muc25pcHBldHNTdXBwb3J0LmlzRW5h YmxlZCgpICYmIHNjcmlwdC5pc1NuaXBwZXQoKSkKKyAgICAgICAgICAgIHJldHVybiB0aGlzLl9z bmlwcGV0TWFwcGluZzsKIAogICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLnNldHRpbmdzLnNvdXJj ZU1hcHNFbmFibGVkLmdldCgpICYmIHNjcmlwdC5zb3VyY2VNYXBVUkwpIHsKICAgICAgICAgICAg IGlmICh0aGlzLl9jb21waWxlck1hcHBpbmcubG9hZFNvdXJjZU1hcEZvclNjcmlwdChzY3JpcHQp KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3Jr VUlTb3VyY2VDb2RlUHJvdmlkZXIuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05ldHdvcmtVSVNvdXJjZUNvZGVQcm92aWRlci5qcwppbmRleCAxMGZhODZjOTYwMTE5NjRl MmQ0M2JjODdjNjgyODIyZTgwNmMyMmU2Li5iMDk0YmZiOGRmMWY1ZWI1YzNjMjNlZThiOTI3ZTlj YWEzMWQxZWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L05ldHdvcmtVSVNvdXJjZUNvZGVQcm92aWRlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtVSVNvdXJjZUNvZGVQcm92aWRlci5qcwpAQCAtNzAsNiAr NzAsOCBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1VJU291cmNlQ29kZVByb3ZpZGVyLnByb3RvdHlw ZSA9IHsKICAgICAgICAgdmFyIHNjcmlwdCA9IC8qKiBAdHlwZSB7V2ViSW5zcGVjdG9yLlNjcmlw dH0gKi8gKGV2ZW50LmRhdGEpOwogICAgICAgICBpZiAoIXNjcmlwdC5zb3VyY2VVUkwgfHwgc2Ny aXB0LmlzSW5saW5lU2NyaXB0KCkpCiAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIGlmIChX ZWJJbnNwZWN0b3IuZXhwZXJpbWVudHNTZXR0aW5ncy5zbmlwcGV0c1N1cHBvcnQuaXNFbmFibGVk KCkgJiYgc2NyaXB0LmlzU25pcHBldCgpKQorICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB2 YXIgaXNEeW5hbWljQW5vbnltb3VzU2NyaXB0OwogICAgICAgICAvLyBPbmx5IGFkZCB1aVNvdXJj ZUNvZGVzIGZvcgogICAgICAgICAvLyAtIGNvbnRlbnQgc2NyaXB0czsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0LmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHQuanMKaW5kZXggNDQ1YzVkMTQwMTMwNDM4NTI5 MDJmN2FkYTUxNmNlMzY0NmMzYzgxZS4uZTc5NDQ3NzUyMWZhYjQ2YThmNDU2YjI4OGJkN2QwNjRh Nzk5ZDBiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T Y3JpcHQuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHQu anMKQEAgLTUwLDYgKzUwLDggQEAgV2ViSW5zcGVjdG9yLlNjcmlwdCA9IGZ1bmN0aW9uKHNjcmlw dElkLCBzb3VyY2VVUkwsIHN0YXJ0TGluZSwgc3RhcnRDb2x1bW4sIGVuZEwKICAgICB0aGlzLl9s b2NhdGlvbnMgPSBbXTsKIH0KIAorV2ViSW5zcGVjdG9yLlNjcmlwdC5zbmlwcGV0U291cmNlVVJM UHJlZml4ID0gInNuaXBwZXRzOi8vLyI7CisKIFdlYkluc3BlY3Rvci5TY3JpcHQucHJvdG90eXBl ID0gewogICAgIC8qKgogICAgICAqIEByZXR1cm4ge3N0cmluZ30KQEAgLTE3MCw2ICsxNzIsMTQg QEAgV2ViSW5zcGVjdG9yLlNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgfSwKIAogICAgIC8qKgor ICAgICAqIEByZXR1cm4ge2Jvb2xlYW59CisgICAgICovCisgICAgaXNTbmlwcGV0OiBmdW5jdGlv bigpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5zb3VyY2VVUkwgJiYgdGhpcy5zb3VyY2VV Ukwuc3RhcnRzV2l0aChXZWJJbnNwZWN0b3IuU2NyaXB0LnNuaXBwZXRTb3VyY2VVUkxQcmVmaXgp OworICAgIH0sCisKKyAgICAvKioKICAgICAgKiBAcGFyYW0ge251bWJlcn0gbGluZU51bWJlcgog ICAgICAqIEBwYXJhbSB7bnVtYmVyPX0gY29sdW1uTnVtYmVyCiAgICAgICogQHJldHVybiB7V2Vi SW5zcGVjdG9yLlVJTG9jYXRpb259CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1NjcmlwdFNuaXBwZXRNb2RlbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU2NyaXB0U25pcHBldE1vZGVsLmpzCmluZGV4IGJkMWY0NWI4ZmQ4MGFi OTVlNWY4NzZlNTkyOWUwZDBkNzIzMWYzMjUuLmExOTcwODNjZDdjMjg3MWI3Y2U1YTA1ZmM3Mzky M2Y1NTgwMjMxNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvU2NyaXB0U25pcHBldE1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2NyaXB0U25pcHBldE1vZGVsLmpzCkBAIC01MSw4ICs1MSw2IEBAIFdlYkluc3Bl Y3Rvci5TY3JpcHRTbmlwcGV0TW9kZWwgPSBmdW5jdGlvbih3b3Jrc3BhY2UsIG5ldHdvcmtXb3Jr c3BhY2VQcm92aWRlcikKICAgICB0aGlzLl9sb2FkU25pcHBldHMoKTsKIH0KIAotV2ViSW5zcGVj dG9yLlNjcmlwdFNuaXBwZXRNb2RlbC5zbmlwcGV0U291cmNlVVJMUHJlZml4ID0gInNuaXBwZXRz Oi8vLyI7Ci0KIFdlYkluc3BlY3Rvci5TY3JpcHRTbmlwcGV0TW9kZWwucHJvdG90eXBlID0gewog ICAgIC8qKgogICAgICAqIEByZXR1cm4ge1dlYkluc3BlY3Rvci5TbmlwcGV0U2NyaXB0TWFwcGlu Z30KQEAgLTMwMiw2ICszMDAsOCBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0U25pcHBldE1vZGVsLnBy b3RvdHlwZSA9IHsKICAgICBfYWRkU2NyaXB0OiBmdW5jdGlvbihzY3JpcHQpCiAgICAgewogICAg ICAgICB2YXIgc25pcHBldElkID0gdGhpcy5fc25pcHBldElkRm9yU291cmNlVVJMKHNjcmlwdC5z b3VyY2VVUkwpOworICAgICAgICBpZiAoIXNuaXBwZXRJZCkKKyAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgdmFyIHVpU291cmNlQ29kZSA9IHRoaXMuX3VpU291cmNlQ29kZUZvclNuaXBwZXRJ ZFtzbmlwcGV0SWRdOwogCiAgICAgICAgIGlmICghdWlTb3VyY2VDb2RlIHx8IHRoaXMuX2V2YWx1 YXRpb25Tb3VyY2VVUkwodWlTb3VyY2VDb2RlKSAhPT0gc2NyaXB0LnNvdXJjZVVSTCkgewpAQCAt MzgxLDEwICszODEsOSBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0U25pcHBldE1vZGVsLnByb3RvdHlw ZSA9IHsKICAgICAgKi8KICAgICBfZXZhbHVhdGlvblNvdXJjZVVSTDogZnVuY3Rpb24odWlTb3Vy Y2VDb2RlKQogICAgIHsKLSAgICAgICAgdmFyIHNuaXBwZXRQcmVmaXggPSBXZWJJbnNwZWN0b3Iu U2NyaXB0U25pcHBldE1vZGVsLnNuaXBwZXRTb3VyY2VVUkxQcmVmaXg7CiAgICAgICAgIHZhciBl dmFsdWF0aW9uU3VmZml4ID0gIl8iICsgdWlTb3VyY2VDb2RlLl9ldmFsdWF0aW9uSW5kZXg7CiAg ICAgICAgIHZhciBzbmlwcGV0SWQgPSB0aGlzLl9zbmlwcGV0SWRGb3JVSVNvdXJjZUNvZGUuZ2V0 KHVpU291cmNlQ29kZSk7Ci0gICAgICAgIHJldHVybiBzbmlwcGV0UHJlZml4ICsgc25pcHBldElk ICsgZXZhbHVhdGlvblN1ZmZpeDsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5TY3JpcHQu c25pcHBldFNvdXJjZVVSTFByZWZpeCArIHNuaXBwZXRJZCArIGV2YWx1YXRpb25TdWZmaXg7CiAg ICAgfSwKIAogICAgIC8qKgpAQCAtMzkzLDcgKzM5Miw3IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRT bmlwcGV0TW9kZWwucHJvdG90eXBlID0gewogICAgICAqLwogICAgIF9zbmlwcGV0SWRGb3JTb3Vy Y2VVUkw6IGZ1bmN0aW9uKHNvdXJjZVVSTCkKICAgICB7Ci0gICAgICAgIHZhciBzbmlwcGV0UHJl Zml4ID0gV2ViSW5zcGVjdG9yLlNjcmlwdFNuaXBwZXRNb2RlbC5zbmlwcGV0U291cmNlVVJMUHJl Zml4OworICAgICAgICB2YXIgc25pcHBldFByZWZpeCA9IFdlYkluc3BlY3Rvci5TY3JpcHQuc25p cHBldFNvdXJjZVVSTFByZWZpeDsKICAgICAgICAgaWYgKCFzb3VyY2VVUkwuc3RhcnRzV2l0aChz bmlwcGV0UHJlZml4KSkKICAgICAgICAgICAgIHJldHVybiBudWxsOwogICAgICAgICB2YXIgc3Bs aXR0ZWRVUkwgPSBzb3VyY2VVUkwuc3Vic3RyaW5nKHNuaXBwZXRQcmVmaXgubGVuZ3RoKS5zcGxp dCgiXyIpOwo=