<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101353</bug_id>
          
          <creation_ts>2012-11-06 07:49:08 -0800</creation_ts>
          <short_desc>[WTR] Reset EventSender before running each test.</short_desc>
          <delta_ts>2012-11-06 22:40:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>gustavo</cc>
    
    <cc>kenneth</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ossy</cc>
    
    <cc>philn</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>xan.lopez</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>759689</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 07:49:08 -0800</bug_when>
    <thetext>[WTR] Reset EventSender before running each test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759692</commentid>
    <comment_count>1</comment_count>
      <attachid>172588</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 07:51:31 -0800</bug_when>
    <thetext>Created attachment 172588
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759695</commentid>
    <comment_count>2</comment_count>
      <attachid>172588</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 07:53:26 -0800</bug_when>
    <thetext>Comment on attachment 172588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172588&amp;action=review

&gt; Tools/WebKitTestRunner/TestController.cpp:507
&gt; +    // Reset the EventSender for each test.
&gt; +#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL)
&gt; +    m_eventSenderProxy = adoptPtr(new EventSenderProxy(this));
&gt; +#endif

I&apos;m not 100% sure this is the best place to do it (we could make EventSendingController::makeWindowObject() send a message and act when it is received, for example), or whether calling some EventSenderProxy::resetState() makes more sense. I&apos;m open to suggestions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759703</commentid>
    <comment_count>3</comment_count>
      <attachid>172588</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2012-11-06 07:58:40 -0800</bug_when>
    <thetext>Comment on attachment 172588
Patch

Attachment 172588 did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14728855</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759710</commentid>
    <comment_count>4</comment_count>
      <attachid>172590</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 08:06:38 -0800</bug_when>
    <thetext>Created attachment 172590
Add dummy destructors to the mac/gtk/qt ports</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759724</commentid>
    <comment_count>5</comment_count>
      <attachid>172590</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2012-11-06 08:17:55 -0800</bug_when>
    <thetext>Comment on attachment 172590
Add dummy destructors to the mac/gtk/qt ports

Attachment 172590 did not pass win-ews (win):
Output: http://queues.webkit.org/results/14758008</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759729</commentid>
    <comment_count>6</comment_count>
      <attachid>172595</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 08:24:16 -0800</bug_when>
    <thetext>Created attachment 172595
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759741</commentid>
    <comment_count>7</comment_count>
      <attachid>172595</attachid>
    <who name="Rafael Brandao">rafael.lobo</who>
    <bug_when>2012-11-06 08:42:11 -0800</bug_when>
    <thetext>Comment on attachment 172595
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>759793</commentid>
    <comment_count>8</comment_count>
      <attachid>172595</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2012-11-06 09:58:44 -0800</bug_when>
    <thetext>Comment on attachment 172595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172595&amp;action=review

&gt; Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88
&gt; +EventSenderProxy::~EventSenderProxy()
&gt; +{
&gt; +}

Is there any port that requires a non-empty destructor? If not, you could remove them all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760079</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 14:51:54 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 172595 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=172595&amp;action=review
&gt; 
&gt; &gt; Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88
&gt; &gt; +EventSenderProxy::~EventSenderProxy()
&gt; &gt; +{
&gt; &gt; +}
&gt; 
&gt; Is there any port that requires a non-empty destructor? If not, you could remove them all.

The EFL one currently clears the list of selected touch points when ENABLE(TOUCH_EVENTS) is on, so I guess it makes sense to keep these for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760092</commentid>
    <comment_count>10</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-11-06 15:05:37 -0800</bug_when>
    <thetext>Committed r133676: &lt;http://trac.webkit.org/changeset/133676&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>760408</commentid>
    <comment_count>11</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-11-06 22:40:08 -0800</bug_when>
    <thetext>*** Bug 92231 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172588</attachid>
            <date>2012-11-06 07:51:31 -0800</date>
            <delta_ts>2012-11-06 08:06:28 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101353-20121106174830.patch</filename>
            <type>text/plain</type>
            <size>2661</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzMzYwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDIxIEBACisyMDEyLTExLTA2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1
Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFtXVFJdIFJlc2V0IEV2ZW50U2VuZGVy
IGJlZm9yZSBydW5uaW5nIGVhY2ggdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEwMTM1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIENvbnRyYXJ5IHRvIHdoYXQgd2FzIGRvbmUgdG8gYXQgbGVhc3Qg
c29tZSBwb3J0cyBpbiBEdW1wUmVuZGVyVHJlZSwKKyAgICAgICAgRXZlbnRTZW5kZXIgZGlkIG5v
dCBjdXJyZW50bHkgcmVzZXQgaXRzIHZhbHVlcyBpbiBXVFIuIFRoaXMgY2F1c2VkCisgICAgICAg
IGZsYWtpbmVzcyBpZiBhIHRlc3Qgc3VjaCBhcyBlZGl0aW5nL3NlbGVjdGlvbi9mYWtlLWRvdWJs
ZWNsaWNrLmh0bWwgd2FzCisgICAgICAgIHJ1biB0d2ljZSBpbiBhIHJvdywgc2luY2UgdGhlIGNs
aWNrIGNvdW50IHdhcyBub3QgcmVzZXQgYWNyb3NzIGVhY2gKKyAgICAgICAgcnVuLgorCisgICAg
ICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6
OlRlc3RDb250cm9sbGVyOjpUZXN0Q29udHJvbGxlcik6CisgICAgICAgIChXVFI6OlRlc3RDb250
cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKToKKyAgICAgICAgKiBXZWJLaXRU
ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmg6CisKIDIwMTItMTEtMDYgIFNhbWkgS3lvc3RpbGEg
IDxza3lvc3RpbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgZml4
ZWQgcG9zaXRpb24gY29tcG9zaXRpbmcgb24gQW5kcm9pZCBEUlQKSW5kZXg6IFRvb2xzL1dlYktp
dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktp
dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMzM2MDgpCisrKyBUb29s
cy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt
OTYsOSArOTYsNiBAQCBUZXN0Q29udHJvbGxlcjo6VGVzdENvbnRyb2xsZXIoaW50IGFyZ2MsCiAg
ICAgLCBtX2lzR2VvbG9jYXRpb25QZXJtaXNzaW9uQWxsb3dlZChmYWxzZSkKICAgICAsIG1fcG9s
aWN5RGVsZWdhdGVFbmFibGVkKGZhbHNlKQogICAgICwgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3Np
dmUoZmFsc2UpCi0jaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0o
R1RLKSB8fCBQTEFURk9STShFRkwpCi0gICAgLCBtX2V2ZW50U2VuZGVyUHJveHkobmV3IEV2ZW50
U2VuZGVyUHJveHkodGhpcykpCi0jZW5kaWYKIHsKICAgICBpbml0aWFsaXplKGFyZ2MsIGFyZ3Yp
OwogICAgIGNvbnRyb2xsZXIgPSB0aGlzOwpAQCAtNTA0LDYgKzUwMSwxMSBAQCBib29sIFRlc3RD
b250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0CiAKICAgICAvLyBGSVhNRTogVGhpcyBmdW5j
dGlvbiBzaG91bGQgYWxzbyBlbnN1cmUgdGhhdCB0aGVyZSBpcyBvbmx5IG9uZSBwYWdlIG9wZW4u
CiAKKyAgICAvLyBSZXNldCB0aGUgRXZlbnRTZW5kZXIgZm9yIGVhY2ggdGVzdC4KKyNpZiBQTEFU
Rk9STShNQUMpIHx8IFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVG
TCkKKyAgICBtX2V2ZW50U2VuZGVyUHJveHkgPSBhZG9wdFB0cihuZXcgRXZlbnRTZW5kZXJQcm94
eSh0aGlzKSk7CisjZW5kaWYKKwogICAgIC8vIFJlc2V0IHByZWZlcmVuY2VzCiAgICAgV0tQcmVm
ZXJlbmNlc1JlZiBwcmVmZXJlbmNlcyA9IFdLUGFnZUdyb3VwR2V0UHJlZmVyZW5jZXMobV9wYWdl
R3JvdXAuZ2V0KCkpOwogICAgIFdLUHJlZmVyZW5jZXNSZXNldFRlc3RSdW5uZXJPdmVycmlkZXMo
cHJlZmVyZW5jZXMpOwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxl
ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIu
aAkocmV2aXNpb24gMTMzNjA4KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJv
bGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzgsNyArMTc4LDcgQEAgcHJpdmF0ZToKICAgICBi
b29sIG1fcG9saWN5RGVsZWdhdGVFbmFibGVkOwogICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZVBl
cm1pc3NpdmU7CiAKLSAgICBFdmVudFNlbmRlclByb3h5KiBtX2V2ZW50U2VuZGVyUHJveHk7Cisg
ICAgT3duUHRyPEV2ZW50U2VuZGVyUHJveHk+IG1fZXZlbnRTZW5kZXJQcm94eTsKIAogICAgIFdv
cmtRdWV1ZU1hbmFnZXIgbV93b3JrUXVldWVNYW5hZ2VyOwogfTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172590</attachid>
            <date>2012-11-06 08:06:38 -0800</date>
            <delta_ts>2012-11-06 08:24:08 -0800</delta_ts>
            <desc>Add dummy destructors to the mac/gtk/qt ports</desc>
            <filename>bug-101353-20121106180338.patch</filename>
            <type>text/plain</type>
            <size>4771</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzMzYxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDMxIEBACisyMDEyLTExLTA2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1
Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFtXVFJdIFJlc2V0IEV2ZW50U2VuZGVy
IGJlZm9yZSBydW5uaW5nIGVhY2ggdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEwMTM1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIENvbnRyYXJ5IHRvIHdoYXQgd2FzIGRvbmUgdG8gYXQgbGVhc3Qg
c29tZSBwb3J0cyBpbiBEdW1wUmVuZGVyVHJlZSwKKyAgICAgICAgRXZlbnRTZW5kZXIgZGlkIG5v
dCBjdXJyZW50bHkgcmVzZXQgaXRzIHZhbHVlcyBpbiBXVFIuIFRoaXMgY2F1c2VkCisgICAgICAg
IGZsYWtpbmVzcyBpZiBhIHRlc3Qgc3VjaCBhcyBlZGl0aW5nL3NlbGVjdGlvbi9mYWtlLWRvdWJs
ZWNsaWNrLmh0bWwgd2FzCisgICAgICAgIHJ1biB0d2ljZSBpbiBhIHJvdywgc2luY2UgdGhlIGNs
aWNrIGNvdW50IHdhcyBub3QgcmVzZXQgYWNyb3NzIGVhY2gKKyAgICAgICAgcnVuLgorCisgICAg
ICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6
OlRlc3RDb250cm9sbGVyOjpUZXN0Q29udHJvbGxlcik6IERvIG5vdCBjcmVhdGUgbV9ldmVudFNl
bmRlclByb3h5CisgICAgICAgIGluIHRoZSBjb25zdHJ1Y3RvciBhbnltb3JlLCBpdCBpcyBjcmVh
dGVkIGluCisgICAgICAgIHJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMgbm93LgorICAgICAg
ICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyk6IFJl
Y3JlYXRlCisgICAgICAgIG1fZXZlbnRTZW5kZXJQcm94eSBldmVyeSB0aW1lIHRoaXMgbWV0aG9k
IGlzIHJ1bi4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmg6IE1h
a2UgbV9ldmVudFNlbmRlclByb3h5IGFuIE93blB0ci4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu
bmVyL2d0ay9FdmVudFNlbmRlclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5k
ZXJQcm94eTo6fkV2ZW50U2VuZGVyUHJveHkpOiBBZGQgYW4gZW1wdHkKKyAgICAgICAgaW1wbGVt
ZW50YXRpb24uCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94
eS5tbToKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6fkV2ZW50U2VuZGVyUHJveHkp
OiBEaXR0by4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlR
dC5jcHA6CisgICAgICAgIChXVFI6OkV2ZW50U2VuZGVyUHJveHk6On5FdmVudFNlbmRlclByb3h5
KTogRGl0dG8uCisKIDIwMTItMTEtMDYgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJvbWl1
bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgZml4ZWQgcG9zaXRpb24gY29tcG9z
aXRpbmcgb24gQW5kcm9pZCBEUlQKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENv
bnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENv
bnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMzM2MTEpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVy
L1Rlc3RDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTYsOSArOTYsNiBAQCBUZXN0
Q29udHJvbGxlcjo6VGVzdENvbnRyb2xsZXIoaW50IGFyZ2MsCiAgICAgLCBtX2lzR2VvbG9jYXRp
b25QZXJtaXNzaW9uQWxsb3dlZChmYWxzZSkKICAgICAsIG1fcG9saWN5RGVsZWdhdGVFbmFibGVk
KGZhbHNlKQogICAgICwgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmUoZmFsc2UpCi0jaWYgUExB
VEZPUk0oTUFDKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShF
RkwpCi0gICAgLCBtX2V2ZW50U2VuZGVyUHJveHkobmV3IEV2ZW50U2VuZGVyUHJveHkodGhpcykp
Ci0jZW5kaWYKIHsKICAgICBpbml0aWFsaXplKGFyZ2MsIGFyZ3YpOwogICAgIGNvbnRyb2xsZXIg
PSB0aGlzOwpAQCAtNTA0LDYgKzUwMSwxMSBAQCBib29sIFRlc3RDb250cm9sbGVyOjpyZXNldFN0
YXRlVG9Db25zaXN0CiAKICAgICAvLyBGSVhNRTogVGhpcyBmdW5jdGlvbiBzaG91bGQgYWxzbyBl
bnN1cmUgdGhhdCB0aGVyZSBpcyBvbmx5IG9uZSBwYWdlIG9wZW4uCiAKKyAgICAvLyBSZXNldCB0
aGUgRXZlbnRTZW5kZXIgZm9yIGVhY2ggdGVzdC4KKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRG
T1JNKFFUKSB8fCBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkKKyAgICBtX2V2ZW50U2Vu
ZGVyUHJveHkgPSBhZG9wdFB0cihuZXcgRXZlbnRTZW5kZXJQcm94eSh0aGlzKSk7CisjZW5kaWYK
KwogICAgIC8vIFJlc2V0IHByZWZlcmVuY2VzCiAgICAgV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJl
bmNlcyA9IFdLUGFnZUdyb3VwR2V0UHJlZmVyZW5jZXMobV9wYWdlR3JvdXAuZ2V0KCkpOwogICAg
IFdLUHJlZmVyZW5jZXNSZXNldFRlc3RSdW5uZXJPdmVycmlkZXMocHJlZmVyZW5jZXMpOwpJbmRl
eDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaAkocmV2aXNpb24gMTMzNjEx
KQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCSh3b3JraW5nIGNv
cHkpCkBAIC0xNzgsNyArMTc4LDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1fcG9saWN5RGVsZWdh
dGVFbmFibGVkOwogICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmU7CiAKLSAgICBF
dmVudFNlbmRlclByb3h5KiBtX2V2ZW50U2VuZGVyUHJveHk7CisgICAgT3duUHRyPEV2ZW50U2Vu
ZGVyUHJveHk+IG1fZXZlbnRTZW5kZXJQcm94eTsKIAogICAgIFdvcmtRdWV1ZU1hbmFnZXIgbV93
b3JrUXVldWVNYW5hZ2VyOwogfTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2
ZW50U2VuZGVyUHJveHlHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5u
ZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCShyZXZpc2lvbiAxMzM2MTEpCisrKyBUb29s
cy9XZWJLaXRUZXN0UnVubmVyL2d0ay9FdmVudFNlbmRlclByb3h5R3RrLmNwcAkod29ya2luZyBj
b3B5KQpAQCAtODMsNiArODMsMTAgQEAgRXZlbnRTZW5kZXJQcm94eTo6RXZlbnRTZW5kZXJQcm94
eShUZXN0QwogewogfQogCitFdmVudFNlbmRlclByb3h5Ojp+RXZlbnRTZW5kZXJQcm94eSgpCit7
Cit9CisKIHN0YXRpYyBndWludCBnZXRNb3VzZUJ1dHRvbk1vZGlmaWVycyhpbnQgZ2RrQnV0dG9u
KQogewogICAgIGlmIChnZGtCdXR0b24gPT0gMSkKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5u
ZXIvbWFjL0V2ZW50U2VuZGVyUHJveHkubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVz
dFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94eS5tbQkocmV2aXNpb24gMTMzNjExKQorKysgVG9v
bHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94eS5tbQkod29ya2luZyBjb3B5
KQpAQCAtMTExLDYgKzExMSwxMCBAQCBFdmVudFNlbmRlclByb3h5OjpFdmVudFNlbmRlclByb3h5
KFRlc3RDCiB7CiB9CiAKK0V2ZW50U2VuZGVyUHJveHk6On5FdmVudFNlbmRlclByb3h5KCkKK3sK
K30KKwogdm9pZCBFdmVudFNlbmRlclByb3h5Ojp1cGRhdGVDbGlja0NvdW50Rm9yQnV0dG9uKGlu
dCBidXR0b24pCiB7CiAgICAgaWYgKG1fdGltZSAtIG1fY2xpY2tUaW1lIDwgMSAmJiBtX3Bvc2l0
aW9uID09IG1fY2xpY2tQb3NpdGlvbiAmJiBidXR0b24gPT0gbV9jbGlja0J1dHRvbikgewpJbmRl
eDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9FdmVudFNlbmRlclByb3h5UXQuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvRXZlbnRTZW5kZXJQcm94eVF0LmNw
cAkocmV2aXNpb24gMTMzNjExKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9FdmVudFNl
bmRlclByb3h5UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03Miw2ICs3MiwxMCBAQCBFdmVudFNl
bmRlclByb3h5OjpFdmVudFNlbmRlclByb3h5KFRlc3RDCiAgICAgaXNSZXBsYXlpbmdFdmVudHMg
PSBmYWxzZTsKIH0KIAorRXZlbnRTZW5kZXJQcm94eTo6fkV2ZW50U2VuZGVyUHJveHkoKQorewor
fQorCiBzdGF0aWMgUXQ6Ok1vdXNlQnV0dG9uIGdldE1vdXNlQnV0dG9uKHVuc2lnbmVkIGJ1dHRv
bikKIHsKICAgICBRdDo6TW91c2VCdXR0b24gbW91c2VCdXR0b247Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172595</attachid>
            <date>2012-11-06 08:24:16 -0800</date>
            <delta_ts>2012-11-06 09:58:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101353-20121106182116.patch</filename>
            <type>text/plain</type>
            <size>4893</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDEzMzYxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDMyIEBACisyMDEyLTExLTA2ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1
Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFtXVFJdIFJlc2V0IEV2ZW50U2VuZGVy
IGJlZm9yZSBydW5uaW5nIGVhY2ggdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEwMTM1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIENvbnRyYXJ5IHRvIHdoYXQgd2FzIGRvbmUgdG8gYXQgbGVhc3Qg
c29tZSBwb3J0cyBpbiBEdW1wUmVuZGVyVHJlZSwKKyAgICAgICAgRXZlbnRTZW5kZXIgZGlkIG5v
dCBjdXJyZW50bHkgcmVzZXQgaXRzIHZhbHVlcyBpbiBXVFIuIFRoaXMgY2F1c2VkCisgICAgICAg
IGZsYWtpbmVzcyBpZiBhIHRlc3Qgc3VjaCBhcyBlZGl0aW5nL3NlbGVjdGlvbi9mYWtlLWRvdWJs
ZWNsaWNrLmh0bWwgd2FzCisgICAgICAgIHJ1biB0d2ljZSBpbiBhIHJvdywgc2luY2UgdGhlIGNs
aWNrIGNvdW50IHdhcyBub3QgcmVzZXQgYWNyb3NzIGVhY2gKKyAgICAgICAgcnVuLgorCisgICAg
ICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6
OlRlc3RDb250cm9sbGVyOjpUZXN0Q29udHJvbGxlcik6IERvIG5vdCBjcmVhdGUgbV9ldmVudFNl
bmRlclByb3h5CisgICAgICAgIGluIHRoZSBjb25zdHJ1Y3RvciBhbnltb3JlLCBpdCBpcyBjcmVh
dGVkIGluCisgICAgICAgIHJlc2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMgbm93LgorICAgICAg
ICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyk6IFJl
Y3JlYXRlCisgICAgICAgIG1fZXZlbnRTZW5kZXJQcm94eSBldmVyeSB0aW1lIHRoaXMgbWV0aG9k
IGlzIHJ1bi4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmg6IE1h
a2UgbV9ldmVudFNlbmRlclByb3h5IGFuIE93blB0cgorICAgICAgICBhbmQgZ3VhcmQgaXQgd2l0
aCBhIHBsYXRmb3JtICNpZmRlZi4KKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL2d0ay9FdmVu
dFNlbmRlclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6fkV2
ZW50U2VuZGVyUHJveHkpOiBBZGQgYW4gZW1wdHkKKyAgICAgICAgaW1wbGVtZW50YXRpb24uCisg
ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94eS5tbToKKyAgICAg
ICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6fkV2ZW50U2VuZGVyUHJveHkpOiBEaXR0by4KKyAg
ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlRdC5jcHA6CisgICAg
ICAgIChXVFI6OkV2ZW50U2VuZGVyUHJveHk6On5FdmVudFNlbmRlclByb3h5KTogRGl0dG8uCisK
IDIwMTItMTEtMDYgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJvbWl1bS5vcmc+CiAKICAg
ICAgICAgW2Nocm9taXVtXSBFbmFibGUgZml4ZWQgcG9zaXRpb24gY29tcG9zaXRpbmcgb24gQW5k
cm9pZCBEUlQKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3Bw
CShyZXZpc2lvbiAxMzM2MTIpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9s
bGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTYsOSArOTYsNiBAQCBUZXN0Q29udHJvbGxlcjo6
VGVzdENvbnRyb2xsZXIoaW50IGFyZ2MsCiAgICAgLCBtX2lzR2VvbG9jYXRpb25QZXJtaXNzaW9u
QWxsb3dlZChmYWxzZSkKICAgICAsIG1fcG9saWN5RGVsZWdhdGVFbmFibGVkKGZhbHNlKQogICAg
ICwgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmUoZmFsc2UpCi0jaWYgUExBVEZPUk0oTUFDKSB8
fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpCi0gICAgLCBt
X2V2ZW50U2VuZGVyUHJveHkobmV3IEV2ZW50U2VuZGVyUHJveHkodGhpcykpCi0jZW5kaWYKIHsK
ICAgICBpbml0aWFsaXplKGFyZ2MsIGFyZ3YpOwogICAgIGNvbnRyb2xsZXIgPSB0aGlzOwpAQCAt
NTA0LDYgKzUwMSwxMSBAQCBib29sIFRlc3RDb250cm9sbGVyOjpyZXNldFN0YXRlVG9Db25zaXN0
CiAKICAgICAvLyBGSVhNRTogVGhpcyBmdW5jdGlvbiBzaG91bGQgYWxzbyBlbnN1cmUgdGhhdCB0
aGVyZSBpcyBvbmx5IG9uZSBwYWdlIG9wZW4uCiAKKyAgICAvLyBSZXNldCB0aGUgRXZlbnRTZW5k
ZXIgZm9yIGVhY2ggdGVzdC4KKyNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFFUKSB8fCBQ
TEFURk9STShHVEspIHx8IFBMQVRGT1JNKEVGTCkKKyAgICBtX2V2ZW50U2VuZGVyUHJveHkgPSBh
ZG9wdFB0cihuZXcgRXZlbnRTZW5kZXJQcm94eSh0aGlzKSk7CisjZW5kaWYKKwogICAgIC8vIFJl
c2V0IHByZWZlcmVuY2VzCiAgICAgV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlcyA9IFdLUGFn
ZUdyb3VwR2V0UHJlZmVyZW5jZXMobV9wYWdlR3JvdXAuZ2V0KCkpOwogICAgIFdLUHJlZmVyZW5j
ZXNSZXNldFRlc3RSdW5uZXJPdmVycmlkZXMocHJlZmVyZW5jZXMpOwpJbmRleDogVG9vbHMvV2Vi
S2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktp
dFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaAkocmV2aXNpb24gMTMzNjEyKQorKysgVG9vbHMv
V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNzgs
NyArMTc4LDkgQEAgcHJpdmF0ZToKICAgICBib29sIG1fcG9saWN5RGVsZWdhdGVFbmFibGVkOwog
ICAgIGJvb2wgbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmU7CiAKLSAgICBFdmVudFNlbmRlclBy
b3h5KiBtX2V2ZW50U2VuZGVyUHJveHk7CisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShR
VCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpCisgICAgT3duUHRyPEV2ZW50U2Vu
ZGVyUHJveHk+IG1fZXZlbnRTZW5kZXJQcm94eTsKKyNlbmRpZgogCiAgICAgV29ya1F1ZXVlTWFu
YWdlciBtX3dvcmtRdWV1ZU1hbmFnZXI7CiB9OwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5l
ci9ndGsvRXZlbnRTZW5kZXJQcm94eUd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0
VGVzdFJ1bm5lci9ndGsvRXZlbnRTZW5kZXJQcm94eUd0ay5jcHAJKHJldmlzaW9uIDEzMzYxMikK
KysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL0V2ZW50U2VuZGVyUHJveHlHdGsuY3BwCSh3
b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4MywxMCBAQCBFdmVudFNlbmRlclByb3h5OjpFdmVudFNl
bmRlclByb3h5KFRlc3RDCiB7CiB9CiAKK0V2ZW50U2VuZGVyUHJveHk6On5FdmVudFNlbmRlclBy
b3h5KCkKK3sKK30KKwogc3RhdGljIGd1aW50IGdldE1vdXNlQnV0dG9uTW9kaWZpZXJzKGludCBn
ZGtCdXR0b24pCiB7CiAgICAgaWYgKGdka0J1dHRvbiA9PSAxKQpJbmRleDogVG9vbHMvV2ViS2l0
VGVzdFJ1bm5lci9tYWMvRXZlbnRTZW5kZXJQcm94eS5tbQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9X
ZWJLaXRUZXN0UnVubmVyL21hYy9FdmVudFNlbmRlclByb3h5Lm1tCShyZXZpc2lvbiAxMzM2MTIp
CisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9FdmVudFNlbmRlclByb3h5Lm1tCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xMTEsNiArMTExLDEwIEBAIEV2ZW50U2VuZGVyUHJveHk6OkV2ZW50U2Vu
ZGVyUHJveHkoVGVzdEMKIHsKIH0KIAorRXZlbnRTZW5kZXJQcm94eTo6fkV2ZW50U2VuZGVyUHJv
eHkoKQoreworfQorCiB2b2lkIEV2ZW50U2VuZGVyUHJveHk6OnVwZGF0ZUNsaWNrQ291bnRGb3JC
dXR0b24oaW50IGJ1dHRvbikKIHsKICAgICBpZiAobV90aW1lIC0gbV9jbGlja1RpbWUgPCAxICYm
IG1fcG9zaXRpb24gPT0gbV9jbGlja1Bvc2l0aW9uICYmIGJ1dHRvbiA9PSBtX2NsaWNrQnV0dG9u
KSB7CkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlRdC5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9FdmVudFNlbmRlclBy
b3h5UXQuY3BwCShyZXZpc2lvbiAxMzM2MTIpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0
L0V2ZW50U2VuZGVyUHJveHlRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyLDYgKzcyLDEwIEBA
IEV2ZW50U2VuZGVyUHJveHk6OkV2ZW50U2VuZGVyUHJveHkoVGVzdEMKICAgICBpc1JlcGxheWlu
Z0V2ZW50cyA9IGZhbHNlOwogfQogCitFdmVudFNlbmRlclByb3h5Ojp+RXZlbnRTZW5kZXJQcm94
eSgpCit7Cit9CisKIHN0YXRpYyBRdDo6TW91c2VCdXR0b24gZ2V0TW91c2VCdXR0b24odW5zaWdu
ZWQgYnV0dG9uKQogewogICAgIFF0OjpNb3VzZUJ1dHRvbiBtb3VzZUJ1dHRvbjsK
</data>
<flag name="review"
          id="186967"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>