101343 2012-11-06 06:39:45 -0800 [EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot 2012-11-07 00:53:27 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d-r d-r eric kenneth lucas.de.marchi tmpsantos webkit.review.bot oldest_to_newest 759622 0 d-r 2012-11-06 06:39:45 -0800 Test fails because WebKit is in shouldRespectImageOrientation=0 mode, see https://bugs.webkit.org/show_bug.cgi?id=100698#c17 760424 1 d-r 2012-11-06 23:53:54 -0800 Nico helpfully explained that we need to include Cairo in the ifdef in RenderObject::shouldRespectImageOrientation: https://bugs.webkit.org/show_bug.cgi?id=100698#c18 760434 2 172728 d-r 2012-11-07 00:29:48 -0800 Created attachment 172728 Patch 760441 3 d-r 2012-11-07 00:41:04 -0800 Committed r133728: <http://trac.webkit.org/changeset/133728> 172728 2012-11-07 00:29:48 -0800 2012-11-07 00:53:27 -0800 Patch bug-101343-20121107103136.patch text/plain 3410 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI2MzdkZDI0ZjcxOWMz MmFlYmQ0OWNjYjkyNmMzNmU4ZWY2ZWY4Ni4uYzIzYzViYjQ1YmRjMzM3MDE5Y2I5ODBhZjczNWQ5 ZjAxZGYyNmE2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA3ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W0VGTF0gRml4IGV4ZWN1dGlvbiBvZiBleGlmLW9yaWVudGF0aW9uLWltYWdlLWRvY3VtZW50Lmh0 bWwgb24gRUZMIFdrMiBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTM0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBDYWlybyB0byB0aGUgbGlzdCBvZiBiYWNrZW5kcyB0aGF0IHN1cHBvcnQg c2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBm aXhlcyBleGlmLW9yaWVudGF0aW9uLWltYWdlLWRvY3VtZW50Lmh0bWwuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVj dDo6c2hvdWxkUmVzcGVjdEltYWdlT3JpZW50YXRpb24pOgorCiAyMDEyLTExLTA2ICBLZWlzaGkg SGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBtb250aCBw aWNraW5nIHRvIGNhbGVuZGFyIHBpY2tlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy T2JqZWN0LmNwcAppbmRleCA5OGQwYzNkZGY2NGM0N2RkMWY0ODdkMjU0MGVlYmE3YzhkN2FkM2Ey Li40YmIwYTNkY2RiMzJhNGI0ZGZjNGIyOTE2YzljZGNhYmIzNzBjYTk2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMjIyNyw3ICsyMjI3LDcgQEAgUmVz cGVjdEltYWdlT3JpZW50YXRpb25FbnVtIFJlbmRlck9iamVjdDo6c2hvdWxkUmVzcGVjdEltYWdl T3JpZW50YXRpb24oKSBjb25zdAogICAgIC8vIFJlc3BlY3QgdGhlIGltYWdlJ3Mgb3JpZW50YXRp b24gaWYgaXQncyBiZWluZyB1c2VkIGFzIGEgZnVsbC1wYWdlIGltYWdlIG9yIGl0J3MKICAgICAv LyBhbiA8aW1nPiBhbmQgdGhlIHNldHRpbmcgdG8gcmVzcGVjdCBpdCBldmVyeXdoZXJlIGlzIHNl dC4KICAgICByZXR1cm4KLSNpZiBVU0UoQ0cpIHx8IFBMQVRGT1JNKENIUk9NSVVNKQorI2lmIFVT RShDRykgfHwgUExBVEZPUk0oQ0hST01JVU0pIHx8IFVTRShDQUlSTykKICAgICAgICAgLy8gVGhp cyBjYW4gb25seSBiZSBlbmFibGVkIGZvciBwb3J0cyB3aGljaCBob25vciB0aGUgb3JpZW50YXRp b24gZmxhZyBpbiB0aGVpciBkcmF3aW5nIGNvZGUuCiAgICAgICAgIGRvY3VtZW50KCktPmlzSW1h Z2VEb2N1bWVudCgpIHx8CiAjZW5kaWYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhMWRlZmFhOWI2OWY3YmJlMDcxZWEyZWUw ZThiOTE1YmYxOTI0MWE5Li4xMTYwYTE0YzhkYjRjNmU0OTI1NWI5OTdmNzc0NmVmM2U5ZjQwYzVh IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMDcgIERvbWluaWsgUsO2dHRzY2hlcyAg PGRvbWluaWsucm90dHNjaGVzQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggZXhlY3V0 aW9uIG9mIGV4aWYtb3JpZW50YXRpb24taW1hZ2UtZG9jdW1lbnQuaHRtbCBvbiBFRkwgV2syIGJv dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMzQz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lw cGluZyBleGlmLW9yaWVudGF0aW9uLWltYWdlLWRvY3VtZW50Lmh0bWwgbm93IHRoYXQgcmVzcGVj dGluZworICAgICAgICBvcmllbnRhdGlvbiBpcyBkZWZhdWx0IGVuYWJsZWQgZm9yIGltYWdlIGRv Y3VtZW50cy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9uczoK KwogMjAxMi0xMS0wNiAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF1bV0syXSBtZWRpYS9tZWRpYS1jb250aW51ZXMtcGxheWluZy1hZnRlci1yZXBs YWNlLXNvdXJjZS5odG1sIGZhaWxzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l Zmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggYTM5ZTEyYTlkMTczZTdkOWM5M2Y0MDFkNmNkNDAyNmJjMWMy ZTBlZC4uNDBjZTlhYzJmZmQzMWFkYzJiN2IxZGFlZjg1OWJhOTA4NzlkNWM2ZSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjU2LDkgKzI1 Niw2IEBAIHdlYmtpdC5vcmcvYi85ODc0MCBwbHVnaW5zL25wcnVudGltZS9kZWxldGUtcGx1Z2lu LXdpdGhpbi1oYXNQcm9wZXJ0eS1yZXR1cm4tZmFsCiB3ZWJraXQub3JnL2IvOTg3NDAgcGx1Z2lu cy9ucHJ1bnRpbWUvZGVsZXRlLXBsdWdpbi13aXRoaW4taGFzUHJvcGVydHktcmV0dXJuLXRydWUu aHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk4NzQwIHBsdWdpbnMvbnBydW50aW1lL2Rl bGV0ZS1wbHVnaW4td2l0aGluLXNldFByb3BlcnR5Lmh0bWwgWyBGYWlsdXJlIF0KIAotIyBUZXN0 IGZhaWxzIGJlY2F1c2UgV2ViS2l0IGlzIGluIHNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9u PTAgbW9kZS4KLXdlYmtpdC5vcmcvYi8xMDEzNDMgZmFzdC9pbWFnZXMvZXhpZi1vcmllbnRhdGlv bi1pbWFnZS1kb2N1bWVudC5odG1sIFsgRmFpbHVyZSBdCi0KICMgSHR0cCBwbHVnaW4gdGVzdCBm YWlsdXJlcy4KIHdlYmtpdC5vcmcvYi85OTU2MSBodHRwL3Rlc3RzL3BsdWdpbnMvcGx1Z2luLWRv Y3VtZW50LWhhcy1mb2N1cy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvOTk1NjIgaHR0 cC90ZXN0cy9wbHVnaW5zL3Bvc3QtdXJsLWZpbGUuaHRtbCBbIEZhaWx1cmUgXQo=