101319 2012-11-06 01:07:14 -0800 ScriptWrappable should work for more than just Node 2012-11-06 10:20:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101279 1 abarth abarth barraclough eric ggaren haraken oliver sam webkit.review.bot oldest_to_newest 759364 0 abarth 2012-11-06 01:07:14 -0800 ScriptWrappable should work for more than just Node 759365 1 172510 abarth 2012-11-06 01:08:50 -0800 Created attachment 172510 Patch 759372 2 172510 eric 2012-11-06 01:21:35 -0800 Comment on attachment 172510 Patch LGTM. Mostly just moving code. YOu may want ggaren, olliej, gavin, etc. to look before you land -- their JSC knowledge is much fresher than mine. 759375 3 172510 haraken 2012-11-06 01:23:03 -0800 Comment on attachment 172510 Patch LGTM too. 759665 4 abarth 2012-11-06 07:33:55 -0800 @ggaren: Would you like to take a look before I land this patch? This is related to http://lists.webkit.org/pipermail/webkit-dev/2012-November/022737.html 759788 5 172510 abarth 2012-11-06 09:45:50 -0800 Comment on attachment 172510 Patch This patch combined with the patch in bug 101279 is a 69% improvement for JSC in the performance of document.implementation. I'd like to move forward with these patches. ggaren, if you have feedback, I'm happy to address it in a followup patch. 759824 6 172510 webkit.review.bot 2012-11-06 10:20:14 -0800 Comment on attachment 172510 Patch Clearing flags on attachment: 172510 Committed r133633: <http://trac.webkit.org/changeset/133633> 759825 7 webkit.review.bot 2012-11-06 10:20:18 -0800 All reviewed patches have been landed. Closing bug. 172510 2012-11-06 01:08:50 -0800 2012-11-06 10:20:14 -0800 Patch bug-101319-20121106010704.patch text/plain 5112 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFiMjFkNGQ5ZGYxMGM0 MGQ2YmQ5YzQ3Nzk2YjcxZGZmN2MyYjRjOC4uMzgzNTZmM2I1NDFiNGE4NDhhM2U2NzdiOGQyOWEx YjhjOTUzNjQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTA2ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU2NyaXB0V3JhcHBhYmxlIHNo b3VsZCB3b3JrIGZvciBtb3JlIHRoYW4ganVzdCBOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGdlbmVyYWxpemVzIHRoZSBpbmxp bmUgY2FjaGVkIHdyYXBwZXIgY29kZSBwYXRoIHRvIHdvcmsgd2l0aAorICAgICAgICBhbGwgc3Vi Y2xhc3NlcyBvZiBTY3JpcHRXcmFwcGFibGUsIG5vdCBqdXN0IE5vZGUuCisKKyAgICAgICAgKiBi aW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnNldElubGluZUNh Y2hlZFdyYXBwZXIpOgorICAgICAgICAoV2ViQ29yZTo6Z2V0SW5saW5lQ2FjaGVkV3JhcHBlcik6 CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmNsZWFySW5saW5lQ2FjaGVk V3JhcHBlcik6CisgICAgICAgIChXZWJDb3JlOjpjYWNoZVdyYXBwZXIpOgorICAgICAgICAqIGJp bmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5oOgorCiAyMDEyLTExLTA2ICBOaWtpdGEgVmFzaWx5ZXYg IDxtZUBlbHYxcy5ydT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb25zb2xlOiB3cmFwIGxv bmcgVVJMcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5k aW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAppbmRleCAx ZWZhNGIzMDRmNjJiNzAxNWVhMWU1ZGU3MWMyZWM4ZGU0YmM1ODBiLi4wODEyY2JlZWY2NThiYjlh NDE3YzZkYjRkNTY4M2MyZThmMzNmNGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUJpbmRpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RPTUJpbmRpbmcuaApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAj aW5jbHVkZSAiRWxlbWVudC5oIgogI2luY2x1ZGUgIk1lZGlhTGlzdC5oIgorI2luY2x1ZGUgIlNj cmlwdFdyYXBwYWJsZS5oIgogI2luY2x1ZGUgIlN0eWxlUHJvcGVydHlTZXQuaCIKICNpbmNsdWRl ICJTdHlsZWRFbGVtZW50LmgiCiAjaW5jbHVkZSA8aGVhcC9XZWFrLmg+CkBAIC0xMjksMTEgKzEz MCwzMyBAQCBlbnVtIFBhcmFtZXRlckRlZmF1bHRQb2xpY3kgewogICAgICAgICByZXR1cm4gSlND Ojpqc0Nhc3Q8SlNDOjpKU09iamVjdCo+KGFzT2JqZWN0KGdldERPTVN0cnVjdHVyZTxXcmFwcGVy Q2xhc3M+KGV4ZWMsIEpTQzo6anNDYXN0PEpTRE9NR2xvYmFsT2JqZWN0Kj4oZ2xvYmFsT2JqZWN0 KSktPnN0b3JlZFByb3RvdHlwZSgpKSk7CiAgICAgfQogCi0gICAgLy8gT3ZlcmxvYWQgdGhlc2Ug ZnVuY3Rpb25zIHRvIHByb3ZpZGUgYSBmYXN0IHBhdGggZm9yIHdyYXBwZXIgYWNjZXNzLgogICAg IGlubGluZSBKU0RPTVdyYXBwZXIqIGdldElubGluZUNhY2hlZFdyYXBwZXIoRE9NV3JhcHBlcldv cmxkKiwgdm9pZCopIHsgcmV0dXJuIDA7IH0KLSAgICBpbmxpbmUgYm9vbCBzZXRJbmxpbmVDYWNo ZWRXcmFwcGVyKERPTVdyYXBwZXJXb3JsZCosIHZvaWQqLCBKU0RPTVdyYXBwZXIqKSB7IHJldHVy biBmYWxzZTsgfQorICAgIGlubGluZSBib29sIHNldElubGluZUNhY2hlZFdyYXBwZXIoRE9NV3Jh cHBlcldvcmxkKiwgdm9pZCosIEpTRE9NV3JhcHBlciosIEpTQzo6V2Vha0hhbmRsZU93bmVyKiwg dm9pZCopIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgaW5saW5lIGJvb2wgY2xlYXJJbmxpbmVDYWNo ZWRXcmFwcGVyKERPTVdyYXBwZXJXb3JsZCosIHZvaWQqLCBKU0RPTVdyYXBwZXIqKSB7IHJldHVy biBmYWxzZTsgfQogCisgICAgaW5saW5lIEpTRE9NV3JhcHBlciogZ2V0SW5saW5lQ2FjaGVkV3Jh cHBlcihET01XcmFwcGVyV29ybGQqIHdvcmxkLCBTY3JpcHRXcmFwcGFibGUqIGRvbU9iamVjdCkK KyAgICB7CisgICAgICAgIGlmICghd29ybGQtPmlzTm9ybWFsKCkpCisgICAgICAgICAgICByZXR1 cm4gMDsKKyAgICAgICAgcmV0dXJuIGRvbU9iamVjdC0+d3JhcHBlcigpOworICAgIH0KKworICAg IGlubGluZSBib29sIHNldElubGluZUNhY2hlZFdyYXBwZXIoRE9NV3JhcHBlcldvcmxkKiB3b3Js ZCwgU2NyaXB0V3JhcHBhYmxlKiBkb21PYmplY3QsIEpTRE9NV3JhcHBlciogd3JhcHBlciwgSlND OjpXZWFrSGFuZGxlT3duZXIqIHdyYXBwZXJPd25lciwgdm9pZCogY29udGV4dCkKKyAgICB7Cisg ICAgICAgIGlmICghd29ybGQtPmlzTm9ybWFsKCkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIGRvbU9iamVjdC0+c2V0V3JhcHBlcigqd29ybGQtPmdsb2JhbERhdGEoKSwgd3Jh cHBlciwgd3JhcHBlck93bmVyLCBjb250ZXh0KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAg fQorCisgICAgaW5saW5lIGJvb2wgY2xlYXJJbmxpbmVDYWNoZWRXcmFwcGVyKERPTVdyYXBwZXJX b3JsZCogd29ybGQsIFNjcmlwdFdyYXBwYWJsZSogZG9tT2JqZWN0LCBKU0RPTVdyYXBwZXIqIHdy YXBwZXIpCisgICAgeworICAgICAgICBpZiAoIXdvcmxkLT5pc05vcm1hbCgpKQorICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgICAgICBkb21PYmplY3QtPmNsZWFyV3JhcHBlcih3cmFwcGVy KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCiAgICAgdGVtcGxhdGUgPHR5cGVuYW1l IERPTUNsYXNzPiBpbmxpbmUgSlNET01XcmFwcGVyKiBnZXRDYWNoZWRXcmFwcGVyKERPTVdyYXBw ZXJXb3JsZCogd29ybGQsIERPTUNsYXNzKiBkb21PYmplY3QpCiAgICAgewogICAgICAgICBpZiAo SlNET01XcmFwcGVyKiB3cmFwcGVyID0gZ2V0SW5saW5lQ2FjaGVkV3JhcHBlcih3b3JsZCwgZG9t T2JqZWN0KSkKQEAgLTE0Myw5ICsxNjYsMTEgQEAgZW51bSBQYXJhbWV0ZXJEZWZhdWx0UG9saWN5 IHsKIAogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBET01DbGFzcz4gaW5saW5lIHZvaWQgY2FjaGVX cmFwcGVyKERPTVdyYXBwZXJXb3JsZCogd29ybGQsIERPTUNsYXNzKiBkb21PYmplY3QsIEpTRE9N V3JhcHBlciogd3JhcHBlcikKICAgICB7Ci0gICAgICAgIGlmIChzZXRJbmxpbmVDYWNoZWRXcmFw cGVyKHdvcmxkLCBkb21PYmplY3QsIHdyYXBwZXIpKQorICAgICAgICBKU0M6OldlYWtIYW5kbGVP d25lciogb3duZXIgPSB3cmFwcGVyT3duZXIod29ybGQsIGRvbU9iamVjdCk7CisgICAgICAgIHZv aWQqIGNvbnRleHQgPSB3cmFwcGVyQ29udGV4dCh3b3JsZCwgZG9tT2JqZWN0KTsKKyAgICAgICAg aWYgKHNldElubGluZUNhY2hlZFdyYXBwZXIod29ybGQsIGRvbU9iamVjdCwgd3JhcHBlciwgb3du ZXIsIGNvbnRleHQpKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBKU0M6OlBhc3NXZWFr PEpTRE9NV3JhcHBlcj4gcGFzc1dlYWsod3JhcHBlciwgd3JhcHBlck93bmVyKHdvcmxkLCBkb21P YmplY3QpLCB3cmFwcGVyQ29udGV4dCh3b3JsZCwgZG9tT2JqZWN0KSk7CisgICAgICAgIEpTQzo6 UGFzc1dlYWs8SlNET01XcmFwcGVyPiBwYXNzV2Vhayh3cmFwcGVyLCBvd25lciwgY29udGV4dCk7 CiAgICAgICAgIHdlYWtBZGQod29ybGQtPm1fd3JhcHBlcnMsICh2b2lkKilkb21PYmplY3QsIHBh c3NXZWFrKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTTm9kZUN1c3RvbS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNOb2RlQ3VzdG9t LmgKaW5kZXggZTRhZjgwMzZjNzFlMWQ0MTQxZjU0ZjhkMGRiNWFmYjY1YmZmYzhjMy4uY2MwNGZi ZmU5NDU4OTJmNjQ3NTJmZjQ3MWQyZTkwOGM5MzI3YjQ1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNOb2RlQ3VzdG9tLmgKQEAgLTMyLDI5ICszMiw2IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotaW5saW5lIEpTRE9NV3JhcHBlciogZ2V0SW5saW5lQ2FjaGVkV3JhcHBlcihE T01XcmFwcGVyV29ybGQqIHdvcmxkLCBOb2RlKiBub2RlKQotewotICAgIGlmICghd29ybGQtPmlz Tm9ybWFsKCkpCi0gICAgICAgIHJldHVybiAwOwotICAgIHJldHVybiBub2RlLT53cmFwcGVyKCk7 Ci19Ci0KLWlubGluZSBib29sIHNldElubGluZUNhY2hlZFdyYXBwZXIoRE9NV3JhcHBlcldvcmxk KiB3b3JsZCwgTm9kZSogbm9kZSwgSlNET01XcmFwcGVyKiB3cmFwcGVyKQotewotICAgIGlmICgh d29ybGQtPmlzTm9ybWFsKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBub2RlLT5zZXRX cmFwcGVyKCp3b3JsZC0+Z2xvYmFsRGF0YSgpLCB3cmFwcGVyLCB3cmFwcGVyT3duZXIod29ybGQs IG5vZGUpLCB3cmFwcGVyQ29udGV4dCh3b3JsZCwgbm9kZSkpOwotICAgIHJldHVybiB0cnVlOwot fQotCi1pbmxpbmUgYm9vbCBjbGVhcklubGluZUNhY2hlZFdyYXBwZXIoRE9NV3JhcHBlcldvcmxk KiB3b3JsZCwgTm9kZSogbm9kZSwgSlNET01XcmFwcGVyKiB3cmFwcGVyKQotewotICAgIGlmICgh d29ybGQtPmlzTm9ybWFsKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBub2RlLT5jbGVh cldyYXBwZXIod3JhcHBlcik7Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIEpTQzo6SlNWYWx1ZSBj cmVhdGVXcmFwcGVyKEpTQzo6RXhlY1N0YXRlKiwgSlNET01HbG9iYWxPYmplY3QqLCBOb2RlKik7 CiAKIGlubGluZSBKU0M6OkpTVmFsdWUgdG9KUyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNET01H bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgTm9kZSogbm9kZSkK