101293 2012-11-05 19:07:20 -0800 [chromium] Expose CustomEvent through WebDOMCustomEvent. 2012-11-11 16:12:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sadrul sadrul abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 759166 0 sadrul 2012-11-05 19:07:20 -0800 [chromium] Expose CustomEvent through WebDOMCustomEvent. 759168 1 172469 sadrul 2012-11-05 19:10:06 -0800 Created attachment 172469 Patch 759171 2 webkit.review.bot 2012-11-05 19:16:35 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 759177 3 sadrul 2012-11-05 19:29:46 -0800 Hi! This WebDOMCustomEvent is used for browser-plugin event dispatching. The chromium CL that uses this: http://codereview.chromium.org/11368071/ 759279 4 172469 abarth 2012-11-05 22:50:10 -0800 Comment on attachment 172469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172469&action=review > Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:49 > + ScriptValue scriptValue = ScriptValue::deserialize(ScriptState::current(), serializedScriptValue.get()); > + unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable, scriptValue); This would be better if we could give the SerializedScriptValue to the CustomEvent and have it deserialize it when constructing the JavaScript wrapper. That way we'll get a different deserialization for each world that has an event listener. 759672 5 172469 sadrul 2012-11-06 07:38:17 -0800 Comment on attachment 172469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172469&action=review >> Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:49 >> + unwrap<CustomEvent>()->initCustomEvent(type, canBubble, cancelable, scriptValue); > > This would be better if we could give the SerializedScriptValue to the CustomEvent and have it deserialize it when constructing the JavaScript wrapper. That way we'll get a different deserialization for each world that has an event listener. Addressed in https://bugs.webkit.org/show_bug.cgi?id=101348 If that looks good and lands, I will update this patch accordingly. Thanks! 763202 6 173343 sadrul 2012-11-09 11:41:19 -0800 Created attachment 173343 Patch 763209 7 173343 abarth 2012-11-09 11:48:21 -0800 Comment on attachment 173343 Patch This looks good. 763289 8 173343 webkit.review.bot 2012-11-09 13:54:22 -0800 Comment on attachment 173343 Patch Attachment 173343 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14786312 763437 9 173343 sadrul 2012-11-09 16:21:39 -0800 Comment on attachment 173343 Patch The cq- from the bot happened since the patch this depends on hadn't landed yet. But now that that has landed, requesting cq 763507 10 173343 webkit.review.bot 2012-11-09 17:52:46 -0800 Comment on attachment 173343 Patch Rejecting attachment 173343 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ediaControlsChromium.cpp:348: error: enumeration value 'MediaClosedCaptionsContainer' not handled in switch Source/WebCore/rendering/RenderMediaControlsChromium.cpp:348: error: enumeration value 'MediaClosedCaptionsTrackList' not handled in switch CXX(target) out/Release/obj.target/webcore_rendering/Source/WebCore/rendering/RenderTheme.o make: *** [out/Release/obj.target/webcore_rendering/Source/WebCore/rendering/RenderMediaControlsChromium.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14788353 763509 11 173343 sadrul 2012-11-09 17:56:39 -0800 Comment on attachment 173343 Patch The failure is not caused by this CL :( 763894 12 abarth 2012-11-11 15:13:14 -0800 That's true, but this one does: Source/WebKit/chromium/src/WebDOMCustomEvent.cpp: In member function 'void WebKit::WebDOMCustomEvent::initCustomEvent(const WebKit::WebString&, bool, bool, const WebKit::WebSerializedScriptValue&)': Source/WebKit/chromium/src/WebDOMCustomEvent.cpp:48: error: no matching function for call to 'WebCore::CustomEvent::initCustomEvent(const WebKit::WebString&, bool&, bool&, WebCore::SerializedScriptValue*)' Source/WebCore/dom/CustomEvent.h:54: note: candidates are: void WebCore::CustomEvent::initCustomEvent(const WTF::AtomicString&, bool, bool, const WebCore::ScriptValue&) 763916 13 173343 webkit.review.bot 2012-11-11 16:12:36 -0800 Comment on attachment 173343 Patch Clearing flags on attachment: 173343 Committed r134177: <http://trac.webkit.org/changeset/134177> 763918 14 webkit.review.bot 2012-11-11 16:12:40 -0800 All reviewed patches have been landed. Closing bug. 172469 2012-11-05 19:10:06 -0800 2012-11-09 11:41:16 -0800 Patch bug-101293-20121105220820.patch text/plain 6960 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGUzNDNmYTJhMTQ2ZjhhODM3N2JmMjgwMzA4NDExNDU5MWQ0YzBjODUuLjdmZTE2NDhkMDhlZWFh ZmQ1YmE3OTU0ODQ1OTgyNWQwNWM3OTY3MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTEtMDUgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRy dWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRXhwb3NlIEN1c3RvbUV2ZW50 IHRocm91Z2ggV2ViRE9NQ3VzdG9tRXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6CisgICAgICAgICogcHVibGljL1dlYkRP TUN1c3RvbUV2ZW50Lmg6IEFkZGVkLgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKFdlYkRP TUN1c3RvbUV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRE9NQ3VzdG9tRXZlbnQ6OldlYkRP TUN1c3RvbUV2ZW50KToKKyAgICAgICAgKiBzcmMvV2ViRE9NQ3VzdG9tRXZlbnQuY3BwOiBBZGRl ZC4KKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkRPTUN1c3RvbUV2ZW50 Ojppbml0Q3VzdG9tRXZlbnQpOgorCiAyMDEyLTExLTA0ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0 YUBnb29nbGUuY29tPgogCiAgICAgICAgIFNoYWRvdyBET00gc2hvdWxkIGJlIGFibGUgdG8gYmUg ZGlzYWJsZWQgcGVyIGNvbnRleHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L1dlYktpdC5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXggNzRl ZjliZmNmNTdkOTUyOGNkZDg4M2FmZDJiODg5NTljNmQ0Yzc5Mi4uMTllZTliYzk0NzNiOWY0YTMw MjQxN2MyZTQ4ODE5N2EwMzE4MzhjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9XZWJLaXQuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApAQCAt MTIwLDYgKzEyMCw3IEBACiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJDb250ZXh0TWVudURh dGEuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9XZWJDcm9zc09yaWdpblByZWZsaWdodFJl c3VsdENhY2hlLmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViQ3Vyc29ySW5mby5oJywK KyAgICAgICAgICAgICAgICAncHVibGljL1dlYkRPTUN1c3RvbUV2ZW50LmgnLAogICAgICAgICAg ICAgICAgICdwdWJsaWMvV2ViRE9NRXZlbnQuaCcsCiAgICAgICAgICAgICAgICAgJ3B1YmxpYy9X ZWJET01FdmVudExpc3RlbmVyLmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViRE9NTWVz c2FnZUV2ZW50LmgnLApAQCAtNDg3LDYgKzQ4OCw3IEBACiAgICAgICAgICAgICAgICAgJ3NyYy9X ZWJDb21wb3NpdG9ySW5wdXRIYW5kbGVySW1wbC5oJywKICAgICAgICAgICAgICAgICAnc3JjL1dl YkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUuY3BwJywKICAgICAgICAgICAgICAgICAn c3JjL1dlYkN1cnNvckluZm8uY3BwJywKKyAgICAgICAgICAgICAgICAnc3JjL1dlYkRPTUN1c3Rv bUV2ZW50LmNwcCcsCiAgICAgICAgICAgICAgICAgJ3NyYy9XZWJET01FdmVudC5jcHAnLAogICAg ICAgICAgICAgICAgICdzcmMvV2ViRE9NRXZlbnRMaXN0ZW5lci5jcHAnLAogICAgICAgICAgICAg ICAgICdzcmMvV2ViRE9NRXZlbnRMaXN0ZW5lclByaXZhdGUuY3BwJywKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUN1c3RvbUV2ZW50LmggYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJET01DdXN0b21FdmVudC5oCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE1 ZjFmODBkM2E3ZWE2NjRkNTkyNDcyM2M3ZjhiMGIxY2EzYjI5ODMKLS0tIC9kZXYvbnVsbAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJET01DdXN0b21FdmVudC5oCkBAIC0w LDAgKzEsNDkgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBl cm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1l dDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRh aW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l cgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRl ZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBv ZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBi ZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRo aXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisg KgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMg QU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBX QVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVE IFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJU SUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZ UklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1Qs IElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFV RU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VS RU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBE QVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VE IEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1Qs IFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KKyAqLworI2lmbmRlZiBXZWJET01DdXN0b21FdmVudF9oCisjZGVmaW5lIFdlYkRPTUN1c3Rv bUV2ZW50X2gKKworI2luY2x1ZGUgIldlYkRPTUV2ZW50LmgiCisjaW5jbHVkZSAicGxhdGZvcm0v V2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlLmgiCisKK25hbWVzcGFjZSBXZWJLaXQgeworCitjbGFz cyBXZWJGcmFtZTsKK2NsYXNzIFdlYlN0cmluZzsKKworY2xhc3MgV2ViRE9NQ3VzdG9tRXZlbnQg OiBwdWJsaWMgV2ViRE9NRXZlbnQgeworcHVibGljOgorICAgIFdlYkRPTUN1c3RvbUV2ZW50KCkg eyB9CisgICAgV0VCS0lUX0VYUE9SVCB2b2lkIGluaXRDdXN0b21FdmVudChjb25zdCBXZWJTdHJp bmcmIHR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNhbmNlbGFibGUsIGNvbnN0IFdlYlNlcmlh bGl6ZWRTY3JpcHRWYWx1ZSYgbWVzc2FnZURhdGEpOworfTsKKworfSAvLyBuYW1lc3BhY2UgV2Vi S2l0CisKKyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RE9NQ3VzdG9tRXZlbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NQ3Vz dG9tRXZlbnQuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI4MzgyYTU2ZWY3MzgwMjNjMGI1NzBjZDQ4ZmFkMDdk ZGU2MzFlMDgKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJET01DdXN0b21FdmVudC5jcHAKQEAgLTAsMCArMSw1MiBAQAorLyoKKyAqIENvcHlyaWdodCAo QykgMjAxMiBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoKKyAqICAgICAqIFJlZGlzdHJpYnV0aW9u cyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu CisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2Ug dGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQv b3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisgKiBkaXN0cmlidXRpb24uCisg KiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2Yg aXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHBy b2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHBy aW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVE IEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisgKiAiQVMgSVMiIEFO RCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAor ICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g SU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorICogT1dORVIgT1IgQ09OVFJJQlVUT1JT IEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisgKiBTUEVD SUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQg Tk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorICogVEhFT1JZIE9GIExJQUJJ TElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICog KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIK KyNpbmNsdWRlICJXZWJET01DdXN0b21FdmVudC5oIgorCisjaW5jbHVkZSAiQ3VzdG9tRXZlbnQu aCIKKyNpbmNsdWRlICJTZXJpYWxpemVkU2NyaXB0VmFsdWUuaCIKKyNpbmNsdWRlICJwbGF0Zm9y bS9XZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUuaCIKKyNpbmNsdWRlIDxwdWJsaWMvV2ViU3RyaW5n Lmg+CisKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOworCituYW1lc3BhY2UgV2ViS2l0IHsKKwor dm9pZCBXZWJET01DdXN0b21FdmVudDo6aW5pdEN1c3RvbUV2ZW50KGNvbnN0IFdlYlN0cmluZyYg dHlwZSwgYm9vbCBjYW5CdWJibGUsIGJvb2wgY2FuY2VsYWJsZSwgY29uc3QgV2ViU2VyaWFsaXpl ZFNjcmlwdFZhbHVlJiB3ZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUpCit7CisgICAgQVNTRVJUKG1f cHJpdmF0ZSk7CisgICAgUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gc2VyaWFsaXplZFNj cmlwdFZhbHVlOworICAgIHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSA9IHdlYlNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZTsKKyAgICBTY3JpcHRWYWx1ZSBzY3JpcHRWYWx1ZSA9IFNjcmlwdFZhbHVlOjpkZXNl cmlhbGl6ZShTY3JpcHRTdGF0ZTo6Y3VycmVudCgpLCBzZXJpYWxpemVkU2NyaXB0VmFsdWUuZ2V0 KCkpOworICAgIHVud3JhcDxDdXN0b21FdmVudD4oKS0+aW5pdEN1c3RvbUV2ZW50KHR5cGUsIGNh bkJ1YmJsZSwgY2FuY2VsYWJsZSwgc2NyaXB0VmFsdWUpOworfQorCit9IC8vIG5hbWVzcGFjZSBX ZWJLaXQK 173343 2012-11-09 11:41:19 -0800 2012-11-11 16:12:35 -0800 Patch bug-101293-20121109143926.patch text/plain 6852 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ1ODZmYmE0MzIyMzkyZGVjYmI3NTNjYzRkYzBiNGEwMDE0ODFhZGIuLmZjMDJlZTY0ZjQyY2U3 YTlkNTc1NmNhN2NjYjU0Y2Y0MzYxZWJkNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTEtMDkgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRy dWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRXhwb3NlIEN1c3RvbUV2ZW50 IHRocm91Z2ggV2ViRE9NQ3VzdG9tRXZlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC5neXA6CisgICAgICAgICogcHVibGljL1dlYkRP TUN1c3RvbUV2ZW50Lmg6IEFkZGVkLgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKFdlYkRP TUN1c3RvbUV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRE9NQ3VzdG9tRXZlbnQ6OldlYkRP TUN1c3RvbUV2ZW50KToKKyAgICAgICAgKiBzcmMvV2ViRE9NQ3VzdG9tRXZlbnQuY3BwOiBBZGRl ZC4KKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkRPTUN1c3RvbUV2ZW50 Ojppbml0Q3VzdG9tRXZlbnQpOgorCiAyMDEyLTExLTA4ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTM0MDEwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCmluZGV4IDc0ZWY5YmZjZjU3ZDk1Mjhj ZGQ4ODNhZmQyYjg4OTU5YzZkNGM3OTIuLjE5ZWU5YmM5NDczYjlmNGEzMDI0MTdjMmU0ODgxOTdh MDMxODM4Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTEyMCw2ICsxMjAsNyBA QAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViQ29udGV4dE1lbnVEYXRhLmgnLAogICAgICAg ICAgICAgICAgICdwdWJsaWMvV2ViQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5oJywK ICAgICAgICAgICAgICAgICAncHVibGljL1dlYkN1cnNvckluZm8uaCcsCisgICAgICAgICAgICAg ICAgJ3B1YmxpYy9XZWJET01DdXN0b21FdmVudC5oJywKICAgICAgICAgICAgICAgICAncHVibGlj L1dlYkRPTUV2ZW50LmgnLAogICAgICAgICAgICAgICAgICdwdWJsaWMvV2ViRE9NRXZlbnRMaXN0 ZW5lci5oJywKICAgICAgICAgICAgICAgICAncHVibGljL1dlYkRPTU1lc3NhZ2VFdmVudC5oJywK QEAgLTQ4Nyw2ICs0ODgsNyBAQAogICAgICAgICAgICAgICAgICdzcmMvV2ViQ29tcG9zaXRvcklu cHV0SGFuZGxlckltcGwuaCcsCiAgICAgICAgICAgICAgICAgJ3NyYy9XZWJDcm9zc09yaWdpblBy ZWZsaWdodFJlc3VsdENhY2hlLmNwcCcsCiAgICAgICAgICAgICAgICAgJ3NyYy9XZWJDdXJzb3JJ bmZvLmNwcCcsCisgICAgICAgICAgICAgICAgJ3NyYy9XZWJET01DdXN0b21FdmVudC5jcHAnLAog ICAgICAgICAgICAgICAgICdzcmMvV2ViRE9NRXZlbnQuY3BwJywKICAgICAgICAgICAgICAgICAn c3JjL1dlYkRPTUV2ZW50TGlzdGVuZXIuY3BwJywKICAgICAgICAgICAgICAgICAnc3JjL1dlYkRP TUV2ZW50TGlzdGVuZXJQcml2YXRlLmNwcCcsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJET01DdXN0b21FdmVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViRE9NQ3VzdG9tRXZlbnQuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNWYxZjgwZDNhN2VhNjY0 ZDU5MjQ3MjNjN2Y4YjBiMWNhM2IyOTgzCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NQ3VzdG9tRXZlbnQuaApAQCAtMCwwICsxLDQ5IEBACisv KgorICogQ29weXJpZ2h0IChDKSAyMDEyIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAg ICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xs b3dpbmcgZGlzY2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9y bSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlz dCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAq IGRpc3RyaWJ1dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4g bm9yIHRoZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRv cnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdp dGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRP UlMKKyAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5D TFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NF IEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05F UiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5D SURFTlRBTCwKKyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VT IChJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNU SVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklU UzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisg KiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT SU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKyNpZm5k ZWYgV2ViRE9NQ3VzdG9tRXZlbnRfaAorI2RlZmluZSBXZWJET01DdXN0b21FdmVudF9oCisKKyNp bmNsdWRlICJXZWJET01FdmVudC5oIgorI2luY2x1ZGUgInBsYXRmb3JtL1dlYlNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZS5oIgorCituYW1lc3BhY2UgV2ViS2l0IHsKKworY2xhc3MgV2ViRnJhbWU7Citj bGFzcyBXZWJTdHJpbmc7CisKK2NsYXNzIFdlYkRPTUN1c3RvbUV2ZW50IDogcHVibGljIFdlYkRP TUV2ZW50IHsKK3B1YmxpYzoKKyAgICBXZWJET01DdXN0b21FdmVudCgpIHsgfQorICAgIFdFQktJ VF9FWFBPUlQgdm9pZCBpbml0Q3VzdG9tRXZlbnQoY29uc3QgV2ViU3RyaW5nJiB0eXBlLCBib29s IGNhbkJ1YmJsZSwgYm9vbCBjYW5jZWxhYmxlLCBjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFs dWUmIG1lc3NhZ2VEYXRhKTsKK307CisKK30gLy8gbmFtZXNwYWNlIFdlYktpdAorCisjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUN1c3RvbUV2ZW50 LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUN1c3RvbUV2ZW50LmNwcApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi4yZjdmOGY0Mjg5YzE0OWQ2MGQ5Y2RiMGM4ZWE4NDU2NGExMTZhMDZhCi0tLSAv ZGV2L251bGwKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NQ3VzdG9tRXZl bnQuY3BwCkBAIC0wLDAgKzEsNTEgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cyBhcmUKKyAqIG1ldDoKKyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNv ZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVk aXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICog Y29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lcgorICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhl ciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJp YnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVk IGZyb20KKyAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBl cm1pc3Npb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJ R0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8s IFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UgorICogQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNI QUxMIFRIRSBDT1BZUklHSFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9S IEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZ LCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBP RiBVU0UsCisgKiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhP V0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVH TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQor ICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiV2Vi RE9NQ3VzdG9tRXZlbnQuaCIKKworI2luY2x1ZGUgIkN1c3RvbUV2ZW50LmgiCisjaW5jbHVkZSAi U2VyaWFsaXplZFNjcmlwdFZhbHVlLmgiCisjaW5jbHVkZSAicGxhdGZvcm0vV2ViU2VyaWFsaXpl ZFNjcmlwdFZhbHVlLmgiCisjaW5jbHVkZSA8cHVibGljL1dlYlN0cmluZy5oPgorCit1c2luZyBu YW1lc3BhY2UgV2ViQ29yZTsKKworbmFtZXNwYWNlIFdlYktpdCB7CisKK3ZvaWQgV2ViRE9NQ3Vz dG9tRXZlbnQ6OmluaXRDdXN0b21FdmVudChjb25zdCBXZWJTdHJpbmcmIHR5cGUsIGJvb2wgY2Fu QnViYmxlLCBib29sIGNhbmNlbGFibGUsIGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSYg d2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlKQoreworICAgIEFTU0VSVChtX3ByaXZhdGUpOworICAg IFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTsKKyAg ICBzZXJpYWxpemVkU2NyaXB0VmFsdWUgPSB3ZWJTZXJpYWxpemVkU2NyaXB0VmFsdWU7CisgICAg dW53cmFwPEN1c3RvbUV2ZW50PigpLT5pbml0Q3VzdG9tRXZlbnQodHlwZSwgY2FuQnViYmxlLCBj YW5jZWxhYmxlLCBzZXJpYWxpemVkU2NyaXB0VmFsdWUuZ2V0KCkpOworfQorCit9IC8vIG5hbWVz cGFjZSBXZWJLaXQK