101284 2012-11-05 17:24:31 -0800 RenderGeometryMap asserts when loading http://en.softonic.com/mac 2012-11-05 17:46:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton webkit-bug-importer oldest_to_newest 759074 0 simon.fraser 2012-11-05 17:24:31 -0800 RenderGeometryMap asserts when loading http://en.softonic.com/mac 759077 1 172451 simon.fraser 2012-11-05 17:27:56 -0800 Created attachment 172451 Patch 759078 2 simon.fraser 2012-11-05 17:28:47 -0800 <rdar://problem/11540560> 759084 3 172451 thorton 2012-11-05 17:40:40 -0800 Comment on attachment 172451 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172451&action=review Seems reasonable! > Source/WebCore/page/FrameView.cpp:711 > + // If we expect to update compositing after an incipient layout, don't do so here. incipient :\ > Source/WebCore/page/FrameView.cpp:1073 > + m_doingPreLayoutStyleUpdate = true; TemporaryChange thing? Or I guess it doesn’t matter in this case. 759087 4 simon.fraser 2012-11-05 17:46:27 -0800 http://trac.webkit.org/changeset/133544 172451 2012-11-05 17:27:56 -0800 2012-11-05 17:40:40 -0800 Patch bug-101284-20121105172610.patch text/plain 4641 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODExYjNjZmI5YWVkMzQx Y2FiNjVlYzhiMTdkODA2Yjg3ZWMwOGJhOS4uMGIyMjkzM2QzOTVmNWEzNWVjYmZkZGQ5OWQ1ZTlm MTc0ZTA3NDg1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM0IEBACiAyMDEyLTExLTA1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJlbmRlckdlb21l dHJ5TWFwIGFzc2VydHMgd2hlbiBsb2FkaW5nIGh0dHA6Ly9lbi5zb2Z0b25pYy5jb20vbWFjCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyODQKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExNTQwNTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gRnJhbWVWaWV3OjpsYXlvdXQoKSBjYWxscyBk b2N1bWVudC0+dXBkYXRlU3R5bGVJZk5lZWRlZCgpLCB3ZQorICAgICAgICBjYW4gYmUgaW4gYSBz dGF0ZSB3aGVyZSBGcmFtZVZpZXc6Om5lZWRzTGF5b3V0KCkgaXMgZmFsc2UuIEhvd2V2ZXIsCisg ICAgICAgIHRoaXMgaXMgYSBiYWQgdGltZSB0byB1cGRhdGUgY29tcG9zaXRpbmcgbGF5ZXJzLCBi ZWNhdXNlIHdlJ3JlIGFib3V0CisgICAgICAgIHRvIGRvIGxheW91dCwgd2hpY2ggd2lsbCByZXF1 aXJlIHVzIHRvIHVwZGF0ZSB0aGVtIGFnYWluIHNvb24gYW55d2F5LAorICAgICAgICBhbmQgc29t ZSBSZW5kZXJMYXllcnMgbWF5IG5vdCBoYXZlIGJlZW4gc2l6ZWQgb3IgcG9zaXRpb25lZCB5ZXQu CisgICAgICAgIAorICAgICAgICBGaXggYnkgYWRkaW5nIGEgbV9kb2luZ1ByZUxheW91dFN0eWxl VXBkYXRlIG1lbWJlciB0byBGcmFtZVZpZXcsCisgICAgICAgIGFuZCB0b2dnbGluZyBpdCBhcm91 bmQgdGhpcyBjYWxsIHRvIHVwZGF0ZVN0eWxlSWZOZWVkZWQoKS4KKyAgICAgICAgUmVhZCB0aGlz IHN0YXRlIGluIHVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzQWZ0ZXJTdHlsZUNoYW5nZSgpLCB3aGlj aCBpcworICAgICAgICBub3cgY2FsbGVkIHVuY29uZGl0aW9uYWxseSBieSByZWNhbGNTdHlsZSgp LCBidXQgcmV0dXJucyBlYXJseQorICAgICAgICBpZiB0aGlzIGZsYWcgaXMgc2V0LCBvciBsYXlv dXQgaXMgcGVuZGluZy4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6cmVjYWxjU3R5bGUpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cmVzZXQpOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVWaWV3Ojp1cGRhdGVDb21wb3NpdGluZ0xheWVyc0FmdGVyU3R5bGVDaGFuZ2Up OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpsYXlvdXQpOgorICAgICAgICAqIHBhZ2Uv RnJhbWVWaWV3Lmg6CisgICAgICAgIChGcmFtZVZpZXcpOgorCisyMDEyLTExLTA1ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIE1ha2UgRG9jdW1lbnQ6 OnVwZGF0ZVN0eWxlSWZOZWVkZWQoKSBub24tdmlydHVhbAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMjczCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CmluZGV4IDYzODg1OTQwMWUwZTAzY2QwZGZjMzJlYzQ0MmRmM2U3MjQxMjdiNDkuLjljNzY0ODY4 NTBmZDkwM2FkZDU0MWQ4ZTU5YjkwMzMzOGY2MDQyNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cApAQCAtMTg1MiwxNCArMTg1MiwxMCBAQCB2b2lkIERvY3VtZW50OjpyZWNhbGNTdHlsZShTdHls ZUNoYW5nZSBjaGFuZ2UpCiAgICAgICAgICAgICAgICAgZWxlbWVudC0+cmVjYWxjU3R5bGUoY2hh bmdlKTsKICAgICAgICAgfQogCi0gICAgI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykK LSAgICAgICAgaWYgKHZpZXcoKSkgewotICAgICAgICAgICAgYm9vbCBsYXlvdXRQZW5kaW5nID0g dmlldygpLT5sYXlvdXRQZW5kaW5nKCkgfHwgcmVuZGVyZXIoKS0+bmVlZHNMYXlvdXQoKTsKLSAg ICAgICAgICAgIC8vIElmIHdlIGRpZG4ndCB1cGRhdGUgY29tcG9zaXRpbmcgbGF5ZXJzIGJlY2F1 c2Ugb2YgbGF5b3V0KCksIHdlIG5lZWQgdG8gZG8gc28gaGVyZS4KLSAgICAgICAgICAgIGlmICgh bGF5b3V0UGVuZGluZykKLSAgICAgICAgICAgICAgICB2aWV3KCktPnVwZGF0ZUNvbXBvc2l0aW5n TGF5ZXJzQWZ0ZXJTdHlsZUNoYW5nZSgpOwotICAgICAgICB9Ci0gICAgI2VuZGlmCisjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgICAgICBpZiAodmlldygpKQorICAgICAgICAg ICAgdmlldygpLT51cGRhdGVDb21wb3NpdGluZ0xheWVyc0FmdGVyU3R5bGVDaGFuZ2UoKTsKKyNl bmRpZgogCiAgICAgYmFpbE91dDoKICAgICAgICAgY2xlYXJOZWVkc1N0eWxlUmVjYWxjKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggYzlmY2E0MzVkOTA4Y2I0ZjYzNTlhZTBlNTFl MWZhYjNiMTRiNzE3Ni4uMTA1NDhiZGQxMmRlYjEzNGQyYjEyOGZkZjk0ZmQ2MWVlYWJmNGU5MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMjY3LDYgKzI2Nyw3IEBAIHZvaWQgRnJh bWVWaWV3OjpyZXNldCgpCiAgICAgbV9kb0Z1bGxSZXBhaW50ID0gdHJ1ZTsKICAgICBtX2xheW91 dFNjaGVkdWxpbmdFbmFibGVkID0gdHJ1ZTsKICAgICBtX2luTGF5b3V0ID0gZmFsc2U7CisgICAg bV9kb2luZ1ByZUxheW91dFN0eWxlVXBkYXRlID0gZmFsc2U7CiAgICAgbV9pblN5bmNocm9ub3Vz UG9zdExheW91dCA9IGZhbHNlOwogICAgIG1fbGF5b3V0Q291bnQgPSAwOwogICAgIG1fbmVzdGVk TGF5b3V0Q291bnQgPSAwOwpAQCAtNzA3LDYgKzcwOCwxMCBAQCB2b2lkIEZyYW1lVmlldzo6dXBk YXRlQ29tcG9zaXRpbmdMYXllcnNBZnRlclN0eWxlQ2hhbmdlKCkKICAgICBpZiAoIXJvb3QpCiAg ICAgICAgIHJldHVybjsKIAorICAgIC8vIElmIHdlIGV4cGVjdCB0byB1cGRhdGUgY29tcG9zaXRp bmcgYWZ0ZXIgYW4gaW5jaXBpZW50IGxheW91dCwgZG9uJ3QgZG8gc28gaGVyZS4KKyAgICBpZiAo bV9kb2luZ1ByZUxheW91dFN0eWxlVXBkYXRlIHx8IGxheW91dFBlbmRpbmcoKSB8fCByb290LT5u ZWVkc0xheW91dCgpKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBUaGlzIGNhbGwgd2lsbCBt YWtlIHN1cmUgdGhlIGNhY2hlZCBoYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nIGlzIHVwZGF0ZWQg ZnJvbSB0aGUgcHJlZgogICAgIHJvb3QtPmNvbXBvc2l0b3IoKS0+Y2FjaGVBY2NlbGVyYXRlZENv bXBvc2l0aW5nRmxhZ3MoKTsKICAgICByb290LT5jb21wb3NpdG9yKCktPnVwZGF0ZUNvbXBvc2l0 aW5nTGF5ZXJzKENvbXBvc2l0aW5nVXBkYXRlQWZ0ZXJTdHlsZUNoYW5nZSk7CkBAIC0xMDY1LDcg KzEwNzAsOSBAQCB2b2lkIEZyYW1lVmlldzo6bGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlKQogCiAg ICAgICAgIC8vIEFsd2F5cyBlbnN1cmUgb3VyIHN0eWxlIGluZm8gaXMgdXAtdG8tZGF0ZS4gVGhp cyBjYW4gaGFwcGVuIGluIHNpdHVhdGlvbnMgd2hlcmUKICAgICAgICAgLy8gdGhlIGxheW91dCBi ZWF0cyBhbnkgc29ydCBvZiBzdHlsZSByZWNhbGMgdXBkYXRlIHRoYXQgbmVlZHMgdG8gb2NjdXIu CisgICAgICAgIG1fZG9pbmdQcmVMYXlvdXRTdHlsZVVwZGF0ZSA9IHRydWU7CiAgICAgICAgIGRv Y3VtZW50LT51cGRhdGVTdHlsZUlmTmVlZGVkKCk7CisgICAgICAgIG1fZG9pbmdQcmVMYXlvdXRT dHlsZVVwZGF0ZSA9IGZhbHNlOwogCiAgICAgICAgIHN1YnRyZWUgPSBtX2xheW91dFJvb3Q7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IGMyZDdlMmIwNTExNDA4NmQyM2ZmNjJlOTlmMjhi Y2EyODM0ZDdmOWUuLjU4MzQ1M2IyNjU1MjlkMzAzY2IxMmViYmJhYmQ3MjkyYzhhZTZlYWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtNDg3LDYgKzQ4Nyw3IEBAIHByaXZhdGU6CiAgICAg CiAgICAgYm9vbCBtX2xheW91dFNjaGVkdWxpbmdFbmFibGVkOwogICAgIGJvb2wgbV9pbkxheW91 dDsKKyAgICBib29sIG1fZG9pbmdQcmVMYXlvdXRTdHlsZVVwZGF0ZTsKICAgICBib29sIG1faW5T eW5jaHJvbm91c1Bvc3RMYXlvdXQ7CiAgICAgaW50IG1fbGF5b3V0Q291bnQ7CiAgICAgdW5zaWdu ZWQgbV9uZXN0ZWRMYXlvdXRDb3VudDsK