101275 2012-11-05 16:28:04 -0800 Clean up ScrollingConstraints.h 2012-11-05 16:48:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin andersca bdakin darin jamesr simon.fraser tonikitoo webkit.review.bot oldest_to_newest 759012 0 bdakin 2012-11-05 16:28:04 -0800 Darin suggested a few small clean-ups to ScrollingConstraints.h here: https://bugs.webkit.org/show_bug.cgi?id=100796#c3 This bug tracks making the changes he suggested. 759017 1 172434 bdakin 2012-11-05 16:30:46 -0800 Created attachment 172434 Patch 759022 2 172434 simon.fraser 2012-11-05 16:37:48 -0800 Comment on attachment 172434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review > Source/WebCore/page/scrolling/ScrollingConstraints.h:-65 > - ViewportConstraints() > - : m_anchorEdges(0) > - { } You need this one to initialize m_anchorEdges, no? 759034 3 bdakin 2012-11-05 16:48:54 -0800 (In reply to comment #2) > (From update of attachment 172434 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172434&action=review > > > Source/WebCore/page/scrolling/ScrollingConstraints.h:-65 > > - ViewportConstraints() > > - : m_anchorEdges(0) > > - { } > > You need this one to initialize m_anchorEdges, no? Oops, yes! Thank you! http://trac.webkit.org/changeset/133542 172434 2012-11-05 16:30:46 -0800 2012-11-05 16:37:47 -0800 Patch for-review.txt text/plain 3298 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzU0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMjc1CisgICAgICAgIENsZWFuIHVwIFNjcm9sbGluZ0NvbnN0 cmFpbnRzLmgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGNsYXNzIGNsZWFucyB1cCBTY3JvbGxpbmdDb25zdHJhaW50cy5oIGJ5IHJlbW92aW5n IHRoZSBjb25zdHJ1Y3RvcnMgc2luY2UgdGhlIAorICAgICAgICBjb21waWxlciB3aWxsIGdlbmVy YXRlIHRob3NlIGNvbnN0cnVjdG9ycyBmb3IgdXMgYW55d2F5LiBUaGUgcGF0Y2ggYWxzbyBtYWtl cyB0aGUgCisgICAgICAgIHR3byBvdmVycmlkZSBmdW5jdGlvbnMgcHJpdmF0ZS4KKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb25zdHJhaW50cy5oOgorICAgICAgICAoVmlld3Bv cnRDb25zdHJhaW50cyk6CisgICAgICAgIChGaXhlZFBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50 cyk6CisgICAgICAgIChTdGlja3lQb3NpdGlvblZpZXdwb3J0Q29uc3RyYWludHMpOgorCiAyMDEy LTExLTA1ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5ibG9j ayBTVkcgZXh0ZXJuYWwgcmVmZXJlbmNlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nQ29uc3RyYWludHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb25zdHJhaW50cy5oCShyZXZpc2lvbiAxMzM1MzYp CisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb25zdHJhaW50cy5o CSh3b3JraW5nIGNvcHkpCkBAIC02MCwzMiArNjAsMTIgQEAgcHVibGljOgogICAgIHZvaWQgc2V0 QWxpZ25tZW50T2Zmc2V0KGNvbnN0IEZsb2F0U2l6ZSYgb2Zmc2V0KSB7IG1fYWxpZ25tZW50T2Zm c2V0ID0gb2Zmc2V0OyB9CiAKIHByb3RlY3RlZDoKLSAgICBWaWV3cG9ydENvbnN0cmFpbnRzKCkK LSAgICAgICAgOiBtX2FuY2hvckVkZ2VzKDApCi0gICAgeyB9Ci0KLSAgICBWaWV3cG9ydENvbnN0 cmFpbnRzKGNvbnN0IFZpZXdwb3J0Q29uc3RyYWludHMmIGNvbnN0cmFpbnRzKQotICAgICAgICA6 IG1fYWxpZ25tZW50T2Zmc2V0KGNvbnN0cmFpbnRzLmFsaWdubWVudE9mZnNldCgpKQotICAgICAg ICAsIG1fYW5jaG9yRWRnZXMoY29uc3RyYWludHMuYW5jaG9yRWRnZXMoKSkKLSAgICB7IH0KLQog ICAgIEZsb2F0U2l6ZSBtX2FsaWdubWVudE9mZnNldDsKICAgICBBbmNob3JFZGdlcyBtX2FuY2hv ckVkZ2VzOwogfTsKIAogY2xhc3MgRml4ZWRQb3NpdGlvblZpZXdwb3J0Q29uc3RyYWludHMgOiBw dWJsaWMgVmlld3BvcnRDb25zdHJhaW50cyB7CiBwdWJsaWM6Ci0gICAgRml4ZWRQb3NpdGlvblZp ZXdwb3J0Q29uc3RyYWludHMoKQotICAgIHsgfQotCi0gICAgRml4ZWRQb3NpdGlvblZpZXdwb3J0 Q29uc3RyYWludHMoY29uc3QgRml4ZWRQb3NpdGlvblZpZXdwb3J0Q29uc3RyYWludHMmIGNvbnN0 cmFpbnRzKQotICAgICAgICA6IFZpZXdwb3J0Q29uc3RyYWludHMoY29uc3RyYWludHMpCi0gICAg ICAgICwgbV92aWV3cG9ydFJlY3RBdExhc3RMYXlvdXQoY29uc3RyYWludHMudmlld3BvcnRSZWN0 QXRMYXN0TGF5b3V0KCkpCi0gICAgICAgICwgbV9sYXllclBvc2l0aW9uQXRMYXN0TGF5b3V0KGNv bnN0cmFpbnRzLmxheWVyUG9zaXRpb25BdExhc3RMYXlvdXQoKSkKLSAgICB7IH0KLQotICAgIHZp cnR1YWwgQ29uc3RyYWludFR5cGUgY29uc3RyYWludFR5cGUoKSBjb25zdCBPVkVSUklERSB7IHJl dHVybiBGaXhlZFBvc2l0aW9uQ29uc3RhaW50OyB9OwotCiAgICAgRmxvYXRQb2ludCBsYXllclBv c2l0aW9uRm9yVmlld3BvcnRSZWN0KGNvbnN0IEZsb2F0UmVjdCYgdmlld3BvcnRSZWN0KSBjb25z dDsKIAogICAgIGNvbnN0IEZsb2F0UmVjdCYgdmlld3BvcnRSZWN0QXRMYXN0TGF5b3V0KCkgY29u c3QgeyByZXR1cm4gbV92aWV3cG9ydFJlY3RBdExhc3RMYXlvdXQ7IH0KQEAgLTEwNSw2ICs4NSw4 IEBAIHB1YmxpYzoKICAgICBib29sIG9wZXJhdG9yIT0oY29uc3QgRml4ZWRQb3NpdGlvblZpZXdw b3J0Q29uc3RyYWludHMmIG90aGVyKSBjb25zdCB7IHJldHVybiAhKCp0aGlzID09IG90aGVyKTsg fQogCiBwcml2YXRlOgorICAgIHZpcnR1YWwgQ29uc3RyYWludFR5cGUgY29uc3RyYWludFR5cGUo KSBjb25zdCBPVkVSUklERSB7IHJldHVybiBGaXhlZFBvc2l0aW9uQ29uc3RhaW50OyB9OworCiAg ICAgRmxvYXRSZWN0IG1fdmlld3BvcnRSZWN0QXRMYXN0TGF5b3V0OwogICAgIEZsb2F0UG9pbnQg bV9sYXllclBvc2l0aW9uQXRMYXN0TGF5b3V0OwogfTsKQEAgLTExOCw3ICsxMDAsNiBAQCBwdWJs aWM6CiAgICAgICAgICwgbV9ib3R0b21PZmZzZXQoMCkKICAgICB7IH0KIAotICAgIHZpcnR1YWwg Q29uc3RyYWludFR5cGUgY29uc3RyYWludFR5cGUoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBT dGlja3lQb3NpdGlvbkNvbnN0cmFpbnQ7IH07CiAgICAgRmxvYXRTaXplIGNvbXB1dGVTdGlja3lP ZmZzZXQoY29uc3QgRmxvYXRSZWN0JiB2aWV3cG9ydFJlY3QpIGNvbnN0OwogCiAgICAgY29uc3Qg RmxvYXRTaXplIHN0aWNreU9mZnNldEF0TGFzdExheW91dCgpIGNvbnN0IHsgcmV0dXJuIG1fc3Rp Y2t5T2Zmc2V0QXRMYXN0TGF5b3V0OyB9CkBAIC0xNDMsNiArMTI0LDggQEAgcHVibGljOgogICAg IHZvaWQgc2V0QWJzb2x1dGVTdGlja3lCb3hSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkgeyBt X2Fic29sdXRlU3RpY2t5Qm94UmVjdCA9IHJlY3Q7IH0KIAogcHJpdmF0ZToKKyAgICB2aXJ0dWFs IENvbnN0cmFpbnRUeXBlIGNvbnN0cmFpbnRUeXBlKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4g U3RpY2t5UG9zaXRpb25Db25zdHJhaW50OyB9OworCiAgICAgZmxvYXQgbV9sZWZ0T2Zmc2V0Owog ICAgIGZsb2F0IG1fcmlnaHRPZmZzZXQ7CiAgICAgZmxvYXQgbV90b3BPZmZzZXQ7Cg==