101267 2012-11-05 15:20:32 -0800 Hook up the remote layer tree drawing area to an environment variable 2012-11-06 10:43:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca mitz oldest_to_newest 758952 0 andersca 2012-11-05 15:20:32 -0800 Hook up the remote layer tree drawing area to an environment variable 758953 1 172418 andersca 2012-11-05 15:21:02 -0800 Created attachment 172418 Patch 758955 2 172418 mitz 2012-11-05 15:24:16 -0800 Comment on attachment 172418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review > Source/WebKit2/ChangeLog:9 > + (-[WKView WebKit::]): ? > Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 > + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here? 758999 3 andersca 2012-11-05 16:15:51 -0800 (In reply to comment #2) > (From update of attachment 172418 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review > > > Source/WebKit2/ChangeLog:9 > > + (-[WKView WebKit::]): > > ? ! > > > Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 > > + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) > > User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here? Because I don't want this to persist. I did the same thing when bringing up the tiled drawing area. 759839 4 172418 kling 2012-11-06 10:32:04 -0800 Comment on attachment 172418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review >>> Source/WebKit2/UIProcess/API/mac/WKView.mm:2282 >>> + if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA")) >> >> User defaults offer greater flexibility and convenience over environment variables. Why did you choose to use an environment variable here? > > Because I don't want this to persist. I did the same thing when bringing up the tiled drawing area. fine. 759851 5 andersca 2012-11-06 10:43:14 -0800 Committed r133637: <http://trac.webkit.org/changeset/133637> 172418 2012-11-05 15:21:02 -0800 2012-11-06 10:32:03 -0800 Patch bug-101267-20121105151916.patch text/plain 2720 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzFkYjVmNzA3ZWMzNWE1 MWYzOTEyZWFjMGIwM2VmN2FiMzVlMDcwZS4uZjQ3NDZhYmJiMzMzYzljMzZkODM2OTExMDczYTdj MGM1ODI4NGFjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTExLTA1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgSG9vayB1cCB0aGUg cmVtb3RlIGxheWVyIHRyZWUgZHJhd2luZyBhcmVhIHRvIGFuIGVudmlyb25tZW50IHZhcmlhYmxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyNjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IFdlYktpdDo6XSk6Cisg ICAgICAgICogVUlQcm9jZXNzL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1t OgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpzaXpl RGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQ cm94eTo6ZGV2aWNlU2NhbGVGYWN0b3JEaWRDaGFuZ2UpOgorCisyMDEyLTExLTA1ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQmVnaW4gc3R1YmJpbmcg b3V0IHRoZSBuZXcgcmVtb3RlIGxheWVyIHRyZWUgZHJhd2luZyBhcmVhCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyNTYKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCmluZGV4IGQ0YjMwMTI5ODM2OTNmMjQyZDcy YjM1NzczNDUzMmVjMTM4YjJkNGMuLjVmZDE2OWM4NGM4Mzg1NWQwMGI2MzE2OGU4N2M1YTU0MmFh NzMxMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmll dy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KQEAg LTQ2LDYgKzQ2LDcgQEAKICNpbXBvcnQgIlBERlZpZXdDb250cm9sbGVyLmgiCiAjaW1wb3J0ICJQ YWdlQ2xpZW50SW1wbC5oIgogI2ltcG9ydCAiUGFzdGVib2FyZFR5cGVzLmgiCisjaW1wb3J0ICJS ZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5LmgiCiAjaW1wb3J0ICJTdHJpbmdVdGlsaXRp ZXMuaCIKICNpbXBvcnQgIlRleHRDaGVja2VyLmgiCiAjaW1wb3J0ICJUZXh0Q2hlY2tlclN0YXRl LmgiCkBAIC0yMjc3LDggKzIyNzgsMTIgQEAgc3RhdGljIHZvaWQgZHJhd1BhZ2VCYWNrZ3JvdW5k KENHQ29udGV4dFJlZiBjb250ZXh0LCBXZWJQYWdlUHJveHkqIHBhZ2UsIGNvbnN0IEkKIC0gKFBh c3NPd25QdHI8V2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5PilfY3JlYXRlRHJhd2luZ0FyZWFQcm94 eQogewogI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpCi0gICAgaWYgKFtzZWxmIF9zaG91 bGRVc2VUaWxlZERyYXdpbmdBcmVhXSkKKyAgICBpZiAoW3NlbGYgX3Nob3VsZFVzZVRpbGVkRHJh d2luZ0FyZWFdKSB7CisgICAgICAgIGlmIChnZXRlbnYoIldLX1VTRV9SRU1PVEVfTEFZRVJfVFJF RV9EUkFXSU5HX0FSRUEiKSkKKyAgICAgICAgICAgIHJldHVybiBSZW1vdGVMYXllclRyZWVEcmF3 aW5nQXJlYVByb3h5OjpjcmVhdGUoX2RhdGEtPl9wYWdlLmdldCgpKTsKKwogICAgICAgICByZXR1 cm4gVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWFQcm94eTo6Y3JlYXRlKF9kYXRhLT5fcGFn ZS5nZXQoKSk7CisgICAgfQogI2VuZGlmCiAKICAgICByZXR1cm4gRHJhd2luZ0FyZWFQcm94eUlt cGw6OmNyZWF0ZShfZGF0YS0+X3BhZ2UuZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5Lm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5 Lm1tCmluZGV4IDhmMmI1ODE3MzhjYmM5ZTA5NGM1N2YzYjUxODI4YzYxNDJmNjFkY2MuLmQ4NzIw YTEwMGMxNmIyNWZmNjA2MWY1NDI1NDk1YmEwOGI1OTUxMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdB cmVhUHJveHkubW0KQEAgLTQyLDQgKzQyLDEyIEBAIFJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVh UHJveHk6On5SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5KCkKIHsKIH0KIAordm9pZCBS ZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpzaXplRGlkQ2hhbmdlKCkKK3sKK30KKwor dm9pZCBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpkZXZpY2VTY2FsZUZhY3RvckRp ZENoYW5nZSgpCit7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=