101238 2012-11-05 11:27:05 -0800 Fix asm operand type for weakCompareAndSwap on ARM_THUMB2 2012-11-07 12:48:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hans hans benjamin fpizlo thakis webkit.review.bot oldest_to_newest 758735 0 hans 2012-11-05 11:27:05 -0800 Fix asm operand type for weakCompareAndSwap on ARM_THUMB2 758743 1 172369 hans 2012-11-05 11:35:04 -0800 Created attachment 172369 Patch 758746 2 hans 2012-11-05 11:39:22 -0800 Filip: would you like to take a look? 760894 3 hans 2012-11-07 11:07:17 -0800 Ping? 760953 4 172369 benjamin 2012-11-07 12:10:01 -0800 Comment on attachment 172369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172369&action=review > Source/WTF/ChangeLog:20 > + Also make 'result' for the X86 version an 'unsigned char' to make it > + more clear that it is a byte. I honestly have no clue about that one, but that seems consistent with the old code. 760981 5 172369 webkit.review.bot 2012-11-07 12:48:18 -0800 Comment on attachment 172369 Patch Clearing flags on attachment: 172369 Committed r133796: <http://trac.webkit.org/changeset/133796> 760982 6 webkit.review.bot 2012-11-07 12:48:22 -0800 All reviewed patches have been landed. Closing bug. 172369 2012-11-05 11:35:04 -0800 2012-11-07 12:48:18 -0800 Patch bug-101238-20121105193318.patch text/plain 2289 hans U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY5M2MzYjU4YmU1ZjlkMDcwODlhNjIy MjMxNWQ3ZjZhNTMxYjViZjEuLmY3MjY3OTViZTE5ZGY3ODNiZDNlNDhlNGM2N2FlMjhkMWVkMzE3 ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTItMTEtMDUgIEhhbnMgV2VubmJvcmcgIDxoYW5z QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYXNtIG9wZXJhbmQgdHlwZSBmb3Igd2Vha0Nv bXBhcmVBbmRTd2FwIG9uIEFSTV9USFVNQjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMTIzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICdyZXN1bHQnIHdhcyBhIGJvb2wsIGJ1dCB0aGUgYXNtIHdhcyBl eHBlY3RpbmcgYSAzMi1iaXQgcmVnaXN0ZXIuIEEKKyAgICAgICAgcmVjZW50IHZlcnNpb24gb2Yg Q2xhbmcgd2FybmVkIGFib3V0IHRoaXM6CisKKyAgICAgICAgICBXZWJLaXQvU291cmNlL1dURi93 dGYvQXRvbWljcy5oOjE2MzozNDogZXJyb3I6IHRoZSBzaXplIGJlaW5nIHN0b3JlZAorICAgICAg ICAgIGlzIHRydW5jYXRlZCwgdXNlIGEgbW9kaWZpZXIgdG8gc3BlY2lmeSB0aGUgc2l6ZSBbLVdl cnJvciwtV2FzbS1vcGVyYW5kLXdpZHRoc10KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGl0 IGJ5IG1ha2luZyAncmVzdWx0JyBhbiB1bnNpZ25lZC4gSXQgZG9lcyBub3QgY2hhbmdlCisgICAg ICAgIHRoZSBmdW5jdGlvbmFsaXR5IGluIHByYWN0aWNlICgncmVzdWx0JyB3b3VsZCBiZSBpbiBh IDMyLWJpdCByZWdpc3RlcgorICAgICAgICBhbnl3YXkpLCBidXQgaXQgbWFrZXMgdGhlIGNvZGUg bW9yZSBjb3JyZWN0IGFuZCBtYWtlcyB0aGUgd2FybmluZyBnbworICAgICAgICBhd2F5LgorCisg ICAgICAgIEFsc28gbWFrZSAncmVzdWx0JyBmb3IgdGhlIFg4NiB2ZXJzaW9uIGFuICd1bnNpZ25l ZCBjaGFyJyB0byBtYWtlIGl0CisgICAgICAgIG1vcmUgY2xlYXIgdGhhdCBpdCBpcyBhIGJ5dGUu CisKKyAgICAgICAgKiB3dGYvQXRvbWljcy5oOgorICAgICAgICAoV1RGOjp3ZWFrQ29tcGFyZUFu ZFN3YXApOgorCiAyMDEyLTExLTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIEdldCByaWQgb2YgVVNFKENGVVJMU1RPUkFHRVNFU1NJT05TKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvQXRvbWljcy5oIGIvU291cmNlL1dURi93dGYvQXRvbWljcy5o CmluZGV4IDlmODlkZjE0MDkwOTFkYjFkN2Q1MTBkZWJlZTg3ZTE1ZGEwMTRhNmYuLmUyNTYwYWI3 ZmJiZDJjNjU1Mjk5NDFmM2IwMzM2YWMyM2FlODk3ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL0F0b21pY3MuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKQEAgLTE0Miw4ICsx NDIsOCBAQCBpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3YXAodW5zaWduZWQqIGxvY2F0aW9u LCB1bnNpZ25lZCBleHBlY3RlZCwgdW5zaWduZWQgbgogI2VuZGlmCiB7CiAjaWYgRU5BQkxFKENP TVBBUkVfQU5EX1NXQVApCi0gICAgYm9vbCByZXN1bHQ7CiAjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4 Nl82NCkKKyAgICB1bnNpZ25lZCBjaGFyIHJlc3VsdDsKICAgICBhc20gdm9sYXRpbGUoCiAgICAg ICAgICJsb2NrOyBjbXB4Y2hnbCAlMywgJTJcblx0IgogICAgICAgICAic2V0ZSAlMSIKQEAgLTE1 Myw2ICsxNTMsNyBAQCBpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3YXAodW5zaWduZWQqIGxv Y2F0aW9uLCB1bnNpZ25lZCBleHBlY3RlZCwgdW5zaWduZWQgbgogICAgICAgICApOwogI2VsaWYg Q1BVKEFSTV9USFVNQjIpCiAgICAgdW5zaWduZWQgdG1wOworICAgIHVuc2lnbmVkIHJlc3VsdDsK ICAgICBhc20gdm9sYXRpbGUoCiAgICAgICAgICJtb3Z3ICUxLCAjMVxuXHQiCiAgICAgICAgICJs ZHJleCAlMiwgJTBcblx0IgpAQCAtMTczLDcgKzE3NCw3IEBAIGlubGluZSBib29sIHdlYWtDb21w YXJlQW5kU3dhcCh1bnNpZ25lZCogbG9jYXRpb24sIHVuc2lnbmVkIGV4cGVjdGVkLCB1bnNpZ25l ZCBuCiAgICAgVU5VU0VEX1BBUkFNKGV4cGVjdGVkKTsKICAgICBVTlVTRURfUEFSQU0obmV3VmFs dWUpOwogICAgIENSQVNIKCk7Ci0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIGZhbHNlOwogI2Vu ZGlmCiB9CiAK