101230 2012-11-05 09:36:26 -0800 Style-checker strips comments before checking indentation 2022-10-25 08:48:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Unspecified Unspecified NEW P2 Normal --- 1 allan.jensen allan.jensen abarth ahmad.saleem792 ap dpranke gsnedders levin ryanhaddad webkit.review.bot oldest_to_newest 758617 0 allan.jensen 2012-11-05 09:36:26 -0800 The style-checker performs its indentation check on cleansed lines, this means that comments are not checked for indentation, and inline comments followed by white-space will be miscounted by style-checker. Instead the style-checker should perform indentation check on raw-lines. This way it will also ensure comments correctly indented. 758618 1 172353 allan.jensen 2012-11-05 09:38:46 -0800 Created attachment 172353 Patch 758639 2 172353 abarth 2012-11-05 10:07:29 -0800 Comment on attachment 172353 Patch Please add a test. There's a nice unit testing framework for this code. 759444 3 172531 allan.jensen 2012-11-06 02:35:25 -0800 Created attachment 172531 Patch 762961 4 172531 allan.jensen 2012-11-09 06:38:06 -0800 Comment on attachment 172531 Patch I want to run a one more test on this patch before landing. I am uncertain if multi-line comments are correctly handled, or might give false errors. 1908110 5 ahmad.saleem792 2022-10-25 08:48:03 -0700 It seems this r+ patch didn't landed. Is this needed now to enhance "Style-checker" or this is already taken care of one way or another? Thanks! 172353 2012-11-05 09:38:46 -0800 2012-11-06 02:35:21 -0800 Patch bug-101230-20121105183637.patch text/plain 1934 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzIxYTIxYTljM2FlODRjMTEzOTY2ZWRlNTUyY2ZjYWVl NTQxZmQ0NS4uNjQyMDk3NWY2MGFhYTNiODgxYWMwZTY1NzQzNGIyMTkwM2UyMTViMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTExLTA1ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFN0eWxlLWNoZWNrZXIgc3RyaXBzIGNvbW1lbnRzIGJlZm9yZSBj aGVja2luZyBpbmRlbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAxMjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybSBpbmRlbnRhdGlvbiBjaGVjayBvbiByYXcgbGluZXMsIHNvIHRo YXQgaW5saW5lIGNvbW1lbnRzIGRvZXMgbm90IGNvbmZ1c2UgdGhlIHN0eWxlLWNoZWNrZXIKKyAg ICAgICAgYW5kIGNvbW1lbnRzIGFsc28gaGF2ZSB0aGVpciBpbmRlbnRhdGlvbiBjaGVja2VkLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAg ICAgIChjaGVja19pbmRlbnRhdGlvbl9hbW91bnQpOgorCiAyMDEyLTExLTA1ICBLeXVuZ1RhZSBL aW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEZpeCBidWlsZCB3YXJu aW5nIGluIEVXZWJMYXVuY2hlci9tYWluLmMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkKaW5kZXggZWJiZDFhZDJmNjUwOGQzOWFkMTQ5MTVlY2M4MzllYzgx NTlkOWI3Zi4uMTFjOWI0MjJhMTZkNGNjYjZkODVlMTNlYjY4OGZiODQyNGRiMzM3YyAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIwNjgsNyAr MjA2OCw3IEBAIGRlZiBnZXRfaW5pdGlhbF9zcGFjZXNfZm9yX2xpbmUoY2xlYW5fbGluZSk6CiAK IAogZGVmIGNoZWNrX2luZGVudGF0aW9uX2Ftb3VudChjbGVhbl9saW5lcywgbGluZV9udW1iZXIs IGVycm9yKToKLSAgICBsaW5lID0gY2xlYW5fbGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXQorICAg IGxpbmUgPSBjbGVhbl9saW5lcy5yYXdfbGluZXNbbGluZV9udW1iZXJdCiAgICAgaW5pdGlhbF9z cGFjZXMgPSBnZXRfaW5pdGlhbF9zcGFjZXNfZm9yX2xpbmUobGluZSkKIAogICAgIGlmIGluaXRp YWxfc3BhY2VzICUgNDoKQEAgLTIwNzYsNyArMjA3Niw3IEBAIGRlZiBjaGVja19pbmRlbnRhdGlv bl9hbW91bnQoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAgICAgICAg ICdXZWlyZCBudW1iZXIgb2Ygc3BhY2VzIGF0IGxpbmUtc3RhcnQuICBBcmUgeW91IHVzaW5nIGEg NC1zcGFjZSBpbmRlbnQ/JykKICAgICAgICAgcmV0dXJuCiAKLSAgICBwcmV2aW91c19saW5lID0g Z2V0X3ByZXZpb3VzX25vbl9ibGFua19saW5lKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlcilbMF0K KyAgICBwcmV2aW91c19saW5lID0gY2xlYW5fbGluZXMucmF3X2xpbmVzW2dldF9wcmV2aW91c19u b25fYmxhbmtfbGluZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIpWzFdXQogICAgIGlmIG5vdCBw cmV2aW91c19saW5lLnN0cmlwKCkgb3IgbWF0Y2gocidccypcdytccyo6XHMqJCcsIHByZXZpb3Vz X2xpbmUpIG9yIHByZXZpb3VzX2xpbmVbMF0gPT0gJyMnOgogICAgICAgICByZXR1cm4KIAo= 172531 2012-11-06 02:35:25 -0800 2012-11-09 06:38:06 -0800 Patch bug-101230-20121106113314.patch text/plain 2940 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzIxYTIxYTljM2FlODRjMTEzOTY2ZWRlNTUyY2ZjYWVl NTQxZmQ0NS4uZDMzNjE0ZDFkODc1Yzg2YjY3YjNkZTUzMjY1YmY1ODM0ZDA3NWI2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTExLTA2ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGln aWEuY29tPgorCisgICAgICAgIFN0eWxlLWNoZWNrZXIgc3RyaXBzIGNvbW1lbnRzIGJlZm9yZSBj aGVja2luZyBpbmRlbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAxMjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUGVyZm9ybSBpbmRlbnRhdGlvbiBjaGVjayBvbiByYXcgbGluZXMsIHNvIHRo YXQgaW5saW5lIGNvbW1lbnRzIGRvZXMgbm90IGNvbmZ1c2UgdGhlIHN0eWxlLWNoZWNrZXIKKyAg ICAgICAgYW5kIGNvbW1lbnRzIGFsc28gaGF2ZSB0aGVpciBpbmRlbnRhdGlvbiBjaGVja2VkLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAg ICAgIChjaGVja19pbmRlbnRhdGlvbl9hbW91bnQpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3BwU3R5bGVUZXN0 LnRlc3RfaW5kZW50KToKKwogMjAxMi0xMS0wNSAgS3l1bmdUYWUgS2ltICA8a3RmLmtpbUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBGaXggYnVpbGQgd2FybmluZyBpbiBFV2ViTGF1bmNo ZXIvbWFpbi5jCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CmluZGV4IGViYmQxYWQyZjY1MDhkMzlhZDE0OTE1ZWNjODM5ZWM4MTU5ZDliN2YuLjExYzliNDIy YTE2ZDRjY2I2ZDg1ZTEzZWI2ODhmYjg0MjRkYjMzN2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yMDY4LDcgKzIwNjgsNyBAQCBkZWYgZ2V0 X2luaXRpYWxfc3BhY2VzX2Zvcl9saW5lKGNsZWFuX2xpbmUpOgogCiAKIGRlZiBjaGVja19pbmRl bnRhdGlvbl9hbW91bnQoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6Ci0gICAgbGlu ZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0KKyAgICBsaW5lID0gY2xlYW5fbGlu ZXMucmF3X2xpbmVzW2xpbmVfbnVtYmVyXQogICAgIGluaXRpYWxfc3BhY2VzID0gZ2V0X2luaXRp YWxfc3BhY2VzX2Zvcl9saW5lKGxpbmUpCiAKICAgICBpZiBpbml0aWFsX3NwYWNlcyAlIDQ6CkBA IC0yMDc2LDcgKzIwNzYsNyBAQCBkZWYgY2hlY2tfaW5kZW50YXRpb25fYW1vdW50KGNsZWFuX2xp bmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICAgICAgICAgICAnV2VpcmQgbnVtYmVyIG9m IHNwYWNlcyBhdCBsaW5lLXN0YXJ0LiAgQXJlIHlvdSB1c2luZyBhIDQtc3BhY2UgaW5kZW50Pycp CiAgICAgICAgIHJldHVybgogCi0gICAgcHJldmlvdXNfbGluZSA9IGdldF9wcmV2aW91c19ub25f YmxhbmtfbGluZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIpWzBdCisgICAgcHJldmlvdXNfbGlu ZSA9IGNsZWFuX2xpbmVzLnJhd19saW5lc1tnZXRfcHJldmlvdXNfbm9uX2JsYW5rX2xpbmUoY2xl YW5fbGluZXMsIGxpbmVfbnVtYmVyKVsxXV0KICAgICBpZiBub3QgcHJldmlvdXNfbGluZS5zdHJp cCgpIG9yIG1hdGNoKHInXHMqXHcrXHMqOlxzKiQnLCBwcmV2aW91c19saW5lKSBvciBwcmV2aW91 c19saW5lWzBdID09ICcjJzoKICAgICAgICAgcmV0dXJuCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNmYwMDFl MGNiNzYyOGY2Nzg5MDcyZjdmYTUxNzEyY2Q0NGQzMGYxZi4uNTE5NzBkMjgzYzRjMjBhMGRhMTYw MWU5ZDViZjc1YWJlZTg5OTg4YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTIwNjcsNiArMjA2NywxMyBAQCBj bGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnICAgIH07 XG4nCiAgICAgICAgICAgICAnfTsnLAogICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoJyAgIC8vIE15IGNvbW1lbnQnLAorICAgICAgICAgICAgICAgICAgICAgICAgICdX ZWlyZCBudW1iZXIgb2Ygc3BhY2VzIGF0IGxpbmUtc3RhcnQuICAnCisgICAgICAgICAgICAgICAg ICAgICAgICAgJ0FyZSB5b3UgdXNpbmcgYSA0LXNwYWNlIGluZGVudD8gIFt3aGl0ZXNwYWNlL2lu ZGVudF0gWzNdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAgICAg ICAgICAgJ2NhbGxfZnVuY3Rpb24oYXJndW1lbnQxLCAnCisgICAgICAgICAgICAnICAgIC8qYm9v bElzVGhpcyovIGZhbHNlKTsnLAorICAgICAgICAgICAgJycpCiAKICAgICBkZWYgdGVzdF9ub3Rf YWxhYmVsKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdNeVZlcnlMb25nTmFtZXNw YWNlOjpNeVZlcnlMb25nQ2xhc3NOYW1lOjonLCAnJykK