101228 2012-11-05 09:00:54 -0800 [EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile() 2012-11-05 09:33:58 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 758592 0 cdumez 2012-11-05 09:00:54 -0800 The EFL port currently has its own implementation of SharedBuffer::createWithContentsOfFile(), which is pretty much the same as the POSIX one. We should therefore, reuse the POSIX implementation instead of duplicating the code. 758597 1 172350 cdumez 2012-11-05 09:04:58 -0800 Created attachment 172350 Patch 758615 2 172350 webkit.review.bot 2012-11-05 09:33:54 -0800 Comment on attachment 172350 Patch Clearing flags on attachment: 172350 Committed r133488: <http://trac.webkit.org/changeset/133488> 758616 3 webkit.review.bot 2012-11-05 09:33:58 -0800 All reviewed patches have been landed. Closing bug. 172350 2012-11-05 09:04:58 -0800 2012-11-05 09:33:54 -0800 Patch 101228_posix_sharedbuffer.patch text/plain 4212 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNDYyNWQ2Li4zYzBiZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBVc2UgUE9TSVggaW1wbGVtZW50YXRpb24gb2YgU2hhcmVk QnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBFRkwtc3BlY2lmaWMgaW1wbGVt ZW50YXRpb24gb2YgU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUoKQorICAg ICAgICBhbmQgcmV1c2UgdGhlIFBPU0lYIG9uZSBzaW5jZSBpdCBpcyBwcmV0dHkgbXVjaCB0aGUg c2FtZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAg ICAgICAqIFBsYXRmb3JtRWZsLmNtYWtlOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC9TaGFyZWRC dWZmZXJFZmwuY3BwOiBSZW1vdmVkLgorCiAyMDEyLTExLTA1ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm90ZWN0IGFnYWluc3QgcmVzb3VyY2UgZGVsZXRp b24gZHVyaW5nIGl0ZXJhdGlvbiBpbiBNZW1vcnlDYWNoZTo6cHJ1bmVEZWFkUmVzb3VyY2VzVG9T aXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJj ZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGRlMDc1YjAuLjc1ZDY0M2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC00NSw3ICs0NSw2IEBAIExJU1QoQVBQRU5EIFdlYkNv cmVfU09VUkNFUwogICBwbGF0Zm9ybS9lZmwvU2Nyb2xsVmlld0VmbC5jcHAKICAgcGxhdGZvcm0v ZWZsL1Njcm9sbGJhckVmbC5jcHAKICAgcGxhdGZvcm0vZWZsL1Njcm9sbGJhclRoZW1lRWZsLmNw cAotICBwbGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVyRWZsLmNwcAogICBwbGF0Zm9ybS9lZmwvU2hh cmVkVGltZXJFZmwuY3BwCiAgIHBsYXRmb3JtL2VmbC9Tb3VuZEVmbC5jcHAKICAgcGxhdGZvcm0v ZWZsL1N5c3RlbVRpbWVFZmwuY3BwCkBAIC04NSw2ICs4NCw3IEBAIExJU1QoQVBQRU5EIFdlYkNv cmVfU09VUkNFUwogICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cFVSSVV0aWxzLmNwcAogICBw bGF0Zm9ybS9QbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwCiAgIHBsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0 ZW1QT1NJWC5jcHAKKyAgcGxhdGZvcm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwCiAgIHBs YXRmb3JtL3RleHQvZWZsL1RleHRCcmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VFZmwuY3BwCiAgIHBs YXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCiApCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVyRWZsLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TaGFyZWRCdWZmZXJFZmwuY3BwCmRlbGV0ZWQgZmlsZSBt b2RlIDEwMDY0NAppbmRleCA4ZGI0NGE2Li4wMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9TaGFyZWRCdWZmZXJFZmwuY3BwCisrKyAvZGV2L251bGwKQEAgLTEsNjIgKzAs MCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOCBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhl cgotICogICAgICAgICAgICAgICAyMDA4IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuCi0gKiAg ICAgICAgICAgICAgIDIwMDktMjAxMCBQcm9GVVNJT04gZW1iZWRkZWQgc3lzdGVtcwotICogICAg ICAgICAgICAgICAyMDA5LTIwMTAgU2Ftc3VuZyBFbGVjdHJvbmljcwotICoKLSAqIFJlZGlzdHJp YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91 dAotICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv d2luZyBjb25kaXRpb25zCi0gKiBhcmUgbWV0OgotICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNv dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KLSAq IDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv dmUgY29weXJpZ2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0 aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCi0gKiAgICBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgotICoKLSAq IFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQ09NUFVURVIsIElOQy4gYGBBUyBJ UycnIEFORCBBTlkKLSAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcs IEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCi0gKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hB TlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJ U0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBDT01QVVRFUiwgSU5DLiBPUgotICog Q09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5U QUwsIFNQRUNJQUwsCi0gKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5D TFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRF IEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKLSAqIFBST0ZJVFM7IE9S IEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkK LSAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwg T1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNpbmNsdWRl ICJjb25maWcuaCIKLSNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKLQotI2luY2x1ZGUgPHN0ZGlv Lmg+Ci0jaW5jbHVkZSA8c3lzL3N0YXQuaD4KLSNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KLSNpbmNs dWRlIDx1bmlzdGQuaD4KLSNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+Ci0KLW5hbWVzcGFj ZSBXZWJDb3JlIHsKLQotUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6Y3Jl YXRlV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0cmluZyYgZmlsZVBhdGgpCi17Ci0gICAgaWYg KGZpbGVQYXRoLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICBGSUxFKiBmaWxl ID0gZm9wZW4oZmlsZVBhdGgudXRmOCgpLmRhdGEoKSwgInJiIik7Ci0gICAgaWYgKCFmaWxlKQot ICAgICAgICByZXR1cm4gMDsKLQotICAgIHN0cnVjdCBzdGF0IGZpbGVTdGF0OwotICAgIGlmIChm c3RhdChmaWxlbm8oZmlsZSksICZmaWxlU3RhdCkpIHsKLSAgICAgICAgZmNsb3NlKGZpbGUpOwot ICAgICAgICByZXR1cm4gMDsKLSAgICB9Ci0KLSAgICBWZWN0b3I8Y2hhcj4gYnVmZmVyKGZpbGVT dGF0LnN0X3NpemUpOwotICAgIGNvbnN0IHNpemVfdCBieXRlc1JlYWQgPSBmcmVhZChidWZmZXIu ZGF0YSgpLCAxLCBidWZmZXIuc2l6ZSgpLCBmaWxlKTsKLSAgICBmY2xvc2UoZmlsZSk7Ci0KLSAg ICByZXR1cm4gKGJ5dGVzUmVhZCA9PSBidWZmZXIuc2l6ZSgpKSA/IFNoYXJlZEJ1ZmZlcjo6YWRv cHRWZWN0b3IoYnVmZmVyKSA6IDA7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK