101212 2012-11-05 06:21:34 -0800 [V8] IDBKey::toV8(impl) should return null instead of undefined when impl is 0 2012-11-05 14:14:19 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101054 1 haraken haraken abarth alecflett japhet jsbell webkit.review.bot oldest_to_newest 758476 0 haraken 2012-11-05 06:21:34 -0800 All other toV8(impl) return null when impl is 0. 758480 1 172326 haraken 2012-11-05 06:26:06 -0800 Created attachment 172326 Patch 758482 2 haraken 2012-11-05 06:26:47 -0800 jsbell, alecflett: would you check if this patch doesn't break compatibility? 758524 3 172326 abarth 2012-11-05 07:41:52 -0800 Comment on attachment 172326 Patch Please wait to hear from jsbell or alecflett before landing. 758531 4 jsbell 2012-11-05 07:51:14 -0800 Returning undefined in that case is intentional, see: https://bugs.webkit.org/show_bug.cgi?id=96401 ...which contains the spec reference. 758533 5 haraken 2012-11-05 07:53:17 -0800 (In reply to comment #4) > Returning undefined in that case is intentional, see: > > https://bugs.webkit.org/show_bug.cgi?id=96401 > > ...which contains the spec reference. ok, then I'll add a comment about it. (The spec sounds strange to me though.) 758540 6 172336 haraken 2012-11-05 08:04:19 -0800 Created attachment 172336 patch for landing 758557 7 172336 abarth 2012-11-05 08:29:45 -0800 Comment on attachment 172336 patch for landing This probably isn't the best way to implement this requirement. Instead, the attributes that can return undefined should do so explicitly rather than relying upon toJS/toV8 to do something wonky. 758560 8 172336 haraken 2012-11-05 08:31:40 -0800 Comment on attachment 172336 patch for landing Makes sense. Will fix it. 758563 9 172336 webkit.review.bot 2012-11-05 08:32:34 -0800 Comment on attachment 172336 patch for landing Clearing flags on attachment: 172336 Committed r133483: <http://trac.webkit.org/changeset/133483> 758564 10 webkit.review.bot 2012-11-05 08:32:38 -0800 All reviewed patches have been landed. Closing bug. 758631 11 haraken 2012-11-05 10:01:10 -0800 (In reply to comment #7) > (From update of attachment 172336 [details]) > This probably isn't the best way to implement this requirement. Instead, the attributes that can return undefined should do so explicitly rather than relying upon toJS/toV8 to do something wonky. At first I was thinking about introducing a new IDL attribute [TreatReturnedNullAs=Undefined]. However, as far as I scanned custom bindings, DOM attributes benefited by the IDL attribute are only IDBKeyRange.upper and IDBKeyRange.lower. Maybe it would make sense to just write custom getters for IDBKeyRange.upper and IDBKeyRange.lower? 758642 12 abarth 2012-11-05 10:09:24 -0800 > At first I was thinking about introducing a new IDL attribute [TreatReturnedNullAs=Undefined]. However, as far as I scanned custom bindings, DOM attributes benefited by the IDL attribute are only IDBKeyRange.upper and IDBKeyRange.lower. Maybe it would make sense to just write custom getters for IDBKeyRange.upper and IDBKeyRange.lower? We should look in WebIDL, but I think technically the right way to handle this is by adding a ? after the type in the IDL file. 758647 13 haraken 2012-11-05 10:13:05 -0800 (In reply to comment #12) > We should look in WebIDL, but I think technically the right way to handle this is by adding a ? after the type in the IDL file. The situation looks a bit different. 'IDBKey?' means that an IDBKey object and null are valid values. (http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type) On the other hand, in our situation we want to return undefined. 758650 14 abarth 2012-11-05 10:15:41 -0800 Does that mean the behavior of this interface cannot be represented in WebIDL? 758661 15 haraken 2012-11-05 10:22:11 -0800 (In reply to comment #14) > Does that mean the behavior of this interface cannot be represented in WebIDL? In my understanding, we cannot. (If upper and lower are speced to return null, it is conformed to the WebIDL. In that sense, the spec sounds strange to me.) It is possible to represent the behavior in the WebKit IDL by introducing [TreatReturnedNullAs=Undefined], but the IDL attribute just benefits only IDBKeyRange.upper and IDBKeyRannge.lower. (Also, if we try to support [TreatReturnedNullAs=*] for all types, it would mess up JSValueToNative() in CodeGenerator*.pm.) 758665 16 abarth 2012-11-05 10:25:54 -0800 For the time being, I'd recommend going with custom code. I don't fully understand why these attributes return undefined. Is there a strong reason for that from the IDB side? If not, we might want to change the spec to better align with the rest of the platform. 758667 17 haraken 2012-11-05 10:27:20 -0800 (In reply to comment #16) > I don't fully understand why these attributes return undefined. Is there a strong reason for that from the IDB side? If not, we might want to change the spec to better align with the rest of the platform. Agreed. jsbell, alecflett: Do you have any idea? 758699 18 alecflett 2012-11-05 10:56:34 -0800 That sounds totally reasonable to me, but I don't know enough of the background - I defer to jsbell@ here but I expect we'll take it up on the list.. 758766 19 jsbell 2012-11-05 11:56:49 -0800 I don't think there's any particular reason to prefer null vs. undefined for these attributes in the spec. Neither are "valid" values for a key. As alecflett@ says, this will come down to list consensus. As far as implementing it, I have webkit.org/b/97375 filed to propose removing all of the custom binding logic around IDBKey, since IDBKey is a WebKit concept not an IDB concept. I was thinking use any/ScriptValue (IDL/C++) and do IDBKey<->ScriptValue conversion in the IDB code itself by calls into the binding utilities. Not sure that's the right direction to go, but it would remove these special cases. 758768 20 jsbell 2012-11-05 11:59:14 -0800 (In reply to comment #13) > The situation looks a bit different. 'IDBKey?' means that an IDBKey object and null are valid values. (http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type) On the other hand, in our situation we want to return undefined. And just to re-iterate - the IDB spec doesn't define an IDBKey interface in the IDL; that's entirely a WebKit creation. Wherever WebKitIDLs use IDBKey it is |any| in the IDB spec. 758869 21 abarth 2012-11-05 14:03:55 -0800 > And just to re-iterate - the IDB spec doesn't define an IDBKey interface in the IDL; that's entirely a WebKit creation. Wherever WebKitIDLs use IDBKey it is |any| in the IDB spec. Is there a particular reason IDB wants to return undefined here rather than null? 758878 22 jsbell 2012-11-05 14:07:39 -0800 (In reply to comment #21) > > Is there a particular reason IDB wants to return undefined here rather than null? No, I don't think so. (I think the IDB spec in general went a little crazy with "undefined"; I seem to recall this was done across the spec at some point about a year ago but I don't recall the rationale or history.) 758889 23 abarth 2012-11-05 14:14:19 -0800 It might be better if we changed to spec to make these attributes behave like most other attributes in the platform. I don't know how locked down the current spec is, however. 172326 2012-11-05 06:26:06 -0800 2012-11-05 08:04:14 -0800 Patch bug-101212-20121105152420.patch text/plain 7063 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThiOTEyNGVkZDU1ZTBk NGE0MGI4ZGJhZWE1YjE4MDFhMDc3MzMxMy4uYTRjNGQ2MjZmOGUwNTRmZDQ4ZWU4NjcwZmM3OThh NDYwOTk2NGQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTExLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIElEQktleTo6 dG9WOChpbXBsKSBzaG91bGQgcmV0dXJuIG51bGwgaW5zdGVhZCBvZiB1bmRlZmluZWQgd2hlbiBp bXBsIGlzIDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMTIxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFsbCBvdGhlciB0b1Y4KGltcGwpIHJldHVybiBudWxsIHdoZW4gaW1wbCBpcyAwLgorCisgICAg ICAgIFRlc3Q6IHN0b3JhZ2UvaW5kZXhlZGRiL2tleXJhbmdlLmh0bWwKKworICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOElEQktleUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0 b1Y4KToKKworMjAxMi0xMS0wNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgW1Y4XSBEaXNwb3NlKCkgYW5kIENsZWFyKCkgc2hvdWxkIGJlIGFsd2F5cyBj b3VwbGVkIGZvciBzYWZldHkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTE5MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhJREJLZXlDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4SURCS2V5Q3VzdG9tLmNwcAppbmRleCBmYzExNmE5ODYxM2NkMWM0MDYwNzNhMzQw ZDA3NjA3NDE0YzcyNTMwLi5mNmM4NTVlMGM4YjZjYjlhYWNiYTFjYTViYmZkNjY5ZGE2NjM0MmFm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJREJLZXlD dXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQktl eUN1c3RvbS5jcHAKQEAgLTQxLDcgKzQxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdjg6Okhh bmRsZTx2ODo6VmFsdWU+IHRvVjgoSURCS2V5KiBrZXksIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4g Y3JlYXRpb25Db250ZXh0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKICAgICBpZiAoIWtleSkK LSAgICAgICAgcmV0dXJuIHY4VW5kZWZpbmVkKCk7CisgICAgICAgIHJldHVybiB2OE51bGxXaXRo Q2hlY2soaXNvbGF0ZSk7CiAKICAgICBzd2l0Y2ggKGtleS0+dHlwZSgpKSB7CiAgICAgY2FzZSBJ REJLZXk6OkludmFsaWRUeXBlOgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU0NjIyZmJjOTY2NTZjMDc4ZGRjNWZiMzQ5N2Zh ZTUzN2NmYzg5ZTUuLmE4OTgxYjk4OTg0NTAyNTY3ZjRkOTRhYzE5NGE3YmZjOTI5ZTk4MTYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMS0wNSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBJREJLZXk6OnRvVjgoaW1wbCkgc2hvdWxkIHJl dHVybiBudWxsIGluc3RlYWQgb2YgdW5kZWZpbmVkIHdoZW4gaW1wbCBpcyAwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyMTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIHRlc3QgcmVzdWx0 cy4gdW5kZWZpbmVkID0+IG51bGwuCisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9rZXly YW5nZS1leHBlY3RlZC50eHQ6CisKIDIwMTItMTEtMDQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBvYnNvbGV0ZSB0ZXN0cyBmb3IgZGF0ZS90aW1l IGlucHV0IHR5cGVzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9r ZXlyYW5nZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXly YW5nZS1leHBlY3RlZC50eHQKaW5kZXggZjU5YTVkMGQwOTU0MTAwOGU3YmU3ZTFlZjIwOTAyZDEw ZTE5OTA4Yy4uOTQ0NTBlNjdlMGEyMTBkM2RmZWJlYTI4MjY3N2U1MjY5YTU2MGZlNCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIva2V5cmFuZ2UtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2tleXJhbmdlLWV4cGVjdGVkLnR4 dApAQCAtNDIsOTIgKzQyLDkyIEBAIFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlzIGZhbHNlCiBJ REJLZXlSYW5nZS5sb3dlckJvdW5kKDEwLHRydWUpCiBQQVNTIGtleVJhbmdlLmxvd2VyIGlzIDEw CiBQQVNTIGtleVJhbmdlLmxvd2VyT3BlbiBpcyB0cnVlCi1QQVNTIGtleVJhbmdlLnVwcGVyIGlz IHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UudXBwZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5nZS51 cHBlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UubG93ZXJCb3VuZCgxMSxmYWxzZSkKIFBBU1Mg a2V5UmFuZ2UubG93ZXIgaXMgMTEKIFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVuIGlzIGZhbHNlCi1Q QVNTIGtleVJhbmdlLnVwcGVyIGlzIHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UudXBwZXIgaXMg bnVsbAogUEFTUyBrZXlSYW5nZS51cHBlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UubG93ZXJC b3VuZCgxMix1bmRlZmluZWQpCiBQQVNTIGtleVJhbmdlLmxvd2VyIGlzIDEyCiBQQVNTIGtleVJh bmdlLmxvd2VyT3BlbiBpcyBmYWxzZQotUEFTUyBrZXlSYW5nZS51cHBlciBpcyB1bmRlZmluZWQu CitQQVNTIGtleVJhbmdlLnVwcGVyIGlzIG51bGwKIFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlz IHRydWUKIElEQktleVJhbmdlLmxvd2VyQm91bmQoMTAuMSx0cnVlKQogUEFTUyBrZXlSYW5nZS5s b3dlciBpcyAxMC4xCiBQQVNTIGtleVJhbmdlLmxvd2VyT3BlbiBpcyB0cnVlCi1QQVNTIGtleVJh bmdlLnVwcGVyIGlzIHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UudXBwZXIgaXMgbnVsbAogUEFT UyBrZXlSYW5nZS51cHBlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UubG93ZXJCb3VuZCgxMS4y LGZhbHNlKQogUEFTUyBrZXlSYW5nZS5sb3dlciBpcyAxMS4yCiBQQVNTIGtleVJhbmdlLmxvd2Vy T3BlbiBpcyBmYWxzZQotUEFTUyBrZXlSYW5nZS51cHBlciBpcyB1bmRlZmluZWQuCitQQVNTIGtl eVJhbmdlLnVwcGVyIGlzIG51bGwKIFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlzIHRydWUKIElE QktleVJhbmdlLmxvd2VyQm91bmQoMTIuMyx1bmRlZmluZWQpCiBQQVNTIGtleVJhbmdlLmxvd2Vy IGlzIDEyLjMKIFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVuIGlzIGZhbHNlCi1QQVNTIGtleVJhbmdl LnVwcGVyIGlzIHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UudXBwZXIgaXMgbnVsbAogUEFTUyBr ZXlSYW5nZS51cHBlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UubG93ZXJCb3VuZCgnYWEnLHRy dWUpCiBQQVNTIGtleVJhbmdlLmxvd2VyIGlzICdhYScKIFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVu IGlzIHRydWUKLVBBU1Mga2V5UmFuZ2UudXBwZXIgaXMgdW5kZWZpbmVkLgorUEFTUyBrZXlSYW5n ZS51cHBlciBpcyBudWxsCiBQQVNTIGtleVJhbmdlLnVwcGVyT3BlbiBpcyB0cnVlCiBJREJLZXlS YW5nZS5sb3dlckJvdW5kKCdhYicsZmFsc2UpCiBQQVNTIGtleVJhbmdlLmxvd2VyIGlzICdhYicK IFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVuIGlzIGZhbHNlCi1QQVNTIGtleVJhbmdlLnVwcGVyIGlz IHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UudXBwZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5nZS51 cHBlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UubG93ZXJCb3VuZCgnYWMnLHVuZGVmaW5lZCkK IFBBU1Mga2V5UmFuZ2UubG93ZXIgaXMgJ2FjJwogUEFTUyBrZXlSYW5nZS5sb3dlck9wZW4gaXMg ZmFsc2UKLVBBU1Mga2V5UmFuZ2UudXBwZXIgaXMgdW5kZWZpbmVkLgorUEFTUyBrZXlSYW5nZS51 cHBlciBpcyBudWxsCiBQQVNTIGtleVJhbmdlLnVwcGVyT3BlbiBpcyB0cnVlCiBJREJLZXlSYW5n ZS51cHBlckJvdW5kKDIwLHRydWUpCiBQQVNTIGtleVJhbmdlLnVwcGVyIGlzIDIwCiBQQVNTIGtl eVJhbmdlLnVwcGVyT3BlbiBpcyB0cnVlCi1QQVNTIGtleVJhbmdlLmxvd2VyIGlzIHVuZGVmaW5l ZC4KK1BBU1Mga2V5UmFuZ2UubG93ZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5nZS5sb3dlck9wZW4g aXMgdHJ1ZQogSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgyMSxmYWxzZSkKIFBBU1Mga2V5UmFuZ2Uu dXBwZXIgaXMgMjEKIFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlzIGZhbHNlCi1QQVNTIGtleVJh bmdlLmxvd2VyIGlzIHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UubG93ZXIgaXMgbnVsbAogUEFT UyBrZXlSYW5nZS5sb3dlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgyMix1 bmRlZmluZWQpCiBQQVNTIGtleVJhbmdlLnVwcGVyIGlzIDIyCiBQQVNTIGtleVJhbmdlLnVwcGVy T3BlbiBpcyBmYWxzZQotUEFTUyBrZXlSYW5nZS5sb3dlciBpcyB1bmRlZmluZWQuCitQQVNTIGtl eVJhbmdlLmxvd2VyIGlzIG51bGwKIFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVuIGlzIHRydWUKIElE QktleVJhbmdlLnVwcGVyQm91bmQoMjAuMix0cnVlKQogUEFTUyBrZXlSYW5nZS51cHBlciBpcyAy MC4yCiBQQVNTIGtleVJhbmdlLnVwcGVyT3BlbiBpcyB0cnVlCi1QQVNTIGtleVJhbmdlLmxvd2Vy IGlzIHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UubG93ZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5n ZS5sb3dlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgyMS4zLGZhbHNlKQog UEFTUyBrZXlSYW5nZS51cHBlciBpcyAyMS4zCiBQQVNTIGtleVJhbmdlLnVwcGVyT3BlbiBpcyBm YWxzZQotUEFTUyBrZXlSYW5nZS5sb3dlciBpcyB1bmRlZmluZWQuCitQQVNTIGtleVJhbmdlLmxv d2VyIGlzIG51bGwKIFBBU1Mga2V5UmFuZ2UubG93ZXJPcGVuIGlzIHRydWUKIElEQktleVJhbmdl LnVwcGVyQm91bmQoMjIuNCx1bmRlZmluZWQpCiBQQVNTIGtleVJhbmdlLnVwcGVyIGlzIDIyLjQK IFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlzIGZhbHNlCi1QQVNTIGtleVJhbmdlLmxvd2VyIGlz IHVuZGVmaW5lZC4KK1BBU1Mga2V5UmFuZ2UubG93ZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5nZS5s b3dlck9wZW4gaXMgdHJ1ZQogSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgnYmEnLHRydWUpCiBQQVNT IGtleVJhbmdlLnVwcGVyIGlzICdiYScKIFBBU1Mga2V5UmFuZ2UudXBwZXJPcGVuIGlzIHRydWUK LVBBU1Mga2V5UmFuZ2UubG93ZXIgaXMgdW5kZWZpbmVkLgorUEFTUyBrZXlSYW5nZS5sb3dlciBp cyBudWxsCiBQQVNTIGtleVJhbmdlLmxvd2VyT3BlbiBpcyB0cnVlCiBJREJLZXlSYW5nZS51cHBl ckJvdW5kKCdiYicsZmFsc2UpCiBQQVNTIGtleVJhbmdlLnVwcGVyIGlzICdiYicKIFBBU1Mga2V5 UmFuZ2UudXBwZXJPcGVuIGlzIGZhbHNlCi1QQVNTIGtleVJhbmdlLmxvd2VyIGlzIHVuZGVmaW5l ZC4KK1BBU1Mga2V5UmFuZ2UubG93ZXIgaXMgbnVsbAogUEFTUyBrZXlSYW5nZS5sb3dlck9wZW4g aXMgdHJ1ZQogSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgnYmMnLHVuZGVmaW5lZCkKIFBBU1Mga2V5 UmFuZ2UudXBwZXIgaXMgJ2JjJwogUEFTUyBrZXlSYW5nZS51cHBlck9wZW4gaXMgZmFsc2UKLVBB U1Mga2V5UmFuZ2UubG93ZXIgaXMgdW5kZWZpbmVkLgorUEFTUyBrZXlSYW5nZS5sb3dlciBpcyBu dWxsCiBQQVNTIGtleVJhbmdlLmxvd2VyT3BlbiBpcyB0cnVlCiBJREJLZXlSYW5nZS5ib3VuZCgz MCw0MCwgdW5kZWZpbmVkLCB1bmRlZmluZWQpCiBQQVNTIGtleVJhbmdlLmxvd2VyIGlzIDMwCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMva2V5cmFu Z2UuanMgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMva2V5cmFuZ2Uu anMKaW5kZXggYWYyZTNlNDFmZWVmMjkyYzUyNWFjYTFiY2ZmNjcyZjQ2ZTVmYTA4ZS4uZmQ5YjMw ZDAyYTIwYWFhZTZlZDMwY2VjYTFiMGJiYWQ5OWYwNmM2NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2tleXJhbmdlLmpzCisrKyBiL0xheW91dFRl c3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9rZXlyYW5nZS5qcwpAQCAtMjEsNyArMjEs NyBAQCBmdW5jdGlvbiBjaGVja0xvd2VyQm91bmRLZXlSYW5nZSh2YWx1ZSwgb3BlbikKICAgICBp ZiAob3BlbiA9PT0gdW5kZWZpbmVkKQogICAgICAgICBvcGVuID0gZmFsc2U7CiAgICAgc2hvdWxk QmUoImtleVJhbmdlLmxvd2VyT3BlbiIsICIiICsgb3Blbik7Ci0gICAgc2hvdWxkQmVVbmRlZmlu ZWQoImtleVJhbmdlLnVwcGVyIik7CisgICAgc2hvdWxkQmVOdWxsKCJrZXlSYW5nZS51cHBlciIp OwogICAgIHNob3VsZEJlVHJ1ZSgia2V5UmFuZ2UudXBwZXJPcGVuIik7CiB9CiAKQEAgLTMyLDcg KzMyLDcgQEAgZnVuY3Rpb24gY2hlY2tVcHBlckJvdW5kS2V5UmFuZ2UodmFsdWUsIG9wZW4pCiAg ICAgaWYgKG9wZW4gPT09IHVuZGVmaW5lZCkKICAgICAgICAgb3BlbiA9IGZhbHNlOwogICAgIHNo b3VsZEJlKCJrZXlSYW5nZS51cHBlck9wZW4iLCAiIiArIG9wZW4pOwotICAgIHNob3VsZEJlVW5k ZWZpbmVkKCJrZXlSYW5nZS5sb3dlciIpOworICAgIHNob3VsZEJlTnVsbCgia2V5UmFuZ2UubG93 ZXIiKTsKICAgICBzaG91bGRCZVRydWUoImtleVJhbmdlLmxvd2VyT3BlbiIpOwogfQogCg== 172336 2012-11-05 08:04:19 -0800 2012-11-05 08:32:34 -0800 patch for landing bug-101212-20121105170233.patch text/plain 2475 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThiOTEyNGVkZDU1ZTBk NGE0MGI4ZGJhZWE1YjE4MDFhMDc3MzMxMy4uZjc1M2UwODNjNGIyNDg0YjhlNzM1MTk2YTE0YzA5 ZmFkYmNlM2Y0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTExLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBBZGQgYSBjb21tZW50 IGFib3V0IGEgcmV0dXJuIHZhbHVlIG9mIElEQktleTo6dG9WOCgpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyMTIKKworICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIEFsdGhvdWdoIGFsbCBvdGhlciB0b1Y4KGltcGwp IHJldHVybiBudWxsIHdoZW4gaW1wbCBpcyAwLAorICAgICAgICBJREJLZXk6OnRvVjgoaW1wbCkg aXMgZXhwZWN0ZWQgdG8gcmV0dXJuIHVuZGVmaW5lZCB3aGVuIGltcGwgaXMgMC4KKyAgICAgICAg VGhpcyBwYXRjaCBhZGRzIGEgY29tbWVudCBhYm91dCBpdC4KKworICAgICAgICBObyB0ZXN0cy4K KworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSURCS2V5Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnRvSlMpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQktleUN1c3Rv bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1Y4KToKKworMjAxMi0xMS0wNSAgS2VudGFybyBI YXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW1Y4XSBEaXNwb3NlKCkgYW5k IENsZWFyKCkgc2hvdWxkIGJlIGFsd2F5cyBjb3VwbGVkIGZvciBzYWZldHkKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTE5MQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQktleUN1c3RvbS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQktleUN1c3RvbS5jcHAKaW5kZXggODVhYTVkYjlmZjc3 YTAzMjFmMTllNDMxNTU5NjQyZjNlNTQxNTQxZC4uYTY0MDYzZGJjYzBkNGRkMWZmZjdmMDM2YWFm ZjFmMmEzNWZmNGM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJ REJLZXlDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSURCS2V5 Q3VzdG9tLmNwcApAQCAtMzksOCArMzksMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBKU1Zh bHVlIHRvSlMoRXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0 LCBJREJLZXkqIGtleSkKIHsKLSAgICBpZiAoIWtleSkKKyAgICBpZiAoIWtleSkgeworICAgICAg ICAvLyBUaGlzIHNob3VsZCBiZSB1bmRlZmluZWQsIG5vdCBudWxsLgorICAgICAgICAvLyBTcGVj OiBodHRwOi8vZHZjcy53My5vcmcvaGcvSW5kZXhlZERCL3Jhdy1maWxlL3RpcC9PdmVydmlldy5o dG1sI2lkbC1kZWYtSURCS2V5UmFuZ2UKICAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7Cisg ICAgfQogCiAgICAgc3dpdGNoIChrZXktPnR5cGUoKSkgewogICAgIGNhc2UgSURCS2V5OjpBcnJh eVR5cGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJ REJLZXlDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SURC S2V5Q3VzdG9tLmNwcAppbmRleCBmYzExNmE5ODYxM2NkMWM0MDYwNzNhMzQwZDA3NjA3NDE0Yzcy NTMwLi41NjFiYzQ1Yzg1NWYxOTQxNzNmZWYzMDI1MzIzNmVmYzNlOGFiMDA2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhJREJLZXlDdXN0b20uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOElEQktleUN1c3RvbS5jcHAK QEAgLTQwLDggKzQwLDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdjg6OkhhbmRsZTx2ODo6 VmFsdWU+IHRvVjgoSURCS2V5KiBrZXksIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gY3JlYXRpb25D b250ZXh0LCB2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsKLSAgICBpZiAoIWtleSkKKyAgICBpZiAo IWtleSkgeworICAgICAgICAvLyBUaGlzIHNob3VsZCBiZSB1bmRlZmluZWQsIG5vdCBudWxsLgor ICAgICAgICAvLyBTcGVjOiBodHRwOi8vZHZjcy53My5vcmcvaGcvSW5kZXhlZERCL3Jhdy1maWxl L3RpcC9PdmVydmlldy5odG1sI2lkbC1kZWYtSURCS2V5UmFuZ2UKICAgICAgICAgcmV0dXJuIHY4 VW5kZWZpbmVkKCk7CisgICAgfQogCiAgICAgc3dpdGNoIChrZXktPnR5cGUoKSkgewogICAgIGNh c2UgSURCS2V5OjpJbnZhbGlkVHlwZToK