101203 2012-11-05 02:55:03 -0800 [EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389 2012-11-05 04:15:29 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov mrobinson rakuco tonikitoo webkit.review.bot oldest_to_newest 758380 0 cdumez 2012-11-05 02:55:03 -0800 EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after http://trac.webkit.org/changeset/133389. I will investigate to check what needs to be fixed. 758386 1 cdumez 2012-11-05 03:11:31 -0800 The difference seems to be that ResourceHandle::receivedCancellation() is now calling ResourceHandleClient::receivedCancellation(). This apparently causes us not to get a "401 Unauthorized" error for the main resource anymore. Instead of seems to get a 302 provisional load error. 758390 2 cdumez 2012-11-05 03:27:44 -0800 The GTK port calls receivedRequestToContinueWithoutCredential() by default instead of cancelling. I think the EFL port needs to do the same for the behavior to be the one we expected. 758395 3 172307 cdumez 2012-11-05 03:43:02 -0800 Created attachment 172307 Patch This fixes the API test and makes us behave like GTK port. 758415 4 172307 webkit.review.bot 2012-11-05 04:15:25 -0800 Comment on attachment 172307 Patch Clearing flags on attachment: 172307 Committed r133455: <http://trac.webkit.org/changeset/133455> 758416 5 webkit.review.bot 2012-11-05 04:15:29 -0800 All reviewed patches have been landed. Closing bug. 172307 2012-11-05 03:43:02 -0800 2012-11-05 04:15:25 -0800 Patch 101203_continueWithoutCredential.patch text/plain 4088 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NGQ1ZjI1Li5lY2FkZWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjcg QEAKIDIwMTItMTEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEVXSzJVbml0VGVzdEJhc2UuZXdrX2F1dGhfcmVx dWVzdF9jYW5jZWwgQVBJIHRlc3QgaXMgZmFpbGluZyBhZnRlciByMTMzMzg5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyMDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdHRlbXB0IGZvciBjb250aW51 ZSB3aXRob3V0IGNyZWRlbnRpYWwgd2hlbiB0aGUgY2xpZW50IGNhbmNlbHMKKyAgICAgICAgYXV0 aGVudGljYXRpb24gKG9yIGRvZXMgbm90IGhhbmRsZSB0aGUgYXV0aGVudGljYXRpb24gcmVxdWVz dCkKKyAgICAgICAgaW5zdGVhZCBvZiBjYW5jZWxsaW5nIHRoZSBsb2FkLiBXZSBub3cgZ2V0IGEg NDAyIGVycm9yIHdoZW4KKyAgICAgICAgd2hlbiBjYW5jZWxsaW5nIHRoZSBhdXRoZW50aWNhdGlv biwgd2hpY2ggaXMgdGhlIGJlaGF2aW9yIHdlCisgICAgICAgIHdhbnQgKGFuZCB0aGUgYmVoYXZp b3Igd2UgdXNlZCB0byBoYXZlIGJlZm9yZSByMTMzMzg5KS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZWZsL2V3a19hdXRoX3JlcXVlc3QuY3BwOgorICAgICAgICAoRXdrX0F1dGhfUmVxdWVz dDo6fkV3a19BdXRoX1JlcXVlc3QpOgorICAgICAgICAoRXdrX0F1dGhfUmVxdWVzdDo6Y29udGlu dWVXaXRob3V0Q3JlZGVudGlhbCk6CisgICAgICAgIChld2tfYXV0aF9yZXF1ZXN0X2NhbmNlbCk6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2F1dGhfcmVxdWVzdF9wcml2YXRlLmg6 CisgICAgICAgIChFd2tfQXV0aF9SZXF1ZXN0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy90ZXN0X2V3azJfYXV0aF9yZXF1ZXN0LmNwcDoKKyAgICAgICAgKFRFU1RfRik6CisK KzIwMTItMTEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KKwogICAgICAgICBbRUZMXVtXSzJdIFRoZSBpY29uIGRhdGFiYXNlIHBhdGggc2hvdWxkIGJl IHNldCBieSB0aGUgY2xpZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDExODIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX2F1dGhfcmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfYXV0aF9yZXF1ZXN0LmNwcAppbmRleCBjYTk5ZTJhLi40YjI5YWJhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfYXV0aF9yZXF1ZXN0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfYXV0aF9yZXF1 ZXN0LmNwcApAQCAtNDcsNyArNDcsNyBAQCBFd2tfQXV0aF9SZXF1ZXN0OjpFd2tfQXV0aF9SZXF1 ZXN0KEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlUHJveHkqIGF1dGhlbnRpY2F0aW9uQwogRXdrX0F1 dGhfUmVxdWVzdDo6fkV3a19BdXRoX1JlcXVlc3QoKQogewogICAgIGlmICghbV93YXNIYW5kbGVk KQotICAgICAgICBjYW5jZWwoKTsKKyAgICAgICAgY29udGludWVXaXRob3V0Q3JlZGVudGlhbCgp OwogfQogCiBjb25zdCBjaGFyKiBFd2tfQXV0aF9SZXF1ZXN0OjpzdWdnZXN0ZWRVc2VybmFtZSgp IGNvbnN0CkBAIC05OCwxMyArOTgsMTMgQEAgY29uc3QgY2hhciogRXdrX0F1dGhfUmVxdWVzdDo6 aG9zdCgpIGNvbnN0CiAgICAgcmV0dXJuIG1faG9zdDsKIH0KIAotYm9vbCBFd2tfQXV0aF9SZXF1 ZXN0OjpjYW5jZWwoKQorYm9vbCBFd2tfQXV0aF9SZXF1ZXN0Ojpjb250aW51ZVdpdGhvdXRDcmVk ZW50aWFsKCkKIHsKICAgICBpZiAobV93YXNIYW5kbGVkKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICBtX3dhc0hhbmRsZWQgPSB0cnVlOwotICAgIG1fYXV0aGVudGljYXRpb25DaGFsbGVu Z2UtPmNhbmNlbCgpOworICAgIG1fYXV0aGVudGljYXRpb25DaGFsbGVuZ2UtPnVzZUNyZWRlbnRp YWwoMCk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTE1Myw3ICsxNTMsNyBAQCBFaW5hX0Jv b2wgZXdrX2F1dGhfcmVxdWVzdF9jYW5jZWwoRXdrX0F1dGhfUmVxdWVzdCogcmVxdWVzdCkKIHsK ICAgICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwocmVxdWVzdCwgZmFsc2UpOwogCi0g ICAgcmV0dXJuIHJlcXVlc3QtPmNhbmNlbCgpOworICAgIHJldHVybiByZXF1ZXN0LT5jb250aW51 ZVdpdGhvdXRDcmVkZW50aWFsKCk7CiB9CiAKIEVpbmFfQm9vbCBld2tfYXV0aF9yZXF1ZXN0X2F1 dGhlbnRpY2F0ZShFd2tfQXV0aF9SZXF1ZXN0KiByZXF1ZXN0LCBjb25zdCBjaGFyKiB1c2VybmFt ZSwgY29uc3QgY2hhciogcGFzc3dvcmQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfYXV0aF9yZXF1ZXN0X3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19hdXRoX3JlcXVlc3RfcHJpdmF0ZS5oCmluZGV4IGExYmIy ODUuLjM4NDNhZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a19hdXRoX3JlcXVlc3RfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19hdXRoX3JlcXVlc3RfcHJpdmF0ZS5oCkBAIC00OCw3ICs0OCw3IEBAIHB1 YmxpYzoKICAgICBjb25zdCBjaGFyKiBob3N0KCkgY29uc3Q7CiAgICAgYm9vbCBpc1JldHJ5aW5n KCkgY29uc3Q7CiAKLSAgICBib29sIGNhbmNlbCgpOworICAgIGJvb2wgY29udGludWVXaXRob3V0 Q3JlZGVudGlhbCgpOwogICAgIGJvb2wgYXV0aGVudGljYXRlKGNvbnN0IFN0cmluZyYgdXNlcm5h bWUsIGNvbnN0IFN0cmluZyYgcGFzc3dvcmQpOwogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2F1dGhfcmVxdWVz dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJf YXV0aF9yZXF1ZXN0LmNwcAppbmRleCBlNGIyNjg3Li5jZGZhZTdiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfYXV0aF9yZXF1ZXN0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3 azJfYXV0aF9yZXF1ZXN0LmNwcApAQCAtMTg1LDEyICsxODUsMTMgQEAgVEVTVF9GKEVXSzJVbml0 VGVzdEJhc2UsIGV3a19hdXRoX3JlcXVlc3RfY2FuY2VsKQogICAgIGludCBzdGF0dXNDb2RlID0g MDsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2ViVmlldygpLCAicmVzb3Vy Y2UscmVxdWVzdCxyZXNwb25zZSIsIG9uUmVzb3VyY2VMb2FkUmVzcG9uc2UsICZzdGF0dXNDb2Rl KTsKIAotICAgIC8vIENhbmNlbHMgYXV0aGVudGljYXRpb24gYnkgZGVmYXVsdC4KKyAgICAvLyBX aWxsIGF0dGVtcHQgdG8gY29udGludWUgd2l0aG91dCBhdXRoZW50aWNhdGlvbiBieSBkZWZhdWx0 LgogICAgIGV3a19hdXRoX3JlcXVlc3RfdW5yZWYoYXV0aGVudGljYXRpb25SZXF1ZXN0KTsKIAog ICAgIHdoaWxlICghc3RhdHVzQ29kZSkKICAgICAgICAgZWNvcmVfbWFpbl9sb29wX2l0ZXJhdGUo KTsKIAorICAgIC8vIFdlIHNob3VsZCBnZXQgYSAiNDAyIFVuYXV0aG9yaXplZCIgZXJyb3IuCiAg ICAgRVhQRUNUX0VRKFNPVVBfU1RBVFVTX1VOQVVUSE9SSVpFRCwgc3RhdHVzQ29kZSk7CiAKICAg ICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19kZWwod2ViVmlldygpLCAicmVzb3VyY2UscmVx dWVzdCxyZXNwb25zZSIsIG9uUmVzb3VyY2VMb2FkUmVzcG9uc2UpOwo=