101199 2012-11-05 02:35:43 -0800 Disable registerProtocolHandler on Android 2012-11-05 06:28:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Android Unspecified RESOLVED FIXED P2 Normal --- 1 miguelg webkit-unassigned abarth jchaffraix miguelg peter webkit.review.bot oldest_to_newest 758366 0 miguelg 2012-11-05 02:35:43 -0800 Disable registerProtocolHandler on Android 758367 1 172300 miguelg 2012-11-05 02:36:48 -0800 Created attachment 172300 Patch 758378 2 172300 peter 2012-11-05 02:49:10 -0800 Comment on attachment 172300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172300&action=review Thanks for the patch, Miguel! Please find two nits in-line. You may also want to consider requesting commit-queue, which is useful as you're not a committer yet yourself. You can do this in the patch' Details section, or by supplying the "--request-commit" argument to webkit-patch upload. > Source/WebKit/chromium/ChangeLog:3 > + Disable registerProtocolHandler on Android Since this patch only touches Chromium-specific code, it's best to prefix the bug title with "[Chromium]", especially since there is no more Android port in WebKit. > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Any line with "(OOPS!)" will make presubmit unhappy. The only exception here is the "Reviewed by NOBODY (OOPS!)" line, which will be filled in automatically by the tools. In this case, it's important for the reviewer and other members of the Chromium project to understand why registerProtocolHandler is being disabled for Android. A bit of rationale can help here, so something like the following text would be clearer: "Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't actually wired up internally. Disable the feature to avoid breaking feature detection until we can implement it properly." 758382 3 172304 miguelg 2012-11-05 02:56:12 -0800 Created attachment 172304 Patch 758383 4 miguelg 2012-11-05 02:57:36 -0800 (In reply to comment #3) > Created an attachment (id=172304) [details] > Patch Thanks for the comments Peter! Uploaded a new patch with your suggestions 758431 5 172304 jchaffraix 2012-11-05 04:56:29 -0800 Comment on attachment 172304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172304&action=review LGTM, Adam is usually your man for such changes but it is simple enough. > Source/WebKit/chromium/ChangeLog:8 > + Disalble registerProtocolHandler since it is not properly implemented (yet) and could confuse developers trying to use it in android. Typo: disalble. Also let's be precise! Peter's phrasing was more accurate from this perspective as it mentioned that it is a platform issue (reading your wording I thought it was an issue in the feature). 758440 6 172317 miguelg 2012-11-05 05:24:03 -0800 Created attachment 172317 Patch 758443 7 miguelg 2012-11-05 05:25:30 -0800 Thanks for the quick review! Changed to use Peter's wording instead. (In reply to comment #6) > Created an attachment (id=172317) [details] > Patch 758456 8 172322 miguelg 2012-11-05 05:46:32 -0800 Created attachment 172322 Patch 758458 9 172322 peter 2012-11-05 05:48:32 -0800 Comment on attachment 172322 Patch Thank you Miguel! Setting cq+. 758483 10 172322 webkit.review.bot 2012-11-05 06:28:17 -0800 Comment on attachment 172322 Patch Clearing flags on attachment: 172322 Committed r133465: <http://trac.webkit.org/changeset/133465> 758484 11 webkit.review.bot 2012-11-05 06:28:22 -0800 All reviewed patches have been landed. Closing bug. 172300 2012-11-05 02:36:48 -0800 2012-11-05 02:56:08 -0800 Patch bug-101199-20121105103502.patch text/plain 1391 miguelg U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4NzY2NDhjYWE2ZjM1MzQ2ZGU1YzE5ZWJkNmZjMjc4Y2E4NTA0MmMuLjI1ZDc5MWRlZWUyMjAz MjA4NzY2Zjc5YWZkOTY2NzAzNGM2YzE3MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMDUgIE1pZ3VlbCBHYXJjaWEgIDxtaWd1ZWxnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBEaXNhYmxlIHJlZ2lzdGVyUHJvdG9jb2xIYW5kbGVyIG9uIEFu ZHJvaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MTE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRp b25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEp LgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0xMS0wMSAgQWxlYyBGbGV0dCAg PGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBhZGQgbWV0aG9k cyB0byBzdXBwb3J0IGlkLWJhc2VkIGJhY2tlbmQgQVBJcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0 dXJlcy5neXBpCmluZGV4IGYzZTEwYjI3OWEwZTk5ZjI4YzljZTBmZGJmY2ZhNDRlOWRkZjVjZGMu Ljg3ZTk4NDZmNGQzOTJjMjdiODA4NDJhZTc2MTkxNjI0MWJjZmEwYmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL2ZlYXR1cmVzLmd5cGkKQEAgLTE2Niw2ICsxNjYsNyBAQAogICAgICAgICAgICdFTkFC TEVfT1JJRU5UQVRJT05fRVZFTlRTPTEnLAogICAgICAgICAgICdFTkFCTEVfUEFHRV9QT1BVUD0w JywKICAgICAgICAgICAnRU5BQkxFX1BSSU5USU5HPTAnLAorICAgICAgICAgICdFTkFCTEVfUkVH SVNURVJfUFJPVE9DT0xfSEFORExFUj0wJywKICAgICAgICAgICAjIEZJWE1FOiBEaXNhYmxlIG9u Y2UgdGhlIGxpbmtpbmcgZXJyb3IgaGFzIGJlZW4gcmVzb2x2ZWQuCiAgICAgICAgICAgIyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg2MzYKICAgICAgICAgICAnRU5B QkxFX1NIQVJFRF9XT1JLRVJTPTEnLAo= 172304 2012-11-05 02:56:12 -0800 2012-11-05 05:23:59 -0800 Patch bug-101199-20121105105426.patch text/plain 1418 miguelg U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4NzY2NDhjYWE2ZjM1MzQ2ZGU1YzE5ZWJkNmZjMjc4Y2E4NTA0MmMuLmM4YTU1YTE3ZWJiMWFh MTlkMTNiNDk5OWExNTRmYjA4MGRmZWQ3MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMDUgIE1pZ3VlbCBHYXJjaWEgIDxtaWd1ZWxnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIERpc2FibGUgcmVnaXN0ZXJQcm90b2NvbEhh bmRsZXIgb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRGlzYWxibGUgcmVnaXN0ZXJQcm90b2NvbEhhbmRsZXIgc2luY2UgaXQgaXMgbm90 IHByb3Blcmx5IGltcGxlbWVudGVkICh5ZXQpIGFuZCBjb3VsZCBjb25mdXNlIGRldmVsb3BlcnMg dHJ5aW5nIHRvIHVzZSBpdCBpbiBhbmRyb2lkLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lwaToK KwogMjAxMi0xMS0wMSAgQWxlYyBGbGV0dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgSW5kZXhlZERCOiBhZGQgbWV0aG9kcyB0byBzdXBwb3J0IGlkLWJhc2VkIGJhY2tlbmQg QVBJcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IGYzZTEwYjI3OWEwZTk5 ZjI4YzljZTBmZGJmY2ZhNDRlOWRkZjVjZGMuLjg3ZTk4NDZmNGQzOTJjMjdiODA4NDJhZTc2MTkx NjI0MWJjZmEwYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMu Z3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKQEAgLTE2Niw2 ICsxNjYsNyBAQAogICAgICAgICAgICdFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEnLAogICAg ICAgICAgICdFTkFCTEVfUEFHRV9QT1BVUD0wJywKICAgICAgICAgICAnRU5BQkxFX1BSSU5USU5H PTAnLAorICAgICAgICAgICdFTkFCTEVfUkVHSVNURVJfUFJPVE9DT0xfSEFORExFUj0wJywKICAg ICAgICAgICAjIEZJWE1FOiBEaXNhYmxlIG9uY2UgdGhlIGxpbmtpbmcgZXJyb3IgaGFzIGJlZW4g cmVzb2x2ZWQuCiAgICAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODg2MzYKICAgICAgICAgICAnRU5BQkxFX1NIQVJFRF9XT1JLRVJTPTEnLAo= 172317 2012-11-05 05:24:03 -0800 2012-11-05 05:46:27 -0800 Patch bug-101199-20121105132218.patch text/plain 1493 miguelg U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4NzY2NDhjYWE2ZjM1MzQ2ZGU1YzE5ZWJkNmZjMjc4Y2E4NTA0MmMuLjY1ZWRjMDQyNjhmNDlm MTgzMDQ1ZmY2MTcxNWI3YTE1YjA2MTVjYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMDUgIE1pZ3VlbCBHYXJjaWEgIDxtaWd1ZWxnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIERpc2FibGUgcmVnaXN0ZXJQcm90b2NvbEhh bmRsZXIgb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hyb21pdW0gZm9yIEFuZHJvaWQgaGFzIGJlZW4gZXhwb3NpbmcgcmVnaXN0ZXJQ cm90b2NvbEhhbmRsZXIsIGJ1dCB0aGUgZmVhdHVyZSB3YXNuJ3QgYWN0dWFsbHkgd2lyZWQgdXAg aW50ZXJuYWxseS4gRGlzYWJsZSB0aGUgZmVhdHVyZSB0byBhdm9pZCBicmVha2luZyBmZWF0dXJl IGRldGVjdGlvbiB1bnRpbCB3ZSBjYW4gaW1wbGVtZW50IGl0IHByb3Blcmx5LgorCisgICAgICAg ICogZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0xMS0wMSAgQWxlYyBGbGV0dCAgPGFsZWNmbGV0dEBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBhZGQgbWV0aG9kcyB0byBzdXBwb3J0 IGlkLWJhc2VkIGJhY2tlbmQgQVBJcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmlu ZGV4IGYzZTEwYjI3OWEwZTk5ZjI4YzljZTBmZGJmY2ZhNDRlOWRkZjVjZGMuLjg3ZTk4NDZmNGQz OTJjMjdiODA4NDJhZTc2MTkxNjI0MWJjZmEwYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1 cmVzLmd5cGkKQEAgLTE2Niw2ICsxNjYsNyBAQAogICAgICAgICAgICdFTkFCTEVfT1JJRU5UQVRJ T05fRVZFTlRTPTEnLAogICAgICAgICAgICdFTkFCTEVfUEFHRV9QT1BVUD0wJywKICAgICAgICAg ICAnRU5BQkxFX1BSSU5USU5HPTAnLAorICAgICAgICAgICdFTkFCTEVfUkVHSVNURVJfUFJPVE9D T0xfSEFORExFUj0wJywKICAgICAgICAgICAjIEZJWE1FOiBEaXNhYmxlIG9uY2UgdGhlIGxpbmtp bmcgZXJyb3IgaGFzIGJlZW4gcmVzb2x2ZWQuCiAgICAgICAgICAgIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg2MzYKICAgICAgICAgICAnRU5BQkxFX1NIQVJFRF9X T1JLRVJTPTEnLAo= 172322 2012-11-05 05:46:32 -0800 2012-11-05 06:28:17 -0800 Patch bug-101199-20121105134446.patch text/plain 1513 miguelg U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGY4NzY2NDhjYWE2ZjM1MzQ2ZGU1YzE5ZWJkNmZjMjc4Y2E4NTA0MmMuLmIyMWVjY2YxNjE5ZWRl YzhhNGM3NjlkMzVmMjhjNDJiOTQ0NjM5ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMDUgIE1pZ3VlbCBHYXJjaWEgIDxtaWd1ZWxnQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIERpc2FibGUgcmVnaXN0ZXJQcm90b2NvbEhh bmRsZXIgb24gQW5kcm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSnVsaWVuIENoYWZmcmFpeC4K KworICAgICAgICBDaHJvbWl1bSBmb3IgQW5kcm9pZCBoYXMgYmVlbiBleHBvc2luZyByZWdpc3Rl clByb3RvY29sSGFuZGxlciwgYnV0IHRoZSBmZWF0dXJlIHdhc24ndAorICAgICAgICBhY3R1YWxs eSB3aXJlZCB1cCBpbnRlcm5hbGx5LiBEaXNhYmxlIHRoZSBmZWF0dXJlIHRvIGF2b2lkIGJyZWFr aW5nIGZlYXR1cmUgZGV0ZWN0aW9uCisgICAgICAgIHVudGlsIHdlIGNhbiBpbXBsZW1lbnQgaXQg cHJvcGVybHkuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDEyLTExLTAxICBBbGVj IEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IGFk ZCBtZXRob2RzIHRvIHN1cHBvcnQgaWQtYmFzZWQgYmFja2VuZCBBUElzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggZjNlMTBiMjc5YTBlOTlmMjhjOWNlMGZkYmZjZmE0NGU5 ZGRmNWNkYy4uODdlOTg0NmY0ZDM5MmMyN2I4MDg0MmFlNzYxOTE2MjQxYmNmYTBiZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAtMTY2LDYgKzE2Niw3IEBACiAgICAgICAg ICAgJ0VOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9QQUdF X1BPUFVQPTAnLAogICAgICAgICAgICdFTkFCTEVfUFJJTlRJTkc9MCcsCisgICAgICAgICAgJ0VO QUJMRV9SRUdJU1RFUl9QUk9UT0NPTF9IQU5ETEVSPTAnLAogICAgICAgICAgICMgRklYTUU6IERp c2FibGUgb25jZSB0aGUgbGlua2luZyBlcnJvciBoYXMgYmVlbiByZXNvbHZlZC4KICAgICAgICAg ICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODYzNgogICAgICAg ICAgICdFTkFCTEVfU0hBUkVEX1dPUktFUlM9MScsCg==