101197 2012-11-05 02:13:29 -0800 [EFL] Fix build warning in EWebLauncher/main.c 2012-11-05 02:57:45 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim gyuyoung.kim haraken lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 758351 0 ktf.kim 2012-11-05 02:13:29 -0800 For fixing the follow build warnings : /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:941:9: warning: initialization from incompatible pointer type [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:941:9: warning: (near initialization for ‘values[0].strp’) [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:943:9: warning: initialization from incompatible pointer type [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:943:9: warning: (near initialization for ‘values[2].strp’) [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:948:9: warning: initialization from incompatible pointer type [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:948:9: warning: (near initialization for ‘values[7].strp’) [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:949:9: warning: initialization from incompatible pointer type [enabled by default] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release/build/Tools/EWebLauncher/main.c:949:9: warning: (near initialization for ‘values[8].strp’) [enabled by default] The destination for ECORE_GETOPT_VALUE_STR is char**, but the source is &(const char*). One of them need to be fixed. //Ecore_Getopt.h union _Ecore_Getopt_Value { char **strp; .. }; 758357 1 172298 ktf.kim 2012-11-05 02:18:59 -0800 Created attachment 172298 Patch 758360 2 172298 haraken 2012-11-05 02:24:55 -0800 Comment on attachment 172298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review > Tools/EWebLauncher/main.c:146 > + char *engine; According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables. 758361 3 172298 gyuyoung.kim 2012-11-05 02:28:20 -0800 Comment on attachment 172298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review >> Tools/EWebLauncher/main.c:146 >> + char *engine; > > According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables. Kentaro, this is EFL simple application. So, we follow EFL coding style for EWebLauncher. 758363 4 172298 haraken 2012-11-05 02:29:43 -0800 Comment on attachment 172298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review >>> Tools/EWebLauncher/main.c:146 >>> + char *engine; >> >> According to the WebKit coding style, this should be 'char* engine' instead of 'char *engine'. Same comments for the following variables. > > Kentaro, this is EFL simple application. So, we follow EFL coding style for EWebLauncher. Makes sense. Thanks for the clarification. 758384 5 172298 webkit.review.bot 2012-11-05 02:57:41 -0800 Comment on attachment 172298 Patch Clearing flags on attachment: 172298 Committed r133452: <http://trac.webkit.org/changeset/133452> 758385 6 webkit.review.bot 2012-11-05 02:57:45 -0800 All reviewed patches have been landed. Closing bug. 172298 2012-11-05 02:18:59 -0800 2012-11-05 02:57:41 -0800 Patch bug-101197-20121105191715.patch text/plain 1554 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjBkNmU0NGYwMWU1ZjkzZjM1NDBmNzZhZDFkZThjNDg4 NWY3ODVhYi4uMzcwNWE2NDViNTY1MTE2YjkzZjY1ZjVkMGYzM2ZkZmFiNTVjODE0MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTExLTA1ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIEZpeCBidWlsZCB3YXJuaW5nIGluIEVXZWJMYXVuY2hlci9tYWluLmMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTE5NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlY2F1c2UgdGhl IHN0cnAgb2YgX0Vjb3JlX0dldG9wdF9WYWx1ZSBpcyBjaGFyKiogKEVjb3JlX0dldG9wdC5oKSwK KyAgICAgICAgVGhlIHBhcmFtZXRlciBvZiBFQ09SRV9HRVRPUFRfVkFMVUVfU1RSIHNob3VsZCBi ZSBjaGFyKgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoKKyAgICAgICAgKF9Vc2Vy X0FyZ3VtZW50cyk6CisKIDIwMTItMTEtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFRoZSBpY29uIGRhdGFiYXNl IHBhdGggc2hvdWxkIGJlIHNldCBieSB0aGUgY2xpZW50CmRpZmYgLS1naXQgYS9Ub29scy9FV2Vi TGF1bmNoZXIvbWFpbi5jIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwppbmRleCA4MTU4YTgx NjU3OTE3MTlkZjExZTIzYWZhMmQ3NTlmNzQ0N2MzMGZmLi45MGNhYzEyMmJjZmZkMDA5NzEyMGVh N2NjZjYxMGFlYTgwM2VmOThhIDEwMDY0NAotLS0gYS9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5j CisrKyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKQEAgLTE0MywxNiArMTQzLDE2IEBAIHN0 YXRpYyBjb25zdCBFY29yZV9HZXRvcHQgb3B0aW9ucyA9IHsKIH07CiAKIHR5cGVkZWYgc3RydWN0 IF9Vc2VyX0FyZ3VtZW50cyB7Ci0gICAgY29uc3QgY2hhciAqZW5naW5lOworICAgIGNoYXIgKmVu Z2luZTsKICAgICBFaW5hX0Jvb2wgcXVpdE9wdGlvbjsKLSAgICBjb25zdCBjaGFyICpiYWNraW5n U3RvcmU7CisgICAgY2hhciAqYmFja2luZ1N0b3JlOwogICAgIEVpbmFfQm9vbCBlbmFibGVFbmNv ZGluZ0RldGVjdG9yOwogICAgIEVpbmFfQm9vbCBpc0ZsYXR0ZW5pbmc7CiAgICAgRWluYV9Cb29s IGlzRnVsbHNjcmVlbjsKICAgICBFaW5hX1JlY3RhbmdsZSBnZW9tZXRyeTsKLSAgICBjb25zdCBj aGFyICp0aGVtZTsKLSAgICBjb25zdCBjaGFyICp1c2VyQWdlbnQ7Ci0gICAgY29uc3QgY2hhciAq ZGF0YWJhc2VQYXRoOworICAgIGNoYXIgKnRoZW1lOworICAgIGNoYXIgKnVzZXJBZ2VudDsKKyAg ICBjaGFyICpkYXRhYmFzZVBhdGg7CiB9IFVzZXJfQXJndW1lbnRzOwogCiB0eXBlZGVmIHN0cnVj dCBfRUxhdW5jaGVyIHsK