101178 2012-11-04 21:37:51 -0800 [Shadow] ShadowRoot should have a method to return ShadowRootType 2012-11-04 23:30:25 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101170 1 shinyak shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 758228 0 shinyak 2012-11-04 21:37:51 -0800 We would like to reject using pseudo id starting '-webkit-' in AuthorShadowRoot. However, we have to accept it in UA ShadowRoot. So we have to know ShadowRootType now. 758244 1 172272 shinyak 2012-11-04 23:04:31 -0800 Created attachment 172272 Patch 758256 2 172272 morrita 2012-11-04 23:15:40 -0800 Comment on attachment 172272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review > Source/WebCore/dom/ShadowRoot.h:119 > + ShadowRootType m_type : 1; Is it possible to ensure that ShadowRootType can be fit into a bit? Is STATIC_ASSERT or something helpful here? 758261 3 172272 shinyak 2012-11-04 23:22:20 -0800 Comment on attachment 172272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review >> Source/WebCore/dom/ShadowRoot.h:119 >> + ShadowRootType m_type : 1; > > Is it possible to ensure that ShadowRootType can be fit into a bit? > Is STATIC_ASSERT or something helpful here? I've tried adding extra enum item into ShadowRootType, then gcc complained that m_type field is too small. So I don't think we have to do something special here. 758265 4 172272 webkit.review.bot 2012-11-04 23:30:22 -0800 Comment on attachment 172272 Patch Clearing flags on attachment: 172272 Committed r133435: <http://trac.webkit.org/changeset/133435> 758266 5 webkit.review.bot 2012-11-04 23:30:25 -0800 All reviewed patches have been landed. Closing bug. 172272 2012-11-04 23:04:31 -0800 2012-11-04 23:30:22 -0800 Patch bug-101178-20121105160246.patch text/plain 1851 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQxMTFjNzdkNzkwYzVi NDYyYmYzNmRhMDdjN2M2MDUxOGFkZDU4OS4uMzAzNTY3Njg0ZTEyZjM0YWRiOGNmZWNmYzA5NmVi NTU4NGI2MjczOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA0ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbU2hhZG93XSBT aGFkb3dSb290IHNob3VsZCBoYXZlIGEgbWV0aG9kIHRvIHJldHVybiBTaGFkb3dSb290VHlwZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTE3OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gd2Ug c3R5bGUgUHNldWRvQ3VzdG9tRWxlbWVudCwgd2UgaGF2ZSB0byBrbm93IFNoYWRvd1Jvb3RUeXBl LgorICAgICAgICBXZSB3b3VsZCBsaWtlIHRvIGV4cG9zZSBhIG1ldGhvZCB0byBnZXQgU2hhZG93 Um9vdFR5cGUgYWxzbyBpbiBSZWxlYXNlIG1vZGUuCisKKyAgICAgICAgVGhpcyBpcyBhIHByZXBh cmF0aW9uIHBhdGNoIGZvciBCdWcgMTAxMTcwLgorCisgICAgICAgICogZG9tL1NoYWRvd1Jvb3Qu aDoKKyAgICAgICAgKFNoYWRvd1Jvb3QpOgorCiAyMDEyLTExLTA0ICBNT1JJVEEgSGFqaW1lICA8 bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFNoYWRvdyBET00gc2hvdWxkIGJlIGFibGUg dG8gYmUgZGlzYWJsZWQgcGVyIGNvbnRleHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vU2hhZG93Um9vdC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1NoYWRvd1Jvb3QuaAppbmRleCAy MDQ1MmYzYTk1MTIyNmRkNmRjMWU0YWUwMTUxYTRlZjc2OGMzNjEzLi4yYWE1NzczOWI1NDcxNzhk YmQ1NzAyNjMzNjhkNTZhOTFlMTAwNzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v U2hhZG93Um9vdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TaGFkb3dSb290LmgKQEAgLTk4 LDkgKzk4LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZWdpc3RlclNjb3BlZEhUTUxT dHlsZUNoaWxkKCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHVucmVnaXN0ZXJTY29wZWRI VE1MU3R5bGVDaGlsZCgpIE9WRVJSSURFOwogCi0jaWZuZGVmIE5ERUJVRwogICAgIFNoYWRvd1Jv b3RUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVybiBtX3R5cGU7IH0KLSNlbmRpZgogCiAgICAgUGFz c1JlZlB0cjxOb2RlPiBjbG9uZU5vZGUoYm9vbCwgRXhjZXB0aW9uQ29kZSYpOwogCkBAIC0xMTgs MTQgKzExNiwxMSBAQCBwcml2YXRlOgogICAgIFNoYWRvd1Jvb3QqIG1fbmV4dDsKICAgICBib29s IG1fYXBwbHlBdXRob3JTdHlsZXMgOiAxOwogICAgIGJvb2wgbV9yZXNldFN0eWxlSW5oZXJpdGFu Y2UgOiAxOworICAgIFNoYWRvd1Jvb3RUeXBlIG1fdHlwZSA6IDE7CiAgICAgSW5zZXJ0aW9uUG9p bnQqIG1faW5zZXJ0aW9uUG9pbnRBc3NpZ25lZFRvOwogICAgIHNpemVfdCBtX251bWJlck9mU2hh ZG93RWxlbWVudENoaWxkcmVuOwogICAgIHNpemVfdCBtX251bWJlck9mQ29udGVudEVsZW1lbnRD aGlsZHJlbjsKICAgICBzaXplX3QgbV9udW1iZXJPZlN0eWxlczsKLQotI2lmbmRlZiBOREVCVUcK LSAgICBTaGFkb3dSb290VHlwZSBtX3R5cGU7Ci0jZW5kaWYKIH07CiAKIGlubGluZSBFbGVtZW50 KiBTaGFkb3dSb290Ojpob3N0KCkgY29uc3QK