101124 2012-11-02 16:25:34 -0700 LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool 2012-11-02 16:31:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 89235 1 eric glenn glenn seikwon.kim oldest_to_newest 757737 0 eric 2012-11-02 16:25:34 -0700 LineBreakIteratorPoolICU should use a class or std::pair instead of a String as the hash-key for the pool bug 89235 introduces a somewhat odd system of encoding the loose/strict breaking variant as part of the locale string which is used by the pool as a key. It would be cleaner to have ICU-agnostic logic to parse out the locale and break variant and then pass them around as class instead of encoded in the string. I believe this would require either defining a HashTraits for the new class, or using std::pair<AtomicString, LineBreakIteratorMode> which I believe already has generic HashTraits to do the right thing. :)