101107 2012-11-02 14:59:43 -0700 Improve CSSParser::setupParser() since the prefix/suffix are literals 2012-11-02 20:32:50 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo macpherson menard webkit.review.bot oldest_to_newest 757638 0 benjamin 2012-11-02 14:59:43 -0700 Stop using strlen all over the place. 757648 1 172152 benjamin 2012-11-02 15:08:01 -0700 Created attachment 172152 Patch 757870 2 172152 benjamin 2012-11-02 20:32:48 -0700 Comment on attachment 172152 Patch Clearing flags on attachment: 172152 Committed r133387: <http://trac.webkit.org/changeset/133387> 757871 3 benjamin 2012-11-02 20:32:50 -0700 All reviewed patches have been landed. Closing bug. 172152 2012-11-02 15:08:01 -0700 2012-11-02 20:32:48 -0700 Patch bug-101107-20121102150620.patch text/plain 4516 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVjNDM4MjUzMGRmMDZi MGMzZTc0M2IxZTBhODBmZThkNGVhODVmMC4uNzczOTk3ZWMxNDhhYzFiZDRjMTI1MTdmNTI5MmRm Y2YwZDBhYmZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTAyICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgQ1NT UGFyc2VyOjpzZXR1cFBhcnNlcigpIHNpbmNlIHRoZSBwcmVmaXgvc3VmZml4IGFyZSBsaXRlcmFs cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMTA3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3Mv Q1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6c2V0dXBQYXJzZXIp OgorICAgICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKyAgICAgICAgKENTU1BhcnNlcik6CisgICAg ICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnNldHVwUGFyc2VyKToKKyAgICAgICAgQ1NTUGFyc2Vy OjpzZXR1cFBhcnNlcigpIGlzIG9ubHkgdXNlZCB3aXRoIGxpdGVyYWxzIHByZWZpeCBhbmQgc3Vm Zml4LiBXZSBkbyBub3QgaGF2ZQorICAgICAgICB0byBjb21wdXRlIHRoZSBsZW5ndGggYXQgcnVu dGltZSwgd2UgY2FuIGRpcmVjbHR5IGVuY29kZSBpdCBpbiB0aGUgYmluYXJ5LgorCiAyMDEyLTEx LTAxICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzMyNDQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CmluZGV4IGRlYjNlMmM3YTFiZjhjMzUzNTc5NmJiY2I3NmIxOWJiN2FiODM0M2EuLjVhMjlkMmZh MjYyYzlkYzA0YWNjMmZmY2QzYzk1OTUzYTQwN2UwNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCkBAIC0zMzgsMTEgKzMzOCwxMiBAQCBBdG9taWNTdHJpbmcgQ1NTUGFyc2VyU3RyaW5nOjps b3dlclN1YnN0cmluZyh1bnNpZ25lZCBwb3NpdGlvbiwgdW5zaWduZWQgbGVuZ3RoKQogICAgIHJl dHVybiBBdG9taWNTdHJpbmcocmVzdWx0KTsKIH0KIAotdm9pZCBDU1NQYXJzZXI6OnNldHVwUGFy c2VyKGNvbnN0IGNoYXIqIHByZWZpeCwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIGNvbnN0IGNoYXIq IHN1ZmZpeCkKK3ZvaWQgQ1NTUGFyc2VyOjpzZXR1cFBhcnNlcihjb25zdCBjaGFyKiBwcmVmaXgs IHVuc2lnbmVkIHByZWZpeExlbmd0aCwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIGNvbnN0IGNoYXIq IHN1ZmZpeCwgdW5zaWduZWQgc3VmZml4TGVuZ3RoKQogewotICAgIG1fcGFyc2VkVGV4dFByZWZp eExlbmd0aCA9IHN0cmxlbihwcmVmaXgpOworICAgIG1fcGFyc2VkVGV4dFByZWZpeExlbmd0aCA9 IHByZWZpeExlbmd0aDsKICAgICB1bnNpZ25lZCBzdHJpbmdMZW5ndGggPSBzdHJpbmcubGVuZ3Ro KCk7Ci0gICAgdW5zaWduZWQgbGVuZ3RoID0gc3RyaW5nTGVuZ3RoICsgbV9wYXJzZWRUZXh0UHJl Zml4TGVuZ3RoICsgc3RybGVuKHN1ZmZpeCkgKyAxOworICAgIHVuc2lnbmVkIGxlbmd0aCA9IHN0 cmluZ0xlbmd0aCArIG1fcGFyc2VkVGV4dFByZWZpeExlbmd0aCArIHN1ZmZpeExlbmd0aCArIDE7 CisgICAgbV9sZW5ndGggPSBsZW5ndGg7CiAKICAgICBpZiAoIXN0cmluZ0xlbmd0aCB8fCBzdHJp bmcuaXM4Qml0KCkpIHsKICAgICAgICAgbV9kYXRhU3RhcnQ4ID0gYWRvcHRBcnJheVB0cihuZXcg TENoYXJbbGVuZ3RoXSk7CkBAIC0zNTMsNyArMzU0LDcgQEAgdm9pZCBDU1NQYXJzZXI6OnNldHVw UGFyc2VyKGNvbnN0IGNoYXIqIHByZWZpeCwgY29uc3QgU3RyaW5nJiBzdHJpbmcsIGNvbnN0IGNo YXIKICAgICAgICAgICAgIG1lbWNweShtX2RhdGFTdGFydDguZ2V0KCkgKyBtX3BhcnNlZFRleHRQ cmVmaXhMZW5ndGgsIHN0cmluZy5jaGFyYWN0ZXJzOCgpLCBzdHJpbmdMZW5ndGggKiBzaXplb2Yo TENoYXIpKTsKIAogICAgICAgICB1bnNpZ25lZCBzdGFydCA9IG1fcGFyc2VkVGV4dFByZWZpeExl bmd0aCArIHN0cmluZ0xlbmd0aDsKLSAgICAgICAgdW5zaWduZWQgZW5kID0gc3RhcnQgKyBzdHJs ZW4oc3VmZml4KTsKKyAgICAgICAgdW5zaWduZWQgZW5kID0gc3RhcnQgKyBzdWZmaXhMZW5ndGg7 CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IHN0YXJ0OyBpIDwgZW5kOyBpKyspCiAgICAgICAg ICAgICBtX2RhdGFTdGFydDhbaV0gPSBzdWZmaXhbaSAtIHN0YXJ0XTsKIApAQCAtMzYzLDcgKzM2 NCw2IEBAIHZvaWQgQ1NTUGFyc2VyOjpzZXR1cFBhcnNlcihjb25zdCBjaGFyKiBwcmVmaXgsIGNv bnN0IFN0cmluZyYgc3RyaW5nLCBjb25zdCBjaGFyCiAgICAgICAgIG1fY3VycmVudENoYXJhY3Rl cjggPSBtX2RhdGFTdGFydDguZ2V0KCk7CiAgICAgICAgIG1fY3VycmVudENoYXJhY3RlcjE2ID0g MDsKICAgICAgICAgc2V0VG9rZW5TdGFydDxMQ2hhcj4obV9jdXJyZW50Q2hhcmFjdGVyOCk7Ci0g ICAgICAgIG1fbGVuZ3RoID0gbGVuZ3RoOwogICAgICAgICBtX2xleEZ1bmMgPSAmQ1NTUGFyc2Vy OjpyZWFsTGV4PExDaGFyPjsKICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTM3NSw3ICszNzUs NyBAQCB2b2lkIENTU1BhcnNlcjo6c2V0dXBQYXJzZXIoY29uc3QgY2hhciogcHJlZml4LCBjb25z dCBTdHJpbmcmIHN0cmluZywgY29uc3QgY2hhcgogICAgIG1lbWNweShtX2RhdGFTdGFydDE2Lmdl dCgpICsgbV9wYXJzZWRUZXh0UHJlZml4TGVuZ3RoLCBzdHJpbmcuY2hhcmFjdGVycygpLCBzdHJp bmdMZW5ndGggKiBzaXplb2YoVUNoYXIpKTsKIAogICAgIHVuc2lnbmVkIHN0YXJ0ID0gbV9wYXJz ZWRUZXh0UHJlZml4TGVuZ3RoICsgc3RyaW5nTGVuZ3RoOwotICAgIHVuc2lnbmVkIGVuZCA9IHN0 YXJ0ICsgc3RybGVuKHN1ZmZpeCk7CisgICAgdW5zaWduZWQgZW5kID0gc3RhcnQgKyBzdWZmaXhM ZW5ndGg7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gc3RhcnQ7IGkgPCBlbmQ7IGkrKykKICAgICAg ICAgbV9kYXRhU3RhcnQxNltpXSA9IHN1ZmZpeFtpIC0gc3RhcnRdOwogCkBAIC0zODUsNyArMzg1 LDYgQEAgdm9pZCBDU1NQYXJzZXI6OnNldHVwUGFyc2VyKGNvbnN0IGNoYXIqIHByZWZpeCwgY29u c3QgU3RyaW5nJiBzdHJpbmcsIGNvbnN0IGNoYXIKICAgICBtX2N1cnJlbnRDaGFyYWN0ZXI4ID0g MDsKICAgICBtX2N1cnJlbnRDaGFyYWN0ZXIxNiA9IG1fZGF0YVN0YXJ0MTYuZ2V0KCk7CiAgICAg c2V0VG9rZW5TdGFydDxVQ2hhcj4obV9jdXJyZW50Q2hhcmFjdGVyMTYpOwotICAgIG1fbGVuZ3Ro ID0gbGVuZ3RoOwogICAgIG1fbGV4RnVuYyA9ICZDU1NQYXJzZXI6OnJlYWxMZXg8VUNoYXI+Owog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmggYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKaW5kZXggMTkzZTBiNzcxZTMxOWYwM2JjZDgyZDQ1ZDg3 N2YxZDU2OWRmNzAxZi4uNjM1NjQ4YjZmMjUyMjZkZGQ0MWY0NzJiN2NmYzY3ZDk1Zjg1NDNjNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaApAQCAtNDYwLDggKzQ2MCwxMiBAQCBwcml2YXRlOgogCiAg ICAgdm9pZCByZWNoZWNrQXRLZXl3b3JkKGNvbnN0IFVDaGFyKiBzdHIsIGludCBsZW4pOwogCi0g ICAgdm9pZCBzZXR1cFBhcnNlcihjb25zdCBjaGFyKiBwcmVmaXgsIGNvbnN0IFN0cmluZyYsIGNv bnN0IGNoYXIqIHN1ZmZpeCk7Ci0KKyAgICB0ZW1wbGF0ZTx1bnNpZ25lZCBwcmVmaXhMZW5ndGgs IHVuc2lnbmVkIHN1ZmZpeExlbmd0aD4KKyAgICBpbmxpbmUgdm9pZCBzZXR1cFBhcnNlcihjb25z dCBjaGFyICgmcHJlZml4KVtwcmVmaXhMZW5ndGhdLCBjb25zdCBTdHJpbmcmIHN0cmluZywgY29u c3QgY2hhciAoJnN1ZmZpeClbc3VmZml4TGVuZ3RoXSkKKyAgICB7CisgICAgICAgIHNldHVwUGFy c2VyKHByZWZpeCwgcHJlZml4TGVuZ3RoIC0gMSwgc3RyaW5nLCBzdWZmaXgsIHN1ZmZpeExlbmd0 aCAtIDEpOworICAgIH0KKyAgICB2b2lkIHNldHVwUGFyc2VyKGNvbnN0IGNoYXIqIHByZWZpeCwg dW5zaWduZWQgcHJlZml4TGVuZ3RoLCBjb25zdCBTdHJpbmcmLCBjb25zdCBjaGFyKiBzdWZmaXgs IHVuc2lnbmVkIHN1ZmZpeExlbmd0aCk7CiAgICAgYm9vbCBpblNob3J0aGFuZCgpIGNvbnN0IHsg cmV0dXJuIG1faW5QYXJzZVNob3J0aGFuZDsgfQogCiAgICAgYm9vbCB2YWxpZFdpZHRoKENTU1Bh cnNlclZhbHVlKik7Cg==