101105 2012-11-02 14:53:14 -0700 canonicalizedTitle() shouldn't convert 8 bit title strings to 16 bit 2012-11-06 13:59:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 757624 0 msaboff 2012-11-02 14:53:14 -0700 canonicalizedTitle() calls characters() on the title string and processes the title using UChar's. This should be updated to handle 8 bit title strings directly. 758783 1 172378 msaboff 2012-11-05 12:29:17 -0800 Created attachment 172378 Patch 759781 2 172378 darin 2012-11-06 09:37:57 -0800 Comment on attachment 172378 Patch This is starting to feel a little excessive. Is there some way we can do this efficiently without a template? 759816 3 172378 webkit.review.bot 2012-11-06 10:16:14 -0800 Comment on attachment 172378 Patch Clearing flags on attachment: 172378 Committed r133631: <http://trac.webkit.org/changeset/133631> 759817 4 webkit.review.bot 2012-11-06 10:16:17 -0800 All reviewed patches have been landed. Closing bug. 760021 5 msaboff 2012-11-06 13:59:47 -0800 (In reply to comment #2) > (From update of attachment 172378 [details]) > This is starting to feel a little excessive. Is there some way we can do this efficiently without a template? We set the goal of 98% strings that can be 8 bit are 8 bit. I think we're almost there. Templates are considered the best way to make mods where the existing character type (usually UChar) somewhat permeates the code. Here we have a StringBuffer<> that is used throughout the main function we're changing. 172378 2012-11-05 12:29:17 -0800 2012-11-06 10:16:14 -0800 Patch 101105.patch text/plain 6384 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzUxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTA1ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIGNhbm9uaWNhbGl6ZWRUaXRs ZSgpIHNob3VsZG4ndCBjb252ZXJ0IDggYml0IHRpdGxlIHN0cmluZ3MgdG8gMTYgYml0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDExMDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUdXJuZWQgY2Fub25p Y2FsaXplZFRpdGxlKCkgaW50byBhIHRlbXBsYXRlZCBmdW5jdGlvbiBiYXNlZCBvbiBjaGFyYWN0 ZXIgdHlwZS4KKyAgICAgICAgQ2hhbmdlZCBjYWxsIGluIHVwZGF0ZVRpdGxlKCkgdG8gY2hlY2sg dGhlIGJpdG5lc3Mgb2YgdGhlIHRpdGxlIHN0cmluZyB0byBjYWxsCisgICAgICAgIHRoZSByaWdo dCB0ZW1wbGF0ZSBmbGF2b3Igb2YgY2Fub25pY2FsaXplZFRpdGxlKCkuCisgICAgICAgIE1hZGUg c3VwcG9ydGluZyBjaGFuZ2VzIGJ5IGFkZGluZyBkaXNwbGF5QnVmZmVyTW9kaWZpZWRCeUVuY29k aW5nKExDaGFyKiwgLi4uKQorICAgICAgICBhbmQgbWFkZSBUZXh0RW5jb2Rpbmc6OmRpc3BsYXlC dWZmZXIoKSBhIHRlbXBsYXRlZCBmdW5jdGlvbiBhcyB3ZWxsLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBuZWVkZWQsIGFzIGZ1bmN0aW9uYWxpdHkgaXMgdW5jaGFuZ2VkLgorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbm9uaWNhbGl6ZWRUaXRsZSk6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlVGl0bGUpOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OmRpc3BsYXlCdWZmZXJNb2RpZmllZEJ5RW5jb2RpbmdJbnRlcm5hbCk6 CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6 ZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGluZyk6CisgICAgICAgICogcGxhdGZvcm0vdGV4 dC9UZXh0RW5jb2RpbmcuaDoKKyAgICAgICAgKFRleHRFbmNvZGluZyk6CisgICAgICAgIChXZWJD b3JlOjpUZXh0RW5jb2Rpbmc6OmRpc3BsYXlCdWZmZXIpOgorCiAyMDEyLTExLTA1ICBHZW5ldmll dmUgTWFrICA8Z21ha0ByaW0uY29tPgogCiAgICAgICAgIFtCTEFDS0JFUlJZXSBVcGRhdGUgdG91 Y2ggY29kZSB0byByZWZsZWN0IHRvdWNoIHJlZmFjdG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAJKHJldmlzaW9uIDEzMzM3NikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE0OTYsMTkgKzE0OTYsMjAgQEAgUGFzc1JlZlB0cjxSYW5n ZT4gRG9jdW1lbnQ6OmNhcmV0UmFuZ2VGcgogICogIDIuIFRyaW0gbGVhZGluZyBhbmQgdHJhaWxp bmcgc3BhY2VzCiAgKiAgMy4gQ29sbGFwc2UgaW50ZXJuYWwgd2hpdGVzcGFjZS4KICAqLwordGVt cGxhdGUgPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+CiBzdGF0aWMgaW5saW5lIFN0cmluZ1dpdGhE aXJlY3Rpb24gY2Fub25pY2FsaXplZFRpdGxlKERvY3VtZW50KiBkb2N1bWVudCwgY29uc3QgU3Ry aW5nV2l0aERpcmVjdGlvbiYgdGl0bGVXaXRoRGlyZWN0aW9uKQogewogICAgIGNvbnN0IFN0cmlu ZyYgdGl0bGUgPSB0aXRsZVdpdGhEaXJlY3Rpb24uc3RyaW5nKCk7Ci0gICAgY29uc3QgVUNoYXIq IGNoYXJhY3RlcnMgPSB0aXRsZS5jaGFyYWN0ZXJzKCk7CisgICAgY29uc3QgQ2hhcmFjdGVyVHlw ZSogY2hhcmFjdGVycyA9IHRpdGxlLmdldENoYXJhY3RlcnM8Q2hhcmFjdGVyVHlwZT4oKTsKICAg ICB1bnNpZ25lZCBsZW5ndGggPSB0aXRsZS5sZW5ndGgoKTsKICAgICB1bnNpZ25lZCBpOwogCi0g ICAgU3RyaW5nQnVmZmVyPFVDaGFyPiBidWZmZXIobGVuZ3RoKTsKKyAgICBTdHJpbmdCdWZmZXI8 Q2hhcmFjdGVyVHlwZT4gYnVmZmVyKGxlbmd0aCk7CiAgICAgdW5zaWduZWQgYnVpbGRlckluZGV4 ID0gMDsKIAogICAgIC8vIFNraXAgbGVhZGluZyBzcGFjZXMgYW5kIGxlYWRpbmcgY2hhcmFjdGVy cyB0aGF0IHdvdWxkIGNvbnZlcnQgdG8gc3BhY2VzCiAgICAgZm9yIChpID0gMDsgaSA8IGxlbmd0 aDsgKytpKSB7Ci0gICAgICAgIFVDaGFyIGMgPSBjaGFyYWN0ZXJzW2ldOworICAgICAgICBDaGFy YWN0ZXJUeXBlIGMgPSBjaGFyYWN0ZXJzW2ldOwogICAgICAgICBpZiAoIShjIDw9IDB4MjAgfHwg YyA9PSAweDdGKSkKICAgICAgICAgICAgIGJyZWFrOwogICAgIH0KQEAgLTE1MTksNyArMTUyMCw3 IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5nV2l0aERpcmVjdGlvbiBjYW5vbmkKICAgICAvLyBSZXBs YWNlIGNvbnRyb2wgY2hhcmFjdGVycyB3aXRoIHNwYWNlcywgYW5kIGJhY2tzbGFzaGVzIHdpdGgg Y3VycmVuY3kgc3ltYm9scywgYW5kIGNvbGxhcHNlIHdoaXRlc3BhY2UuCiAgICAgYm9vbCBwcmV2 aW91c0NoYXJXYXNXUyA9IGZhbHNlOwogICAgIGZvciAoOyBpIDwgbGVuZ3RoOyArK2kpIHsKLSAg ICAgICAgVUNoYXIgYyA9IGNoYXJhY3RlcnNbaV07CisgICAgICAgIENoYXJhY3RlclR5cGUgYyA9 IGNoYXJhY3RlcnNbaV07CiAgICAgICAgIGlmIChjIDw9IDB4MjAgfHwgYyA9PSAweDdGIHx8IChX VEY6OlVuaWNvZGU6OmNhdGVnb3J5KGMpICYgKFdURjo6VW5pY29kZTo6U2VwYXJhdG9yX0xpbmUg fCBXVEY6OlVuaWNvZGU6OlNlcGFyYXRvcl9QYXJhZ3JhcGgpKSkgewogICAgICAgICAgICAgaWYg KHByZXZpb3VzQ2hhcldhc1dTKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMTU1NSw3 ICsxNTU2LDE1IEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0ZVRpdGxlKGNvbnN0IFN0cmluZ1cKICAg ICAgICAgcmV0dXJuOwogCiAgICAgbV9yYXdUaXRsZSA9IHRpdGxlOwotICAgIG1fdGl0bGUgPSBj YW5vbmljYWxpemVkVGl0bGUodGhpcywgbV9yYXdUaXRsZSk7CisKKyAgICBpZiAobV9yYXdUaXRs ZS5zdHJpbmcoKS5pc0VtcHR5KCkpCisgICAgICAgIG1fdGl0bGUgPSBTdHJpbmdXaXRoRGlyZWN0 aW9uKCk7CisgICAgZWxzZSB7CisgICAgICAgIGlmIChtX3Jhd1RpdGxlLnN0cmluZygpLmlzOEJp dCgpKQorICAgICAgICAgICAgbV90aXRsZSA9IGNhbm9uaWNhbGl6ZWRUaXRsZTxMQ2hhcj4odGhp cywgbV9yYXdUaXRsZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG1fdGl0bGUgPSBjYW5v bmljYWxpemVkVGl0bGU8VUNoYXI+KHRoaXMsIG1fcmF3VGl0bGUpOworICAgIH0KICAgICBpZiAo RnJhbWUqIGYgPSBmcmFtZSgpKQogICAgICAgICBmLT5sb2FkZXIoKS0+c2V0VGl0bGUobV90aXRs ZSk7CiB9CkBAIC00OTk2LDEyICs1MDA1LDE3IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gRG9j dW1lbnQ6OmRpc3BsYXkKICAgICByZXR1cm4gc3RyOwogfQogCi12b2lkIERvY3VtZW50OjpkaXNw bGF5QnVmZmVyTW9kaWZpZWRCeUVuY29kaW5nKFVDaGFyKiBidWZmZXIsIHVuc2lnbmVkIGxlbikg Y29uc3QKK3RlbXBsYXRlIDx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPgordm9pZCBEb2N1bWVudDo6 ZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGluZ0ludGVybmFsKENoYXJhY3RlclR5cGUqIGJ1 ZmZlciwgdW5zaWduZWQgbGVuKSBjb25zdAogewogICAgIGlmIChtX2RlY29kZXIpCiAgICAgICAg IG1fZGVjb2Rlci0+ZW5jb2RpbmcoKS5kaXNwbGF5QnVmZmVyKGJ1ZmZlciwgbGVuKTsKIH0KIAor Ly8gR2VuZXJhdGUgZGVmaW5pdGlvbnMgZm9yIGJvdGggY2hhcmFjdGVyIHR5cGVzCit0ZW1wbGF0 ZSB2b2lkIERvY3VtZW50OjpkaXNwbGF5QnVmZmVyTW9kaWZpZWRCeUVuY29kaW5nSW50ZXJuYWw8 TENoYXI+KExDaGFyKiwgdW5zaWduZWQpIGNvbnN0OwordGVtcGxhdGUgdm9pZCBEb2N1bWVudDo6 ZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGluZ0ludGVybmFsPFVDaGFyPihVQ2hhciosIHVu c2lnbmVkKSBjb25zdDsKKwogdm9pZCBEb2N1bWVudDo6ZW5xdWV1ZVBhZ2VzaG93RXZlbnQoUGFn ZXNob3dFdmVudFBlcnNpc3RlbmNlIHBlcnNpc3RlZCkKIHsKICAgICAvLyBGSVhNRTogaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzM0IFBhZ2VzaG93IGV2ZW50IG5l ZWRzIHRvIGZpcmUgYXN5bmNocm9ub3VzbHkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkocmV2 aXNpb24gMTMzMzc2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTk4MSw3ICs5ODEsMTQgQEAgcHVibGljOgogCiAgICAgU3RyaW5nIGRpc3BsYXlT dHJpbmdNb2RpZmllZEJ5RW5jb2RpbmcoY29uc3QgU3RyaW5nJikgY29uc3Q7CiAgICAgUGFzc1Jl ZlB0cjxTdHJpbmdJbXBsPiBkaXNwbGF5U3RyaW5nTW9kaWZpZWRCeUVuY29kaW5nKFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4pIGNvbnN0OwotICAgIHZvaWQgZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlF bmNvZGluZyhVQ2hhciogYnVmZmVyLCB1bnNpZ25lZCBsZW4pIGNvbnN0OworICAgIHZvaWQgZGlz cGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGluZyhMQ2hhciogYnVmZmVyLCB1bnNpZ25lZCBsZW4p IGNvbnN0CisgICAgeworICAgICAgICBkaXNwbGF5QnVmZmVyTW9kaWZpZWRCeUVuY29kaW5nSW50 ZXJuYWwoYnVmZmVyLCBsZW4pOworICAgIH0KKyAgICB2b2lkIGRpc3BsYXlCdWZmZXJNb2RpZmll ZEJ5RW5jb2RpbmcoVUNoYXIqIGJ1ZmZlciwgdW5zaWduZWQgbGVuKSBjb25zdAorICAgIHsKKyAg ICAgICAgZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGluZ0ludGVybmFsKGJ1ZmZlciwgbGVu KTsKKyAgICB9CiAKICAgICAvLyBRdWlyayBmb3IgdGhlIGJlbmVmaXQgb2YgQXBwbGUncyBEaWN0 aW9uYXJ5IGFwcGxpY2F0aW9uLgogICAgIHZvaWQgc2V0RnJhbWVFbGVtZW50c1Nob3VsZElnbm9y ZVNjcm9sbGluZyhib29sIGlnbm9yZSkgeyBtX2ZyYW1lRWxlbWVudHNTaG91bGRJZ25vcmVTY3Jv bGxpbmcgPSBpZ25vcmU7IH0KQEAgLTEyMDcsNiArMTIxNCw5IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBwZW5kaW5nVGFza3NUaW1lckZpcmVkKFRpbWVyPERvY3VtZW50PiopOwogCiAgICAgc3RhdGlj IHZvaWQgZGlkUmVjZWl2ZVRhc2sodm9pZCopOworICAgIAorICAgIHRlbXBsYXRlIDx0eXBlbmFt ZSBDaGFyYWN0ZXJUeXBlPgorICAgIHZvaWQgZGlzcGxheUJ1ZmZlck1vZGlmaWVkQnlFbmNvZGlu Z0ludGVybmFsKENoYXJhY3RlclR5cGUqLCB1bnNpZ25lZCkgY29uc3Q7CiAKICNpZiBFTkFCTEUo UEFHRV9WSVNJQklMSVRZX0FQSSkKICAgICBQYWdlVmlzaWJpbGl0eVN0YXRlIHZpc2liaWxpdHlT dGF0ZSgpIGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5j b2RpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRF bmNvZGluZy5oCShyZXZpc2lvbiAxMzMzNzYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L1RleHRFbmNvZGluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw4IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICAgICByZXR1cm4gc3RyOwogICAgICAgICAgICAg cmV0dXJuIHN0ci0+cmVwbGFjZSgnXFwnLCBtX2JhY2tzbGFzaEFzQ3VycmVuY3lTeW1ib2wpOwog ICAgICAgICB9Ci0gICAgICAgIHZvaWQgZGlzcGxheUJ1ZmZlcihVQ2hhciogY2hhcmFjdGVycywg dW5zaWduZWQgbGVuKSBjb25zdAorICAgICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVy VHlwZT4KKyAgICAgICAgdm9pZCBkaXNwbGF5QnVmZmVyKENoYXJhY3RlclR5cGUqIGNoYXJhY3Rl cnMsIHVuc2lnbmVkIGxlbikgY29uc3QKICAgICAgICAgewogICAgICAgICAgICAgaWYgKG1fYmFj a3NsYXNoQXNDdXJyZW5jeVN5bWJvbCA9PSAnXFwnKQogICAgICAgICAgICAgICAgIHJldHVybjsK