101104 2012-11-02 14:46:27 -0700 JSStringCreateWithCFString() Should create an 8 bit String if possible 2022-03-01 03:02:44 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 757619 0 msaboff 2012-11-02 14:46:27 -0700 JSStringCreateWithCFString() uses CFStringGetCharacters() to get a pointer to the 16 bit character buffer for the argument CFString. First we should try using CFStringGetBytes(..., kCFStringEncodingISOLatin1, ...) to get a Latin-1 8 bit character buffer if possible. 758712 1 172366 msaboff 2012-11-05 11:09:50 -0800 Created attachment 172366 Patch 759779 2 172366 darin 2012-11-06 09:36:48 -0800 Comment on attachment 172366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172366&action=review > Source/JavaScriptCore/API/JSStringRefCF.cpp:45 > + CFIndex usedBufLen; How about a non-abbreviated version, usedBufferLength? > Source/JavaScriptCore/API/JSStringRefCF.cpp:46 > + CFIndex convertedsize = CFStringGetBytes(string, CFRangeMake(0, length), kCFStringEncodingISOLatin1, 0, false, lcharBuffer.data(), length, &usedBufLen); Typically we’d capitalize “size”. > Source/JavaScriptCore/API/JSStringRefCF.cpp:47 > + if ((static_cast<size_t>(convertedsize) == length) && (static_cast<size_t>(usedBufLen) == length)) We normally wouldn’t use parentheses in an a == b && c == d expression. 760040 3 msaboff 2012-11-06 14:17:09 -0800 Committed r133672: <http://trac.webkit.org/changeset/133672> 172366 2012-11-05 11:09:50 -0800 2022-03-01 03:02:44 -0800 Patch 101104.patch text/plain 1973 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzNDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTExLTA1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEpTU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5nKCkgU2hvdWxkIGNyZWF0ZSBhbiA4IGJpdCBT dHJpbmcgaWYgcG9zc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTEwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRyeSBjb252ZXJ0aW5nIHRoZSBDRlN0cmluZyB0byBhbiA4IGJpdCBzdHJpbmcg dXNpbmcgQ0ZTdHJpbmdHZXRCeXRlcyguLi4sCisgICAgICAgIGtDRlN0cmluZ0VuY29kaW5nSVNP TGF0aW4xLCAuLi4pIGFuZCByZXR1cm4gdGhlIDggYml0IHN0cmluZyBpZiBzdWNjZXNzZnVsLgor ICAgICAgICBJZiBub3QgcHJvY2VlZCB3aXRoIDE2IGJpdCBjb252ZXJzaW9uLgorCisgICAgICAg ICogQVBJL0pTU3RyaW5nUmVmQ0YuY3BwOgorICAgICAgICAoSlNTdHJpbmdDcmVhdGVXaXRoQ0ZT dHJpbmcpOgorCiAyMDEyLTExLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmVkdWNlIHRoZSB2ZXJib3NpdHkgb2YgcmVmZXJyaW5nIHRvIFFOYU4gaW4gSmF2 YVNjcmlwdENvcmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWZD Ri5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1Jl ZkNGLmNwcAkocmV2aXNpb24gMTMzMzc2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1N0cmluZ1JlZkNGLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsMTIgQEAgSlNTdHJp bmdSZWYgSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoQwogICAgIC8vIGl0IGNhbiBob2xkLiAg KDxyZGFyOi8vcHJvYmxlbS82ODA2NDc4PikKICAgICBzaXplX3QgbGVuZ3RoID0gQ0ZTdHJpbmdH ZXRMZW5ndGgoc3RyaW5nKTsKICAgICBpZiAobGVuZ3RoKSB7CisgICAgICAgIFZlY3RvcjxMQ2hh ciwgMTAyND4gbGNoYXJCdWZmZXIobGVuZ3RoKTsKKyAgICAgICAgQ0ZJbmRleCB1c2VkQnVmTGVu OworICAgICAgICBDRkluZGV4IGNvbnZlcnRlZHNpemUgPSBDRlN0cmluZ0dldEJ5dGVzKHN0cmlu ZywgQ0ZSYW5nZU1ha2UoMCwgbGVuZ3RoKSwga0NGU3RyaW5nRW5jb2RpbmdJU09MYXRpbjEsIDAs IGZhbHNlLCBsY2hhckJ1ZmZlci5kYXRhKCksIGxlbmd0aCwgJnVzZWRCdWZMZW4pOworICAgICAg ICBpZiAoKHN0YXRpY19jYXN0PHNpemVfdD4oY29udmVydGVkc2l6ZSkgPT0gbGVuZ3RoKSAmJiAo c3RhdGljX2Nhc3Q8c2l6ZV90Pih1c2VkQnVmTGVuKSA9PSBsZW5ndGgpKQorICAgICAgICAgICAg cmV0dXJuIE9wYXF1ZUpTU3RyaW5nOjpjcmVhdGUobGNoYXJCdWZmZXIuZGF0YSgpLCBsZW5ndGgp LmxlYWtSZWYoKTsKKwogICAgICAgICBPd25BcnJheVB0cjxVbmlDaGFyPiBidWZmZXIgPSBhZG9w dEFycmF5UHRyKG5ldyBVbmlDaGFyW2xlbmd0aF0pOwogICAgICAgICBDRlN0cmluZ0dldENoYXJh Y3RlcnMoc3RyaW5nLCBDRlJhbmdlTWFrZSgwLCBsZW5ndGgpLCBidWZmZXIuZ2V0KCkpOwogICAg ICAgICBDT01QSUxFX0FTU0VSVChzaXplb2YoVW5pQ2hhcikgPT0gc2l6ZW9mKFVDaGFyKSwgdW5p Y2hhcl9hbmRfdWNoYXJfbXVzdF9iZV9zYW1lX3NpemUpOwo=